Re: pppd not working on latest current 2002-10-20

2002-10-26 Thread Terry Lambert
Bakul Shah wrote: Thank you for explicating the security argument! I'll also point out that hardwiring module names makes it harder to experiment with replacement modules (i.e. I may want to develop if_super_duper_ppp). Actually, this isn't an issue (I'm assuming that you want it to be named

Re: pppd not working on latest current 2002-10-20

2002-10-26 Thread Maxime Henrion
Terry Lambert wrote: Brooks Davis wrote: This isn't going to have an effect on the ability to use kernel ppp for other things. The tty orientation of pppd and the outdated, unmodular design on ppp(4) have taken care of that. This patch gives people the functionality they want (pppd just

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Bakul Shah
Until pppd is taught to create the interface if one doesn't exist, this information needs to be in /usr/src/UPDATING. pppd doesn't need to be taught to create the interface. Rather it needed to learn to check for ppp support in a non-stupid way. The following patch should do it as well

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Brooks Davis
On Fri, Oct 25, 2002 at 02:16:32PM -0700, Bakul Shah wrote: Until pppd is taught to create the interface if one doesn't exist, this information needs to be in /usr/src/UPDATING. pppd doesn't need to be taught to create the interface. Rather it needed to learn to check for ppp support

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Brooks Davis
On Fri, Oct 25, 2002 at 01:43:57PM -0700, Terry Lambert wrote: It's a moderately common case in -CURRENT, when kernel structure sizes change, and you build a new kernel without new modules, and a module refuses to load. It's not technically correct. The old message might not be either, but

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Terry Lambert
Brooks Davis wrote: On Fri, Oct 25, 2002 at 01:43:57PM -0700, Terry Lambert wrote: It's a moderately common case in -CURRENT, when kernel structure sizes change, and you build a new kernel without new modules, and a module refuses to load. It's not technically correct. The old message

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Brooks Davis
On Fri, Oct 25, 2002 at 12:35:22PM -0700, Brooks Davis wrote: If someone who actually uses pppd could test it, perferably in both sceneios, I'll see about getting it commited. Here's a new patch that gives the user more of a hint at how to add PPP support and only loads the module if they are

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Terry Lambert
Brooks Davis wrote: On Fri, Oct 25, 2002 at 12:35:22PM -0700, Brooks Davis wrote: If someone who actually uses pppd could test it, perferably in both sceneios, I'll see about getting it commited. Here's a new patch that gives the user more of a hint at how to add PPP support and only

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Bakul Shah
Here's a new patch that gives the user more of a hint at how to add PPP support and only loads the module if they are actully root. How's this look? I still don't like it. How to explain I don't think it is pppd's responsibility to muck with modules. It is like mount kldloading a disk

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Brooks Davis
On Fri, Oct 25, 2002 at 05:34:15PM -0700, Bakul Shah wrote: Here's a new patch that gives the user more of a hint at how to add PPP support and only loads the module if they are actully root. How's this look? I still don't like it. How to explain I don't think it is pppd's

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Terry Lambert
Brooks Davis wrote: This isn't going to have an effect on the ability to use kernel ppp for other things. The tty orientation of pppd and the outdated, unmodular design on ppp(4) have taken care of that. This patch gives people the functionality they want (pppd just working) without any

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Brooks Davis
On Fri, Oct 25, 2002 at 07:05:57PM -0700, Terry Lambert wrote: Brooks Davis wrote: This isn't going to have an effect on the ability to use kernel ppp for other things. The tty orientation of pppd and the outdated, unmodular design on ppp(4) have taken care of that. This patch gives

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Brooks Davis
On Fri, Oct 25, 2002 at 07:20:33PM -0700, Brooks Davis wrote: On Fri, Oct 25, 2002 at 07:05:57PM -0700, Terry Lambert wrote: Depending on the value of sysctl kern.module_path, if the if_ppp module does not exist, and one of the path components is writeable, then this would permit you to

RE: pppd not working on latest current 2002-10-20

2002-10-25 Thread Maksim Yevmenkin
From: Terry Lambert [mailto:tlambert2;mindspring.com] Brooks Davis wrote: This isn't going to have an effect on the ability to use kernel ppp for other things. The tty orientation of pppd and the outdated, unmodular design on ppp(4) have taken care of that. This patch gives people

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Bakul Shah
Brooks Davis wrote: This isn't going to have an effect on the ability to use kernel ppp for other things. The tty orientation of pppd and the outdated, unmodular design on ppp(4) have taken care of that. This patch gives people the functionality they want (pppd just working) without any

pppd not working on latest current 2002-10-20

2002-10-25 Thread Dave Evans
Is anyone using pppd on CURRENT. somewhere between may and October it seems to have broken. My KERNEL is GENERIC, my sources are dated cvs -D2002-10-20, but I now get a message about needing facilities in the kernel. However, the kernel has many ppp entry points, I haven't modified GENERIC which

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Brooks Davis
On Fri, Oct 25, 2002 at 06:15:55PM +, Dave Evans wrote: Is anyone using pppd on CURRENT. somewhere between may and October it seems to have broken. My KERNEL is GENERIC, my sources are dated cvs -D2002-10-20, but I now get a message about needing facilities in the kernel. However, the

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Bakul Shah
On Fri, Oct 25, 2002 at 06:15:55PM +, Dave Evans wrote: Is anyone using pppd on CURRENT. somewhere between may and October it seems to have broken. My KERNEL is GENERIC, my sources are dated cvs -D2002-10-20, but I now get a message about needing facilities in the kernel. However,

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Brooks Davis
On Fri, Oct 25, 2002 at 11:41:33AM -0700, Bakul Shah wrote: Until pppd is taught to create the interface if one doesn't exist, this information needs to be in /usr/src/UPDATING. pppd doesn't need to be taught to create the interface. Rather it needed to learn to check for ppp support in a

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Bruce Evans
On Fri, 25 Oct 2002, Bakul Shah wrote: On Fri, Oct 25, 2002 at 06:15:55PM +, Dave Evans wrote: Is anyone using pppd on CURRENT. somewhere between may and October it seems to have broken. My KERNEL is GENERIC, my sources are dated cvs -D2002-10-20, but I now get a message about

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Terry Lambert
Brooks Davis wrote: pppd doesn't need to be taught to create the interface. Rather it needed to learn to check for ppp support in a non-stupid way. The following patch should do it as well as making pppd do the right thing when support isn't compiled in, but a module is available. It should

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Brooks Davis
On Fri, Oct 25, 2002 at 12:58:57PM -0700, Terry Lambert wrote: Brooks Davis wrote: pppd doesn't need to be taught to create the interface. Rather it needed to learn to check for ppp support in a non-stupid way. The following patch should do it as well as making pppd do the right thing

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Bruce Evans
On Fri, 25 Oct 2002, Brooks Davis wrote: On Fri, Oct 25, 2002 at 11:41:33AM -0700, Bakul Shah wrote: Until pppd is taught to create the interface if one doesn't exist, this information needs to be in /usr/src/UPDATING. pppd doesn't need to be taught to create the interface. Rather it

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Terry Lambert
Brooks Davis wrote: If someone who actually uses pppd could test it, perferably in both sceneios, I'll see about getting it commited. Try running you program when the module is there, but fails to load. You got rid of the failure message that it used to print. No, it just let the

Re: pppd not working on latest current 2002-10-20

2002-10-25 Thread Terry Lambert
Bruce Evans wrote: patch should do it as well as making pppd do the right thing when support isn't compiled in, but a module is available. It should make things work with a GENERIC kernel. I disagree with auto-loading of modules for anything, but especially in setuid programs like pppd.