Re: resolvconf needs @RESTARTCMD@ to be replaced after r303062

2016-08-01 Thread Guy Yur
On Sun, Jul 31, 2016 at 9:09 PM, Pedro Giffuni wrote: > > > On 07/31/16 11:56, Guy Yur wrote: >> >> Hi, >> >> I meant for the RESTARTCMD_= statement to be added too. >> I should have sent a patch file. >> > > Ugh ... yeah I am really bad at "guessing" patches. > > I will play with your patch. Than

Re: resolvconf needs @RESTARTCMD@ to be replaced after r303062

2016-07-31 Thread Pedro Giffuni
On 07/31/16 11:56, Guy Yur wrote: On Sun, Jul 31, 2016 at 5:46 AM, Pedro Giffuni wrote: Index: sbin/resolvconf/Makefile === --- sbin/resolvconf/Makefile(revision 303557) +++ sbin/resolvconf/Makefile(working copy) @@ -3

Re: resolvconf needs @RESTARTCMD@ to be replaced after r303062

2016-07-31 Thread Guy Yur
On Sun, Jul 31, 2016 at 5:46 AM, Pedro Giffuni wrote: > > >>> Index: sbin/resolvconf/Makefile >>> === >>> --- sbin/resolvconf/Makefile(revision 303557) >>> +++ sbin/resolvconf/Makefile(working copy) >>> @@ -30,6 +30,7 @@ >>>

Re: resolvconf needs @RESTARTCMD@ to be replaced after r303062

2016-07-30 Thread Pedro Giffuni
On 07/30/16 21:35, Glen Barber wrote: ... I don't see the error message though. so I need some confirmation that this fixes the issue. Likewise, I do not see the error either, so would like definitive confirmation the patch resolves the issue. OK, I don't see the error message but I can

Re: resolvconf needs @RESTARTCMD@ to be replaced after r303062

2016-07-30 Thread Glen Barber
On Sat, Jul 30, 2016 at 08:40:02PM -0500, Pedro Giffuni wrote: > (CC'ing Glen for review, since he was the last to touch that file and > may know better). > Unfortunately, I don't know better. I only touched the file last in order to close a PR prior to the final 10.2-RELEASE (if I remember corr

Re: resolvconf needs @RESTARTCMD@ to be replaced after r303062

2016-07-30 Thread Pedro Giffuni
(CC'ing Glen for review, since he was the last to touch that file and may know better). Hi Guy; On 07/30/16 17:37, Guy Yur wrote: Hi, openresolv 3.8.1 added RESTARTCMD=@RESTARTCMD@ in contrib/openresolv/resolvconf.in. It is not replaced by the sed expressions in sbin/resolvconf/Makefile. Err

resolvconf needs @RESTARTCMD@ to be replaced after r303062

2016-07-30 Thread Guy Yur
Hi, openresolv 3.8.1 added RESTARTCMD=@RESTARTCMD@ in contrib/openresolv/resolvconf.in. It is not replaced by the sed expressions in sbin/resolvconf/Makefile. Error seen is "eval: @RESTARTCMD@: not found". Current @RESTARTCMD \(.*\)@ sed expression needs to be kept for pdns_recursor.in and a new