Re: Another tweak to "burncd msinfo"

2002-01-05 Thread Stephen McKay

On Saturday, 5th January 2002, Søren Schmidt wrote:

>I forgot to say that I already committed the change to current...

:-)

I try to keep up with -current, but that's too current for me!

I'll hassle the REs tomorrow about permission to merge.

Thanks,

Stephen.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Another tweak to "burncd msinfo"

2002-01-05 Thread Stephen McKay

On Saturday, 5th January 2002, Søren Schmidt wrote:

>It seems Stephen McKay wrote:
>> 
>> Are these changes intended for 4.5?  I'm hoping the small change I
>> proposed would be accepted into 4.5, before anybody starts using
>> "burncd msinfo" in practice.  I think this is sensible, even if
>> a much improved burncd is scheduled for 4.6.
>
>You should ask permission from the release engineer to commit it
>to 4.5, but it really should be committed to -current first.

Of course!  But given how simple the change is, just a couple of days
in -current would be sufficient testing.  I am asking your approval
to commit to -current, then I'll ask the REs about -stable.

Does this mean you've decided that it is a beneficial change and won't
intefere with your other work?

Stephen.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Another tweak to "burncd msinfo"

2002-01-05 Thread Søren Schmidt

It seems Søren Schmidt wrote:
> It seems Stephen McKay wrote:
> > 
> > Are these changes intended for 4.5?  I'm hoping the small change I
> > proposed would be accepted into 4.5, before anybody starts using
> > "burncd msinfo" in practice.  I think this is sensible, even if
> > a much improved burncd is scheduled for 4.6.
> 
> You should ask permission from the release engineer to commit it
> to 4.5, but it really should be committed to -current first.

I forgot to say that I already committed the change to current...

-Søren

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Another tweak to "burncd msinfo"

2002-01-05 Thread Søren Schmidt

It seems Stephen McKay wrote:
> 
> Are these changes intended for 4.5?  I'm hoping the small change I
> proposed would be accepted into 4.5, before anybody starts using
> "burncd msinfo" in practice.  I think this is sensible, even if
> a much improved burncd is scheduled for 4.6.

You should ask permission from the release engineer to commit it
to 4.5, but it really should be committed to -current first.

-Søren

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Another tweak to "burncd msinfo"

2002-01-05 Thread Stephen McKay

On Saturday, 5th January 2002, Søren Schmidt wrote:

>It seems Stephen McKay wrote:
>> Now that "burncd msinfo" returns the correct values I noticed another small
>> problem: it displays the result on stderr instead of stdout.
>
>Hmm, that was intentional...

Could you explain why?  The most obvious practical use would be:

$ mkisofs -r -C `burncd msinfo` -M /dev/acd0c -o new.iso goodies

Writing to stderr means this doesn't work, and you have to add 2>&1 to it.
Also the white space means you have to use extra quoting.

>> Can I commit the obvious patch?
>
>Could you just hang on for now, since I'm doing large changes to
>burncd just now in order to support other things, and keeping
>everybody changes to the stock sources is not making things 
>easier...

Are these changes intended for 4.5?  I'm hoping the small change I
proposed would be accepted into 4.5, before anybody starts using
"burncd msinfo" in practice.  I think this is sensible, even if
a much improved burncd is scheduled for 4.6.

Regardless of this, I do not intend to commit any unwelcome changes.

Stephen.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Another tweak to "burncd msinfo"

2002-01-05 Thread Søren Schmidt

It seems Stephen McKay wrote:
> Now that "burncd msinfo" returns the correct values I noticed another small
> problem: it displays the result on stderr instead of stdout.

Hmm, that was intentional...

> Since very few people (nobody?) would be using this option yet because
> of the previous problem, it seems like nobody would be adversely affected
> by changing the output to stdout.  Also, removing the whitespace in the
> output would help script writers.
> 
> Can I commit the obvious patch?

Could you just hang on for now, since I'm doing large changes to
burncd just now in order to support other things, and keeping
everybody changes to the stock sources is not making things 
easier...

-Søren

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message