On 10-Feb-2003 Mike Makonnen wrote:
> On Mon, 10 Feb 2003 13:31:48 +1100
> Tim Robbins <[EMAIL PROTECTED]> wrote:
>
>>
>> hashinit() can sleep, and I don't think it's safe to sleep here
>> (msdosfs_hashget() and msdosfs_hashins()) with dehash_mtx and
>> sometimes a vnode lock held.
>
> Doh! I s
On Mon, 10 Feb 2003 13:31:48 +1100
Tim Robbins <[EMAIL PROTECTED]> wrote:
>
> hashinit() can sleep, and I don't think it's safe to sleep here
> (msdosfs_hashget() and msdosfs_hashins()) with dehash_mtx and
> sometimes a vnode lock held.
Doh! I should have noticed that.
>
> It might be better t
On Mon, 10 Feb 2003 13:31:48 +1100
Tim Robbins <[EMAIL PROTECTED]> wrote:
> It might be better to initialise the table the first time an
> msdosfs filesystem is mounted.
>
This implies that the existence of the hash table be revealed outside the
module. Is this a layering violation? None of the
- Original Message -
From: "Hiten Pandya" <[EMAIL PROTECTED]>
To: "Alexey Zelkin" <[EMAIL PROTECTED]>
Cc: "Poul-Henning Kamp" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
Sent: Monday, February 10, 2003 12:38 PM
Subject: Re: kld problem ?
On Sun, Feb 09, 2003 at 10:16:21PM +0200, Alexey Zelkin wrote the words in effect of:
> hi,
>
> On Sun, Feb 09, 2003 at 08:39:59PM +0100, Poul-Henning Kamp wrote:
>
> > /*ARGSUSED*/
> > int
> > msdosfs_init(vfsp)
> > struct vfsconf *vfsp;
> > {
> > dehashtbl = hashinit(desiredvnod
Thus spake Poul-Henning Kamp <[EMAIL PROTECTED]>:
> Somebody: please fix so this doesn't suck.
Does msdosfs even have an active maintainer? There seem to be
about half a dozen PRs open against it, one of which is a
semi-obvious 4-line patch I submitted last April.
To Unsubscribe: send mail to [E
On Sun, Feb 09, 2003 at 06:08:47PM -0500, Mike Makonnen wrote:
> How about the attached?
>
> It's only partially tested since it seems I can't mount any msdos floppies (both
> on this _and_ my previous kernel).
> Index: sys/fs/msdosfs/msdosfs_denode.c
> ==
How about the attached?
It's only partially tested since it seems I can't mount any msdos floppies (both
on this _and_ my previous kernel).
Cheers.
--
Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc
[EMAIL PROTECTED] | Fingerprint: D228 1A6F C64E 120A A1C9 A3AA DAE1 E2AF DBCC 68B9
On Sun, 9 Feb 2003, Poul-Henning Kamp wrote:
> I don't have any msdos filesystems mounted, yet:
>
> kern.malloc:
> Type InUse MemUse HighUse Requests Size(s)
> [...]
> MSDOSFS mount 1 256K256K1
> [...]
>
> due to this:
>
> /*ARGSUSED*/
> int
> msdosfs_init(vfsp)
>
hi,
On Sun, Feb 09, 2003 at 08:39:59PM +0100, Poul-Henning Kamp wrote:
> /*ARGSUSED*/
> int
> msdosfs_init(vfsp)
> struct vfsconf *vfsp;
> {
> dehashtbl = hashinit(desiredvnodes/2, M_MSDOSFSMNT, &dehash);
> mtx_init(&dehash_mtx, "msdosfs dehash", NULL, MTX_DEF);
>
10 matches
Mail list logo
