Re: Revert awk to one that works

2001-11-02 Thread John Baldwin


On 01-Nov-01 Mike Barcroft wrote:
 Doug Barton [EMAIL PROTECTED] writes:
 On Wed, 31 Oct 2001, David O'Brien wrote:
  I *DID* test it with a full `make world'.  By chance is this your second
  `make world' after the change?  It seems we are using the host awk
  instead of the one we built.  Requiring someone to do two back-to-back
  `make world's before a commit has never been a requirement.  Some things
  we just find out after a commit.
 
  Required isn't really the question. It seems like common sense
 to me when discussing such a frequently used build tool.
 
 I'm sure there's better things you could be doing besides lecturing
 David about testing his changes before committing.  Not every bug can
 be found before committing, which is why we have a little thing called
 -CURRENT.

And the irony being that David has one of the best test methodologies of any
committer I know.  The number of torture tests he has submitted binutils and
gcc updates to in the past is amazing.  So he missed one, give him a break and
help fix it if you can.

-- 

John Baldwin [EMAIL PROTECTED] -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
Power Users Use the Power to Serve!  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread David O'Brien

On Wed, Oct 31, 2001 at 03:16:37PM -0800, Steve Kargl wrote:
 Can someone revert awk to one that actually works?

Why don't we look at fixing the mkioctls script instead??

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread Steve Kargl

On Wed, Oct 31, 2001 at 04:45:58PM -0800, David O'Brien wrote:
 On Wed, Oct 31, 2001 at 03:16:37PM -0800, Steve Kargl wrote:
  Can someone revert awk to one that actually works?
 
 Why don't we look at fixing the mkioctls script instead??

That's fine.

But, before pulling the switch on a major utility, it 
would be nice if the committer would actually test the
new utility.

-- 
Steve

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread David O'Brien

On Wed, Oct 31, 2001 at 04:56:18PM -0800, Steve Kargl wrote:
 On Wed, Oct 31, 2001 at 04:45:58PM -0800, David O'Brien wrote:
  On Wed, Oct 31, 2001 at 03:16:37PM -0800, Steve Kargl wrote:
   Can someone revert awk to one that actually works?
  
  Why don't we look at fixing the mkioctls script instead??
 
 That's fine.
 
 But, before pulling the switch on a major utility, it 
 would be nice if the committer would actually test the
 new utility.

I *DID* test it with a full `make world'.  By chance is this your second
`make world' after the change?  It seems we are using the host awk
instead of the one we built.  Requiring someone to do two back-to-back
`make world's before a commit has never been a requirement.  Some things
we just find out after a commit.  There isn't much we can do about that
with our current practices.
 
-- 
-- David  ([EMAIL PROTECTED])

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread Jos Backus

On Wed, Oct 31, 2001 at 04:45:58PM -0800, David O'Brien wrote:
 Why don't we look at fixing the mkioctls script instead??

What about this patch?

--- mkioctls.orig   Wed Oct 31 17:08:33 2001
+++ mkioctlsWed Oct 31 17:13:07 2001
@@ -19,50 +19,48 @@
 # Build a list of headers that have ioctls in them.
 # XXX should we use an ANSI cpp?
 # XXX netipx conflicts with netns (leave out netns).
-ioctl_includes=`
-   cd $1
-   find -s * -name '*.h' -follow |
-   egrep -v '^(netns)/' |
-   xargs egrep -l \
-'^#[   ]*define[   ]+[A-Za-z_][A-Za-z0-9_]*[   ]+_IO[^a-z0-9_]' |
-   sed -e 's/^/#include /' -e s'/$//'
-`
 
-echo $ioctl_includes |
+cat 'EOT'
+/* XXX obnoxious prerequisites. */
+#define COMPAT_43
+#include sys/param.h
+#include sys/devicestat.h
+#include sys/disklabel.h
+#include sys/socket.h
+#include sys/time.h
+#include sys/tty.h
+#include net/ethernet.h
+#include net/if.h
+#include net/if_var.h
+#include net/route.h
+#include netatm/atm.h
+#include netatm/atm_if.h
+#include netatm/atm_sap.h
+#include netatm/atm_sys.h
+#include netinet/in.h
+#include netinet/ip_compat.h
+#include netinet/ip_fil.h
+#include netinet/ip_auth.h
+#include netinet/ip_nat.h
+#include netinet/ip_frag.h
+#include netinet/ip_state.h
+#include netinet/ip_mroute.h
+#include netinet6/in6_var.h
+#include netinet6/nd6.h
+#include netinet6/ip6_mroute.h
+#include stdio.h
+#include cam/cam.h
+EOT
+
+cd $1
+find -s * -name '*.h' -follow |
+   egrep -v '^(netns)/' |
+   xargs egrep -l \
+'^#[   ]*define[   ]+[A-Za-z_][A-Za-z0-9_]*[   ]+_IO[^a-z0-9_]' |
+   sed -e 's/^/#include /' -e s'/$//' |
gcc -E -I$1 -dM - |
-   awk -v ioctl_includes=$ioctl_includes -v use_switch=$use_switch '
+   awk -v use_switch=$use_switch '
 BEGIN {
-   print /* XXX obnoxious prerequisites. */
-   print #define COMPAT_43
-   print #include sys/param.h
-   print #include sys/devicestat.h
-   print #include sys/disklabel.h
-   print #include sys/socket.h
-   print #include sys/time.h
-   print #include sys/tty.h
-   print #include net/ethernet.h
-   print #include net/if.h
-   print #include net/if_var.h
-   print #include net/route.h
-   print #include netatm/atm.h
-   print #include netatm/atm_if.h
-   print #include netatm/atm_sap.h
-   print #include netatm/atm_sys.h
-   print #include netinet/in.h
-   print #include netinet/ip_compat.h
-   print #include netinet/ip_fil.h
-   print #include netinet/ip_auth.h
-   print #include netinet/ip_nat.h
-   print #include netinet/ip_frag.h
-   print #include netinet/ip_state.h
-   print #include netinet/ip_mroute.h
-   print #include netinet6/in6_var.h
-   print #include netinet6/nd6.h
-   print #include netinet6/ip6_mroute.h
-   print #include stdio.h
-   print #include cam/cam.h
-   print 
-   print ioctl_includes
print 
print char *
print ioctlname(register_t val)

-- 
Jos Backus _/  _/_/_/Santa Clara, CA
  _/  _/   _/
 _/  _/_/_/ 
_/  _/  _/_/
[EMAIL PROTECTED] _/_/   _/_/_/use Std::Disclaimer;

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread David O'Brien

On Wed, Oct 31, 2001 at 05:14:34PM -0800, Jos Backus wrote:
 On Wed, Oct 31, 2001 at 04:45:58PM -0800, David O'Brien wrote:
  Why don't we look at fixing the mkioctls script instead??
 
 What about this patch?

It does not work.
 
 +cat 'EOT'
 +/* XXX obnoxious prerequisites. */
^^^

what should this  be terminating?  Or where is it's terminating ?


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread Jos Backus

On Wed, Oct 31, 2001 at 06:12:07PM -0800, David O'Brien wrote:
 It does not work.
  
Bummer. I'll look at it when I get back from dinner.

  +cat 'EOT'
  +/* XXX obnoxious prerequisites. */
 ^^^
 
 what should this  be terminating?  Or where is it's terminating ?

Typo. Does it work better when you remove it?

-- 
Jos Backus _/  _/_/_/Santa Clara, CA
  _/  _/   _/
 _/  _/_/_/ 
_/  _/  _/_/
[EMAIL PROTECTED] _/_/   _/_/_/use Std::Disclaimer;

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread Doug Barton

On Wed, 31 Oct 2001, David O'Brien wrote:

 On Wed, Oct 31, 2001 at 04:56:18PM -0800, Steve Kargl wrote:
  On Wed, Oct 31, 2001 at 04:45:58PM -0800, David O'Brien wrote:
   On Wed, Oct 31, 2001 at 03:16:37PM -0800, Steve Kargl wrote:
Can someone revert awk to one that actually works?
  
   Why don't we look at fixing the mkioctls script instead??
 
  That's fine.
 
  But, before pulling the switch on a major utility, it
  would be nice if the committer would actually test the
  new utility.

 I *DID* test it with a full `make world'.  By chance is this your second
 `make world' after the change?  It seems we are using the host awk
 instead of the one we built.  Requiring someone to do two back-to-back
 `make world's before a commit has never been a requirement.  Some things
 we just find out after a commit.

Required isn't really the question. It seems like common sense
to me when discussing such a frequently used build tool.



To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread Mike Barcroft

Doug Barton [EMAIL PROTECTED] writes:
 On Wed, 31 Oct 2001, David O'Brien wrote:
  I *DID* test it with a full `make world'.  By chance is this your second
  `make world' after the change?  It seems we are using the host awk
  instead of the one we built.  Requiring someone to do two back-to-back
  `make world's before a commit has never been a requirement.  Some things
  we just find out after a commit.
 
   Required isn't really the question. It seems like common sense
 to me when discussing such a frequently used build tool.

I'm sure there's better things you could be doing besides lecturing
David about testing his changes before committing.  Not every bug can
be found before committing, which is why we have a little thing called
-CURRENT.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread Jos Backus

(Sigh. In my mkioctls patch I tried to get rid of the need to pass in
$ioctl_includes to awk but I can't think of any way to make that work. Oh
well. Glad it works now.)

-- 
Jos Backus _/  _/_/_/Santa Clara, CA
  _/  _/   _/
 _/  _/_/_/ 
_/  _/  _/_/
[EMAIL PROTECTED] _/_/   _/_/_/use Std::Disclaimer;

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread Doug Barton

On Wed, 31 Oct 2001, Mike Barcroft wrote:

 Doug Barton [EMAIL PROTECTED] writes:
  On Wed, 31 Oct 2001, David O'Brien wrote:
   I *DID* test it with a full `make world'.  By chance is this your second
   `make world' after the change?  It seems we are using the host awk
   instead of the one we built.  Requiring someone to do two back-to-back
   `make world's before a commit has never been a requirement.  Some things
   we just find out after a commit.
 
  Required isn't really the question. It seems like common sense
  to me when discussing such a frequently used build tool.

 I'm sure there's better things you could be doing besides lecturing
 David about testing his changes before committing.  Not every bug can
 be found before committing, which is why we have a little thing called
 -CURRENT.

A) Two sentences isn't a lecture. B) We have a little thing
called -current to shake out the non-obvious bugs that still exist after
all reasonable testing has already occurred. If you're not familiar with
the arguments about how much valuable developer time is wasted due to
insufficiently tested changes, check the archives.

My only purpose in replying was to state my objection to the
sufficency of David's argument. There are a lot of things that aren't
required, but are a good idea none the less.

-- 
We will not tire, we will not falter, and we will not fail.
- George W. Bush, President of the United States
  September 20, 2001

 Do YOU Yahoo!?



To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread David O'Brien

On Wed, Oct 31, 2001 at 10:12:43PM -0800, Doug Barton wrote:
   My only purpose in replying was to state my objection to the
 sufficency of David's argument. There are a lot of things that aren't
 required, but are a good idea none the less.

All I'll say is just about every large change I make, goes thru a
`make buildworld' before committing.  Only about 15% of committers seems
to do this much.

-- 
-- David  ([EMAIL PROTECTED])

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Revert awk to one that works

2001-10-31 Thread Doug Barton

On Wed, 31 Oct 2001, David O'Brien wrote:

 On Wed, Oct 31, 2001 at 10:12:43PM -0800, Doug Barton wrote:
  My only purpose in replying was to state my objection to the
  sufficency of David's argument. There are a lot of things that aren't
  required, but are a good idea none the less.

 All I'll say is just about every large change I make, goes thru a
 `make buildworld' before committing.  Only about 15% of committers seems
 to do this much.

Also a good point. I almost felt bad about picking on you about
this. :)

-- 
We will not tire, we will not falter, and we will not fail.
- George W. Bush, President of the United States
  September 20, 2001

 Do YOU Yahoo!?



To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message