Re: lock reversal in fdalloc()

2002-02-01 Thread Terry Lambert
Alfred Perlstein wrote: > There's a bunch of bogosity in the ordering of allocation of > slots in the filedesc versus filling out the struct file and > insertion into the list that I need to work out. I should be > able to take a swipe at it in a couple of weeks hopefully. It's very tempting to

Re: lock reversal in fdalloc()

2002-02-01 Thread Alfred Perlstein
* Terry Lambert <[EMAIL PROTECTED]> [020201 17:02] wrote: > Bruce Evans wrote: > > > basically it seems to get pissy if it doesn't get the file slot it asks > > > for, so if another thread wins the race here, we'll panic. this problem > > > seems to also exist for 4.x and previous versions of fre

Re: lock reversal in fdalloc()

2002-02-01 Thread Terry Lambert
Bruce Evans wrote: > > basically it seems to get pissy if it doesn't get the file slot it asks > > for, so if another thread wins the race here, we'll panic. this problem > > seems to also exist for 4.x and previous versions of freebsd. > > > > I'd like to get this fixed. Any suggestions? I thi

Re: lock reversal in fdalloc()

2002-02-01 Thread Bruce Evans
On Fri, 1 Feb 2002, Alfred Perlstein wrote: > It's actually safe... however dup2 thinks that we won't race > for the file slot: > > if (new >= fdp->fd_nfiles) { > if ((error = fdalloc(td, new, &i))) { > FILEDESC_UNLOCK(fdp); >

Re: lock reversal in fdalloc()

2002-02-01 Thread Alfred Perlstein
* Alfred Perlstein <[EMAIL PROTECTED]> [020131 10:48] wrote: > * Bruce Evans <[EMAIL PROTECTED]> [020131 09:42] wrote: > > > > I'm not sure that releasing the lock here is safe, but other parts of > > fdalloc() do this. > > I don't think this is safe at a glance, I think it's only safe right > b

Re: lock reversal in fdalloc()

2002-01-31 Thread Alfred Perlstein
* Bruce Evans <[EMAIL PROTECTED]> [020131 09:42] wrote: > Jan 31 18:27:29 gamplex kernel: lock order reversal > Jan 31 18:27:29 gamplex kernel: 1st 0xc26ea034 filedesc structure @ >./@/kern/kern_descrip.c:925 > Jan 31 18:27:29 gamplex kernel: 2nd 0xc031eca0 Giant @ ./@/kern/kern_descrip.c:959 >

lock reversal in fdalloc()

2002-01-31 Thread Bruce Evans
Jan 31 18:27:29 gamplex kernel: lock order reversal Jan 31 18:27:29 gamplex kernel: 1st 0xc26ea034 filedesc structure @ ./@/kern/kern_descrip.c:925 Jan 31 18:27:29 gamplex kernel: 2nd 0xc031eca0 Giant @ ./@/kern/kern_descrip.c:959 %%% Index: kern_descrip.c ===