Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread Eitan Adler
On 17 May 2018 at 21:15, Kurt Jaeger wrote: > Hi! > >> The FreeBSD project could help by asking committers to qualify >> "Sponsored by" lines to indicate which participant(s) is(are) sponsored, >> in way that is equivalent to the way that the actual work itself is >> customarily

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread Maxim Sobolev
You guys are still trying to read and interpret labels on the t-shirts I think. "Sponsored by: XYZ" in the commit message only means that some undefined portion of the work has been in some form supported or encouraged by XYZ. It does not mean or imply all work, it does not mean any particular

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread Kurt Jaeger
Hi! > The FreeBSD project could help by asking committers to qualify > "Sponsored by" lines to indicate which participant(s) is(are) sponsored, > in way that is equivalent to the way that the actual work itself is > customarily attributed. This sounds reasonable, so I suggest that you submit a

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread John W. O'Brien
On 2018/05/17 19:36, Maxim Sobolev wrote: > Well, if your  employer feels  slighted it's for him to bring it up with > you (see my previous rant on the amount and scope of the credit and who > parties involved). And then for you to bring it up with me if you feel > brave enough. :) I don't see how

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread Maxim Sobolev
Well, if your employer feels slighted it's for him to bring it up with you (see my previous rant on the amount and scope of the credit and who parties involved). And then for you to bring it up with me if you feel brave enough. :) I don't see how and why FreeBSD project can help in this highly

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread John W. O'Brien
On 2018/05/17 19:18, Maxim Sobolev wrote: > John, no, not really, sorry. Work is done, credit is given. The form and > amount of this credit is between whoever does the work and whoever is > being credited. I don't see why is there any third-party to be involved > in governing whether or not this

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread Maxim Sobolev
John, no, not really, sorry. Work is done, credit is given. The form and amount of this credit is between whoever does the work and whoever is being credited. I don't see why is there any third-party to be involved in governing whether or not this credit is "appropriate", "sufficient" or "all

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread John W. O'Brien
On 2018/05/14 20:25, Julian Elischer wrote: > On 15/5/18 7:40 am, John W. O'Brien wrote: >> Hello FreeBSD Ports, >> >> The Committer's Guide section on Commit Log Messages [0], doesn't cover >> the use of the "Sponsored by" key word. As a non-committer contributor, >> it only recently occurred to

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread John W. O'Brien
On 2018/05/14 20:14, Maxim Sobolev wrote: > What's wrong with a current practice. Why is it of any concern to you, > John? Just curious that is not very clear from your message. It is like > someone trying to moderate what people in general or some group in > particular (e.g. freebsd committers)

Re: PR looking for committer

2018-05-17 Thread Kurt Jaeger
Hi! > Could someone committer please have a look at this? > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227507 Done, thanks for the submission! -- p...@opsec.eu+49 171 31013722 years to go ! ___

Re: www/firefox-i18n: Install problems on 12.0-CURRENT

2018-05-17 Thread Rainer Hurling
Sorry for answering myself. But I found the changes in Firefox 60.x, please see above. Am 17.05.2018 um 17:30 schrieb Rainer Hurling: > Hi Jan, > > Am 17.05.2018 um 13:21 schrieb Jan Beich: >> Rainer Hurling writes: >> >>> For some time now (Firefox 60.x beta versions and on),

PR looking for committer

2018-05-17 Thread Nikolay Korotkiy
Hi All, Could someone committer please have a look at this? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227507 -- Best regards, Nikolay ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To

www/firefox-i18n: Install problems on 12.0-CURRENT

2018-05-17 Thread Rainer Hurling
Hi Jan, Am 17.05.2018 um 13:21 schrieb Jan Beich: > Rainer Hurling writes: > >> For some time now (Firefox 60.x beta versions and on), I get the >> following error, if I try to install www/firefox-i18n on 12.0-CURRENT >> amd64: > > Can you reproduce with firefox binary built

Re: Should we Rust warnings suggesting adding work/stage/usr/local/bin to the PATH?

2018-05-17 Thread Stefan Esser
Am 17.05.18 um 14:42 schrieb Mateusz Piotrowski: > Hello, > > When I build Rust packages I get warnings like this one: > >> warning: be sure to add >> `/usr/home/0mp/ports/games/genact/work/stage/usr/local/bin` to your PATH to >> be able to run the installed binaries > > It is not very

Should we Rust warnings suggesting adding work/stage/usr/local/bin to the PATH?

2018-05-17 Thread Mateusz Piotrowski
Hello, When I build Rust packages I get warnings like this one: > warning: be sure to add > `/usr/home/0mp/ports/games/genact/work/stage/usr/local/bin` to your PATH to > be able to run the installed binaries It is not very helpful when building ports. Do you think that we should try to mute

Re: www/firefox-i18n: Install problems on 12.0-CURRENT

2018-05-17 Thread Jan Beich
Rainer Hurling writes: > For some time now (Firefox 60.x beta versions and on), I get the > following error, if I try to install www/firefox-i18n on 12.0-CURRENT > amd64: Can you reproduce with firefox binary built by FreeBSD package cluster? $ pkg delete -f firefox $ pkg

www/firefox-i18n: Install problems on 12.0-CURRENT

2018-05-17 Thread Rainer Hurling
For some time now (Firefox 60.x beta versions and on), I get the following error, if I try to install www/firefox-i18n on 12.0-CURRENT amd64: #make make: "/usr/ports/Mk/Uses/gecko.mk" line 48: warning: "/usr/local/bin/firefox --version 2>/dev/null" returned non-zero status ===>

FreeBSD ports you maintain which are out of date

2018-05-17 Thread portscout
Dear port maintainer, The portscout new distfile checker has detected that one or more of your ports appears to be out of date. Please take the opportunity to check each of the ports listed below, and if possible and appropriate, submit/commit an update. If any ports have already been updated,