[Freeciv-commits] r24643 - in /trunk: client/ client/gui-gtk-2.0/ client/gui-gtk-3.0/ client/gui-qt/ client/gui-sdl/ client/gui-sdl2/ client/g...

2014-03-10 Thread sveinung84
Author: sveinung Date: Mon Mar 10 11:47:09 2014 New Revision: 24643 URL: http://svn.gna.org/viewcvs/freeciv?rev=24643view=rev Log: Let the translator decide where to put the action probability The spy action button label text of the Qt and the Gtk clients include the probability of success.

[Freeciv-commits] r24644 - in /trunk: ai/default/aidiplomat.c common/actions.c common/actions.h

2014-03-10 Thread sveinung84
Author: sveinung Date: Mon Mar 10 12:02:14 2014 New Revision: 24644 URL: http://svn.gna.org/viewcvs/freeciv?rev=24644view=rev Log: AI: Check that a city isn't immune to a spy action because of action enablers when thinking about targeting it. See patch #4587 Modified:

[Freeciv-commits] r24655 - /trunk/common/actions.c

2014-03-12 Thread sveinung84
Author: sveinung Date: Wed Mar 12 18:25:05 2014 New Revision: 24655 URL: http://svn.gna.org/viewcvs/freeciv?rev=24655view=rev Log: Action probability for Sabotage Unit (unless it is in a city) See patch #4594 Modified: trunk/common/actions.c Modified: trunk/common/actions.c URL:

[Freeciv-commits] r24698 - /trunk/common/metaknowledge.c

2014-03-19 Thread sveinung84
Author: sveinung Date: Wed Mar 19 16:48:45 2014 New Revision: 24698 URL: http://svn.gna.org/viewcvs/freeciv?rev=24698view=rev Log: Coding style: The brace opening a function body should have its own line. See patch #4617 Modified: trunk/common/metaknowledge.c Modified:

[Freeciv-commits] r24699 - in /trunk: ai/default/aicity.c common/actions.c

2014-03-19 Thread sveinung84
Author: sveinung Date: Wed Mar 19 18:11:41 2014 New Revision: 24699 URL: http://svn.gna.org/viewcvs/freeciv?rev=24699view=rev Log: AI: consider how a building affects a city as a potential action target Take any significant change in what actions a city can be the target of into account when

[Freeciv-commits] r24705 - in /trunk: ai/default/ client/ common/ data/alien/ data/civ1/ data/civ2/ data/civ2civ3/ data/classic/ data/multipla...

2014-03-21 Thread sveinung84
Author: sveinung Date: Fri Mar 21 15:31:03 2014 New Revision: 24705 URL: http://svn.gna.org/viewcvs/freeciv?rev=24705view=rev Log: Replace the No_Incite effect with the Incite City action enabler. Rules to prevent inciting a city can be expressed using target requirements in the action enablers

[Freeciv-commits] r24706 - /trunk/fc_version

2014-03-21 Thread sveinung84
Author: sveinung Date: Fri Mar 21 17:27:07 2014 New Revision: 24706 URL: http://svn.gna.org/viewcvs/freeciv?rev=24706view=rev Log: Update the network capstring (missing part of the previous commit) The network capstring should have been updated when patch #4624 was committed. Modified:

[Freeciv-commits] r24715 - /trunk/ai/default/aidiplomat.c

2014-03-23 Thread sveinung84
Author: sveinung Date: Sun Mar 23 15:05:25 2014 New Revision: 24715 URL: http://svn.gna.org/viewcvs/freeciv?rev=24715view=rev Log: AI: Use the spy action Sabotage Unit if Bribe Unit was impossible. See patch #4153 Modified: trunk/ai/default/aidiplomat.c Modified:

[Freeciv-commits] r24716 - /trunk/common/actions.c

2014-03-23 Thread sveinung84
Author: sveinung Date: Sun Mar 23 15:33:00 2014 New Revision: 24716 URL: http://svn.gna.org/viewcvs/freeciv?rev=24716view=rev Log: Action probability for the Bribe Unit action Don't include information about the bribe cost in the probability. This is so a player can learn the odds of success

[Freeciv-commits] r24717 - /trunk/ai/default/aicity.c

2014-03-24 Thread sveinung84
Author: sveinung Date: Mon Mar 24 16:08:53 2014 New Revision: 24717 URL: http://svn.gna.org/viewcvs/freeciv?rev=24717view=rev Log: AI: Assume that other cities in range get action target immunity too This will increase the motivation to build a wonder that makes many cities immune to an action.

[Freeciv-commits] r24721 - /trunk/ai/default/aicity.c

2014-03-24 Thread sveinung84
Author: sveinung Date: Mon Mar 24 19:55:27 2014 New Revision: 24721 URL: http://svn.gna.org/viewcvs/freeciv?rev=24721view=rev Log: AI: Effects from local range buildings could be active in 1 city When assigning building want a local building requirement could be active in 1 city. It could also,

[Freeciv-commits] r24722 - /branches/S2_5/ai/default/aicity.c

2014-03-24 Thread sveinung84
Author: sveinung Date: Mon Mar 24 19:56:39 2014 New Revision: 24722 URL: http://svn.gna.org/viewcvs/freeciv?rev=24722view=rev Log: AI: Effects from local range buildings could be active in 1 city When assigning building want a local building requirement could be active in 1 city. It could also,

[Freeciv-commits] r24723 - /branches/S2_4/ai/default/aicity.c

2014-03-24 Thread sveinung84
Author: sveinung Date: Mon Mar 24 19:57:57 2014 New Revision: 24723 URL: http://svn.gna.org/viewcvs/freeciv?rev=24723view=rev Log: AI: Effects from local range buildings could be active in 1 city When assigning building want a local building requirement could be active in 1 city. It could also,

[Freeciv-commits] r24726 - /trunk/ai/default/aicity.c

2014-03-25 Thread sveinung84
Author: sveinung Date: Tue Mar 25 20:08:31 2014 New Revision: 24726 URL: http://svn.gna.org/viewcvs/freeciv?rev=24726view=rev Log: AI: Set number of cities in invalid requirement ranges to 0 The ranges adjacent and cadjacent aren't valid for buildings. Set the number of cities in their range to

[Freeciv-commits] r24727 - /branches/S2_5/ai/default/aicity.c

2014-03-25 Thread sveinung84
Author: sveinung Date: Tue Mar 25 20:09:19 2014 New Revision: 24727 URL: http://svn.gna.org/viewcvs/freeciv?rev=24727view=rev Log: AI: Set number of cities in invalid requirement ranges to 0 The ranges adjacent and cadjacent aren't valid for buildings. Set the number of cities in their range to

[Freeciv-commits] r24728 - /branches/S2_4/ai/default/aicity.c

2014-03-25 Thread sveinung84
Author: sveinung Date: Tue Mar 25 20:10:20 2014 New Revision: 24728 URL: http://svn.gna.org/viewcvs/freeciv?rev=24728view=rev Log: AI: Set number of cities in invalid requirement ranges to 0 The ranges adjacent and cadjacent aren't valid for buildings. Set the number of cities in their range to

[Freeciv-commits] r24748 - /trunk/tools/ruledit/rulesave.c

2014-04-02 Thread sveinung84
Author: sveinung Date: Wed Apr 2 17:13:39 2014 New Revision: 24748 URL: http://svn.gna.org/viewcvs/freeciv?rev=24748view=rev Log: Remove obsolete oceanic city gfx tags from city styles in ruledit to make it compile again Patch by Emmet Hikory persia Reported by Emmet Hikory persia See bug

[Freeciv-commits] r24769 - /trunk/server/unithand.c

2014-04-16 Thread sveinung84
Author: sveinung Date: Wed Apr 16 14:55:11 2014 New Revision: 24769 URL: http://svn.gna.org/viewcvs/freeciv?rev=24769view=rev Log: Stop processing unit_get_actions when the request is invalid. Reported by Andreas Rosdal andreasr Patch by Andreas Rosdal andreasr See bug #21900 Modified:

[Freeciv-commits] r24770 - /trunk/server/unithand.c

2014-04-16 Thread sveinung84
Author: sveinung Date: Wed Apr 16 16:25:16 2014 New Revision: 24770 URL: http://svn.gna.org/viewcvs/freeciv?rev=24770view=rev Log: Explicitly return when a diplomat action query won't get the wanted information. At the moment nothing is done after unit_query_impossible() is called. Add an

[Freeciv-commits] r24771 - in /trunk/client: gui-sdl/diplomat_dialog.c gui-sdl2/diplomat_dialog.c

2014-04-16 Thread sveinung84
Author: sveinung Date: Wed Apr 16 23:47:23 2014 New Revision: 24771 URL: http://svn.gna.org/viewcvs/freeciv?rev=24771view=rev Log: SDL clients: Show the probability that a (spy) action will be successful See patch #4654 Modified: trunk/client/gui-sdl/diplomat_dialog.c

[Freeciv-commits] r24807 - in /trunk/client/gui-qt: dialogs.cpp dialogs.h

2014-04-26 Thread sveinung84
Author: sveinung Date: Sat Apr 26 23:49:40 2014 New Revision: 24807 URL: http://svn.gna.org/viewcvs/freeciv?rev=24807view=rev Log: Qt client: Change the way spy action probabilities are displayed. - Show (?%) in stead of a warning icon for known to be unknown. - Remove the text after chance

[Freeciv-commits] r24814 - in /trunk: client/helpdata.c common/requirements.c common/requirements.h

2014-04-27 Thread sveinung84
Author: sveinung Date: Sun Apr 27 19:29:07 2014 New Revision: 24814 URL: http://svn.gna.org/viewcvs/freeciv?rev=24814view=rev Log: Make the function to check if a unit fulfills a requirement vector more reusable - Move it to common requirement code - Make it easy to support other universal

[Freeciv-commits] r24845 - /trunk/server/rssanity.c

2014-05-04 Thread sveinung84
Author: sveinung Date: Sun May 4 14:19:10 2014 New Revision: 24845 URL: http://svn.gna.org/viewcvs/freeciv?rev=24845view=rev Log: Rule set sanity check: the unit type flag Spy requires that Diplomat is set Requested by Marko Lindqvist cazfi See patch #4682 Modified:

[Freeciv-commits] r24846 - /branches/S2_5/server/rssanity.c

2014-05-04 Thread sveinung84
Author: sveinung Date: Sun May 4 14:20:51 2014 New Revision: 24846 URL: http://svn.gna.org/viewcvs/freeciv?rev=24846view=rev Log: Rule set sanity check: the unit type flag Spy requires that Diplomat is set Requested by Marko Lindqvist cazfi See patch #4682 Modified:

[Freeciv-commits] r24867 - /trunk/server/rssanity.c

2014-05-08 Thread sveinung84
Author: sveinung Date: Fri May 9 00:33:34 2014 New Revision: 24867 URL: http://svn.gna.org/viewcvs/freeciv?rev=24867view=rev Log: Remove the extra ' in Spy must be Diplomat ruleset check's error message See bug #22011 Modified: trunk/server/rssanity.c Modified: trunk/server/rssanity.c

[Freeciv-commits] r24868 - /branches/S2_5/server/rssanity.c

2014-05-08 Thread sveinung84
Author: sveinung Date: Fri May 9 00:35:21 2014 New Revision: 24868 URL: http://svn.gna.org/viewcvs/freeciv?rev=24868view=rev Log: Remove the extra ' in Spy must be Diplomat ruleset check's error message See bug #22011 Modified: branches/S2_5/server/rssanity.c Modified:

[Freeciv-commits] r25146 - in /trunk/client/gui-gtk-2.0: choice_dialog.c choice_dialog.h dialogs.c diplomat_dialog.c

2014-06-15 Thread sveinung84
Author: sveinung Date: Sun Jun 15 14:42:25 2014 New Revision: 25146 URL: http://svn.gna.org/viewcvs/freeciv?rev=25146view=rev Log: Gtk2 client: Change the way spy action probabilities are displayed. - Show the action success probability as ?% in stead of showing a warning icon when the

[Freeciv-commits] r25147 - in /trunk/client/gui-gtk-3.0: choice_dialog.c choice_dialog.h dialogs.c diplomat_dialog.c

2014-06-15 Thread sveinung84
Author: sveinung Date: Sun Jun 15 15:32:43 2014 New Revision: 25147 URL: http://svn.gna.org/viewcvs/freeciv?rev=25147view=rev Log: Gtk3 client: Change the way spy action probabilities are displayed. - Show the action success probability as ?% in stead of making the button red when the

[Freeciv-commits] r25363 - /trunk/m4/qt5.m4

2014-07-02 Thread sveinung84
Author: sveinung Date: Wed Jul 2 17:25:17 2014 New Revision: 25363 URL: http://svn.gna.org/viewcvs/freeciv?rev=25363view=rev Log: Also search multiarch folders when looking for Qt 5 (and using GCC) Some systems, like recent versions of Debian, store some architecture specific headers and

[Freeciv-commits] r25364 - /branches/S2_5/m4/qt5.m4

2014-07-02 Thread sveinung84
Author: sveinung Date: Wed Jul 2 17:25:35 2014 New Revision: 25364 URL: http://svn.gna.org/viewcvs/freeciv?rev=25364view=rev Log: Also search multiarch folders when looking for Qt 5 (and using GCC) Some systems, like recent versions of Debian, store some architecture specific headers and

[Freeciv-commits] r25374 - in /trunk: client/packhand.c common/effects.c common/effects.h common/packets.def fc_version

2014-07-02 Thread sveinung84
Author: sveinung Date: Thu Jul 3 03:29:27 2014 New Revision: 25374 URL: http://svn.gna.org/viewcvs/freeciv?rev=25374view=rev Log: Network protocol: Send each effect rule in a single packet. Thanks to the work of Emmet Hikory persia effects now use a single requirement vector. This makes it easy

[Freeciv-commits] r25382 - in /trunk: ai/default/ client/ common/ common/scriptcore/ server/ server/advisors/ server/generator/

2014-07-04 Thread sveinung84
Author: sveinung Date: Fri Jul 4 15:29:40 2014 New Revision: 25382 URL: http://svn.gna.org/viewcvs/freeciv?rev=25382view=rev Log: API change: Make requirement types that check a units state possible Forward unit to is_req_active(), the requirement evaluation function. This is just an API

[Freeciv-commits] r25383 - in /trunk/data: civ2civ3/ classic/ experimental/ multiplayer/

2014-07-04 Thread sveinung84
Author: sveinung Date: Fri Jul 4 18:10:57 2014 New Revision: 25383 URL: http://svn.gna.org/viewcvs/freeciv?rev=25383view=rev Log: Helptext: Don't say that a unit is unbribable more than once. Each user flag adds its description to the generated help text of all unit types that has it. If an

[Freeciv-commits] r25401 - /trunk/tools/ruledit/rulesave.c

2014-07-06 Thread sveinung84
Author: sveinung Date: Sun Jul 6 21:01:52 2014 New Revision: 25401 URL: http://svn.gna.org/viewcvs/freeciv?rev=25401view=rev Log: Make ruledit compile again SVN commit 25397 renamed the advance field preset_cost to cost without updating its use in ruledit's rulesave.c. Update it. See bug bug

[Freeciv-commits] r25410 - in /trunk: client/helpdata.c common/fc_types.h common/requirements.c server/cityturn.c

2014-07-06 Thread sveinung84
Author: sveinung Date: Mon Jul 7 02:39:27 2014 New Revision: 25410 URL: http://svn.gna.org/viewcvs/freeciv?rev=25410view=rev Log: Coding style: rename maxTileUnits to max_tile_units The rest of the Freeciv C code use KR style variable names in stead of camel case. See patch #4903 Modified:

[Freeciv-commits] r25490 - /trunk/common/actions.c

2014-07-11 Thread sveinung84
Author: sveinung Date: Fri Jul 11 13:24:09 2014 New Revision: 25490 URL: http://svn.gna.org/viewcvs/freeciv?rev=25490view=rev Log: Make ap_diplomat_battle() handle battle against a unit in a city For now the only result is that the action probability for bribing a visible unit in a city can be

[Freeciv-commits] r25593 - /trunk/common/actions.h

2014-07-16 Thread sveinung84
Author: sveinung Date: Thu Jul 17 01:46:51 2014 New Revision: 25593 URL: http://svn.gna.org/viewcvs/freeciv?rev=25593view=rev Log: Correct the type of the action struct's actor_kind field Reported by Marko Lindqvist cazfi See bug #22349 Modified: trunk/common/actions.h Modified:

[Freeciv-commits] r25614 - /trunk/common/packets.def

2014-07-18 Thread sveinung84
Author: sveinung Date: Fri Jul 18 13:09:12 2014 New Revision: 25614 URL: http://svn.gna.org/viewcvs/freeciv?rev=25614view=rev Log: Remove the now unused fields REQ_RANGE and REQ_TYPE from packets.def See patch #4962 Modified: trunk/common/packets.def Modified: trunk/common/packets.def URL:

[Freeciv-commits] r25672 - /trunk/data/stub/game.ruleset

2014-07-21 Thread sveinung84
Author: sveinung Date: Mon Jul 21 14:13:06 2014 New Revision: 25672 URL: http://svn.gna.org/viewcvs/freeciv?rev=25672view=rev Log: Make the stub ruleset more minimal by removing all action enablers. See patch #4959 Modified: trunk/data/stub/game.ruleset Modified:

[Freeciv-commits] r25699 - in /trunk: server/rssanity.c utility/registry_ini.c utility/registry_ini.h

2014-07-23 Thread sveinung84
Author: sveinung Date: Wed Jul 23 16:25:38 2014 New Revision: 25699 URL: http://svn.gna.org/viewcvs/freeciv?rev=25699view=rev Log: Check that ruleset supplied specialist names won't break savegames Savegames stores the number of each kind of specialists a city has using the specialist rule name

[Freeciv-commits] r25700 - in /branches/S2_5: server/rssanity.c utility/registry_ini.c utility/registry_ini.h

2014-07-23 Thread sveinung84
Author: sveinung Date: Wed Jul 23 16:26:28 2014 New Revision: 25700 URL: http://svn.gna.org/viewcvs/freeciv?rev=25700view=rev Log: Check that ruleset supplied specialist names won't break savegames Savegames stores the number of each kind of specialists a city has using the specialist rule name

[Freeciv-commits] r25717 - /trunk/common/metaknowledge.c

2014-07-24 Thread sveinung84
Author: sveinung Date: Fri Jul 25 04:57:18 2014 New Revision: 25717 URL: http://svn.gna.org/viewcvs/freeciv?rev=25717view=rev Log: Add meta knowledge for the building (improvement) requirement type. See patch #4977 Modified: trunk/common/metaknowledge.c Modified:

[Freeciv-commits] r25727 - in /trunk: client/ client/gui-gtk-2.0/ client/gui-gtk-3.0/ client/gui-qt/ client/gui-sdl/ client/gui-sdl2/ client/g...

2014-07-25 Thread sveinung84
Author: sveinung Date: Fri Jul 25 11:56:40 2014 New Revision: 25727 URL: http://svn.gna.org/viewcvs/freeciv?rev=25727view=rev Log: Share the code adding the success probability to a spy actions button text Bonus: the Xaw client will now display a spy actions success probability See patch #4980

[Freeciv-commits] r25728 - in /branches/S2_4: server/ruleset.c utility/registry.c utility/registry.h

2014-07-25 Thread sveinung84
Author: sveinung Date: Fri Jul 25 12:35:54 2014 New Revision: 25728 URL: http://svn.gna.org/viewcvs/freeciv?rev=25728view=rev Log: Check that ruleset supplied specialist names won't break savegames Savegames stores the number of each kind of specialists a city has using the specialist rule name

[Freeciv-commits] r25731 - in /branches/S2_5/common: aicore/pf_tools.c combat.c

2014-07-26 Thread sveinung84
Author: sveinung Date: Sun Jul 27 00:12:47 2014 New Revision: 25731 URL: http://svn.gna.org/viewcvs/freeciv?rev=25731view=rev Log: Make the nativity limits on the source tile for regular attacks consistent Make everything test if the attacking unit can exist on its tile like

[Freeciv-commits] r25730 - in /trunk/common: aicore/pf_tools.c combat.c

2014-07-26 Thread sveinung84
Author: sveinung Date: Sun Jul 27 00:09:51 2014 New Revision: 25730 URL: http://svn.gna.org/viewcvs/freeciv?rev=25730view=rev Log: Make the nativity limits on the source tile for regular attacks consistent Make everything test if the attacking unit can exist on its tile like

[Freeciv-commits] r25732 - in /trunk: ./ client/ common/ doc/ server/

2014-07-26 Thread sveinung84
Author: sveinung Date: Sun Jul 27 02:06:40 2014 New Revision: 25732 URL: http://svn.gna.org/viewcvs/freeciv?rev=25732view=rev Log: Introduce the UnitState requirement type with the test Transported Add the new requirement type UnitState. UnitState is for checking the properties of a unit's

[Freeciv-commits] r25738 - in /trunk: client/helpdata.c common/actions.c

2014-07-28 Thread sveinung84
Author: sveinung Date: Mon Jul 28 11:56:23 2014 New Revision: 25738 URL: http://svn.gna.org/viewcvs/freeciv?rev=25738view=rev Log: Improve the action UI name getter functions Change action_get_ui_name() so it will return the name without anything else. Use it for mentioning actions in the

[Freeciv-commits] r25748 - /trunk/common/metaknowledge.c

2014-07-30 Thread sveinung84
Author: sveinung Date: Wed Jul 30 13:28:54 2014 New Revision: 25748 URL: http://svn.gna.org/viewcvs/freeciv?rev=25748view=rev Log: Metaknowledge for Terrain, TerrainFlag, TerrainClass, Resource, Extra, BaseFlag and RoadFlag See patch #4996 Modified: trunk/common/metaknowledge.c Modified:

[Freeciv-commits] r25749 - /trunk/server/ruleset.c

2014-07-30 Thread sveinung84
Author: sveinung Date: Wed Jul 30 13:45:56 2014 New Revision: 25749 URL: http://svn.gna.org/viewcvs/freeciv?rev=25749view=rev Log: Only append requirements to action enablers when loading the rules to play Reported by Emmet Hikory persia and Marko Lindqvist cazfi See bug #22401 Modified:

[Freeciv-commits] r25755 - in /trunk/common: actions.c unit.c

2014-07-31 Thread sveinung84
Author: sveinung Date: Thu Jul 31 11:22:30 2014 New Revision: 25755 URL: http://svn.gna.org/viewcvs/freeciv?rev=25755view=rev Log: Make the source tile limit on spy actions a hard action enabler requirement Move the requirement that the actor must be able to exist on its tile (the source tile)

[Freeciv-commits] r25762 - /trunk/server/diplomats.c

2014-08-01 Thread sveinung84
Author: sveinung Date: Fri Aug 1 12:03:05 2014 New Revision: 25762 URL: http://svn.gna.org/viewcvs/freeciv?rev=25762view=rev Log: Fix spy stealing of future techs and of techs chosen by the spy The renumbering of A_UNSET and A_FUTURE in r25394 broke stealing future techs and letting the spy

[Freeciv-commits] r25839 - /trunk/doc/README.actions

2014-08-06 Thread sveinung84
Author: sveinung Date: Wed Aug 6 10:59:45 2014 New Revision: 25839 URL: http://svn.gna.org/viewcvs/freeciv?rev=25839view=rev Log: Document more hard requirements in doc/README.actions See patch #5017 Modified: trunk/doc/README.actions Modified: trunk/doc/README.actions URL:

[Freeciv-commits] r25843 - /trunk/doc/README.actions

2014-08-07 Thread sveinung84
Author: sveinung Date: Thu Aug 7 12:53:51 2014 New Revision: 25843 URL: http://svn.gna.org/viewcvs/freeciv?rev=25843view=rev Log: Rewrite description of action enablers in doc/README.actions See patch #5018 Modified: trunk/doc/README.actions Modified: trunk/doc/README.actions URL:

[Freeciv-commits] r25877 - in /trunk: data/alien/ data/civ1/ data/civ2/ data/civ2civ3/ data/classic/ data/experimental/ data/multiplayer/ data...

2014-08-12 Thread sveinung84
Author: sveinung Date: Tue Aug 12 15:01:31 2014 New Revision: 25877 URL: http://svn.gna.org/viewcvs/freeciv?rev=25877view=rev Log: Document that hard action requirements may be appended patch #5019 Modified: trunk/data/alien/game.ruleset trunk/data/civ1/game.ruleset

[Freeciv-commits] r25917 - /trunk/common/unit.c

2014-08-15 Thread sveinung84
Author: sveinung Date: Fri Aug 15 11:37:15 2014 New Revision: 25917 URL: http://svn.gna.org/viewcvs/freeciv?rev=25917view=rev Log: Bribing or sabotaging your own units should not be allowed. See bug #22469 Modified: trunk/common/unit.c Modified: trunk/common/unit.c URL:

[Freeciv-commits] r25918 - /trunk/client/control.c

2014-08-15 Thread sveinung84
Author: sveinung Date: Fri Aug 15 16:08:07 2014 New Revision: 25918 URL: http://svn.gna.org/viewcvs/freeciv?rev=25918view=rev Log: Make key_unit_diplomat_actions() dumber and therefore less redundant Before spy acting against own tile key_unit_diplomat_actions() will check that there is a

[Freeciv-commits] r25928 - /trunk/common/unittype.c

2014-08-17 Thread sveinung84
Author: sveinung Date: Sun Aug 17 11:10:05 2014 New Revision: 25928 URL: http://svn.gna.org/viewcvs/freeciv?rev=25928view=rev Log: Add comments that should have been a part of patch #5020 See patch #5020 Modified: trunk/common/unittype.c Modified: trunk/common/unittype.c URL:

[Freeciv-commits] r25941 - in /trunk: common/ data/alien/ data/civ1/ data/civ2/ data/civ2civ3/ data/classic/ data/experimental/ data/multiplay...

2014-08-18 Thread sveinung84
Author: sveinung Date: Tue Aug 19 00:35:34 2014 New Revision: 25941 URL: http://svn.gna.org/viewcvs/freeciv?rev=25941view=rev Log: The rule that a spy unit must have moves left to act now lives in the ruleset If the requirement is removed from the spy action's action enabler the player can do

[Freeciv-commits] r25942 - /trunk/client/gui-sdl/diplomat_dialog.c

2014-08-19 Thread sveinung84
Author: sveinung Date: Tue Aug 19 10:51:03 2014 New Revision: 25942 URL: http://svn.gna.org/viewcvs/freeciv?rev=25942view=rev Log: SDL 1 client: Use the spy actor unit provided by the API in stead of guessing it See patch #5050 Modified: trunk/client/gui-sdl/diplomat_dialog.c Modified:

[Freeciv-commits] r25943 - /trunk/client/gui-sdl2/diplomat_dialog.c

2014-08-19 Thread sveinung84
Author: sveinung Date: Tue Aug 19 11:15:46 2014 New Revision: 25943 URL: http://svn.gna.org/viewcvs/freeciv?rev=25943view=rev Log: SDL 2 client: Use the spy actor unit provided by the API in stead of guessing it See patch #5051 Modified: trunk/client/gui-sdl2/diplomat_dialog.c Modified:

[Freeciv-commits] r25944 - in /trunk/client: options.c options.h packhand.c

2014-08-19 Thread sveinung84
Author: sveinung Date: Tue Aug 19 11:31:26 2014 New Revision: 25944 URL: http://svn.gna.org/viewcvs/freeciv?rev=25944view=rev Log: Pop up the spy action dialog when a spy arrives at a city by transport When a unit that can establish a trade route arrives at a city by transport the trade route

[Freeciv-commits] r25945 - in /trunk/client: gui-sdl/diplomat_dialog.c gui-sdl2/diplomat_dialog.c packhand.c

2014-08-19 Thread sveinung84
Author: sveinung Date: Tue Aug 19 11:53:43 2014 New Revision: 25945 URL: http://svn.gna.org/viewcvs/freeciv?rev=25945view=rev Log: Let the player know what unit a diplomat dialog is about by focusing on it. The SDL clients already had this feature. Move its code to shared code so all the clients

[Freeciv-commits] r25958 - in /trunk/client: gui-sdl/diplomat_dialog.c gui-sdl2/diplomat_dialog.c

2014-08-20 Thread sveinung84
Author: sveinung Date: Wed Aug 20 11:16:12 2014 New Revision: 25958 URL: http://svn.gna.org/viewcvs/freeciv?rev=25958view=rev Log: SDL clients: Fix segfault during industrial sabotage in a city with no buildings The dialog were the building to sabotage would only initialize the variable

[Freeciv-commits] r25959 - /branches/S2_5/client/gui-sdl/diplomat_dialog.c

2014-08-20 Thread sveinung84
Author: sveinung Date: Wed Aug 20 11:16:56 2014 New Revision: 25959 URL: http://svn.gna.org/viewcvs/freeciv?rev=25959view=rev Log: SDL clients: Fix segfault during industrial sabotage in a city with no buildings The dialog were the building to sabotage would only initialize the variable

[Freeciv-commits] r25960 - /branches/S2_4/client/gui-sdl/diplomat_dialog.c

2014-08-20 Thread sveinung84
Author: sveinung Date: Wed Aug 20 11:17:37 2014 New Revision: 25960 URL: http://svn.gna.org/viewcvs/freeciv?rev=25960view=rev Log: SDL clients: Fix segfault during industrial sabotage in a city with no buildings The dialog were the building to sabotage would only initialize the variable

[Freeciv-commits] r25970 - /trunk/bootstrap/

2014-08-21 Thread sveinung84
Author: sveinung Date: Thu Aug 21 11:52:27 2014 New Revision: 25970 URL: http://svn.gna.org/viewcvs/freeciv?rev=25970view=rev Log: Add keywords to desktop files Patch by Markus Koschany a...@gambaru.de See bug #21573 Modified: trunk/bootstrap/freeciv-gtk2.desktop.in

[Freeciv-commits] r25971 - /branches/S2_5/bootstrap/

2014-08-21 Thread sveinung84
Author: sveinung Date: Thu Aug 21 11:53:09 2014 New Revision: 25971 URL: http://svn.gna.org/viewcvs/freeciv?rev=25971view=rev Log: Add keywords to desktop files Patch by Markus Koschany a...@gambaru.de See bug #21573 Modified: branches/S2_5/bootstrap/freeciv-gtk2.desktop.in

[Freeciv-commits] r25972 - /branches/S2_4/bootstrap/

2014-08-21 Thread sveinung84
Author: sveinung Date: Thu Aug 21 11:53:30 2014 New Revision: 25972 URL: http://svn.gna.org/viewcvs/freeciv?rev=25972view=rev Log: Add keywords to desktop files Patch by Markus Koschany a...@gambaru.de See bug #21573 Modified: branches/S2_4/bootstrap/freeciv-gtk3.desktop.in

[Freeciv-commits] r25988 - in /trunk: ai/default/ client/ client/gui-sdl/ client/gui-sdl2/ common/ common/aicore/ server/

2014-08-21 Thread sveinung84
Author: sveinung Date: Thu Aug 21 20:14:19 2014 New Revision: 25988 URL: http://svn.gna.org/viewcvs/freeciv?rev=25988view=rev Log: Start isolating the actor meaning of the Diplomat unit flag The Diplomat unit flag signals that a unit can defend against diplomatic actions, that it can perform

[Freeciv-commits] r25995 - /trunk/server/unithand.c

2014-08-22 Thread sveinung84
Author: sveinung Date: Fri Aug 22 14:49:47 2014 New Revision: 25995 URL: http://svn.gna.org/viewcvs/freeciv?rev=25995view=rev Log: Try to explain why no action currently is possible when asked by the client It is possible that no action will be possible when the client asks the server for the

[Freeciv-commits] r25996 - /trunk/client/packhand.c

2014-08-22 Thread sveinung84
Author: sveinung Date: Fri Aug 22 15:20:10 2014 New Revision: 25996 URL: http://svn.gna.org/viewcvs/freeciv?rev=25996view=rev Log: Focus on the acting unit before asking for extra information about a spy action The spy action targeted sabotage requires the player to select a target. The spy

[Freeciv-commits] r26015 - /trunk/doc/README.actions

2014-08-24 Thread sveinung84
Author: sveinung Date: Sun Aug 24 16:10:25 2014 New Revision: 26015 URL: http://svn.gna.org/viewcvs/freeciv?rev=26015view=rev Log: Document maximum distance between actor and target for Steal Tech Steal Tech must be done from the same tile as the target or from the tile next to it. The same

[Freeciv-commits] r26014 - in /trunk: common/fc_types.h common/player.c common/player.h common/requirements.c doc/README.effects

2014-08-24 Thread sveinung84
Author: sveinung Date: Sun Aug 24 16:10:20 2014 New Revision: 26014 URL: http://svn.gna.org/viewcvs/freeciv?rev=26014view=rev Log: New diplomatic relationship requirement type property foreign Only support the local range since that is the only place it makes sense. See patch #5068 Modified:

[Freeciv-commits] r26016 - /trunk/fc_version

2014-08-24 Thread sveinung84
Author: sveinung Date: Sun Aug 24 16:23:51 2014 New Revision: 26016 URL: http://svn.gna.org/viewcvs/freeciv?rev=26016view=rev Log: Update Network capability string for patch #5068 I forgot to update it before the patch was comitted. Reported by Marko Lindqvist cazfi on the mailing list See

[Freeciv-commits] r26031 - in /trunk/client: climisc.c climisc.h gui-sdl/menu.c gui-sdl2/menu.c

2014-08-25 Thread sveinung84
Author: sveinung Date: Mon Aug 25 13:52:15 2014 New Revision: 26031 URL: http://svn.gna.org/viewcvs/freeciv?rev=26031view=rev Log: SDL clients: don't use client side knowledge to evaluate action enablers Checking for what diplomatic actions are possible in the client can give the wrong result

[Freeciv-commits] r26047 - in /trunk/common: fc_types.h player.h terrain.h unittype.h

2014-08-26 Thread sveinung84
Author: sveinung Date: Tue Aug 26 14:02:00 2014 New Revision: 26047 URL: http://svn.gna.org/viewcvs/freeciv?rev=26047view=rev Log: Mark enums used in universal as used in the network protocol universals_u can hold the values of some enums. When one of those enums change the meaning universal

[Freeciv-commits] r26075 - /trunk/common/unittype.c

2014-08-27 Thread sveinung84
Author: sveinung Date: Wed Aug 27 11:49:02 2014 New Revision: 26075 URL: http://svn.gna.org/viewcvs/freeciv?rev=26075view=rev Log: Infer if a unit type is an actor from the action enablers, not Diplomat Up until now a unit have been seen as a potential actor if it has the Diplomat unit type

[Freeciv-commits] r26091 - /trunk/common/player.c

2014-08-28 Thread sveinung84
Author: sveinung Date: Thu Aug 28 13:08:34 2014 New Revision: 26091 URL: http://svn.gna.org/viewcvs/freeciv?rev=26091view=rev Log: Fix spelling mistake in comment in diplrel_by_rule_name() See bug #22524 Modified: trunk/common/player.c Modified: trunk/common/player.c URL:

[Freeciv-commits] r26092 - in /trunk: common/terrain.h fc_version

2014-08-28 Thread sveinung84
Author: sveinung Date: Thu Aug 28 14:07:17 2014 New Revision: 26092 URL: http://svn.gna.org/viewcvs/freeciv?rev=26092view=rev Log: Define bv_terrain_flags in terrain_flag_id using SPECENUM_BITVECTOR. * Makes bv_terrain_flags follow the size of the enum terrain_flag_id. * Makes bv_terrain_flags's

[Freeciv-commits] r26093 - in /trunk: common/unittype.h fc_version

2014-08-28 Thread sveinung84
Author: sveinung Date: Thu Aug 28 14:07:22 2014 New Revision: 26093 URL: http://svn.gna.org/viewcvs/freeciv?rev=26093view=rev Log: Define bv_unit_type_flags in unit_type_flag_id using SPECENUM_BITVECTOR. * Makes bv_unit_type_flags follow the size of the enum unit_type_flag_id. * Makes

[Freeciv-commits] r26094 - in /trunk: ./ client/ client/gui-gtk-2.0/ client/gui-gtk-3.0/ client/gui-qt/ client/gui-sdl/ client/gui-sdl2/ clien...

2014-08-28 Thread sveinung84
Author: sveinung Date: Thu Aug 28 15:05:34 2014 New Revision: 26094 URL: http://svn.gna.org/viewcvs/freeciv?rev=26094view=rev Log: Change the packet UNIT_DIPLOMAT_QUERY to UNIT_ACTION_QUERY * Use gen_action in stead of diplomat_actions to name the action. * There is no need for a value field.

[Freeciv-commits] r26132 - in /trunk: common/ data/alien/ data/civ1/ data/civ2/ data/civ2civ3/ data/classic/ data/experimental/ data/multiplay...

2014-08-29 Thread sveinung84
Author: sveinung Date: Fri Aug 29 12:57:20 2014 New Revision: 26132 URL: http://svn.gna.org/viewcvs/freeciv?rev=26132view=rev Log: Move the rule that an actor must have the Diplomat flag to the ruleset The Diplomat unit type flag should now only be about the ability to defend against spy

[Freeciv-commits] r26134 - in /trunk: ./ ai/default/ client/ common/ doc/ server/

2014-08-29 Thread sveinung84
Author: sveinung Date: Fri Aug 29 13:45:03 2014 New Revision: 26134 URL: http://svn.gna.org/viewcvs/freeciv?rev=26134view=rev Log: New requirement type MinHitPoints See patch #5135 Modified: trunk/ai/default/daieffects.c trunk/client/helpdata.c trunk/common/fc_types.h

[Freeciv-commits] r26151 - in /trunk: client/packhand.c common/packets.def fc_version server/unithand.c

2014-08-30 Thread sveinung84
Author: sveinung Date: Sun Aug 31 02:11:39 2014 New Revision: 26151 URL: http://svn.gna.org/viewcvs/freeciv?rev=26151view=rev Log: Change the packet UNIT_DIPLOMAT_ANSWER to UNIT_ACTION_ANSWER See patch #5141 Modified: trunk/client/packhand.c trunk/common/packets.def trunk/fc_version

[Freeciv-commits] r26157 - in /trunk: common/ data/civ2/ data/civ2civ3/ data/classic/ data/experimental/ data/multiplayer/ doc/ server/

2014-08-31 Thread sveinung84
Author: sveinung Date: Sun Aug 31 14:25:31 2014 New Revision: 26157 URL: http://svn.gna.org/viewcvs/freeciv?rev=26157view=rev Log: Move the rule that a unit with 1 hit point can't be sabotaged to the ruleset See patch #5147 Modified: trunk/common/actions.c trunk/data/civ2/game.ruleset

[Freeciv-commits] r26160 - in /trunk/data: civ2/ civ2civ3/ classic/ experimental/ multiplayer/

2014-09-01 Thread sveinung84
Author: sveinung Date: Mon Sep 1 14:25:01 2014 New Revision: 26160 URL: http://svn.gna.org/viewcvs/freeciv?rev=26160view=rev Log: Remove redundant Diplomat flag checks from action enablers Some action enablers require the Spy unit flag. The Spy unit flag requires the Diplomat unit flag.

[Freeciv-commits] r26186 - /trunk/client/gui-qt/dialogs.cpp

2014-09-02 Thread sveinung84
Author: sveinung Date: Tue Sep 2 14:25:03 2014 New Revision: 26186 URL: http://svn.gna.org/viewcvs/freeciv?rev=26186view=rev Log: Qt client: Use the actor and target provided by the API when it is there The API of the dialogs containing follow up questions about the spy actions for targeted

[Freeciv-commits] r26187 - in /trunk: client/packhand.c common/actions.c common/packets.def fc_version server/unithand.c

2014-09-02 Thread sveinung84
Author: sveinung Date: Tue Sep 2 15:09:11 2014 New Revision: 26187 URL: http://svn.gna.org/viewcvs/freeciv?rev=26187view=rev Log: Make action target selection server side. See patch #5150 Modified: trunk/client/packhand.c trunk/common/actions.c trunk/common/packets.def

[Freeciv-commits] r26196 - in /trunk: ai/default/ client/gui-gtk-2.0/ client/gui-gtk-3.0/ client/gui-qt/ client/gui-sdl/ client/gui-sdl2/ clie...

2014-09-03 Thread sveinung84
Author: sveinung Date: Wed Sep 3 14:30:07 2014 New Revision: 26196 URL: http://svn.gna.org/viewcvs/freeciv?rev=26196view=rev Log: Move the test that an actor unit is close enough to its target to actions.c Remove diplomat_can_do_action() since this makes it redundant. See patch #5156

[Freeciv-commits] r26204 - in /trunk/client: gui-gtk-2.0/diplomat_dialog.c gui-gtk-3.0/diplomat_dialog.c

2014-09-03 Thread sveinung84
Author: sveinung Date: Wed Sep 3 16:05:02 2014 New Revision: 26204 URL: http://svn.gna.org/viewcvs/freeciv?rev=26204view=rev Log: Gtk clients: Don't store spy action information in static variables Unlike the other clients the Gtk clients won't wait until the previous spy action is complete,

[Freeciv-commits] r26205 - in /branches/S2_5/client: gui-gtk-2.0/diplomat_dialog.c gui-gtk-3.0/diplomat_dialog.c

2014-09-03 Thread sveinung84
Author: sveinung Date: Wed Sep 3 16:24:05 2014 New Revision: 26205 URL: http://svn.gna.org/viewcvs/freeciv?rev=26205view=rev Log: Gtk clients: Don't store spy action information in static variables Unlike the other clients the Gtk clients won't wait until the previous spy action is complete,

[Freeciv-commits] r26214 - in /trunk/client/gui-qt: dialogs.cpp fc_client.cpp fc_client.h

2014-09-04 Thread sveinung84
Author: sveinung Date: Thu Sep 4 14:34:55 2014 New Revision: 26214 URL: http://svn.gna.org/viewcvs/freeciv?rev=26214view=rev Log: Qt client: Remove get_current_unit() and set_current_unit(). Make their only remaining user, the selection of what tech to steal, pass the action information forward

[Freeciv-commits] r26215 - /trunk/server/unithand.c

2014-09-04 Thread sveinung84
Author: sveinung Date: Thu Sep 4 14:50:08 2014 New Revision: 26215 URL: http://svn.gna.org/viewcvs/freeciv?rev=26215view=rev Log: Use the knowledge of the player to see if a move triggers an action. The server side function unit_move_handling() figures out if a move triggers a spy action. If it

[Freeciv-commits] r26222 - in /trunk/client: gui-gtk-2.0/ gui-gtk-3.0/ gui-qt/ gui-sdl/ gui-sdl2/ gui-xaw/

2014-09-05 Thread sveinung84
Author: sveinung Date: Fri Sep 5 10:02:39 2014 New Revision: 26222 URL: http://svn.gna.org/viewcvs/freeciv?rev=26222view=rev Log: Don't show the Keep moving option when acting against the actor's own tile The actor can't move to the tile he already is on. The Keep moving option should therefore

[Freeciv-commits] r26224 - /trunk/common/metaknowledge.c

2014-09-05 Thread sveinung84
Author: sveinung Date: Fri Sep 5 10:02:47 2014 New Revision: 26224 URL: http://svn.gna.org/viewcvs/freeciv?rev=26224view=rev Log: Clean up: use is_tile_seen() in metaknowledge.c (when possible) See patch #5162 Modified: trunk/common/metaknowledge.c Modified: trunk/common/metaknowledge.c

[Freeciv-commits] r26232 - in /branches/S2_4/client: ./ gui-gtk-2.0/ gui-gtk-3.0/ gui-qt/ gui-sdl/ gui-stub/ gui-xaw/ include/

2014-09-05 Thread sveinung84
Author: sveinung Date: Fri Sep 5 10:53:18 2014 New Revision: 26232 URL: http://svn.gna.org/viewcvs/freeciv?rev=26232view=rev Log: Pass the acting diplomat from the generic to the specific client code All packets asking follow up questions about a spy action contain the ID of the acting

[Freeciv-commits] r26233 - in /branches/S2_4/client: gui-gtk-2.0/diplomat_dialog.c gui-gtk-3.0/diplomat_dialog.c

2014-09-05 Thread sveinung84
Author: sveinung Date: Fri Sep 5 10:53:21 2014 New Revision: 26233 URL: http://svn.gna.org/viewcvs/freeciv?rev=26233view=rev Log: Gtk clients: Don't store spy action information in static variables Unlike the other clients the Gtk clients won't wait until the previous spy action is complete,

[Freeciv-commits] r26250 - in /trunk: common/unit.h server/diplomats.c

2014-09-06 Thread sveinung84
Author: sveinung Date: Sun Sep 7 04:07:06 2014 New Revision: 26250 URL: http://svn.gna.org/viewcvs/freeciv?rev=26250view=rev Log: Use gen_action in stead of diplomat_actions in maybe_cause_incident() This was the last remaining user of the enum diplomat_actions. Remove it. See patch #5178

[Freeciv-commits] r26280 - /trunk/client/gui-qt/dialogs.cpp

2014-09-07 Thread sveinung84
Author: sveinung Date: Sun Sep 7 15:21:56 2014 New Revision: 26280 URL: http://svn.gna.org/viewcvs/freeciv?rev=26280view=rev Log: Qt client: Add information to the action selection dialog text. If there is a target city add its name. If there is a target city and the actor unit has a home city

  1   2   3   4   5   6   7   8   9   10   >