URL:
http://gna.org/bugs/?13803
Summary: [Patch] Start position cleanup and extension
Project: Freeciv
Submitted by: mbook
Submitted on: Sunday 06/28/2009 at 06:07
Category: editor
Severity: 3 - Normal
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40833
(gdb) bt full
#0 0xb7f5b430 in __kernel_vsyscall ()
No symbol table info available.
#1 0xb77916d0 in raise () from /lib/tls/i686/cmov/libc.so.6
No symbol table info available.
#2 0xb7793098 in abort () from
Follow-up Comment #1, bug #13770 (project freeciv):
Added macro pf_map_iterate_move_costs to iterate only the move cost, which
should work faster than pf_map_iterate_positions, especially in the AI code.
Also, added the functions pf_*_map_iterate_until(), which prevents to iterate
the whole map
URL:
http://gna.org/bugs/?13804
Summary: remove unused function prototype
report_server_options()
Project: Freeciv
Submitted by: syntron
Submitted on: Sonntag 28.06.2009 um 14:16
Category: general
URL:
http://gna.org/bugs/?13805
Summary: [patch] change call by id (int) to call by
reference (struct settings_s)
Project: Freeciv
Submitted by: syntron
Submitted on: Sonntag 28.06.2009 um 14:21
Category: general
Update of bug #13804 (project freeciv):
Assigned to:None = cazfi
___
Reply to this item at:
http://gna.org/bugs/?13804
___
Message sent
URL:
http://gna.org/bugs/?13807
Summary: [patch] define the settings within a function
Project: Freeciv
Submitted by: syntron
Submitted on: Sonntag 28.06.2009 um 17:31
Category: general
Severity: 2 -
Update of bug #13805 (project freeciv):
Assigned to:None = mbook
___
Follow-up Comment #1:
This patch is good, but you can reduce references to the
global variable 'settings' even more
Follow-up Comment #2, bug #13805 (project freeciv):
In case you want git to use your public name and
email address (instead of using information from the
local machine), use
git config --global user.name Your Name Comes Here
git config --global user.email y...@yourdomain.example.com
to set
Update of bug #13807 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13807
___
Message sent
Follow-up Comment #1, bug #13807 (project freeciv):
I'm not sure that we need to get rid of the static
'settings' array and use dynamic memory for settings,
since even with your approach there will still be at
least one variable global to the settings.c file.
If you are worried that you cannot
Follow-up Comment #3, bug #13805 (project freeciv):
This patch is good, but you can reduce references to the
global variable 'settings' even more by using helper
functions to get a setting pointer from a setting id:
So ideally there would be _no_ global variable settings
but helper
Follow-up Comment #3, bug #13807 (project freeciv):
If you are worried that you cannot use static initializers
with unions, you need not be, since you can use the
syntax:
union foo {
int i;
const char *s;
bool b;
};
union foo f1 = { .b = TRUE };
union foo f2 = { .s = hi };
Update of bug #13670 (project freeciv):
Category:None = general
Status:None = Fixed
Assigned to:None = cazfi
Open/Closed:
Follow-up Comment #4, bug #13807 (project freeciv):
This will help! The 'static initializers' error message
was the reason for me to try it with a function. Is an
union portable to win, ...?
Struct/union initializers are part of the c language
(but not c++ apparently), so it should work with
URL:
http://gna.org/bugs/?13810
Summary: [patch] use unions to save the game settings
Project: Freeciv
Submitted by: syntron
Submitted on: Sonntag 28.06.2009 um 22:07
Category: general
Severity: 2 - Minor
Follow-up Comment #1, bug #13810 (project freeciv):
Why not using the union like:
union {
struct {
bool *value;
const bool default_value;
const bool_validate_func_t validate;
} boolean;
struct {
int *value;
const int default_value;
const int min_value;
const int
Update of bug #13810 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13810
___
Message sent
Follow-up Comment #3, bug #13810 (project freeciv):
It looks really better and understandable to me. More
over, it should take the minimal size of the whole
structure, and not an addition of all of them.
I agree with pepeto, the union of structs would
probably make more sense, since what we
Follow-up Comment #4, bug #13810 (project freeciv):
static inline bool setting_boolval(conct struct setting_s *op)
That should be const of course.
I'm also not sure about the naming scheme, since
with the full setting_ prefix this makes it a
little awkward to use in expressions.
Perhaps just
URL:
http://gna.org/bugs/?13811
Summary: [Patch] string vector
Project: Freeciv
Submitted by: pepeto
Submitted on: Monday 06/29/2009 at 02:47
Category: general
Severity: 2 - Minor
Update of bug #13811 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13811
___
Message sent
22 matches
Mail list logo
