[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already

2013-04-30 Thread RafałMużyło
Follow-up Comment #2, patch #3889 (project freeciv): In random order: - gtk_rc_get_theme_dir is an annoyance: it was a concept change in gtk3, css themes are read from by default from paths hardcoded on (gtk+) build time (i.e. ${prefix}/share/themes), so there's no real equivalent for it - creat

[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already

2013-04-30 Thread Marko Lindqvist
Follow-up Comment #1, patch #3889 (project freeciv): Attached is deprecation warnings from current TRUNK when built against gtk+-3.4.0. (file #17867) ___ Additional Item Attachment: File name: stderr.log Size:2 KB

[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already

2013-04-30 Thread Marko Lindqvist
URL: Summary: [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already Project: Freeciv Submitted by: cazfi Submitted on: Wed 01 May 2013 02:07:05 AM EEST Category: client-gtk-

[Freeciv-Dev] [patch #3730] Remove MAX_LEN_USERNAME

2013-04-30 Thread Marko Lindqvist
Update of patch #3730 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #3885] base_assess_defense_unit() BadCityDefender handling

2013-04-30 Thread Marko Lindqvist
Update of patch #3885 (project freeciv): Planned Release:2.5.0, 2.6.0 => 2.6.0 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #3867] Drop map_move_cost_ai()

2013-04-30 Thread Marko Lindqvist
Update of patch #3867 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #20721] Recursive logging

2013-04-30 Thread Marko Lindqvist
Update of bug #20721 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

Re: [Freeciv-Dev] Here be dragons

2013-04-30 Thread Sveinung Kvilhaugsvik
On 4/30/13, Bernd Jendrissek wrote: > The focus is on testing client and server behaviour overall, packets be > damned, so not really in the same category as your recorder tool. It still looks interesting. I wrote my recorder because I'll need records on the level of player actions for another pr

[Freeciv-Dev] [patch #3826] Allow bases on city tiles

2013-04-30 Thread Marko Lindqvist
Update of patch #3826 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

Re: [Freeciv-Dev] Here be dragons

2013-04-30 Thread Bernd Jendrissek
Now is as opportune a time to mention this as any... On Mon, Apr 29, 2013 at 2:49 AM, Sveinung Kvilhaugsvik wrote: > It may also have potential as a real paranoid > debugging tool by testing that each packet is the same when nothing is > supposed to have changed (not implemented yet). Here's ano

[Freeciv-Dev] [patch #3885] base_assess_defense_unit() BadCityDefender handling

2013-04-30 Thread Emmet Hikory
Follow-up Comment #3, patch #3885 (project freeciv): Indeed, looking through the call stack, the couple places where it is called without a check that pcity != NULL happen to be in city iterations, where it is safe to assume pcity isn't null (or the iterator is broken, which is a larger issue). I

[Freeciv-Dev] [patch #3885] base_assess_defense_unit() BadCityDefender handling

2013-04-30 Thread Marko Lindqvist
Follow-up Comment #2, patch #3885 (project freeciv): Extra check for pcity != NULL makes sense for future compatibility, but note that currently this function is used for selecting city defenders only, i.e., it should never be called with pcity == NULL. ___

[Freeciv-Dev] [bug #20747] Units in nested transport considered defensive units

2013-04-30 Thread Marko Lindqvist
Update of bug #20747 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at: