Update of bug #13891 (project freeciv):
Status:None = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #17, bug #13891 (project freeciv):
Done.
(file #6543)
___
Additional Item Attachment:
File name: client_implementation4.diffSize:13 KB
___
Reply to this
Update of bug #13891 (project freeciv):
Planned Release:None = 2.2.0
___
Follow-up Comment #16:
featured_text5.diff has been committed.
Remaining minor nitpick about
Follow-up Comment #14, bug #13891 (project freeciv):
For translating unit name in server side, shouldn't it put
translated name in unit_link() and text_tag_replace_text() to
always use that name?
Like you answered in the previous message, it depends of the local of the
emitter. If the
Follow-up Comment #13, bug #13891 (project freeciv):
Actually this translation thing depends where message originates from. I plan
to commit this patch as it is and to leave imrpovements to future tickets.
___
Reply to this item at:
Follow-up Comment #12, bug #13891 (project freeciv):
For translating unit name in server side, shouldn't it put translated name in
unit_link() and text_tag_replace_text() to always use that name?
___
Reply to this item at:
Follow-up Comment #10, bug #13891 (project freeciv):
maybe it would try to translate the link name to the local
language in text_tag_replace_text()
Yes, that sounds like right thing to do.
Just realized that rest of the message is translated at the server side. Link
name also should be
Follow-up Comment #11, bug #13891 (project freeciv):
Just realized that rest of the message is translated at the
server side. Link name also should be translated server side
to make translation at least consistent, if not one translated
for client's local language. This is how things
Follow-up Comment #7, bug #13891 (project freeciv):
featured_text4.diff:
* Fixed link id initialization.
client_implementation3.diff:
* Parse colors only once.
* Links are clickable. The colors used are the traditionnal warclient
ones. The graphical implementation is not done
Follow-up Comment #8, bug #13891 (project freeciv):
(I'm not sure about the usage client_info packet instead of
server_join_req).
server_join_req itself contains capability information. Capabilities cannot
be checked before it is sent. I rather avoid making incompatible versions of
Follow-up Comment #9, bug #13891 (project freeciv):
Patches in this ticket can go in first. Sending plain text to
clients without featured text capabilities should be next step
(or at least before server sends any featured text)
My patch for this is nearly ready, but I have some problems to
Follow-up Comment #4, bug #13891 (project freeciv):
text_tag_replace_text() actually looks for unit or city id and then
determines city/unit name based on that like you said. But in the case the
unit/city is not known by a client, it's replaced by the name granted with
the link
Follow-up Comment #5, bug #13891 (project freeciv):
maybe it would try to translate the link name to the local
language in text_tag_replace_text()
Yes, that sounds like right thing to do.
Will it be possible, and feasible, in future ticket, to make server send
plain text only to those
Follow-up Comment #6, bug #13891 (project freeciv):
maybe it would try to translate the link name to the local
language in text_tag_replace_text()
Yes, that sounds like right thing to do.
New patch attached.
Will it be possible, and feasible, in future ticket, to make
server send plain
Follow-up Comment #3, bug #13891 (project freeciv):
text_tag_replace_text() looks for unit or city id and then determines
city/unit name based on that. This means no name is shown when city/unit is
not known by client. This is a problem. Server should be allowed to send
messages about any
Follow-up Comment #2, bug #13891 (project freeciv):
Some fixes...
featured_text2.diff:
* When there are two escape sequences for foreground color without a end
sequence, really change the foreground color.
client_implementation2.diff:
* Do not get gtk warnings when a color name is not valid.
*
URL:
http://gna.org/bugs/?13891
Summary: [Patch] Chat colors and other improvements
Project: Freeciv
Submitted by: pepeto
Submitted on: Tuesday 07/07/2009 at 06:40
Category: general
Severity: 1 - Wish
17 matches
Mail list logo
