[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-26 Thread Marko Lindqvist
Update of bug #19447 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-23 Thread Jacob Nevins
Follow-up Comment #10, bug #19447 (project freeciv): Patch looks sensible and I've verified it fixes the problem, thanks. ___ Reply to this item at: http://gna.org/bugs/?19447 ___ Message

[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-22 Thread Jacob Nevins
Follow-up Comment #8, bug #19447 (project freeciv): I agree that (2) should be safe. FWIW, I think the unused veteran level fields in RULESET_UNIT packets are initialised to zeroes, by virtue of the implicit zero initialisation of unittype.c:unit_type[] on the server.

[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-22 Thread Marko Lindqvist
Update of bug #19447 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #9: 2) Change client u-veteran_levels = 0 to u-veteran_levels = MAX_VET_LEVELS Untested patch to

[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-20 Thread Marko Lindqvist
Update of bug #19447 (project freeciv): Status: Fixed = In Progress Open/Closed: Closed = Open ___ Follow-up Comment #7: Well, then I think

[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-19 Thread Jacob Nevins
Follow-up Comment #4, bug #19447 (project freeciv): Unfortunately this patch causes a variety of breakage on S2_3 on the client: * Where veteran level names should be displayed for individual units (middle-click popit and city dialog), garbage is displayed instead. * Middle-click popit doesn't

[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-19 Thread Marko Lindqvist
Follow-up Comment #5, bug #19447 (project freeciv): Could client determine number of veteran levels from actual veteran levels information even if the number itself is not explicitly part of the protocol? Information of effects of different veteran levels is certainly needed (move_rate of units

[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-19 Thread Jacob Nevins
Follow-up Comment #6, bug #19447 (project freeciv): I think the client just trusts that UNIT_INFO.veteran is correct and indexes using that. On a quick look I didn't convince myself that unused levels' info in RULESET_UNIT packets were even initialised, so I doubt there are clues there either.

[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-17 Thread Marko Lindqvist
Update of bug #19447 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-14 Thread Marko Lindqvist
URL: http://gna.org/bugs/?19447 Summary: Over maximum veteran level assigned initially to unit Project: Freeciv Submitted by: cazfi Submitted on: Tue 14 Feb 2012 11:56:36 PM EET Category: general Severity: