[Freeciv-Dev] (PR#40060) civserver core dump on debug command

2008-01-31 Thread Jason Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40060 This doesn't reliably crash for me either. But the memory error is obvious enough from the backtrace and shows up in valgrind. This will cause arbitrary memory reads every time /debug is done with no parameters. Looks like this

Re: [Freeciv-Dev] (PR#40036) 2.1.2 savegame data loss on rapid saves

2008-01-31 Thread Martin Rubinstein
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40036 Further information - the problem is not in the basic Freeciv program, but in the Windows Vista distribution which automaticalloy sets certain defaults which cause errors. a) The switch to turn on AI after a player disconnects

Re: [Freeciv-Dev] (PR#40057) strerror-mystrerror

2008-01-31 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40057 On 27/01/2008, Jason Dorje Short [EMAIL PROTECTED] wrote: mystrerror is included in support.c. Two places don't use this but access strerror directly. This patch fixes it (for 2.1). That broke compilation. mystrerror() takes no

Re: [Freeciv-Dev] (PR#40063) RFE: increase historian levels to prime number

2008-01-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40063 Added +1 to ensure only top rank is rated Supreme (unless tied). Added clamp to final entry. Committed S2_2 revision 14364. Committed trunk revision 14365. Index: server/report.c

Re: [Freeciv-Dev] (PR#40064) historian report passes NULL format to cat_snprintf()

2008-01-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40064 Jason Short wrote: Looks like this is cause by 40063. That would be highly surprising, as PR#40063 had not been committed yet! Anyway, I've just committed it minutes ago, and I'll do some testing now with the savegame provided

Re: [Freeciv-Dev] (PR#40064) historian report passes NULL format to cat_snprintf()

2008-01-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40064 My trivial patch was only meant to change an existing array from sentence fragments for easier translation. Then, it ballooned from fixed size to variable, and fancier, and Used sizeof() instead of ARRAY_SIZE(). Fixed. Excellent

Re: [Freeciv-Dev] (PR#40057) strerror-mystrerror

2008-01-31 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40057 On Jan 31, 2008 8:35 AM, Marko Lindqvist [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40057 On 27/01/2008, Jason Dorje Short [EMAIL PROTECTED] wrote: mystrerror is included in support.c. Two

Re: [Freeciv-Dev] (PR#40062) server/stdinhand.c duplicates server/command.c text

2008-01-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40062 I looked at cmd_reply_prefix(), and chose not to use it for the Usage: lines. It really isn't multi-lingual friendly. Saved for another ticket. I looked at command_named(). It should be re-written to be more like

[Freeciv-Dev] (PR#40066) i18n: commands and settings text should work for LtR and RtL, and wordwrap

2008-01-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40066 In PR#40043, the disfunctional wordwrap was removed for server/stdinhand.c (stdout) and others. In PR#40062, the Usage: could sometimes use some wordwrap and prettifying. Ideally, the server/commands.c and server/settings.c text should