Re: [Freeciv-Dev] 2.1.5

2008-06-12 Thread Daniel Markstedt
On Thu, 12 Jun 2008 10:32:01 +0900, Marko Lindqvist [EMAIL PROTECTED] wrote: Daniel: Does it compile in your environment now? #40266 should go in before release (there's no risk of breaking anything that currently works; civ1 ruleset is completely broken without this patch anyway) but no

Re: [Freeciv-Dev] (PR#40184) [editor] Toolbar GUI front-end preliminary work

2008-06-12 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40184 Madeline Book wrote: I actually like the whole 3 line ... header as a visual separator between functions (thanks in large part due to the nice color difference in syntax hilighting). Anyway, that is just my preference; are you

[Freeciv-Dev] (PR#40270) [Patch] Unhardcode TERRAIN_LAKE_IDENTIFIER

2008-06-12 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40270 This patch adds terrain flag FreshWater and uses it instead of hardcoded TERRAIN_LAKE_IDENTIFIER - Gets rid of hardcoded TERRAIN_LAKE_IDENTIFIER - Lake type terrain is not needed. If ruleset does not provide one, normal ocean types

[Freeciv-Dev] (PR#40271) Assertion failure after building fortress

2008-06-12 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40271 [EMAIL PROTECTED] - Thu Jun 12 18:20:22 2008]: 2008/6/12 Madeline Book: Server was aborted while I was testing a completely unrelated matter. To reproduce start the attached save game as Orgetorix and use an engineer or two

Re: [Freeciv-Dev] (PR#40271) Assertion failure after building fortress

2008-06-12 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40271 2008/6/12 Madeline Book: Server was aborted while I was testing a completely unrelated matter. To reproduce start the attached save game as Orgetorix and use an engineer or two to build a fortress. See #40178. One cannot build

[Freeciv-Dev] (PR#40184) [editor] Toolbar GUI front-end preliminary work

2008-06-12 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40184 [book - Wed Jun 11 19:56:11 2008]: [EMAIL PROTECTED] - Wed Jun 11 16:51:03 2008]: - There's some new direct S_FORTRESS and S_AIRBASE references. That goes against work for generic military bases. See common/ base.[ch] to

[Freeciv-Dev] (PR#40272) Meta-ticket for 2.2 release

2008-06-12 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40272 This is a pre-emptive meta-ticket for the 2.2 release. Any tickets which the new release should depend on should be linked here. In order to get new features faster to end-users I'd like to make feature releases more often (with

[Freeciv-Dev] (PR#40184) [editor] Toolbar GUI front-end preliminary work

2008-06-12 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40184 Thanks for the thorough reply. My ideas for specific issues follow below. [EMAIL PROTECTED] - Thu Jun 12 21:21:14 2008]: Please don't assume that bases are stored as specials. Iterating specials should already skip S_FORTRESS and