[Freeciv-Dev] [patch #1437] show changed settings only one time if a comand file is read

2010-02-04 Thread Matthias Pfafferodt

URL:
  http://gna.org/patch/?1437

 Summary: show changed settings only one time if a comand
file is read
 Project: Freeciv
Submitted by: syntron
Submitted on: Donnerstag 04.02.2010 um 11:21
Category: general
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

with patch #1198 the changed game settings are shown after a 'reset' or
'rulesetdir' command. If these commands are used within a script file the
changed settings could be shown several times. This patch updates the
behavior such, that the changed settings are only shown once for the commands
'reset', 'rulesetdir' and 'read' using the recursion counter of the read
command.



___

File Attachments:


---
Date: Donnerstag 04.02.2010 um 11:21  Name:
trunk-show-changed-settings-only-one-time-if-a-comand-file.patch  Size: 6kB  
By: syntron

http://gna.org/patch/download.php?file_id=7903

___

Reply to this item at:

  http://gna.org/patch/?1437

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1301] Metaticket: settings patch series

2010-02-04 Thread Matthias Pfafferodt

Update of patch #1301 (project freeciv):

  Depends on: = patch #1437


___

Reply to this item at:

  http://gna.org/patch/?1301

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15266] Crashes after 200-400 moves

2010-02-04 Thread Matthias Pfafferodt

Follow-up Comment #6, bug #15266 (project freeciv):

 But I think, IIRC, some parts of the code still assume borders
 are enabled. SO I think a such crash is possible also in S2_1.
 I want to check this before fixing this item.

You are right. I checked S2_1 and the following code is used:


void tile_set_owner(struct tile *ptile, struct player *owner)
{
  if (0  game.info.borders) {
ptile-owner = owner;
  }
}


So for game info.borders == 0, the tile owner is not set. I have check both
versions, S2_1 and S_2_2 / trunk, again and will attach the updated patches.
Both compile but I did not test all possible cases ...

(file #7904, file #7905)
___

Additional Item Attachment:

File name: S2_1-fix-assert-for-tile_owner-if-borders-0-S2_1.patch Size:4 KB
File name: S2_2-trunk-fix-assert-for-tile_owner-if-borders-0.patch Size:5 KB


___

Reply to this item at:

  http://gna.org/bugs/?15266

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15277] Fall to main menu

2010-02-04 Thread Real Name

URL:
  http://gna.org/bugs/?15277

 Summary: Fall to main menu
 Project: Freeciv
Submitted by: jkjk
Submitted on: Thursday 02/04/10 at 13:27
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.2.0-beta3
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

If I end of turn in this save, game will fall to main menu.



___

File Attachments:


---
Date: Thursday 02/04/10 at 13:27  Name: civgame-T066-Y850BCm.sav.gz  Size:
300kB   By: jkjk
savegame
http://gna.org/bugs/download.php?file_id=7906

___

Reply to this item at:

  http://gna.org/bugs/?15277

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14944] fogged borders are not restored from a savegame

2010-02-04 Thread Matthias Pfafferodt

Update of bug #14944 (project freeciv):

  Status:None = Ready For Test 
 Release: 2.3 = 2.2.0  
 Planned Release:   2.3.0 = 2.2.0  

___

Follow-up Comment #5:

restore loading of known owner map (foggedborders option)

in savegame.c the following check is done before loading map information:


  if (secfile_lookup_int_default(file, -1, game.fogofwar) != -1
   game.info.fogofwar == TRUE
   -1 != total_ncities
   secfile_lookup_bool_default(file, TRUE, game.save_private_map)) {


The first check will fail due to the fact that fogofwar is saved as bool
(TRUE / FALSE string).

Does somebody can explain to me the use of
game.server.save_options.save_private_map? game.h states:


bool save_private_map; /* FoW map; will be created if not saved */


but there seems to be no use of this variable at all (not in any scenario; it
defaults to TRUE)


(file #7907)
___

Additional Item Attachment:

File name:
S2_2-trunk-restore-loading-of-known-owner-map-foggedborders-op.patch Size:1
KB


___

Reply to this item at:

  http://gna.org/bugs/?14944

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14944] fogged borders are not restored from a savegame

2010-02-04 Thread Matthias Pfafferodt

Update of bug #14944 (project freeciv):

  Status:None = Ready For Test 
 Release: 2.3 = 2.2
 Planned Release:   2.3.0 = 2.2.0  


___

Reply to this item at:

  http://gna.org/bugs/?14944

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14944] fogged borders are not restored from a savegame

2010-02-04 Thread Matthias Pfafferodt

Follow-up Comment #6, bug #14944 (project freeciv):

It seems to be that I'm not able to change the settings for this patch. It
should be:

Status   None  =  Ready For Test
Release  2.3   =  2.2
Planned Release  2.3.0 =  2.2.0

___

Reply to this item at:

  http://gna.org/bugs/?14944

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15277] Fall to main menu

2010-02-04 Thread Matthias Pfafferodt

Update of bug #15277 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.2.0  

___

Follow-up Comment #1:

gdb output:


#0  0x7fec366a1645 in raise () from /lib64/libc.so.6
(gdb) where
#0  0x7fec366a1645 in raise () from /lib64/libc.so.6
#1  0x7fec366a2c33 in abort () from /lib64/libc.so.6
#2  0x7fec3669a329 in __assert_fail () from /lib64/libc.so.6
#3  0x004623b6 in pick_a_nation (choices=0x0, ignore_conflicts=false,
only_available=true,
barb_type=LAND_BARBARIAN) at plrhand.c:1337
#4  0x00440169 in create_barbarian_player (type=LAND_BARBARIAN) at
barbarian.c:121
#5  0x00440b3c in summon_barbarians () at barbarian.c:528
#6  0x0040b1f5 in end_turn () at srv_main.c:947
#7  0x0040c847 in srv_main () at srv_main.c:2105
#8  0x004043c6 in main (argc=1, argv=0x7fff8db37d18) at
civserver.c:359


The server fails because it can't find a barbarian nation. The reason is
within srv_main.c. With start positions set only a selected range of nation
will be allowed within init_available_nations(). The patch activates sea and
land barbarians for every game.

Patch for S2_2 and trunk.

(file #7908)
___

Additional Item Attachment:

File name: S2_2-trunk-allow-sea-and-land-barbarians.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?15277

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15277] Fall to main menu

2010-02-04 Thread Matthias Pfafferodt

Follow-up Comment #2, bug #15277 (project freeciv):

version for S2_1

(file #7910)
___

Additional Item Attachment:

File name: S2_1-allow-sea-and-land-barbarians-S2_1.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?15277

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [bug #15276] Cruise missile cannot attack Bomber.

2010-02-04 Thread David Lowe
On 3 Feb, 2010, at 11:33 PM, pepeto wrote:

 The game manual is not correct, Cruise Missiles are not able to attack
 Bomber, and this is really realistic.  Cruise Missiles are for floor targets,
 there are not able to hurt targets on the airs.

So the presence of an aircraft prevents the Cruise Missile from harming 
the land units?

Sent from my MacBookPro

Never go to a doctor whose office plants have died. - Bombeck
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1438] Guatemalan nation (+Mayan changes)

2010-02-04 Thread J.M. Maalderink

URL:
  http://gna.org/patch/?1438

 Summary: Guatemalan nation (+Mayan changes)
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Thursday 02/04/2010 at 19:40
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Guatemalan nation.
I've also changed the Mayan ruleset. I added a few leaders (including
post-Columbian ones), straightened out the ortography, and changed the city
list. Some of the cities had their original and modern names mixed up, I've
used the original name wherever possible and tried to be consistent (as far
as humanly possible) with their ortography. I also changed the order to have
the most important ones first, and added a lot of cities.



___

File Attachments:


---
Date: Thursday 02/04/2010 at 19:40  Name: guatemalan.patch  Size: 191kB   By:
mixcoatl

http://gna.org/patch/download.php?file_id=7911

___

Reply to this item at:

  http://gna.org/patch/?1438

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1430] Improve scenario descriptions

2010-02-04 Thread Daniel Markstedt

Update of patch #1430 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?1430

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1431] Include more scenarios by default

2010-02-04 Thread Daniel Markstedt

Update of patch #1431 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.2.0  

___

Follow-up Comment #4:

Patch for Italy, Japan, and North America attached. Some terrain and
rulesetdir fixes to the scenarios themselves.

Having a problem with the Italian scenario. The server throws 1: Saved game
contains incomplete map data.  This can happen with old saved games, or it
may indicate an invalid saved game file.  Proceed at your own risk.

But it works seemingly fine after this. Could it be because it lacks player
starting positions?

(file #7915)
___

Additional Item Attachment:

File name: more-scenarios.diffSize:92 KB


___

Reply to this item at:

  http://gna.org/patch/?1431

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1439] Kalmyk nation

2010-02-04 Thread J.M. Maalderink

URL:
  http://gna.org/patch/?1439

 Summary: Kalmyk nation
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Thursday 02/04/2010 at 20:54
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Kalmyks



___

File Attachments:


---
Date: Thursday 02/04/2010 at 20:54  Name: kalmyk.patch  Size: 9kB   By:
mixcoatl

http://gna.org/patch/download.php?file_id=7916

___

Reply to this item at:

  http://gna.org/patch/?1439

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1440] Anishinaabe nation

2010-02-04 Thread J.M. Maalderink

URL:
  http://gna.org/patch/?1440

 Summary: Anishinaabe nation
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Thursday 02/04/2010 at 21:37
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Anishinaabe nation



___

File Attachments:


---
Date: Thursday 02/04/2010 at 21:37  Name: anishinaabe.patch  Size: 8kB   By:
mixcoatl

http://gna.org/patch/download.php?file_id=7917

___

Reply to this item at:

  http://gna.org/patch/?1440

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15277] Fall to main menu

2010-02-04 Thread pepeto

Update of bug #15277 (project freeciv):

 Assigned to:None = pepeto 
 Planned Release:   2.2.0 = 2.1.12, 2.2.0  


___

Reply to this item at:

  http://gna.org/bugs/?15277

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15276] Cruise missile cannot attack Bomber.

2010-02-04 Thread pepeto

Update of bug #15276 (project freeciv):

Category:None = rulesets   
  Status:None = Wont Fix   
 Assigned to:None = pepeto 
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?15276

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15274] Typo in vote command

2010-02-04 Thread pepeto

Update of bug #15274 (project freeciv):

 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?15274

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15266] Crashes after 200-400 moves

2010-02-04 Thread pepeto

Follow-up Comment #7, bug #15266 (project freeciv):

The test:

tile_owner(ptile)  players_non_invade(tile_owner(ptile), pplayer)

should be replaced by

player_can_invade_tile(pplayer, ptile)


___

Reply to this item at:

  http://gna.org/bugs/?15266

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15258] Some cities fail sanity checking after nuclear winter

2010-02-04 Thread pepeto

Update of bug #15258 (project freeciv):

 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?15258

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1431] Include more scenarios by default

2010-02-04 Thread Matthias Pfafferodt

Follow-up Comment #5, patch #1431 (project freeciv):

updated italy scenario ...

 Could it be because it lacks player starting positions?

The problem was that one map was missing; for a complete definition of the
map the sections map.l*, map.u*, map.n* and map.f* are needed (see
savegame:map_load()). map.f* was missing. I copied map.u* (all 0's) to map.f*
and now it is loading fine.

I also replaced the in-land oceans by lakes.

(file #7919)
___

Additional Item Attachment:

File name: update-italy-scenario.patchSize:55 KB


___

Reply to this item at:

  http://gna.org/patch/?1431

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15195] Behaviour with Clear unit orders on selection unset is sub-optimal

2010-02-04 Thread pepeto

Update of bug #15195 (project freeciv):

Category:None = client 
 Assigned to:None = pepeto 
 Planned Release: = 2.1.12, 2.2.0  


___

Reply to this item at:

  http://gna.org/bugs/?15195

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15104] S2_2: gui-xaw never shows connection dialog

2010-02-04 Thread pepeto

Follow-up Comment #2, bug #15104 (project freeciv):

Are you going to commit this patch?


___

Reply to this item at:

  http://gna.org/bugs/?15104

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15266] Crashes after 200-400 moves

2010-02-04 Thread Matthias Pfafferodt

Follow-up Comment #8, bug #15266 (project freeciv):

 The test: ... should be replaced by ...

Done. Version 3 of the patches for S2_1 and S2_2 / trunk

(file #7920, file #7921)
___

Additional Item Attachment:

File name: version3-S2_1-fix-assert-for-tile_owner-if-borders-0-S2_1.patch
Size:4 KB
File name: version3-S2_2-trunk-fix-assert-for-tile_owner-if-borders-0.patch
Size:5 KB


___

Reply to this item at:

  http://gna.org/bugs/?15266

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15261] City production in city overview does not update on change

2010-02-04 Thread pepeto

Update of bug #15261 (project freeciv):

  Status:   Confirmed = In Progress

___

Follow-up Comment #3:

This is a one-minute made patch.  Need to check the historic before
committing to unsure it's correct...


(file #7922)
___

Additional Item Attachment:

File name: trunk_S2_2_S2_1_sdl_cityrep_update.diff Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?15261

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15266] Crashes after 200-400 moves

2010-02-04 Thread pepeto

Update of bug #15266 (project freeciv):

  Status: In Progress = Ready For Test 
 Assigned to:None = pepeto 
 Planned Release:   2.2.0 = 2.1.12, 2.2.0  


___

Reply to this item at:

  http://gna.org/bugs/?15266

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1441] Holy Roman Empire

2010-02-04 Thread J.M. Maalderink

URL:
  http://gna.org/patch/?1441

 Summary: Holy Roman Empire
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Thursday 02/04/2010 at 22:33
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

A personal favorite: the Holy Roman Empire, With city and leader names in
Latin. Build such cities as 'Brandenburgum', 'Hannovera', 'Manhemium' and
'Wittenberga'.

Many of the civil war nations are not yet in the game, but I've already made
nations of all of them, I'll upload them on a later date. Some of them are
already in a patch I previously uploaded: https://gna.org/patch/?1406



___

File Attachments:


---
Date: Thursday 02/04/2010 at 22:33  Name: holyromanempire.patch  Size: 609kB 
 By: mixcoatl

http://gna.org/patch/download.php?file_id=7923

___

Reply to this item at:

  http://gna.org/patch/?1441

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev