[Freeciv-Dev] [patch #1236] experimental ruleset

2010-04-06 Thread Ulrik Sverdrup
Follow-up Comment #9, patch #1236 (project freeciv): The experimental ruleset also serves as documentation or example of ruleset possibilities, something that might be very helpful for people creating custom rulesets. ___ Reply to this ite

[Freeciv-Dev] Amplio 2

2010-04-06 Thread Hogne Håskjold
Hi I've started working on an update to the Amplio tileset. I wanted to incorporate some of the excellent tiles from Freeland and do a general update on some of the more dated tiles. Major changes from Amplio: * New hills * New mountains * New desert * New tundra * New oasis * New forest and jung

[Freeciv-Dev] [bug #15753] should support IPv6 when connecting to metaserver

2010-04-06 Thread Marko Lindqvist
Follow-up Comment #3, bug #15753 (project freeciv): > Is there support for reporting to a dual-staked metaserver > via both IPv6 and IPv4 at the same time? No. ___ Reply to this item at: _

[Freeciv-Dev] [bug #15801] fix some S2_0 compiler warnings

2010-04-06 Thread Jason Dorje Short
URL: Summary: fix some S2_0 compiler warnings Project: Freeciv Submitted by: jdorje Submitted on: Tuesday 04/06/2010 at 15:59 Category: general Severity: 2 - Minor

[Freeciv-Dev] [bug #15802] bad english "sure to sell" in cityrep

2010-04-06 Thread Jason Dorje Short
URL: Summary: bad english "sure to sell" in cityrep Project: Freeciv Submitted by: jdorje Submitted on: Tuesday 04/06/2010 at 16:04 Category: client-gtk-2.0 Severity: 3 - Norma

[Freeciv-Dev] [bug #15801] fix some S2_0 compiler warnings

2010-04-06 Thread Jason Dorje Short
Follow-up Comment #1, bug #15801 (project freeciv): This second attached patch does the same for 1.14. (file #8828) ___ Additional Item Attachment: File name: compile-warnings-1.14.diff Size:12 KB ___

Re: [Freeciv-Dev] Amplio 2

2010-04-06 Thread Andreas Røsdal
Hello Hogne, This new version of the Amplio tileset looks very nice. I'm looking forward to seeing the final version! Here's a suggestion for a more compact theme-format, which can be useful when transferring the tileset over network connections. http://github.com/freecivnet/freeciv-web/blob/

[Freeciv-Dev] [patch #1589] struct city cleanup

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #3, patch #1589 (project freeciv): and here it is (file #8829) ___ Additional Item Attachment: File name: 20100406-trunk-struct-city-cleanup.diff Size:91 KB

[Freeciv-Dev] [bug #15804] fix city map (variable city radii, xaw client)

2010-04-06 Thread Matthias Pfafferodt
URL: Summary: fix city map (variable city radii, xaw client) Project: Freeciv Submitted by: syntron Submitted on: Dienstag 06.04.2010 um 22:01 Category: client-xaw Severity: 3

[Freeciv-Dev] [bug #15805] fix city map (variable city radii, sdl client)

2010-04-06 Thread Matthias Pfafferodt
URL: Summary: fix city map (variable city radii, sdl client) Project: Freeciv Submitted by: syntron Submitted on: Dienstag 06.04.2010 um 22:01 Category: client-sdl Severity: 3

[Freeciv-Dev] [patch #1235] [Metaticket] variable city radii

2010-04-06 Thread Matthias Pfafferodt
Update of patch #1235 (project freeciv): Depends on: => bugs #15804 ___ Reply to this item at: ___ Nachricht

[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #19, patch #1330 (project freeciv): > Perhaps this information could go in a tab of it's own? A lot of (additional) information is only available in the gtk via a click on the summary (trade, happiness, illness, ...). If you can summarize how to change it that: * the informat

[Freeciv-Dev] [bug #15804] fix city map (variable city radii, xaw client)

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #1, bug #15804 (project freeciv): see patch #1235 for an idea of a new layout: [city map       ][buildings] [units                     ] [food][city info][build now] ___ Reply to this item at:

[Freeciv-Dev] [bug #15804] fix city map (variable city radii, sdl client)

2010-04-06 Thread Matthias Pfafferodt
Update of bug #15804 (project freeciv): Category: client-xaw => client-sdl Summary: fix city map (variable city radii, xaw client) => fix city map (variable city radii, sdl client) ___

[Freeciv-Dev] [bug #15805] fix city map (variable city radii, xaw client)

2010-04-06 Thread Matthias Pfafferodt
Update of bug #15805 (project freeciv): Category: client-sdl => client-xaw Summary: fix city map (variable city radii, sdl client) => fix city map (variable city radii, xaw client) ___

[Freeciv-Dev] [bug #15790] Fix typo in trade route correction

2010-04-06 Thread Jacob Nevins
Update of bug #15790 (project freeciv): Status: Ready For Test => In Progress ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)

2010-04-06 Thread Ulrik Sverdrup
Follow-up Comment #20, patch #1330 (project freeciv): Just my opinion but, the city dialog should not be as small as possible. If everything is just available via small clickable icons, it's hard to use. The gtk client uses a lot of space for common tasks (changing production from first city dial

[Freeciv-Dev] [bug #15790] Fix typo in trade route correction

2010-04-06 Thread Jacob Nevins
Update of bug #15790 (project freeciv): Status: In Progress => Fixed Open/Closed:Open => Closed ___ Follow-up Comment #4: > we haven't run u

[Freeciv-Dev] [bug #15738] map view not centered at the start

2010-04-06 Thread Ulrik Sverdrup
Follow-up Comment #16, bug #15738 (project freeciv): I see that the map is drawn with canvas_put_rectangle in map_canvas_resized. Does that mean that regardless if moving the origin or not, we still redraw the whole canvas without moving/copying pixels? _

[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #21, patch #1330 (project freeciv): yes, you are right. To clarify: the size should not be increased or reduced but stay near or at the current size. At the time I started the city radii patches I had no update for the city map ... and it was somehow possible to view the city d

[Freeciv-Dev] [patch #1446] [Metaticket] Ruleset object

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #1, patch #1446 (project freeciv): some ideas about the ruleset rework: 1) at the moment all ruleset data used in the ruleset files is saved in the packet_ruleset_* structs; so use them for a ruleset object: struct ruleset { struct packet_ruleset_game game; ... /* spec

[Freeciv-Dev] [patch #1589] struct city cleanup

2010-04-06 Thread pepeto
Follow-up Comment #4, patch #1589 (project freeciv): I read especially common/city.[ch]: * I don't understand the _placeholder for searching_ comments. Some values are initialized somewhere else (e.g. pcity->worklist), some others don't (e.g. pcity->client.info_units_present). * _pcity->illness_t

[Freeciv-Dev] [bug #15807] assert in player_invention_state() [tech.c::129]

2010-04-06 Thread Matthias Pfafferodt
URL: Summary: assert in player_invention_state() [tech.c::129] Project: Freeciv Submitted by: syntron Submitted on: Dienstag 06.04.2010 um 23:40 Category: general Severity: 3 -

[Freeciv-Dev] [patch #1446] [Metaticket] Ruleset object

2010-04-06 Thread pepeto
Follow-up Comment #2, patch #1446 (project freeciv): 1 & 2) I have already thought about a such solution for numerous structures of Freeciv. However, this is quite problematic. Most ruleset types for example need a translation support that need a gettext() pointer, which cannot be used in a packe

[Freeciv-Dev] [patch #1446] [Metaticket] Ruleset object

2010-04-06 Thread pepeto
Follow-up Comment #3, patch #1446 (project freeciv): 3) I agree. 4) I had similar idea. This would also give a way to save a ruleset into a savegame, and probably also to make a ruleset editor in a very far future... ___ Reply to this it

[Freeciv-Dev] [patch #1591] dynamically allocated pcity->tile_output

2010-04-06 Thread Matthias Pfafferodt
URL: Summary: dynamically allocated pcity->tile_output Project: Freeciv Submitted by: syntron Submitted on: Dienstag 06.04.2010 um 23:45 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1592] dynamically allocate cm_result

2010-04-06 Thread Matthias Pfafferodt
URL: Summary: dynamically allocate cm_result Project: Freeciv Submitted by: syntron Submitted on: Dienstag 06.04.2010 um 23:46 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1593] cleanup city map iterators

2010-04-06 Thread Matthias Pfafferodt
URL: Summary: cleanup city map iterators Project: Freeciv Submitted by: syntron Submitted on: Dienstag 06.04.2010 um 23:46 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1594] dynamically allocate activity map within struct ai_city

2010-04-06 Thread Matthias Pfafferodt
URL: Summary: dynamically allocate activity map within struct ai_city Project: Freeciv Submitted by: syntron Submitted on: Dienstag 06.04.2010 um 23:46 Category: general Priori

[Freeciv-Dev] [patch #1595] move ai_city to aicity.h

2010-04-06 Thread Matthias Pfafferodt
URL: Summary: move ai_city to aicity.h Project: Freeciv Submitted by: syntron Submitted on: Dienstag 06.04.2010 um 23:46 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1591] dynamically allocated pcity->tile_output

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #1, patch #1591 (project freeciv): patch order (there could be dependencies): patch #1595 move ai_city to aicity.h patch #1594 dynamically allocate activity map within struct ai_city patch #1593 cleanup city map iterators patch #1592 dynamically allocate cm_result patch #15

[Freeciv-Dev] [patch #1591] dynamically allocated pcity->tile_output

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #2, patch #1591 (project freeciv): lower to higher numbers ;-) ___ Reply to this item at: ___ Nachricht geschickt von/durch Gna! http://gna.

[Freeciv-Dev] [patch #1589] struct city cleanup

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #5, patch #1589 (project freeciv): I will update the patch. About your comments: I would remove the entire block 'ZERO_VARIABLES_FOR_SEARCHING' or list all unused variables within a comment block. ___ Reply to this item

[Freeciv-Dev] [patch #1589] struct city cleanup

2010-04-06 Thread pepeto
Follow-up Comment #6, patch #1589 (project freeciv): I forgot to tell the most important: it fails to compile the SDL client: citydlg.c: In function ‘redraw_supported_units_city_dialog’: citydlg.c:1778: error: ‘struct city’ has no member named ‘info_units_supported’ citydlg.c: In function ‘redra

[Freeciv-Dev] [patch #1589] struct city cleanup

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #7, patch #1589 (project freeciv): s/unused/zero value/ ___ Reply to this item at: ___ Nachricht geschickt von/durch Gna! http://gna.org/

[Freeciv-Dev] [patch #1589] struct city cleanup

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #8, patch #1589 (project freeciv): > I forgot to tell the most important: it fails to compile the SDL client: I did a search and replace using the replace script provided in ./scripts. I did not take into account, that in the SDL client p_C_ity is used ... ___

[Freeciv-Dev] [bug #15808] Cosmetic English grammar/spelling/typographical fixes in strings

2010-04-06 Thread Jacob Nevins
URL: Summary: Cosmetic English grammar/spelling/typographical fixes in strings Project: Freeciv Submitted by: jtn Submitted on: Tuesday 04/06/10 at 23:04 Category: None Severit

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread Jordi Negrevernis i Font
URL: Summary: Non-localized string in city dialog Project: Freeciv Submitted by: jorneg Submitted on: martes 06/04/10 at 22:07 Category: client-gtk-2.0 Severity: 2 - Minor

[Freeciv-Dev] [patch #1589] struct city cleanup

2010-04-06 Thread pepeto
Follow-up Comment #9, patch #1589 (project freeciv): pCity is not real correct Freeciv coding style. Maybe could you replace them by normal pcity? ___ Reply to this item at: ___

[Freeciv-Dev] [bug #15490] Sanity check NULL != tile_owner(pcenter) failing

2010-04-06 Thread pepeto
Update of bug #15490 (project freeciv): Status:None => Confirmed ___ Follow-up Comment #1: Confirmed on trunk, at revision 17278. 1: in auto_arrange_workers() [cityturn.c::284]: Failed

[Freeciv-Dev] [bug #15810] Sanity check should use fc_assert()

2010-04-06 Thread pepeto
URL: Summary: Sanity check should use fc_assert() Project: Freeciv Submitted by: pepeto Submitted on: mardi 06.04.2010 à 22:15 Category: general Severity: 3 - Normal

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread Jacob Nevins
Update of bug #15809 (project freeciv): Status:None => Ready For Test Assigned to:None => jtn Planned Release: => 2.2.1 _

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread Matthias Pfafferodt
Update of bug #15809 (project freeciv): Status: Ready For Test => None Assigned to: jtn => None Planned Release: 2.2.1 => 2.3.0 _

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread Jacob Nevins
Follow-up Comment #3, bug #15809 (project freeciv): jinx! ___ Reply to this item at: ___ Message sent via/by Gna! http://gna.org/ __

[Freeciv-Dev] [patch #1589] struct city cleanup

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #10, patch #1589 (project freeciv): its possible but as the sdl client uses capital letters everythere it would create more confusion (example: pEndCityMenuWidgetList) ___ Reply to this item at:

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread pepeto
Update of bug #15809 (project freeciv): Status:None => Ready For Test Planned Release: 2.3.0 => 2.1.12, 2.2.1, 2.3.0 ___ Reply to this item at:

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread pepeto
Follow-up Comment #4, bug #15809 (project freeciv): I worked too slow it seems. You already attached the version for trunk and S2_2. This is the one for S2_1... (file #8842) ___ Additional Item Attachment: File name: S2_1_citydlg_untrans

[Freeciv-Dev] [patch #1589] struct city cleanup

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #11, patch #1589 (project freeciv): updated patch (file #8843) ___ Additional Item Attachment: File name: 20100405-01-trunk-struct-city-cleanup.diff Size:90 KB __

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread Matthias Pfafferodt
Follow-up Comment #5, bug #15809 (project freeciv): > jinx! Only 56 seconds to late ;-) I changed also an additional whitespace error in get_city_dialog_pollution_text() but else both patches are identical! ___ Reply to this item at:

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread Jordi Negrevernis i Font
Follow-up Comment #6, bug #15809 (project freeciv): You gays make competition for solving bugs? ;-) ___ Reply to this item at: ___ Message sent via/by Gna! h

[Freeciv-Dev] [bug #15345] Help: document new features illness and migration

2010-04-06 Thread Jacob Nevins
Update of bug #15345 (project freeciv): Status:None => Ready For Test Planned Release: => 2.2.1 ___ Follow-up Comment #1: Patch attached. It

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread Jason Dorje Short
Update of bug #15809 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => jdorje ___ Reply to this item at:

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread Jason Dorje Short
Update of bug #15809 (project freeciv): Category: client-gtk-2.0 => client ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #15809] Non-localized string in city dialog

2010-04-06 Thread Jason Dorje Short
Update of bug #15809 (project freeciv): Open/Closed:Open => Closed ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #15808] Cosmetic English grammar/spelling/typographical fixes in strings

2010-04-06 Thread Jason Dorje Short
Follow-up Comment #1, bug #15808 (project freeciv): Good eye. Should it be "struck by plague" instead of "struck by a plague"? I guess it's correct either way. Also, bug #15802 should be lumped in with these. ___ Reply to this item at:

[Freeciv-Dev] [bug #15513] Put 'All' nations tab at the bottom

2010-04-06 Thread Jason Dorje Short
Update of bug #15513 (project freeciv): Status:None => Need Info ___ Follow-up Comment #1: Agreed. ___ Reply to this item at:

[Freeciv-Dev] [bug #15502] Translation "Illegal treaty ... they already have this treaty level"

2010-04-06 Thread Jason Dorje Short
Update of bug #15502 (project freeciv): Severity: 2 - Minor => 3 - Normal ___ Follow-up Comment #3: It sounds to me like there's some deeper issues than just the translation. Do you have a saveg