[Freeciv-Dev] [patch #3117] Generic road build time
URL: http://gna.org/patch/?3117 Summary: Generic road build time Project: Freeciv Submitted by: cazfi Submitted on: Sat 04 Feb 2012 01:37:08 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0 ___ Details: This patch replaces road railroad specific build time implementation with one thta can be extended to any number of road types. This does make impossible one use-case that was possible earlier. One cannot have terrain specific road and railroad times so that road and railroad time differ from each other. One can have these: - Road and Railroad taking different terrain-independent times - Both Road and Railroad taking same terrain-specific time - One of Road and Railroad taking terrain-specific time, and another taking terrain-independent time No ruleset part of freeciv tree used now-removed feature. ___ File Attachments: --- Date: Sat 04 Feb 2012 01:37:08 PM EET Name: RoadBuildTime.diff.bz2 Size: 4kB By: cazfi http://gna.org/patch/download.php?file_id=15003 ___ Reply to this item at: http://gna.org/patch/?3117 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19383] missing NULL in serverid command definition
Update of bug #19383 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19383 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19389] stdsounds.soundspec does not list e_game_quit (etc)
Update of bug #19389 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19389 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19398] Packet creation overflow checks broken
Update of bug #19398 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #3: (Committed to trunk as [http://svn.gna.org/viewcvs/freeciv?view=revisionrevision=20798 r20798.) ___ Reply to this item at: http://gna.org/bugs/?19398 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19399] Assertion failure when game ends
Update of bug #19399 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #3: (Committed to trunk as r20799 http://svn.gna.org/viewcvs/freeciv?view=revisionrevision=20799.) ___ Reply to this item at: http://gna.org/bugs/?19399 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3101] Add missing lua-5.2 source files to Makefile.am
Update of patch #3101 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3101 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3105] Road type as pillage target
Follow-up Comment #2, patch #3105 (project freeciv): - Fixed qui-qt compilation - Updated network protocol capability. While no fields in network packets have changed, client expects server to behave differently upon receiving certain packets - old version and new one are incompatible. (file #15008) ___ Additional Item Attachment: File name: PillageRoad_3105-3.diff.bz2Size:6 KB ___ Reply to this item at: http://gna.org/patch/?3105 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3104] Expansionist AI trait
Update of patch #3104 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3104 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3069] African-American nation
Update of patch #3069 (project freeciv): Status:None = In Progress Assigned to:None = mixcoatl ___ Follow-up Comment #2: some edits (file #15010) ___ Additional Item Attachment: File name: african-american.ruleset Size:2 KB ___ Reply to this item at: http://gna.org/patch/?3069 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3068] Chrobatian nation
Update of patch #3068 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/patch/?3068 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3063] Removing some minor/useless 'leaders' from ukrainian nation
Update of patch #3063 (project freeciv): Category:None = rulesets Status:None = In Progress ___ Follow-up Comment #6: I guess this mainly refers to Timoshenko? The reason I included her was because the nationset didn't include any female nor any contemporary leaders. And please note that inclusion of a leader does not mean any kind of endorsement (after all, we have plenty of horrible dictators included). In any case I still have a half-improved Ukrainian version on my computer, the main thing is that it adds more cities. (file #15011) ___ Additional Item Attachment: File name: ukrainian.ruleset Size:2 KB ___ Reply to this item at: http://gna.org/patch/?3063 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3070] Pelasgian nation
Update of patch #3070 (project freeciv): Category:None = rulesets Status:None = In Progress Assigned to:None = mixcoatl ___ Follow-up Comment #2: some edits (file #15012) ___ Additional Item Attachment: File name: pelasgian.ruleset Size:1 KB ___ Reply to this item at: http://gna.org/patch/?3070 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19397] Hardcoded lua include path in tolua-5.1/src/lib
Update of bug #19397 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19397 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19409] cmdhelp_new() modifies const parameter on some platforms
URL: http://gna.org/bugs/?19409 Summary: cmdhelp_new() modifies const parameter on some platforms Project: Freeciv Submitted by: cazfi Submitted on: Sun 05 Feb 2012 02:46:37 AM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: I got warning that at first seemed only a missing #include when compiling for Windows. After some thinking, I'm quite convinced that this is more serious than that. GNU basename() takes const parameter, POSIX one does not. cmdhelp_new() passes const parameter to basename(). Everything is fine as long as GNU basename() is being used, but bad things happen if not. One gets GNU basename on systems supporting it by *not* including libgen.h that has POSIX version. But simply omitting libgen.h include (as we do at the moment) results prototype not to be included at all in systems without GNU basename(). Then two C features come to play. First is that in lack of explicit prototype (stating that parameter is *not* const in current platform) implicit one is used, and from the fact that caller passes const parameter, implicit prototype is constructed with const parameter. Now we have const parameter in compile time, and non-const only in library to be linked against (linking time). Second C (unlike C++) feature is that symbol names do not contain information about parameter types, or even their count. To linker basename(const char *) and basename(char *) are both just basename(), and so it happily links our 'const char *' parameter against library's 'char *' function without any warnings. Easy solution would be to always use POSIX version, but I'm still trying to construct fc_basename() that would pass its const parameter as is to GNU basename if available, and do more complicated things itself if available baseline() modifies its parameters. Portable (not gcc-specific) configure checks catering for all the cases seems to be quite hairy to do, though. ___ Reply to this item at: http://gna.org/bugs/?19409 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3069] African-American nation
Follow-up Comment #3, patch #3069 (project freeciv): I read an interested article recently in the London Review of Books[1] about the political debate around the time of the abolition of slavery, in particular during the Lincoln presidency. The topic was 'what to do' with blacks after abolition. The political (white) elite favored various apartheid-style schemes to establish an African American independent nation to where the black population was to be forcibly removed after abolition. The federal government had already secured, or was working on securing, territory in the Caribbean (Ile à Vache, off the coast of Haiti) or Latin America (parts of Panama). Some even suggested turning Florida into a black-only state. This concept apparently had limited appeal to black leaders. The vast majority of them vehemently opposed such plans. They wished to stay in the United States and be allowed to settle wherever they wanted. So I guess what I wanted to get to with this little digression is that the concept of an African American nation (independent from the United States) in a game such as Freeciv might be controversial among black Americans themselves. Just my $0.1 :) [1] http://www.lrb.co.uk/v33/n23/nicholas-guyatt/a-topic-best-avoided (requires paid subscription to read the whole article, I'm afraid) ___ Reply to this item at: http://gna.org/patch/?3069 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
