[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-22 Thread Jacob Nevins
Follow-up Comment #8, bug #19447 (project freeciv): I agree that (2) should be safe. FWIW, I think the unused veteran level fields in RULESET_UNIT packets are initialised to zeroes, by virtue of the implicit zero initialisation of unittype.c:unit_type[] on the server.

[Freeciv-Dev] [patch #3141] Remove statically initialized roads information completely

2012-02-22 Thread Marko Lindqvist
Follow-up Comment #2, patch #3141 (project freeciv): - road_by_special() returns NULL if special in question is S_LAST - Ruleset loading gives error if compatibility special None is given as savegame handling code does not support it yet. (file #15197)

[Freeciv-Dev] [bug #19472] Wrong activity icon for ACTIVITY_GEN_ROAD

2012-02-22 Thread Marko Lindqvist
Update of bug #19472 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #3130] Random disasters module

2012-02-22 Thread Marko Lindqvist
Update of patch #3130 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #19467] Ignored requirement ranges for effect Unit_Recover

2012-02-22 Thread Marko Lindqvist
Update of bug #19467 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #3132] Default ruleset description to make clear that it's mainly meant for single player

2012-02-22 Thread Marko Lindqvist
Update of patch #3132 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #19487] Tech loss in ruleset without tech upkeep

2012-02-22 Thread Marko Lindqvist
Follow-up Comment #1, bug #19487 (project freeciv): Attached patch simply restores old behavior of never losing tech when ruleset has no tech upkeep. We still want better fix for tech loss rules for tech upkeep case, in trunk at least, but until then this fix already makes rulesets without tech

[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-22 Thread Marko Lindqvist
Update of bug #19447 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #9: 2) Change client u-veteran_levels = 0 to u-veteran_levels = MAX_VET_LEVELS Untested patch to

[Freeciv-Dev] [bug #19487] Tech loss in ruleset without tech upkeep

2012-02-22 Thread Marko Lindqvist
Follow-up Comment #2, bug #19487 (project freeciv): Another case to consider, this time with tech upkeep enabled: Player research technology that enables new government. Number of bulbs carried over is happens to be very low. Player immediately issues revolution, entering Anarchy during which

[Freeciv-Dev] [bug #19488] Gtk3-client packaging still expects binary to be named freeciv-gtk2x

2012-02-22 Thread Marko Lindqvist
URL: http://gna.org/bugs/?19488 Summary: Gtk3-client packaging still expects binary to be named freeciv-gtk2x Project: Freeciv Submitted by: cazfi Submitted on: Thu 23 Feb 2012 12:25:06 AM EET Category: general

[Freeciv-Dev] [bug #19029] Possible trouble saving/loading players' known territory for player indices =40

2012-02-22 Thread Marko Lindqvist
Update of bug #19029 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #8: Untested fix for S2_3 and S2_4. In those branches we have to save in a format that also earlier

[Freeciv-Dev] [patch #3154] Remove road removal code when city destroyed

2012-02-22 Thread Marko Lindqvist
URL: http://gna.org/patch/?3154 Summary: Remove road removal code when city destroyed Project: Freeciv Submitted by: cazfi Submitted on: Thu 23 Feb 2012 01:16:49 AM EET Category: general Priority: 5 -

[Freeciv-Dev] [patch #3155] Remove overzealous sanity check about Road under Railroad

2012-02-22 Thread Marko Lindqvist
URL: http://gna.org/patch/?3155 Summary: Remove overzealous sanity check about Road under Railroad Project: Freeciv Submitted by: cazfi Submitted on: Thu 23 Feb 2012 01:20:49 AM EET Category: general

[Freeciv-Dev] [patch #3141] Remove statically initialized roads information completely

2012-02-22 Thread Marko Lindqvist
Follow-up Comment #3, patch #3141 (project freeciv): - Send compat_special to client side (file #15204) ___ Additional Item Attachment: File name: NoStaticRoads-4.diff Size:13 KB

[Freeciv-Dev] [bug #19490] can_unit_do_activity_road() checks wrong activity

2012-02-22 Thread Marko Lindqvist
URL: http://gna.org/bugs/?19490 Summary: can_unit_do_activity_road() checks wrong activity Project: Freeciv Submitted by: cazfi Submitted on: Thu 23 Feb 2012 03:21:37 AM EET Category: general Severity: 3 -

[Freeciv-Dev] [patch #3156] Fix remaining comments referring to client/civclient.c

2012-02-22 Thread Marko Lindqvist
URL: http://gna.org/patch/?3156 Summary: Fix remaining comments referring to client/civclient.c Project: Freeciv Submitted by: cazfi Submitted on: Thu 23 Feb 2012 07:31:16 AM EET Category: client Priority:

[Freeciv-Dev] [patch #3150] Trait aggressive

2012-02-22 Thread Marko Lindqvist
Follow-up Comment #1, patch #3150 (project freeciv): - Added commented out trait.aggressive entry to default nations.ruleset (file #15207) ___ Additional Item Attachment: File name: TraitAggressive-2.diff Size:3 KB

[Freeciv-Dev] [bug #19458] assertion 'activity_requires_target(new_activity)' failed.

2012-02-22 Thread Marko Lindqvist
Update of bug #19458 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #3145] Remove client/civclient.c from version control

2012-02-22 Thread Marko Lindqvist
Update of patch #3145 (project freeciv): Status:None = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #19467] Ignored requirement ranges for effect Unit_Recover

2012-02-22 Thread Marko Lindqvist
Update of bug #19467 (project freeciv): Status: Fixed = In Progress Open/Closed: Closed = Open ___ Follow-up Comment #4: Autogame is now