[Freeciv-Dev] (PR#40616) patch: allow 2.1.8 to compile under sun studio community edition 11/08

2008-12-31 Thread James McClain
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40616 diff -ru freeciv-2.1.8/client/gui-gtk-2.0/repodlgs.c /home/person/src/freeciv-2.1.8/client/gui-gtk-2.0/repodlgs.c --- freeciv-2.1.8/client/gui-gtk-2.0/repodlgs.c 2008-11-30 12:53:30.0 + +++

[Freeciv-Dev] (PR#40616) patch: allow 2.1.8 to compile under sun studio community edition 11/08

2008-12-31 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40616 [james.mccl...@gmail.com - Wed Dec 31 01:55:26 2008]: This email contains a patch that allows version 2.1.8 of FreeCiv to compile under the 11/08 version (the latest I believe) version of the Sun Studio Community Edition compiler.

Re: [Freeciv-Dev] (PR#40612) Patch: migration

2008-12-31 Thread Matthias Pfafferodt
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40612 Attached the (hopefully) final version (or the last version for this year ;-) ) I included the suggestions / changes from your patch. I also hope, that this version follows the coding style guidelines for freeciv. Am Tuesday 30

Re: [Freeciv-Dev] (PR#40616) patch: allow 2.1.8 to compile under sun studio community edition 11/08

2008-12-31 Thread James McClain
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40616 This transaction appears to have no content Hello, Please let me take a step back from the patch that I sent before. I have attached smaller one to this email. I will explain in detail what it does. Essentially, the patch just allows

Re: [Freeciv-Dev] (PR#40616) patch: allow 2.1.8 to compile under sun studio community edition 11/08

2008-12-31 Thread James McClain
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40616 Hello, Using O_MAX rather than O_COUNT does work. Moving the definition out of the function into file scope does not work.. Sincerely, James McClain On Wed, Dec 31, 2008 at 9:14 PM, Madeline Book madeline.b...@gmail.comwrote: URL:

[Freeciv-Dev] (PR#40616) patch: allow 2.1.8 to compile under sun studio community edition 11/08

2008-12-31 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40616 [james.mccl...@gmail.com - Wed Dec 31 22:12:35 2008]: Using O_MAX rather than O_COUNT does work. Moving the definition out of the function into file scope does not work.. Interesting. So I assume the attached patch completely

[Freeciv-Dev] (PR#40612) Patch: migration

2008-12-31 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40612 [matthias.pfaffer...@mapfa.de - Wed Dec 31 18:03:52 2008]: I get the following error; could it be related to the migration code (remove_city() in make_city_migration())? I have not found a pattern to narrow it down if it is the

[Freeciv-Dev] (PR#40616) patch: allow 2.1.8 to compile under sun studio community edition 11/08

2008-12-31 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40616 [james.mccl...@gmail.com - Thu Jan 01 02:38:33 2009]: That patch that you attached completely fixes the problem with repodlgs.c, but the change to helpdata.c that was in the earlier patch(es) that I sent is also required to make

Re: [Freeciv-Dev] (PR#40616) patch: allow 2.1.8 to compile under sun studio community edition 11/08

2008-12-31 Thread James McClain
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40616 Hello, I can confirm that the gtk 2 client does compile smoothly with the patch that you sent applied. I can also build with the --enable-debug and --enable-client=sdl versions. I have not tried the other two. Sincerely, James