[Freeciv-Dev] [bug #16318] strict aliasing and warnings
Follow-up Comment #2, bug #16318 (project freeciv):
The scanf
if (sscanf(level_str, %d, (int *) level) != 1) {
lines can be fixed by an auxiliary temp variable. Or perhaps an atoi with
error checking.
When passing pointers of different type to functions
sg_failure_ret(secfile_lookup_int(loading-file, (int *) ship-state,
the function prototype can be changed from taking (int *) or (void *) to
(char *)
The C99 standard says that, as an exception, a pointer to char can be aliased
(section 6.5.7)
___
Reply to this item at:
http://gna.org/bugs/?16318
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16319] Game Crashes at End of Turn
URL: http://gna.org/bugs/?16319 Summary: Game Crashes at End of Turn Project: Freeciv Submitted by: None Submitted on: Friday 07/30/2010 at 08:29 CEST Category: client-sdl Severity: 4 - Important Priority: 5 - Normal Status: None Assigned to: None Originator Email: minchin...@gmail.com Open/Closed: Open Release: 2.2.2 Discussion Lock: Any Operating System: Microsoft Windows Planned Release: ___ Details: I move all my units and at the end of the turn, after moving the last trireme (the one moving along the 'North Pole'), the game crashes. It brings up the Windows dialogue that the program has stopped working. I'm running Windows 7 and the precompiled version of 2.2.2 with the SDL Client. ___ File Attachments: --- Date: Friday 07/30/2010 at 08:29 CEST Name: Will - Bretons - 320AD.sav.gz Size: 61kB By: None http://gna.org/bugs/download.php?file_id=9628 ___ Reply to this item at: http://gna.org/bugs/?16319 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1778] [interface][ai] define the ai via the new interface
Update of patch #1778 (project freeciv): Depends on: = patch #1792 ___ Reply to this item at: http://gna.org/patch/?1778 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16301] update queue not working with player pointers
Update of bug #16301 (project freeciv): Severity: 3 - Normal = 4 - Important Status:None = Ready For Test Assigned to:None = syntron Release: trunk (patched) = runk (svn17606) ___ Follow-up Comment #1: I did a git biselect and found the error - it's my own patch fix call to update_queue_free() (see bug #16291). The attached patch reverts it and adds a comment why a call to an init() function is needed in a free() function: update_queue_init() is correct at this point. The queue is reseted to a clean state which is also needed if the client is not connected to the server! (reverts gna bug #16291, svn 17606) (file #9633) ___ Additional Item Attachment: File name: 20100730-05-trunk-Revert-fix-call-to-update_queue_free.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?16301 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16325] fix compiler warning for non-debugging buildsin city.c
URL: http://gna.org/bugs/?16325 Summary: fix compiler warning for non-debugging buildsin city.c Project: Freeciv Submitted by: syntron Submitted on: Freitag 30.07.2010 um 10:48 Category: general Severity: 2 - Minor Priority: 1 - Later Status: None Assigned to: syntron Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: citylog_map_index() and citylog_map_radius_sq() are only called for debugging builds ___ File Attachments: --- Date: Freitag 30.07.2010 um 10:48 Name: 0006-fix-compiler-warning-for-non-debugging-builds.patch Size: 899B By: syntron http://gna.org/bugs/download.php?file_id=9634 ___ Reply to this item at: http://gna.org/bugs/?16325 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16326] fix compiler warning for non-debugging builds i packet.c
URL: http://gna.org/bugs/?16326 Summary: fix compiler warning for non-debugging builds i packet.c Project: Freeciv Submitted by: syntron Submitted on: Freitag 30.07.2010 um 10:48 Category: general Severity: 2 - Minor Priority: 1 - Later Status: None Assigned to: syntron Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: * fix warning about unused variable packet_type ___ File Attachments: --- Date: Freitag 30.07.2010 um 10:48 Name: 0007-fix-compiler-warning-for-non-debugging-builds.patch Size: 834B By: syntron http://gna.org/bugs/download.php?file_id=9635 ___ Reply to this item at: http://gna.org/bugs/?16326 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16300] doesn't compile with --enable-debug
Update of bug #16300 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?16300 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1671] Remove Bash syntax from Bourne shell scripts
Update of patch #1671 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1671 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16296] gtk client fails to sort files in load-save dialog
Update of bug #16296 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?16296 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1766] remove TEST_BIT from server/score.c
Update of patch #1766 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1766 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1767] [players] fix bv_player in sdl client
Update of patch #1767 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1767 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1764] [players] fix unit-server.ai-hunted
Update of patch #1764 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1764 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1763] [players] rename player-ai_common.control to player-ai_controlled
Update of patch #1763 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1763 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1762] [players] dynamically allocate the team names
Update of patch #1762 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1762 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1761] [players] add team pointer
Update of patch #1761 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1761 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1760] [players] define MAX_NUM_PLAYER_SLOTS
Update of patch #1760 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1760 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1759] [players] fix debugging tool in score.c
Update of patch #1759 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1759 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1746] [players] send diplstate as separate network packages
Update of patch #1746 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1746 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1745] [players] dynamically allocate ai_data
Update of patch #1745 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1745 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1744] [players] rename struct player-ai_data to ai_common
Update of patch #1744 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1744 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1743] [players] dynamically allocate player-diplstates
Update of patch #1743 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1743 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1742] [players] cleanup game_init()
Update of patch #1742 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1742 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1741] [players] use player_slot_count
Update of patch #1741 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1741 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1792] Move ai function pointer setting to ai code
Follow-up Comment #2, patch #1792 (project freeciv): updated to current trunk (file #9636) ___ Additional Item Attachment: File name: 20100730-01-trunk-Move-ai-function-pointer-setting-to-ai-code.patch Size:5 KB ___ Reply to this item at: http://gna.org/patch/?1792 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1778] [interface][ai] define the ai via the new interface
Follow-up Comment #4, patch #1778 (project freeciv): update to current trunk (file #9637) ___ Additional Item Attachment: File name: 20100730-02-trunk-update-definition-of-the-AI.patch Size:25 KB ___ Reply to this item at: http://gna.org/patch/?1778 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16326] fix compiler warning for non-debugging builds in packet.c
Update of bug #16326 (project freeciv): Summary: fix compiler warning for non-debugging builds i packet.c = fix compiler warning for non-debugging builds in packet.c ___ Reply to this item at: http://gna.org/bugs/?16326 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16325] fix compiler warning for non-debugging builds in city.c
Update of bug #16325 (project freeciv): Summary: fix compiler warning for non-debugging buildsin city.c = fix compiler warning for non-debugging builds in city.c ___ Reply to this item at: http://gna.org/bugs/?16325 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1792] Move ai function pointer setting to ai code
Follow-up Comment #3, patch #1792 (project freeciv): * Renamed default_ai_init() as fcai_default_setup(). This will be more correct name after some more patches * Moved init_ai() call from ai implementation specific fcai_default_setup() to ai_init() in common server code move all code which helps players (autosettler, autoexplorer, helper tools like aitools, advisors) into ./server/advisor Yes, although doing this right requires much more work than simply moving stuff. Some rewrites are required as well the server should only use function from ./server/advisor or call the AI via functions pointers; never call AI functions directly This should already be the case after I implemented ai_type and function pointers in it. This makes it possible to make AI as separately loadable module. the AI should prefer to use functions from ./common over functions from ./server (posibility of a client side AI) I don't see the gain here. Client side AI could use almost no code from current server side AI. There's no much point in making ai to look like common code when it still can be used only as server code. (file #9638) ___ Additional Item Attachment: File name: DefaultAiInit_1792-2.diff Size:5 KB ___ Reply to this item at: http://gna.org/patch/?1792 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1793] call_incident() never fallbacks to violators function
URL: http://gna.org/patch/?1793 Summary: call_incident() never fallbacks to violators function Project: Freeciv Submitted by: cazfi Submitted on: Friday 07/30/2010 at 18:58 Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: It doesn't make much sense that if ai_type of the victim does not define incident function, violators version is used instead. call_incident() does that just because nuclear incident affects all the players and thus there is no clear one victim. Attached patch fixes this by moving player iteration from inside the incident code to the caller. ___ File Attachments: --- Date: Friday 07/30/2010 at 18:58 Name: CallIncidentRewrite.diff Size: 6kB By: cazfi http://gna.org/patch/download.php?file_id=9639 ___ Reply to this item at: http://gna.org/patch/?1793 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1792] Move ai function pointer setting to ai code
Follow-up Comment #4, patch #1792 (project freeciv): I guess the prefix fcai should be fc_ai, according to the most functions using this prefix. ___ Reply to this item at: http://gna.org/patch/?1792 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1715] Translation fixes for FR
Update of patch #1715 (project freeciv): Planned Release: 2.2.2 = 2.2.3 ___ Reply to this item at: http://gna.org/patch/?1715 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1792] Move ai function pointer setting to ai code
Follow-up Comment #5, patch #1792 (project freeciv): This should already be the case after I implemented ai_type and function pointers in it. This makes it possible to make AI as separately loadable module. It is not the case. As listed in patch #1785 there are a lot dependencies of the server on code in ./ai. This should already be the case after I implemented ai_type and function pointers in it. This makes it possible to make AI as separately loadable module. Yes; but at the moment the server code and the ai code are really interconnected (ai_choice, settlermap, ...). ___ Reply to this item at: http://gna.org/patch/?1792 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16329] Problem loading France Scenario
URL: http://gna.org/bugs/?16329 Summary: Problem loading France Scenario Project: Freeciv Submitted by: None Submitted on: Saturday 07/31/2010 at 07:45 CEST Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: clark.mil...@yahoo.com Open/Closed: Open Release: 2.2.2 Discussion Lock: Any Operating System: Microsoft Windows Planned Release: ___ Details: Scenario bug. Version 2.2.2. When trying to start scenario for France, receive the following error in a popup window: sectionfile data/scenario/france-140x90-v2.sav.gz doesn't contain a 'game.turn' entry ___ Reply to this item at: http://gna.org/bugs/?16329 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
