[Freeciv-Dev] [bug #18005] in dbv_isset() [bitvector.c::120]: assertion 'pdbv->vec != ((void *)0)' failed.

[Jacob Nevins]

Follow-up Comment #5, bug #18005 (project freeciv):

(My reproduction case for this is now attached to bug #17990.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17990] can see inside of lost city

[Jacob Nevins]

Update of bug #17990 (project freeciv):

  Status:None => Confirmed  
 Planned Release: => 2.3.0  

___

Follow-up Comment #6:

Here's my reproduction case:
* Trunk r19601 (needs patch #2627 and patch #2630).
* Start server with attached savegame canadians-T0330-Y01905-manual.sav.bz2
(originally from S2_2, but I doubt it matters).
* Connect one client and take player 'jtn' (Canadian).
* Also connect another client as a global observer (user 'observer').
* Start game and run server command '/lua
print(civil_war(find.player(0),100))' (force civil war on Canadians, creating
the Iroquois).

Results:

'jtn' still sees the city of Quebec in fog-of-war with a Canadian flag,
despite the fact that it's clearly in Iroquois territory and the global
observer can see it's an Iroquois city; 'jtn' and can open up a city dialog
for Quebec and apparently see private information (although comparing with the
global observer's view, it's out of date). See screenshot.

After civil war, jtn's client has the following on the console, which looks
like bug #13701 (although I don't know if it has the same cause, nor if it's
related to this problem with Quebec -- city 303 is ex-Canadian Regina which
has also rebelled, but this is correctly reflected in jtn's view):

1: game_remove_unit() at (52,15) unit 2369, Canadian Engineers home 303
invalid
1: game_remove_unit() at (52,15) unit 1607, Canadian Engineers home 303
invalid
1: game_remove_unit() at (52,15) unit 2580, Canadian Engineers home 303
invalid


After the civil war, observer's client starts spewing dbv_isset assertions on
its console whenever you e.g. scroll (bug #18005). Again, don't know if it's
related, but it only starts happening after the civil war.

If the server is logging with "-d 3", I get the attached logfile. Looking for
CITY_INFO / CITY_SHORT_INFO packets about city ID 146 (Quebec), I see that no
packet with "field 'owner' has changed" is ever sent to 'jtn', only to
'observer', which is consistent with the symptom.

I speculate that such out-of-date client info could be implicated in bug
#17860 (a client crash when an enemy takes a city -- not a server crash as I
stated in comment #2).

(file #12846, file #12847, file #12848)
___

Additional Item Attachment:

File name: canadians-T0330-Y01905-manual.sav.bz2 Size:52 KB
File name: bug17990_quebec.pngSize:511 KB
File name: canadians-civilwar-2.log.gzSize:326 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17990] can see inside of lost city

[Jacob Nevins]

Follow-up Comment #5, bug #17990 (project freeciv):

As for reproducing it from the original savegames in this bug, I can't:
* If I load file #12778 into the 2.3.0-beta3 or latest S2_3 codebase and take
bvanevery, I can't see that there is a city on that tile at all, let alone one
with the wrong flag (of course I can confirm Carnot's existence if I connect a
separate global observer).
** This seems wrong; I think I've seen behaviour like this before, where the
player's view of cities is not saved correctly; I think we have a separate bug
here.
* If I load file #12781 into 2.3.0-beta3, bvanevery sees Carnot, owned by the
correct nation (Central African).

I'll post my own reproduction case next.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2630] Debug: identify connection in network packet log

[Jacob Nevins]

Update of patch #2630 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2621] Faroese nation

[Jacob Nevins]

Follow-up Comment #2, patch #2621 (project freeciv):

There's a typo in r19599 that's breaking the build. Committing attached patch
immediately.

(file #12845)
___

Additional Item Attachment:

File name: trunk-faroese-typo.diffSize:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2635] Improvements to French nation

[J.M. Maalderink]

URL:
  

 Summary: Improvements to French nation
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Tue 12 Apr 2011 05:25:15 PM GMT
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: mixcoatl
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

More cities, more leaders, more legend.



___

File Attachments:


---
Date: Tue 12 Apr 2011 05:25:16 PM GMT  Name: french.ruleset  Size: 5kB   By:
mixcoatl



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2634] Kuwaiti nation

[J.M. Maalderink]

URL:
  

 Summary: Kuwaiti nation
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Tue 12 Apr 2011 05:00:10 PM GMT
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: mixcoatl
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Kuwait

flag by myself



___

File Attachments:


---
Date: Tue 12 Apr 2011 05:00:10 PM GMT  Name: kuwaiti.ruleset  Size: 2kB   By:
mixcoatl


---
Date: Tue 12 Apr 2011 05:00:10 PM GMT  Name: kuwait.svg  Size: 542B   By:
mixcoatl



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2505] Helvetian nation

[J.M. Maalderink]

Update of patch #2505 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

Made a svg flag and added some cities in the ruleset.

(file #12840, file #12841)
___

Additional Item Attachment:

File name: helvetii.svg   Size:9 KB
File name: helvetian.ruleset  Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2428] Sabinian nation

[Andrzej M. Gorzym]

Follow-up Comment #4, patch #2428 (project freeciv):

Based on coat of Rieti provincia and flag of Rome.
http://img811.imageshack.us/img811/3743/sabine.png

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2532] Samnite nation

[Andrzej M. Gorzym]

Follow-up Comment #2, patch #2532 (project freeciv):

Oops, another topic. xD

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2532] Samnite nation

[Andrzej M. Gorzym]

Follow-up Comment #1, patch #2532 (project freeciv):

Sabine flag based on a coat of Rieti provincia and flag of Rome.
http://img811.imageshack.us/img811/3743/sabine.png

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev