[Freeciv-Dev] [patch #2773] Backtrace log callback for log levels = error
Update of patch #2773 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2773 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2796] Build freeciv-modpack deb package
Update of patch #2796 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2796 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18358] LUA script to change/merge nations
URL: http://gna.org/bugs/?18358 Summary: LUA script to change/merge nations Project: Freeciv Submitted by: tirolalira Submitted on: sáb 16 jul 2011 09:38:14 GMT Category: rulesets Severity: 1 - Wish Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Just a wish/suggestion... I have seen in v2.4 it will be possible to trigger a civil war with LUA scripts. I think it would be very useful in order to create immersive scenarios, if you also a add the possibility to merge AI nations, or to change one nation into another. For example, you could start an scenario with Russian, Ukrainian and Belarusian, and to merge them into Soviets when Communism is researched. Or you could start with Gallic and Teutonic, and to transform them to France and Germany later in game. I think Civil War code might be similar to my suggestion. I guess it would be as if Russians start a civil war between Soviets and Soviets. ___ Reply to this item at: http://gna.org/bugs/?18358 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2810] Unix desktop file and icons for freeciv-modpack
URL: http://gna.org/patch/?2810 Summary: Unix desktop file and icons for freeciv-modpack Project: Freeciv Submitted by: jtn Submitted on: Sat Jul 16 17:04:01 2011 Category: module installer Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.1,2.4.0 ___ Details: Based on the same icon by yd on the forum http://forum.freeciv.org/viewtopic.php?t=6907 as patch #2787. This adds a .desktop file that will put freeciv-modpack in the same place in a Linux (or other freedesktop-standard-supporting) menu structure as the server and Gtk client. (I'm not sure that's what everyone will want, but for Debian/Ubuntu at least it's planned to be a separate package.) (It would be nice to give the Gtk executable an icon at runtime, too, but it's tricky. The Gtk client's application icon is all tied up with loading tilesets; freeciv-modpack doesn't even know where the data directories are.) ___ Reply to this item at: http://gna.org/patch/?2810 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2810] Unix desktop file and icons for freeciv-modpack
Additional Item Attachment, patch #2810 (project freeciv): File name: trunk-S2_3-freeciv-modpack-freedesktop-icons.diff Size:4 KB ___ Reply to this item at: http://gna.org/patch/?2810 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2810] Unix desktop file and icons for freeciv-modpack
Additional Item Attachment, patch #2810 (project freeciv): File name: freeciv-modpack-128x128.pngSize:20 KB ___ Reply to this item at: http://gna.org/patch/?2810 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2810] Unix desktop file and icons for freeciv-modpack
Additional Item Attachment, patch #2810 (project freeciv): File name: freeciv-modpack-64x64.png Size:6 KB File name: freeciv-modpack-48x48.png Size:4 KB File name: freeciv-modpack-32x32.png Size:2 KB File name: freeciv-modpack-16x16.png Size:0 KB ___ Reply to this item at: http://gna.org/patch/?2810 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2810] Unix desktop file and icons for freeciv-modpack
Update of patch #2810 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/patch/?2810 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2808] Commandline options for freeciv-modpack
Update of patch #2808 (project freeciv): Planned Release:2.3.0, 2.4.0 = 2.3.1, 2.4.0 ___ Follow-up Comment #1: - Updated against current svn (file #13589, file #13590) ___ Additional Item Attachment: File name: MPCmdLine_2808-2.diff Size:6 KB File name: MPCmdLine_2808-S2_3-2.diff Size:6 KB ___ Reply to this item at: http://gna.org/patch/?2808 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7425] Windows packages for 2.2.7
URL: http://gna.org/task/?7425 Summary: Windows packages for 2.2.7 Project: Freeciv Submitted by: jtn Submitted on: Sat Jul 16 21:51:15 2011 Should Start On: Sat Jul 16 00:00:00 2011 Should be Finished on: Sat Jul 23 00:00:00 2011 Category: None Priority: 5 - Normal Status: None Privacy: Public Percent Complete: 0% Assigned to: cproc Open/Closed: Open Discussion Lock: Any Effort: 0.00 Planned Release: 2.2.7 ___ Details: ___ Reply to this item at: http://gna.org/task/?7425 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7426] Mac packages for 2.2.7
URL: http://gna.org/task/?7426 Summary: Mac packages for 2.2.7 Project: Freeciv Submitted by: jtn Submitted on: Sat Jul 16 21:51:17 2011 Should Start On: Sat Jul 16 00:00:00 2011 Should be Finished on: Sat Jul 23 00:00:00 2011 Category: None Priority: 5 - Normal Status: None Privacy: Public Percent Complete: 0% Assigned to: bitaxis Open/Closed: Open Discussion Lock: Any Effort: 0.00 Planned Release: 2.2.7 ___ Details: This time, for sure! ___ Reply to this item at: http://gna.org/task/?7426 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2811] Static (compile-time) assert mechanism
URL:
http://gna.org/patch/?2811
Summary: Static (compile-time) assert mechanism
Project: Freeciv
Submitted by: jtn
Submitted on: Sat Jul 16 23:35:33 2011
Category: general
Priority: 5 - Normal
Status: In Progress
Privacy: Public
Assigned to: jtn
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 2.4.0
___
Details:
For maintainability, it's occasionally useful to be able to make the build
fail if certain conditions are not true, usually relating to build-time
tweakables or system limits.
Bug #18087 is a case in point; MAP_MAX_SIZE relies on MAX_DBV_LENGTH having a
certain minimum value, and this is currently commented, but it would be better
if the build failed hard when someone increased MAP_MAX_SIZE without noticing
the comment, rather than them having to debug some subtle failure. (OK, in
this case you run into a run-time assertion failure pretty quickly, but in
some other case you might not happen to tickle that code path in your
testing.)
This isn't a standard facility in the C language (yet), but there are a
number of well-known techniques for doing this in C, each with their
advantages and drawbacks (particularly generation of warnings, which matters
to us because we run with -Werror).
Googling found some surveys of available techniques here
http://www.pixelbeat.org/programming/gcc/static_assert.html, here
http://www.jaggersoft.com/pubs/CVu11_3.html (old!), and here
http://bytes.com/topic/c/answers/758263-more-portable-compile-time-assert,
for example.
I'm leaning toward this one:
#define FC_STATIC_ASSERT(cond, tag) enum { static_assert_ ## tag = 1 /
(!!(cond)) }
FC_STATIC_ASSERT(MAP_MAX_SIZE * 1000 = MAX_DBV_LENGTH,
map_too_big_for_bitvector);
which, if it fails, throws the following error on my system:
In file included from ../packets.h:29,
from ../game.h:33,
from aisupport.c:26:
../map.h:571: error: division by zero
../map.h:571: error: enumerator value for
‘static_assert_map_too_big_for_bitvector’ is not an integer constant
Ugly, but effective.
(It's a shame this idiom doesn't map onto the
static_assert(constant-expression, error message) pattern that's apparently
coming in a future C standard, but I haven't found a satisfactory technique
that does.)
___
Reply to this item at:
http://gna.org/patch/?2811
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2811] Static (compile-time) assert mechanism
Update of patch #2811 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #1: Proof of concept attached. (Note that I haven't actually verified that the specific condition I'm asserting as an example is correct yet...) (file #13594) ___ Additional Item Attachment: File name: trunk-static-assert.diff Size:2 KB ___ Reply to this item at: http://gna.org/patch/?2811 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18087] Increase max map size to 2, 048, 000 tiles (and max linear size to 32, 768)
Follow-up Comment #20, bug #18087 (project freeciv): I only noticed one [memory leak]: in sg_load_map_known()), SAVE_MAP_CHAR() - sg_failure_ret() - sg_check_ret() can return prematurely. I will try to find a way to handle such cases. Would it help to add a (possible) goto action to the macro, i.e goto CLEANUP? Having a standard goto CLEANUP would oblige every direct or indirect caller to have a CLEANUP label, and perhaps limit you to one use of this stuff per function, neither of which is likely to be acceptable. I'm not 100% sure what the answer is; probably something like adding a cleanup argument to the macro, which is executed as code before returning, and into which you'd put free(whatever). Anyway, I've raised bug #18347 about this. trunk-S2_3-hugemap-colatitude.diff It is only needed if the map size is increased further (patch 3). Thanks for confirming. Is there something like #error? It could stop compilation if the check fails ... #if/#error looks like the right thing (and would probably work in this case) but often it's subtly wrong or annoyingly incapable (no sizeof, etc). I've raised patch #2811 for a non-preprocessor static assert mechanism. ___ Reply to this item at: http://gna.org/bugs/?18087 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18354] freeciv-modpack.exe crashes on startup
Follow-up Comment #4, bug #18354 (project freeciv): The attached patch fixes the startup crash for me. Now the main windows shows, but it says Failed to download modpack list. (file #13595) ___ Additional Item Attachment: File name: bug18354-init_character_encodings-S2_3.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?18354 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18363] Themes make freeciv interface unusable
Follow-up Comment #1, bug #18363 (project freeciv): That's pretty bad. Can you give details of your OS, desktop environment, system theme etc? ___ Reply to this item at: http://gna.org/bugs/?18363 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18363] Themes make freeciv interface unusable
Follow-up Comment #2, bug #18363 (project freeciv): Thanks for the friendly reply. Most developers won't consider this problem. Linux Mint 11, Gnome 2.32.1, using Cillop-Midnight controls. Any dark theme (or high-contrast Assistive/Accessibility theme) that sets the controls text to a light colour will cause the problem. This happens constantly in Windows when programs have a custom interface, ignoring system colours. ___ Reply to this item at: http://gna.org/bugs/?18363 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2811] Static (compile-time) assert mechanism
Follow-up Comment #2, patch #2811 (project freeciv): I haven't looked your patch at all, but... This idiom doesn't map onto the static_assert(constant-expression, error message) pattern that's apparently coming in a future C standard Well, no standard with static_assert has been released yet, but that has never stopped gcc folk from implementing things that are already in proposal... At least g++ side has had static_assert since 4.3. One should check if also gcc supports it. If it does: as gcc is the compiler used for freeciv compilation 99.5% of the time, I'd simply add configure check if compiler supports static_assert(), and define our own macro accordingly (either use static_assert, or do nothing). ___ Reply to this item at: http://gna.org/patch/?2811 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
URL: http://gna.org/patch/?2812 Summary: Fix modpack initialization Project: Freeciv Submitted by: cproc Submitted on: So 17 Jul 2011 05:14:57 CEST Category: module installer Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: $subject + add libgthread dependency on Windows, where it is not already a dependency of GTK+ as on Linux. Modpack downloading seems to work now on Windows. Here's an S2_3 Windows package for testing: http://download.gna.org/freeciv/packages/windows/testing/Freeciv-S2_3-2011-07-17-win32-gtk2-setup.exe ___ File Attachments: --- Date: So 17 Jul 2011 05:14:57 CEST Name: modpack_initialization.diff Size: 1kB By: cproc http://gna.org/patch/download.php?file_id=13597 ___ Reply to this item at: http://gna.org/patch/?2812 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
