[Freeciv-Dev] Fullmoon build results

2012-02-14 Thread fullmoon
This is build report automatically generated by FullMoon Ilmarinen (0.4.50.1)

Fullmoon operated by Marko Lindqvist cazf...@gmail.com This build is from 
TRUNK.

Component svn, Host build.cazfi.net, Phase Source update(1): FAILED


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Fullmoon build results

2012-02-14 Thread fullmoon
This is build report automatically generated by FullMoon Ilmarinen (0.4.50.1)

Fullmoon operated by Marko Lindqvist cazf...@gmail.com This build is from 
TRUNK.

Component svn, Host build.cazfi.net, Phase Source update(1): FAILED


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Fullmoon build results

2012-02-14 Thread fullmoon
This is build report automatically generated by FullMoon Ilmarinen (0.4.50.1)

Fullmoon operated by Marko Lindqvist cazf...@gmail.com This build is from 
TRUNK.

Component svn, Host build.cazfi.net, Phase Source update(1): FAILED


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Fullmoon build results

2012-02-14 Thread fullmoon
This is build report automatically generated by FullMoon Ilmarinen (0.4.50.1)

Fullmoon operated by Marko Lindqvist cazf...@gmail.com This build is from 
TRUNK.

Component svn, Host build.cazfi.net, Phase Source update(1): FAILED


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Fullmoon build results

2012-02-14 Thread fullmoon
This is build report automatically generated by FullMoon Ilmarinen (0.4.50.1)

Fullmoon operated by Marko Lindqvist cazf...@gmail.com This build is from 
TRUNK.

Component svn, Host build.cazfi.net, Phase Source update(1): FAILED


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19241] Server crash when game ends with 100 players

2012-02-14 Thread Marko Lindqvist
Update of bug #19241 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19241

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19445] Non-existent citizens migrate

2012-02-14 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?19445

 Summary: Non-existent citizens migrate
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 14 Feb 2012 11:15:02 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0, 2.5.0

___

Details:

Migration tries to move citizen of source city owner nationality without
checking if one exist. This leads to problems when migrating from city that
has only foreigners in.

Fix attached



___

File Attachments:


---
Date: Tue 14 Feb 2012 11:15:02 PM EET  Name: MigratingForeigners.diff  Size:
2kB   By: cazfi

http://gna.org/bugs/download.php?file_id=15044

___

Reply to this item at:

  http://gna.org/bugs/?19445

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19446] URL missing from modpack.list leaves freeciv-modpack to forever-loop

2012-02-14 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?19446

 Summary: URL missing from modpack.list leaves freeciv-modpack
to forever-loop
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 14 Feb 2012 11:23:27 PM EET
Category: module installer
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.2, 2.4.0, 2.5.0

___

Details:

If there's modpack name without URL in modpack.list, list handling loop does
not terminate nor advance to next line.

Fix attached.



___

File Attachments:


---
Date: Tue 14 Feb 2012 11:23:27 PM EET  Name: MissURLNotBusyLoop.diff  Size:
413B   By: cazfi

http://gna.org/bugs/download.php?file_id=15045
---
Date: Tue 14 Feb 2012 11:23:27 PM EET  Name: MissURLNotBusyLoop-S2_3.diff 
Size: 408B   By: cazfi

http://gna.org/bugs/download.php?file_id=15046

___

Reply to this item at:

  http://gna.org/bugs/?19446

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19447] Over maximum veteran level assigned initially to unit

2012-02-14 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?19447

 Summary: Over maximum veteran level assigned initially to
unit
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 14 Feb 2012 11:56:36 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.2, 2.4.0, 2.5.0

___

Details:

create_unit_virtual() can get called with initial veteran level that exceeds
maximum for unit type. It then happily assigns that value to created unit.

Attached fix limits veterancy level to maximum for unit type inside
create_unit_virtual(). Similar check inside callers would be no more correct
than this, and by placing it to create_unit_virtual() all callers are handled
at once.

I think this bug could cause problems in S2_3 only with ruleset that has only
single veterancy level, but has some Veteran_Build -effect. In S2_4 and TRUNK
this is more serious problem as Veteran_Build value means number of levels and
thus multiple effects together can increase level unexpectedly, and effect
that gives just maximum level for one unit type can be over maximum for
another unit type.



___

File Attachments:


---
Date: Tue 14 Feb 2012 11:56:36 PM EET  Name: MaxVetLvlsForVunit.diff  Size:
909B   By: cazfi

http://gna.org/bugs/download.php?file_id=15047
---
Date: Tue 14 Feb 2012 11:56:36 PM EET  Name: MaxVetLvlsForVunit-S2_3.diff 
Size: 903B   By: cazfi

http://gna.org/bugs/download.php?file_id=15048

___

Reply to this item at:

  http://gna.org/bugs/?19447

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19448] civ2 Barracks and Sun Tzu cumulative

2012-02-14 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?19448

 Summary: civ2 Barracks and Sun Tzu cumulative
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 15 Feb 2012 12:11:56 AM EET
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0, 2.5.0

___

Details:

In civ2 ruleset Barracks and Sun Tzu are cumulative, increasing veterancy
level of newly built units by 2. Fix attached.

Since civ2 has only two veterancy levels, this fix is not strictly needed once
bug #19447 is fixed, but is still semantically correct.

Barracks and Sun Tzu are cumulative in other rulesets too, and with multiple
veterancy levels in those it really makes a difference. However, I like the
idea that Wonder does not make some Building obsolete, but rather complements
it. I'm for declaring this as new feature rather than bug. Helptexts should be
adjusted, of course.



___

File Attachments:


---
Date: Wed 15 Feb 2012 12:11:56 AM EET  Name: Civ2STBarracksNotCumulative.diff 
Size: 535B   By: cazfi

http://gna.org/bugs/download.php?file_id=15049

___

Reply to this item at:

  http://gna.org/bugs/?19448

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19449] Aisettlers reserving tile already reserved for another city center as place for first worker

2012-02-14 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?19449

 Summary: Aisettlers reserving tile already reserved for
another city center as place for first worker
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 15 Feb 2012 12:33:43 AM EET
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0, 2.5.0

___

Details:

When aisettler searches best tile for first worker of city it considers to
build, already reserved tiles are assigned goodness of 0. If no tile at all
gets positive goodness, such an tile can still be considered best one, and
aisettler tries to reserve it.

Attached fix assigns value of -1 for tiles reserved for city centers, and no
tile at all is reserved as first one to be worked if there's only tiles with
negative goodness.



___

File Attachments:


---
Date: Wed 15 Feb 2012 12:33:43 AM EET  Name: ReservedBestOtherCitytile.diff 
Size: 908B   By: cazfi

http://gna.org/bugs/download.php?file_id=15050

___

Reply to this item at:

  http://gna.org/bugs/?19449

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18945] Unit orientation can change between partial research dialog redraws

2012-02-14 Thread Marko Lindqvist
Update of bug #18945 (project freeciv):

  Status:None = Ready For Test 
 Summary: Units with orientation corrupted in partial research
dialog redraw = Unit orientation can change between partial research dialog
redraws

___

Follow-up Comment #1:

Attached patch makes orientation in research dialog fixed to South. More
importantly it provides way to have fixed orientation in any such dialog if
similar problems arise. For now all other dialogs are left to use random
orientation.

(file #15051)
___

Additional Item Attachment:

File name: FixedUSpriteOrientation.diff   Size:11 KB


___

Reply to this item at:

  http://gna.org/bugs/?18945

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19450] Setting of Max rates access player team information before it's set

2012-02-14 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?19450

 Summary: Setting of Max rates access player team information
before it's set
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 15 Feb 2012 01:26:30 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.2, 2.4.0, 2.5.0

___

Details:

Even with bug #17557 fixed, initial setting of player max rates can access
player team information too early.

Attached fix postpones initial setting of max rates until team information is
certainly set up.

I found this problem with Alien Ruleset. There's also report by tirolalira in
forum about similar problem with his ruleset:
http://forum.freeciv.org/viewtopic.php?t=6845start=29



___

File Attachments:


---
Date: Wed 15 Feb 2012 01:26:30 AM EET  Name: MaxRatesInit.diff  Size: 1kB  
By: cazfi

http://gna.org/bugs/download.php?file_id=15052

___

Reply to this item at:

  http://gna.org/bugs/?19450

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3129] section_file header

2012-02-14 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3129

 Summary: section_file header
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 15 Feb 2012 01:40:39 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

This patch moves section_file internals to new header section_file.h. Idea is
that all the registry internal source files (all the backends) can include
that header, but no external source file should include it.



___

File Attachments:


---
Date: Wed 15 Feb 2012 01:40:39 AM EET  Name: SectionFileHdr.diff  Size: 3kB  
By: cazfi

http://gna.org/patch/download.php?file_id=15053

___

Reply to this item at:

  http://gna.org/patch/?3129

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18776] /remove after game start causes crashes due to player vision mishandling

2012-02-14 Thread Jacob Nevins
Follow-up Comment #35, bug #18776 (project freeciv):

 == Vision cleanup when player removed ==
 Apply immediately after 2.3.1 release, to get confidence in fix.

Hem. Sorry, dropped the ball here. Well, better late than never.
Matthias' S2_3 patch applied. Version ported to S2_4/trunk attached
(differences trivial, due to patch #2357); will apply soon.
Testing minimal (I'm mostly relying on akfaew saying it made things better).
I've provoked a few bad client behaviours (which should be the subject of a
new bug), but no *server* crash.

 == Player slots miscounted when loading/saving known tiles ==

Now bug #19007. Patch long since applied.

 == Divisor issue when saving/loading known tiles == 

Now bug #19029. Still outstanding.

(file #15054)
___

Additional Item Attachment:

File name: trunk-S2_4-server-remove-player-after-start.diff Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?18776

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev