[Freeciv-Dev] [patch #4299] Minor bugs in nation ruleset loading error checking
URL: http://gna.org/patch/?4299 Summary: Minor bugs in nation ruleset loading error checking Project: Freeciv Submitted by: jtn Submitted on: Sat Nov 9 23:13:12 2013 Category: None Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.1,2.5.0,2.6.0 ___ Details: * Can double-free a seclist on errors (2.5 and later) * Trouble if too many nation groups are defined * Bail out earlier if there's a problem with leader titles (2.5 and later) ___ Reply to this item at: http://gna.org/patch/?4299 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4300] Fix error with rulesets with no nation groups defined
URL: http://gna.org/patch/?4300 Summary: Fix error with rulesets with no nation groups defined Project: Freeciv Submitted by: jtn Submitted on: Sat Nov 9 23:13:55 2013 Category: None Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.1,2.5.0,2.6.0 ___ Details: Using a ruleset with no nation groups causes various assertion failures at ruleset load time. Since the game has no hard requirement for there to be any nation groups (I think everything works OK without), this patch suppresses the errors during ruleset loading. ___ Reply to this item at: http://gna.org/patch/?4300 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4301] Remove Nation/Flag headers from list in nation selection dialog
URL: http://gna.org/patch/?4301 Summary: Remove Nation/Flag headers from list in nation selection dialog Project: Freeciv Submitted by: jtn Submitted on: Sat Nov 9 23:16:55 2013 Category: client-gtk-2.0 Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0,2.6.0 ___ Details: The only thing these headers give you is the ability to sort the nations in a group in reverse alphabetical order, which doesn't seem worth the screen real estate they take up. (Patch for both Gtk2 and Gtk3 clients.) ___ Reply to this item at: http://gna.org/patch/?4301 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4302] Suppress notebook in nation selection dialog if ruleset defines no nation groups
URL: http://gna.org/patch/?4302 Summary: Suppress notebook in nation selection dialog if ruleset defines no nation groups Project: Freeciv Submitted by: jtn Submitted on: Sat Nov 9 23:18:48 2013 Category: client-gtk-2.0 Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Following on from patch #4300, we can remove some clutter when rulesets don't define any nation groups -- there is only one tab (All) so we don't need to take up screen space with it. ___ Reply to this item at: http://gna.org/patch/?4302 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4303] Alien World: remove nation group
URL: http://gna.org/patch/?4303 Summary: Alien World: remove nation group Project: Freeciv Submitted by: jtn Submitted on: Sat Nov 9 23:22:01 2013 Category: rulesets Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0,2.6.0 ___ Details: The Alien World ruleset currently has a single nation group, also called Alien World, containing all the playable nations. This seems unnecessary, and looks a bit silly as the only tab during nation selection in the Gtk clients. After patch #4300 and patch #4302, we can remove it. (The nation group has an associated match value which will be lost, but I'm reasonably convinced that it makes no difference to the matching algorithm, since all the playable nations will be affected by the same amount.) ___ Reply to this item at: http://gna.org/patch/?4303 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4303] Alien World: remove nation group
Update of patch #4303 (project freeciv): Depends on: = patch #4300 ___ Reply to this item at: http://gna.org/patch/?4303 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4303] Alien World: remove superfluous nation group
Update of patch #4303 (project freeciv): Summary: Alien World: remove nation group = Alien World: remove superfluous nation group ___ Reply to this item at: http://gna.org/patch/?4303 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4304] Rename 'is_available' property of nations to 'is_pickable'
URL: http://gna.org/patch/?4304 Summary: Rename 'is_available' property of nations to 'is_pickable' Project: Freeciv Submitted by: jtn Submitted on: Sat Nov 9 23:39:24 2013 Category: None Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0,2.6.0 ___ Details: While working on patch #3448, I found the member name 'is_available' a misleading name for what it does. I've chosen 'is_pickable' as being possibly a bit better (Whether the client is allowed to try to pick the nation at game start). Also, many comment updates regarding its use and related topics, particularly its interaction with nation map start positions. No functional change in this patch (except to some log_verbose() messages). ___ Reply to this item at: http://gna.org/patch/?4304 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4299] Minor bugs in nation ruleset loading error checking
Update of patch #4299 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_5-ruleset-nation-load-error-checking.patch Size:2 KB File name: S2_4-ruleset-nation-load-error-checking.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?4299 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4300] Fix error with rulesets with no nation groups defined
Update of patch #4300 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_5-allow-no-nation-groups.patch Size:2 KB File name: S2_4-allow-no-nation-groups.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?4300 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4303] Alien World: remove superfluous nation group
Update of patch #4303 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_5-alien-rm-nation-group.patch Size:3 KB ___ Reply to this item at: http://gna.org/patch/?4303 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4302] Suppress notebook in nation selection dialog if ruleset defines no nation groups
Update of patch #4302 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn Planned Release: = 2.5.0,2.6.0 ___ Additional Item Attachment: File name: trunk-S2_5-gtk-nationdlg-nogroups.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?4302 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4301] Remove Nation/Flag headers from list in nation selection dialog
Update of patch #4301 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_5-gtk-nationdlg-rm-colheadings.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?4301 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4304] Rename 'is_available' property of nations to 'is_pickable'
Update of patch #4304 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_5-is_pickable.patch Size:19 KB ___ Reply to this item at: http://gna.org/patch/?4304 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4300] Fix error with rulesets with no nation groups defined
Update of patch #4300 (project freeciv): Depends on: = patch #4299 ___ Reply to this item at: http://gna.org/patch/?4300 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21060] Cosmetic issues in Windows installer language selection
Follow-up Comment #8, bug #21060 (project freeciv): Thanks for testing this and doing this. (I agree the language code should remain visible.) Cosmetic: I propose tweaking American English to US English. (file #19350) ___ Additional Item Attachment: File name: trunk-S2_5-S2_4-installer-us-english.patch Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?21060 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3448] Nation sets: allow set of nations that will ever appear in-game to be chosen
Follow-up Comment #8, patch #3448 (project freeciv): Current WIP. Adds Gtk3 support. Not far from submission now. (I shall be glad to see the back of this.) Compared to file #19212, the following tickets have been spun off and are no longer in this series: bug #21206, bug #21207, patch #4304, and a bit of patch #4299. ___ Reply to this item at: http://gna.org/patch/?3448 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3448] Nation sets: allow set of nations that will ever appear in-game to be chosen
Additional Item Attachment, patch #3448 (project freeciv): File name: trunk-nation-sets-wip-ter.mbox Size:168 KB ___ Reply to this item at: http://gna.org/patch/?3448 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
