[Freeciv-Dev] [bug #21443] Empty global_init_techs not saved
Update of bug #21443 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21443 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4439] meta.ruleset
URL: http://gna.org/patch/?4439 Summary: meta.ruleset Project: Freeciv Submitted by: cazfi Submitted on: Sun 19 Jan 2014 10:37:44 AM EET Category: freeciv-ruledit Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Freeciv-ruledit will need to save some metadata related to the ruleset so that user is not required to set those settings every time (s)he continues to edit the ruleset. Attached patch adds meta.ruleset for storing such information in the future. The ruleset is loaded in ruleset.c like any other ruleset. While it could make sense for now to make it specific to freeciv-ruledit (not loaded to freeciv-server), server too will want meta.ruleset once we implement ruleset object deprecation framework. Ruleset is not required to have meta.ruleset. There's empty one, satisfying ruleset loading code needs, in default/ to be used by the rulesets that do not have it. Freeciv-ruledit always creates meta.ruleset for the ruleset while saving it. ___ File Attachments: --- Date: Sun 19 Jan 2014 10:37:44 AM EET Name: MetaRuleset.patch Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=19785 ___ Reply to this item at: http://gna.org/patch/?4439 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21514] Extra space in description of nameless rulesets
URL: http://gna.org/bugs/?21514 Summary: Extra space in description of nameless rulesets Project: Freeciv Submitted by: cazfi Submitted on: Sun 19 Jan 2014 10:44:09 AM EET Category: freeciv-ruledit Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: When saving nameless ruleset from freeciv-ruledit, descriptions have extra space: Template building data for Freeciv Fix attached. ___ File Attachments: --- Date: Sun 19 Jan 2014 10:44:09 AM EET Name: RuleditTemplateNameSpace.patch Size: 573B By: cazfi http://gna.org/bugs/download.php?file_id=19786 ___ Reply to this item at: http://gna.org/bugs/?21514 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4440] Default Ruleset Name edit value to real ruleset name
URL: http://gna.org/patch/?4440 Summary: Default Ruleset Name edit value to real ruleset name Project: Freeciv Submitted by: cazfi Submitted on: Sun 19 Jan 2014 11:11:40 AM EET Category: freeciv-ruledit Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: - Use game.control.name as default value for Ruleset Name edit - Save Ruleset Name edit value as game.about.name. ___ File Attachments: --- Date: Sun 19 Jan 2014 11:11:40 AM EET Name: RulesetNameDefault.patch Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=19787 ___ Reply to this item at: http://gna.org/patch/?4440 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4441] Editing tech requirements
URL: http://gna.org/patch/?4441 Summary: Editing tech requirements Project: Freeciv Submitted by: cazfi Submitted on: Sun 19 Jan 2014 01:18:53 PM EET Category: freeciv-ruledit Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: This patch implements changing tech requirements in freeciv-ruledit. ___ File Attachments: --- Date: Sun 19 Jan 2014 01:18:53 PM EET Name: TechTreeEdit.patch Size: 7kB By: cazfi http://gna.org/patch/download.php?file_id=19788 ___ Reply to this item at: http://gna.org/patch/?4441 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21516] fileinfoname_required() is cruft?
URL: http://gna.org/bugs/?21516 Summary: fileinfoname_required() is cruft? Project: Freeciv Submitted by: jtn Submitted on: Sun Jan 19 14:23:16 2014 Category: None Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: trunk r24159 Discussion Lock: Any Operating System: None Planned Release: ___ Details: Nothing seems to invoke it (on trunk at least). It dies if a required file can't be found, and gives bad advice about how to fix the problem (it talks about ensuring files are on FREECIV_PATH, which is often not what you actually want, I think). Propose to delete it from any branches where it's not used, unless anyone objects. ___ Reply to this item at: http://gna.org/bugs/?21516 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21517] Man pages documentation for paths is wrong
URL: http://gna.org/bugs/?21517 Summary: Man pages documentation for paths is wrong Project: Freeciv Submitted by: jtn Submitted on: Sun Jan 19 14:24:47 2014 Category: docs Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: trunk r24159 Discussion Lock: Any Operating System: Any Planned Release: ___ Details: Firstly I noticed that freeciv-server.6 typos FREECIV_SCENARIO_PATH for FREECIV_DATA_PATH, but on digging further I find more important discrepancies with actual behaviour. Haven't checked branches other than trunk yet. ___ Reply to this item at: http://gna.org/bugs/?21517 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4442] Add minimal governments help to freeciv-manual
URL: http://gna.org/patch/?4442 Summary: Add minimal governments help to freeciv-manual Project: Freeciv Submitted by: jtn Submitted on: Sun Jan 19 14:27:46 2014 Category: None Priority: 3 - Low Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: I want to bulk-review changes to government help in light of my fixes to bug #20521. Adding a governments page to the freeciv-manual output seems the quickest way, and having implemented it we may as well keep it. Note that the output is completely different to the current wiki doc format http://www.freeciv.org/wiki/Government, so not directly suitable for updating that. (I've no intention of trying to fix this.) ___ Reply to this item at: http://gna.org/patch/?4442 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21516] fileinfoname_required() is cruft?
Update of bug #21516 (project freeciv): Status:None = In Progress Assigned to:None = jtn ___ Follow-up Comment #1: Also, utility/shared.h has a declaration for struct strvec *fileinfonames(const struct strvec *dirs, const char *filename); which doesn't appear to actually exist. Looks like these things have been true forever (since at least the split into FREECIV_*_PATH in r16297 http://svn.gna.org/viewcvs/freeciv?revision=16297view=revision in 2009). ___ Reply to this item at: http://gna.org/bugs/?21516 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4443] Remove references to config.h
URL: http://gna.org/patch/?4443 Summary: Remove references to config.h Project: Freeciv Submitted by: cazfi Submitted on: Sun 19 Jan 2014 04:50:11 PM EET Category: bootstrap Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: cazfi Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.2, 2.5.0, 2.6.0 ___ Details: Got an error from shared.c compilation mentioning config.h instead of fc_config.h, and started checking other places where old config file name is still used. ___ Reply to this item at: http://gna.org/patch/?4443 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4443] Remove references to config.h
Update of patch #4443 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #1: ...and patches. (file #19789, file #19790) ___ Additional Item Attachment: File name: FcConfigH.patchSize:5 KB File name: FcConfigH-S2_4.patch Size:5 KB ___ Reply to this item at: http://gna.org/patch/?4443 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20521] Government Upkeep_Factor help wrong
Follow-up Comment #4, bug #20521 (project freeciv): Second WIP version -- quite different. Notable changes from first version (probably some of these should be split to separate patches): * discard present=FALSE reqs * more asserts for things that should have been caught during ruleset loading * cope with effects with both output type and unit type reqs silence output in more cases in the presence of extra requirements (otherwise could lie) * add PL_() i18n where it was missing * substantially rework veterans help: ** remain silent if more than one (class, flag, type) req (longstanding FIXME) ** add i18n disambiguation for class/flag/type output (longstanding FIXME) ** in the case of a type req, output the specific veteran rank name ** reword to make it clearer that it applies to newly built units Also attached is the current difference it makes to government help with supplied rulesets + variant2. I haven't investigated the following unexpected diffs, but suspect they are more accurate rather than less: * civ2civ3 waste/corruption * alien max tax rates (file #19791, file #19792) ___ Additional Item Attachment: File name: trunk-gov-help-worldbonus-wip-bis.patch Size:35 KB File name: trunk-gov-help-worldbonus-wip-bis-output.diff Size:66 KB ___ Reply to this item at: http://gna.org/bugs/?20521 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21516] fileinfoname_required() is cruft?
Update of bug #21516 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.3.5,2.4.2,2.5.0,2.6.0 ___ Additional Item Attachment: File name: trunk-S2_5-S2_4-S2_3-unused-fileinfo-fns.patch Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?21516 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21517] Man pages documentation for paths is wrong
Update of bug #21517 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Follow-up Comment #1: Trunk patch doesn't apply cleanly to S2_3, and IIRC the situation may be different there. I may investigate a patch for S2_3 later. (file #19794) ___ Additional Item Attachment: File name: trunk-S2_5-S2_4-man-pages-paths.patch Size:9 KB ___ Reply to this item at: http://gna.org/bugs/?21517 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4442] Add minimal governments help to freeciv-manual
Update of patch #4442 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4,2.2.5.0,2.6.0 ___ Follow-up Comment #1: Patch applies cleanly to S2_3 but I don't plan to commit it there, as it adds a new string. (file #19795) ___ Additional Item Attachment: File name: trunk-S2_5-S2_4-S2_3-freeciv_manual-govs.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?4442 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4444] Castro culture nation
URL: http://gna.org/patch/? Summary: Castro culture nation Project: Freeciv Submitted by: None Submitted on: dom 19 ene 2014 16:54:08 UTC Category: rulesets Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: paf...@hotmail.com Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Just a suggest for a new nation.Hope you like it. ___ File Attachments: --- Date: dom 19 ene 2014 16:54:08 UTC Name: castro.ruleset Size: 1kB By: None http://gna.org/patch/download.php?file_id=19796 --- Date: dom 19 ene 2014 16:54:08 UTC Name: castro.svg Size: 4kB By: None http://gna.org/patch/download.php?file_id=19797 --- Date: dom 19 ene 2014 16:54:08 UTC Name: castro.jpg Size: 6kB By: None http://gna.org/patch/download.php?file_id=19798 ___ Reply to this item at: http://gna.org/patch/? ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4434] Natural defense extras
Update of patch #4434 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4434 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21518] Compilation failure due to size_t section file include counter
URL: http://gna.org/bugs/?21518 Summary: Compilation failure due to size_t section file include counter Project: Freeciv Submitted by: cazfi Submitted on: Sun 19 Jan 2014 08:34:35 PM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: Building current TRUNK with crosser (gcc version 4.6.4) says: unknown conversion type character 'z' in format [-Werror=format] I remember similar problem earlier where I did research to find out that there isn't really portable (as in: works with older compilers than latest standards) way to printf size_t. Attached patch works around the problem. ___ File Attachments: --- Date: Sun 19 Jan 2014 08:34:35 PM EET Name: IntNumIncludes.patch Size: 1kB By: cazfi http://gna.org/bugs/download.php?file_id=19800 ___ Reply to this item at: http://gna.org/bugs/?21518 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21519] civ2 ruleset food upkeep excessive?
URL: http://gna.org/bugs/?21519 Summary: civ2 ruleset food upkeep excessive? Project: Freeciv Submitted by: jtn Submitted on: Mon Jan 20 01:11:28 2014 Category: rulesets Severity: 3 - Normal Priority: 5 - Normal Status: Need Info Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: ___ Details: Split from bug #20521: In the civ2 ruleset, Settlers' food upkeep for various governments is: * Anarchy, Despotism, Monarchy: 1 * Republic, Democracy: 2 * Fundamentalism, Communism: 3 Bbug #20521 comment 1 contains some archaeology indicating that the upkeep=3 govs might have been accidental (in earlier Freeciv they were 2). However, I haven't checked the original Civ2 -- probably that needs doing to close this ticket. The 3 upkeep is not at all evident in the game, due to a combination of bug #20521 and upkeep icons only going up to 2 (patch #3824). If it's a mistake, this may explain why it's gone unnoticed so long. (The only other ruleset we ship having 3 upkeep anywhere is multiplayer, where Fundamentalism has 3 upkeep. This one may have been deliberate.) ___ Reply to this item at: http://gna.org/bugs/?21519 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20521] Government Upkeep_Factor help wrong
Follow-up Comment #5, bug #20521 (project freeciv): Changing the civ2 food upkeep factors [...] to be the subject of new tickets. Now bug #21519. ___ Reply to this item at: http://gna.org/bugs/?20521 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21517] Man pages documentation for paths is wrong
Update of bug #21517 (project freeciv): Planned Release: 2.4.2,2.5.0,2.6.0 = 2.3.5,2.4.2,2.5.0,2.6.0 ___ Follow-up Comment #2: S2_3 version (slightly different as resolution to bug #17787 was different). (file #19801) ___ Additional Item Attachment: File name: S2_3-man-pages-paths.patch Size:9 KB ___ Reply to this item at: http://gna.org/bugs/?21517 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4445] Specify reason for You can't attack there
URL: http://gna.org/patch/?4445 Summary: Specify reason for You can't attack there Project: Freeciv Submitted by: cazfi Submitted on: Mon 20 Jan 2014 08:10:41 AM EET Category: general Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.3, 2.5.0, 2.6.0 ___ Details: It came up in forum thread started by Arbogast that You can't attack there. message can result from multiple reasons, and it's not always clear what caused it: http://forum.freeciv.org/f/viewtopic.php?f=17t=227 I'll look in to making message specify the reason. ___ Reply to this item at: http://gna.org/patch/?4445 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
