[Freeciv-Dev] [patch #4517] Use fc_tristate in meta knowledge and remove mk_eval_result
URL: http://gna.org/patch/?4517 Summary: Use fc_tristate in meta knowledge and remove mk_eval_result Project: Freeciv Submitted by: sveinung Submitted on: Tue 18 Feb 2014 08:58:39 PM UTC Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: One tri state is enough. ___ Reply to this item at: http://gna.org/patch/?4517 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4493] Options to enable sfx and/or music
Update of patch #4493 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4493 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21607] some xaw anomalies
Update of bug #21607 (project freeciv): Summary: some xaw naomalies = some xaw anomalies ___ Reply to this item at: http://gna.org/bugs/?21607 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4487] [Metaticket] Music switching system
Update of patch #4487 (project freeciv): Depends on: = patch #4518 ___ Reply to this item at: http://gna.org/patch/?4487 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3793] [metaticket] Help updates for 2.5.0
Update of patch #3793 (project freeciv): Depends on: = patch #4521 ___ Reply to this item at: http://gna.org/patch/?3793 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4514] Move along the diplomat queue using choose_action_queue_next()
Update of patch #4514 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4514 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4518] menu_music_enable_callback()
URL: http://gna.org/patch/?4518 Summary: menu_music_enable_callback() Project: Freeciv Submitted by: cazfi Submitted on: Wed 19 Feb 2014 05:24:22 AM EET Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Provide menu_music_enable_callback() for the benefit of clients that provide ways to change options in pregame. With that callback menu music gets started/stopped as the setting is applied and not only when next time entering the menu system (probably next time freeciv is launched) ___ File Attachments: --- Date: Wed 19 Feb 2014 05:24:22 AM EET Name: MenuMusicEnableCallback.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=20111 ___ Reply to this item at: http://gna.org/patch/?4518 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4487] [Metaticket] Music switching system
Update of patch #4487 (project freeciv): Depends on: = patch #4519 ___ Reply to this item at: http://gna.org/patch/?4487 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21692] Flag display mangled + assertion failures
URL: http://gna.org/bugs/?21692 Summary: Flag display mangled + assertion failures Project: Freeciv Submitted by: jtn Submitted on: Wed 19 Feb 2014 00:32:47 UTC Category: client-gtk-3.0 Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_4 r24515, trunk Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Certain nation flags are displayed incorrectly in the Gtk3 client's GUI widgets (e.g. pick nation dialog, F3 Nations report), although they are displayed fine on the main map. Symptoms seem to be that flags are cropped to only include a central symbol, sometimes losing all identity (e.g. Italian tricolor). Attached examples with S2_4 r24515 demonstrate the issue: * Arab flag cropped to central symbol * German flag absent? (Row height less than other rows * Inca flag shortened vertically * Indian flag lost top stripe * Italian flag has become just central white stripe (only visible with cursor) * Outlines generally absent compared to Gtk2 client Also I get a long mixture of the following two assertion failures on the console when opening Pick Nation (the first is much more common): 1: in get_flag() [plrdlg.c::599]: assertion 'x0 != -1' failed. 1: in get_flag() [plrdlg.c::608]: assertion 'w = 5 h = 5' failed. Not sure how I would have failed to notice this while working on nation sets, so maybe it's a recent regression (in Freeciv or Gtk, although I'm still using the same distro version I was before). This may be somehow related to bug #21373. ___ File Attachments: --- Date: Wed 19 Feb 2014 00:32:47 UTC Name: cropped-arab.png Size: 13kB By: jtn screen grabs from S2_4 r24515 Gtk3 client http://gna.org/bugs/download.php?file_id=20109 --- Date: Wed 19 Feb 2014 00:32:47 UTC Name: cropped-various.png Size: 29kB By: jtn screen grabs from S2_4 r24515 Gtk3 client http://gna.org/bugs/download.php?file_id=20110 ___ Reply to this item at: http://gna.org/bugs/?21692 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21625] Mapgenerator crash if no category Irrigation or Mine extra
Update of bug #21625 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #1: Patch attached: - Startpos evaluation considers Irrigation and Mine activity only if it will add an extra. 1) Terrain transformations are considered too much work in the beginning of the game for getting startpos improved. 2) Ruleset must have such an extra - tile_irrigate() and tile_mine() check against NULL target extra, especially as I think they can still legally end up there. (file #20114) ___ Additional Item Attachment: File name: StartposExtras.patch Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?21625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7668] Tracking release 2.5.0
Update of task #7668 (project freeciv): Depends on: = patch #3793 ___ Reply to this item at: http://gna.org/task/?7668 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21592] (civclient:29856): Gdk-WARNING **: XID collision, trouble ahead
Follow-up Comment #2, bug #21592 (project freeciv): See also bug #21677. ___ Reply to this item at: http://gna.org/bugs/?21592 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4519] Add support for endgame music
URL: http://gna.org/patch/?4519 Summary: Add support for endgame music Project: Freeciv Submitted by: cazfi Submitted on: Wed 19 Feb 2014 06:05:59 AM EET Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Play either music_victory or music_defeat when game ends. ___ File Attachments: --- Date: Wed 19 Feb 2014 06:05:59 AM EET Name: EndGameMusic.patch Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=20112 ___ Reply to this item at: http://gna.org/patch/?4519 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21683] Big map server freeze
URL: http://gna.org/bugs/?21683 Summary: Big map server freeze Project: Freeciv Submitted by: chrisk Submitted on: Di 18 Feb 2014 21:33:24 CET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.4.2+ Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Freeciv Version 2.4.2+ (modified r24482) seperately started 1 GTK2 client At some point, the server freezes. Logfiles, Backtrace, savegame attached. Core file is 2.6M Christian ___ File Attachments: --- Date: Di 18 Feb 2014 21:33:24 CET Name: bigger-T0063-Y-0925-auto.sav.bz2 Size: 49kB By: chrisk http://gna.org/bugs/download.php?file_id=20102 --- Date: Di 18 Feb 2014 21:33:24 CET Name: clientlog Size: 19kB By: chrisk http://gna.org/bugs/download.php?file_id=20103 --- Date: Di 18 Feb 2014 21:33:24 CET Name: serverlog Size: 26kB By: chrisk http://gna.org/bugs/download.php?file_id=20104 --- Date: Di 18 Feb 2014 21:33:24 CET Name: backtrace Size: 4kB By: chrisk http://gna.org/bugs/download.php?file_id=20105 ___ Reply to this item at: http://gna.org/bugs/?21683 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4517] Use fc_tristate in meta knowledge and remove mk_eval_result
Additional Item Attachment, patch #4517 (project freeciv): File name: there_can_only_be_one.patchSize:9 KB ___ Reply to this item at: http://gna.org/patch/?4517 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21626] science window slider
Follow-up Comment #1, bug #21626 (project freeciv): I'm not sure I know what you mean by the horizontal slider? Can you post a screenshot where you point it out? (I wondered if you meant the scrollbar, but the horizontal scrollbar doesn't have arrows for me in any theme I tried.) ___ Reply to this item at: http://gna.org/bugs/?21626 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21585] If no cities, settlers/workers on autosettler do nothing.
Update of bug #21585 (project freeciv): Summary: All settlers/workers on autosettler do nothing. = If no cities, settlers/workers on autosettler do nothing. ___ Reply to this item at: http://gna.org/bugs/?21585 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21683] Big map server freeze
Follow-up Comment #3, bug #21683 (project freeciv): Actually, the server froze with no logging at all, so I restarted with logging. It was compiled with enable-debug=yes though. I found the 25 iterations of sending packet type=PACKET_PLAYER_DIPLSTATE(59) len=8 to chris remarkably. Christian ___ Reply to this item at: http://gna.org/bugs/?21683 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21683] Big map server freeze
Follow-up Comment #2, bug #21683 (project freeciv): Backtrace looks to me like bug #21083. I suspect it won't happen without verbose logging (-d 3). ___ Reply to this item at: http://gna.org/bugs/?21683 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21656] Tile labels not handled in copy+paste
Follow-up Comment #1, bug #21656 (project freeciv): - S2_4 version (file #20115) ___ Additional Item Attachment: File name: CopyLabel-S2_4.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?21656 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4508] Alpha mod parameter to alphablit()
Update of patch #4508 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4508 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21677] Gtk and Gdk critical errors
Follow-up Comment #1, bug #21677 (project freeciv): Sounds rather like the old symptom from bug #21592. ___ Reply to this item at: http://gna.org/bugs/?21677 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21594] readline expansion (tab completion) in server console doesn't understand player name quoting rules
Update of bug #21594 (project freeciv): Summary: readline expansion in server console = readline expansion (tab completion) in server console doesn't understand player name quoting rules ___ Reply to this item at: http://gna.org/bugs/?21594 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21683] Big map server freeze
Follow-up Comment #1, bug #21683 (project freeciv): Here is the freeze quite similar, attached in a all-in-one file. Turns out the freeze is reproducible from savegame. Just press turn done. Christian (file #20106) ___ Additional Item Attachment: File name: bt2Size:11 KB ___ Reply to this item at: http://gna.org/bugs/?21683 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21693] server crash
URL: http://gna.org/bugs/?21693 Summary: server crash Project: Freeciv Submitted by: chrisk Submitted on: Mi 19 Feb 2014 12:46:05 CET Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.4.2+ Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Core was generated by `freeciv-server --debug 0 -f bigger-T0063-Y-0925-auto.sav.bz2'. Program terminated with signal 11, Segmentation fault. #0 get_total_defense_power (attacker=0xa3b64a8, defender=0x0) at combat.c:594 594 return defense_multiplication(unit_type(attacker), unit_type(defender), (gdb) bt #0 get_total_defense_power (attacker=0xa3b64a8, defender=0x0) at combat.c:594 #1 0x0818d621 in unit_win_chance (attacker=0xa3b64a8, defender=0x0) at combat.c:375 #2 0x080941be in compare_units (p1=0xb39c464, q1=0xb39c468) at unittools.c:2715 #3 0xb6ae13bb in ?? () from /lib/i686/cmov/libc.so.6 #4 0xb6ae134a in ?? () from /lib/i686/cmov/libc.so.6 #5 0xb6ae18d1 in qsort_r () from /lib/i686/cmov/libc.so.6 #6 0xb6ae19ce in qsort () from /lib/i686/cmov/libc.so.6 #7 0x08278804 in genlist_sort (pgenlist=0xb4376a8, compar=0x8094170 compare_units) at genlist.c:640 #8 0x08096a86 in unit_list_sort (punit=0xa36c620) at ../utility/speclist.h:471 #9 unit_survive_autoattack (punit=0xa36c620) at unittools.c:2773 #10 0x0809a466 in unit_move (punit=0xa36c620, pdesttile=0x9f02088, move_cost=1) at unittools.c:3285 #11 0x08125305 in unit_move_handling (punit=0xa36c620, pdesttile=0x9f02088, igzoc=value optimized out, move_diplomat_city=false) at unithand.c:1602 #12 0x080978e3 in execute_orders (punit=0xa36c620) at unittools.c:3567 #13 0x080989f8 in update_unit_activity (pplayer=0xa1f4208) at unittools.c:904 #14 update_unit_activities (pplayer=0xa1f4208) at unittools.c:571 #15 0x0807ea4b in begin_phase () at srv_main.c:905 #16 srv_running () at srv_main.c:2254 #17 0x0807f3d0 in srv_main () at srv_main.c:2770 #18 0x0807520f in main (argc=5, argv=0xbf876384) at civserver.c:453 ___ Reply to this item at: http://gna.org/bugs/?21693 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4520] Hard rule to prevent extra unambigiuous with terrain change
URL: http://gna.org/patch/?4520 Summary: Hard rule to prevent extra unambigiuous with terrain change Project: Freeciv Submitted by: cazfi Submitted on: Wed 19 Feb 2014 06:56:31 AM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Introduce it to the very lowest level of checking if extra can be built to an tile that EC_IRRIGATION extra cannot be added to an tile that will get transformed by Irrigation activity, nor EC_MINE extra to an tile that will transformed by Mining activity. This probably fixes other problems in AI and Advisor code, but the real effect is seen in startpos generation - Forest with Irrigation is no longer seen as the best possible startpos. ___ File Attachments: --- Date: Wed 19 Feb 2014 06:56:31 AM EET Name: NextExtraNotTransform.patch Size: 800B By: cazfi http://gna.org/patch/download.php?file_id=20113 ___ Reply to this item at: http://gna.org/patch/?4520 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21442] Client could report incomplete effect knowledge in city dialog
Update of bug #21442 (project freeciv): Status:None = In Progress Assigned to:None = jtn Planned Release: = 2.4.3,2.5.0,2.6.0 ___ Reply to this item at: http://gna.org/bugs/?21442 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4521] Pillaging help not ready for gen-roads or extras
URL: http://gna.org/patch/?4521 Summary: Pillaging help not ready for gen-roads or extras Project: Freeciv Submitted by: cazfi Submitted on: Wed 19 Feb 2014 07:18:10 AM EET Category: client Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: Help-Terrain-Terrain Alterations-Pillage lists pillage order for rulesets where pillage_select is not set (that is: information there is not even related to classic rulesets but specifically to custom rulesets). There's no guarantee that custom ruleset would introduce those road (S2_5) or extra (TRUNK) types, and in such a way that they get pillaged in the order listed there. ___ Reply to this item at: http://gna.org/patch/?4521 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21693] server crash
Follow-up Comment #1, bug #21693 (project freeciv): reproducible, savegame attached. press turn done platform: i386 compile options: ./autogen.sh --enable-debug=yes --enable-svnrev --enable-client=all --enable-fcmp=yes --with-readline --with-efence --with-ggz-client --with-ggzconfig=/usr/bin/ggz-config --enable-fcdb=all --enable-ipv6=yes --with-xawrd --enable-mapimg=magickwand run opts: --debug 0 $ freeciv-server -v Encodings: Data=UTF-8, Local=UTF-8, Internal=UTF-8 Freeciv Version 2.4.2+ (modified r24482) Christian (file #20117) ___ Additional Item Attachment: File name: bigger-T0074-Y-0650-test1.sav.bz2 Size:59 KB ___ Reply to this item at: http://gna.org/bugs/?21693 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21373] Switching between nationsets causes Cairo-related assertion failure for flags
Follow-up Comment #5, bug #21373 (project freeciv): Ran into bug #21692 when I came to look at this; maybe related? ___ Reply to this item at: http://gna.org/bugs/?21373 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21660] Middle click popup does not show mine or irrigation build activities
Update of bug #21660 (project freeciv): Status:None = In Progress Assigned to:None = cazfi ___ Follow-up Comment #2: Taking to myself as this is somewhat tied to bug #21625 changes I'm making. ___ Reply to this item at: http://gna.org/bugs/?21660 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21409] Notradesize disabled trade shown as corruption
Follow-up Comment #3, bug #21409 (project freeciv): So, how can we improve the UI? The client clearly has the information to distinguish city-size-based trade loss from 'real' corruption -- we can split it out from city_waste(). But what's the patter? The obvious gloss is that small cities just don't produce trade, but you can see it coming off the land, so we need some explanation for where it goes other than 'Corruption'. I suppose we could just baldly say Size penalty. btw what is the default value for server setting 'notradesize' ? 0. ___ Reply to this item at: http://gna.org/bugs/?21409 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21540] Client-spawned server always logs at verbose level (level 3) regardless of client log level
Update of bug #21540 (project freeciv): Summary: debug options do not work as expected = Client-spawned server always logs at verbose level (level 3) regardless of client log level ___ Reply to this item at: http://gna.org/bugs/?21540 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21083] verbose logging (-d 3) + log_error() = server hang due to recursive logging
Follow-up Comment #2, bug #21083 (project freeciv): See also bug #21683. Maybe the lock is being kept longer than necessary? Why the logfile would need to be locked when one is doing the network part? The lock is in log_real() around the call to log_write(). log_write() does two things: writes to the file, and calls log_callback, which in this case is con_handle_log(), which sends stuff to the network, causing recursive hilarity to ensue. It feels like some of the things in con_handle_log() don't want to be called by multiple threads simultaneously, though. ___ Reply to this item at: http://gna.org/bugs/?21083 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21507] Finer controll of ZoC
Update of bug #21507 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #28: Your patch is now in Freeciv trunk (2.6). Congratulations! ___ Reply to this item at: http://gna.org/bugs/?21507 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21694] Assertion failure on spy action vs city
URL: http://gna.org/bugs/?21694 Summary: Assertion failure on spy action vs city Project: Freeciv Submitted by: sveinung Submitted on: Wed 19 Feb 2014 04:25:37 PM UTC Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: sveinung Originator Email: Open/Closed: Open Release: 2.6.0 Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: caused by patch #4510 ___ File Attachments: --- Date: Wed 19 Feb 2014 04:25:37 PM UTC Name: not_null.patch Size: 1kB By: sveinung http://gna.org/bugs/download.php?file_id=20118 ___ Reply to this item at: http://gna.org/bugs/?21694 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21693] server crash
Follow-up Comment #2, bug #21693 (project freeciv): another backtrace, think this is the same bug get_total_defense_power todays svn w/o options two savegames Christian Spiel begonnen. Der Spieler 'Wang Guangmei' hat jetzt die KI-Spielstärke 'Mogeln'. Der Spieler 'Oscar II' hat jetzt die KI-Spielstärke 'Mogeln'. Der Spieler 'İsmail Enver' hat jetzt die KI-Spielstärke 'Mogeln'. Der Spieler 'Sukarno' hat jetzt die KI-Spielstärke 'Mogeln'. Der Spieler 'Henry Morgan' hat jetzt die KI-Spielstärke 'Mogeln'. Der Spieler 'Genseric' hat jetzt die KI-Spielstärke 'Mogeln'. 1: [freeciv-score.log:6] IDs don't match! game='FA8N21xrzZzWSIJfWJfZCOptv0Oxarvv' scorelog='OpVzBfh003llwWNopibNhf6eRoVA4ZUu' Spiel gespeichert als 'bigger-T0075-Y-0625-auto.sav.bz2' 1: in unit_survive_autoattack() [unittools.c::2784]: assertion '((void *)0) != punit_defender' failed. 1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/ 1: in unit_survive_autoattack() [unittools.c::2784]: assertion '((void *)0) != punit_defender' failed. 1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/ 1: in unit_survive_autoattack() [unittools.c::2784]: assertion '((void *)0) != punit_defender' failed. 1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/ 1: in unit_survive_autoattack() [unittools.c::2784]: assertion '((void *)0) != punit_defender' failed. 1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/ 1: in unit_survive_autoattack() [unittools.c::2784]: assertion '((void *)0) != punit_defender' failed. 1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/ 1: in unit_survive_autoattack() [unittools.c::2784]: assertion '((void *)0) != punit_defender' failed. 1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/ Spiel gespeichert als 'bigger-T0076-Y-0600-auto.sav.bz2' 1: in unit_survive_autoattack() [unittools.c::2784]: assertion '((void *)0) != punit_defender' failed. 1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/ 1: in unit_survive_autoattack() [unittools.c::2784]: assertion '((void *)0) != punit_defender' failed. 1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/ 1: in unit_survive_autoattack() [unittools.c::2784]: assertion '((void *)0) != punit_defender' failed. 1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/ 1: in unit_survive_autoattack() [unittools.c::2784]: assertion '((void *)0) != punit_defender' failed. 1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/ Spiel gespeichert als 'bigger-T0077-Y-0575-auto.sav.bz2' Speicherzugriffsfehler (Speicherabzug geschrieben) chris@leo:~/freeciv/play$ gdb freeciv-server -core core GNU gdb (GDB) 7.0.1-debian warning: Can't read pathname for load map: Eingabe-/Ausgabefehler. Core was generated by `freeciv-server -f bigger-T0074-Y-0650-manual.sav.bz2'. Program terminated with signal 11, Segmentation fault. #0 get_total_defense_power (attacker=0xab50a68, defender=0x0) at combat.c:594 594 return defense_multiplication(unit_type(attacker), unit_type(defender), (gdb) bt #0 get_total_defense_power (attacker=0xab50a68, defender=0x0) at combat.c:594 #1 0x08137751 in unit_win_chance (attacker=0xab50a68, defender=0x0) at combat.c:375 #2 0x08067fbe in compare_units (p1=0xae16650, q1=0xae16654) at unittools.c:2715 #3 0xb6e703bb in ?? () from /lib/i686/cmov/libc.so.6 #4 0xb6e708d1 in qsort_r () from /lib/i686/cmov/libc.so.6 #5 0xb6e709ce in qsort () from /lib/i686/cmov/libc.so.6 #6 0x081d58c4 in genlist_sort (pgenlist=0xadea730, compar=0x8067f70 compare_units) at genlist.c:640 #7 0x0806c326 in unit_list_sort (punit=0xadd1c88) at ../utility/speclist.h:471 #8 unit_survive_autoattack (punit=0xadd1c88) at unittools.c:2773 #9 0x0806cc33 in unit_move (punit=0xadd1c88, pdesttile=0xa9ec96c, move_cost=1) at unittools.c:3285 #10 0x080ddbcd in unit_move_handling (punit=0xadd1c88, pdesttile=0xa9ec96c, igzoc=value optimized out, move_diplomat_city=true) at unithand.c:1602 #11 0x080e0d65 in ai_unit_move (punit=0xadd1c88, ptile=0xa9ec96c) at aitools.c:982 #12 0x0807596c in adv_unit_execute_path (punit=0xadd1c88, path=0xbc03b70) at advgoto.c:102 #13 0x08075d09 in adv_follow_path (punit=0xadd1c88, path=0xbc03b70, ptile=0xa9ea738) at advgoto.c:59 #14 0x080e1729 in ai_unit_goto_constrained (punit=0xadd1c88, ptile=0xa9ea738, parameter=0xbf95edc8) at aitools.c:419 #15 0x080e1a47 in ai_unit_goto (punit=0xadd1c88, ptile=0xa9ea738) at aitools.c:690 #16 0x080e2759 in ai_gothere (pplayer=0xa865990, punit=0xadd1c88, dest_tile=0xa9ea738) at aitools.c:282 #17 0x0812164d in dai_auto_settler_run (pplayer=0xa865990, punit=0xadd1c88, state=0xbd0e520) at aisettler.c:1016 #18 0x08074618 in auto_settlers_player (pplayer=0xa865990) at autosettlers.c:715 #19 0x0804f564 in end_phase () at srv_main.c:1007 #20
[Freeciv-Dev] [patch #4200] Don't use meta knowledge in the client
Update of patch #4200 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: serversideMetaKnowledge2.patch Size:34 KB ___ Reply to this item at: http://gna.org/patch/?4200 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21626] science window slider
Follow-up Comment #2, bug #21626 (project freeciv): Yes, I meant the horizontal scrollbar, and yes, it has arrows in my standard gnome2 theme on squeeze. They are greyed out, but when you move the scrollbar a bit, you should see them. They have button effect then but don't move the window content. Christian ___ Reply to this item at: http://gna.org/bugs/?21626 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21693] server crash
Update of bug #21693 (project freeciv): Category:None = general Priority: 5 - Normal = 7 - High Release: 2.4.2+ = 2.4.2+,2.5.99 ___ Reply to this item at: http://gna.org/bugs/?21693 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21693] server crash
Follow-up Comment #3, bug #21693 (project freeciv): Both backtraces show unit_survive_autoattack() so I take it you have autoattack enabled, and that's relevant. ___ Reply to this item at: http://gna.org/bugs/?21693 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21668] Ferry stats not updated when unit changes type
Follow-up Comment #2, bug #21668 (project freeciv): While it's nice to have ferry stats correct and not nagging, they are primarily just an debugging tool. But usually the same bug that causes ferry stats to go off has some more serious consequences too. In the case I were debugging the bug turned out to be that former Caravel and potential cargo wasted many turns still heading towards rendezvous point after former had been upgraded to Ironclad. ___ Reply to this item at: http://gna.org/bugs/?21668 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21693] server crash
Follow-up Comment #4, bug #21693 (project freeciv): So. I can continue my game. Yes. Christian ___ Reply to this item at: http://gna.org/bugs/?21693 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21666] Freeciv web: Bundled vagrant script don't work
Follow-up Comment #4, bug #21666 (project freeciv): I have now tested building Freeciv-web with Vagrant on Linux (Ubuntu 13.10), and I've updated the documentation about how to set it up on github: https://github.com/freeciv/freeciv-web It would be great if you could give it a new test, so that we know it works on other systems as well. Thanks for the testing so far! ___ Reply to this item at: http://gna.org/bugs/?21666 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21683] Big map server freeze
Follow-up Comment #4, bug #21683 (project freeciv): Actually, the server froze with no logging at all, so I restarted with logging. I can only reproduce a hang from your savegame (file #20102) with logging enabled (and the backtrace is like yours). OK, I think bug #21083 is confusing things. Can you get us a backtrace or a reproduction case _without_ logging enabled? I found the 25 iterations of sending packet type=PACKET_PLAYER_DIPLSTATE(59) len=8 to chris remarkably. I think that's normal. Each PACKET_PLAYER_DIPLSTATE describes the relationship between two players. You have 5 players so there's (about) 25 relationships. ___ Reply to this item at: http://gna.org/bugs/?21683 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21641] When gold_upkeep_style = 2, building upkeep not taken into account for taxes
Follow-up Comment #3, bug #21641 (project freeciv): Oh, yes, it is exactly the same bug, I didn't see it. I understand what you say, and I think mostly the same: if the only difference comes when the player runs out of money, then gold upkeep styles are not really needed. However, for some reason, they affect the AI behavior, and that is the reason why I use them in my rulesets. I have not read the AI code much, but from my experience, the AI seems to take into acount the expenses of a city when it comes time to decide to build another improvement, and the AI seems balanced when the only expense of the cities is the gold upkeep of buildings. However, when we introduce units with gold upkeep in a ruleset (and default gold_upkeep_style = 0), then the expenses of the cities are increased by these units, and the AI seems to build less improvements in the cities, but nothing stops them from creating more units (that I know), and at the end the AI is not very challenging (too much units that they can not support due to lack of developed cities). When I use gold_upkeep_style = 1, the amount of units do not seem to affect the construction of buildings in AI cities, and the result are AI cities more similar to rulesets where there are no units with gold upkeep. Then, there was this gold_upkeep_style = 2, where AI seems to build improvements as if there were no tomorrow. It is a bug, but in some rulesets where buildings are really important, the AI was much more challenging this way. My guess is that someone introduced those gold_upkeep_style as a workaround to avoid redesigning the AI behavior to take into account properly the units with gold upkeep, and it is a solution good enough to me. But again, I do not know the code, and I might be wrong. I'll try to test this patch #2863, I'm curious to verify if gold_upkeep_style = 2 still affect the AI behavior once fixed. ___ Reply to this item at: http://gna.org/bugs/?21641 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
URL: http://gna.org/bugs/?21696 Summary: [patch] build fix: libfreeciv-srv.la depends on lua libraries Project: Freeciv Submitted by: prlw1 Submitted on: Thu 20 Feb 2014 12:46:39 AM UTC Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.4.2 Discussion Lock: Any Operating System: None Planned Release: ___ Details: The problem still exists in trunk (revision 24142) from code inspection. Compiling with recent libtool: CCLD libfreeciv-srv.la CCLD freeciv-server ./.libs/libfreeciv-srv.so: undefined reference to `tolua_tousertype' ../common/.libs/libfreeciv.so: undefined reference to `luaopen_table' ... It is libfreeciv.so which depends on the lua libraries rather than freeciv_server. The following patch against 2.4.2 fixes things for me: --- server/Makefile.am.orig 2014-02-08 13:17:47.0 + +++ server/Makefile.am @@ -133,6 +133,7 @@ srvlibs = \ $(top_builddir)/server/scripting/libscripting_server.la libfreeciv_srv_la_LIBADD = \ + $(LUA_LIBS) $(TOLUA_LIBS) $(LUASQL_LIBS) \ $(srvlibs) freeciv_server_LDFLAGS = $(GGZDMOD_LDFLAGS) @@ -140,7 +141,6 @@ freeciv_server_LDFLAGS = $(GGZDMOD_LDFLA freeciv_server_LDADD = \ ./libfreeciv-srv.la \ $(top_builddir)/common/libfreeciv.la \ - $(LUA_LIBS) $(TOLUA_LIBS) $(LUASQL_LIBS) \ $(INTLLIBS) \ $(MAPIMG_WAND_LIBS) \ $(FCDB_MYSQL_LIBS) $(FCDB_POSTGRES_LIBS) $(FCDB_SQLITE3_LIBS) \ ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21693] server crash
Follow-up Comment #5, bug #21693 (project freeciv): Reproduced with S2_4 r24519 from file #20117 (haven't tried the others). Moving unit is Willy Brandt's Archers [l tgt=unit id=274/], into Dortmund. Server is considering autoattack from pirates in boat adjacent to city. In my case it's trying to work out which of Musketeers [l tgt=unit id=393/] and Barbarian Leader [l tgt=unit id=394/] is the better attacker. But neither can attack from boats so get_defender() returns NULL, which compare_units() isn't prepared for. Think this might have been caused by patch #4445 (post 2.4.2): when building the autoattack list, unit_survive_autoattack() treats return from can_unit_attack_unit_at_tile() as boolean, but it's now an enum. (In passing: I think the return from can_unit_attack_any_at_tile() is now different if passed the empty list?) ___ Reply to this item at: http://gna.org/bugs/?21693 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4512] IS_FREEZE_VERSION
Update of patch #4512 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4512 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Follow-up Comment #1, bug #21696 (project freeciv): Just to be sure: you use liblua built from freeciv tree (the default in 2.4), and not external library with --enable-sys-lua. That *might* make important difference to what is in $(LUA_LIBS), meaning that more involved patch will be needed. Also, could you attach your patches as files, and not inline in the message body in the future (especially given how gna reformats messages so that some pointer magic may turn out as bold text instead) ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21657] tile_set_label() claims different labels identical
Update of bug #21657 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21657 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7669] S2_5 datafile format freeze
Follow-up Comment #4, task #7669 (project freeciv): New version of the patch - Set IS_FREEZE_VERSION (introduced by patch #4512) (file #20124) ___ Additional Item Attachment: File name: 2.5DatafileFormatFreeze-4.patch.bz2 Size:5 KB ___ Reply to this item at: http://gna.org/task/?7669 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4522] Correct modpack URL for FREEZE versions
URL: http://gna.org/patch/?4522 Summary: Correct modpack URL for FREEZE versions Project: Freeciv Submitted by: cazfi Submitted on: Thu 20 Feb 2014 06:05:45 AM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: Get the FREEZE version modpacks from the stable (frozen format) URL. ___ File Attachments: --- Date: Thu 20 Feb 2014 06:05:45 AM EET Name: FreezeModpackURL.patch Size: 528B By: cazfi http://gna.org/patch/download.php?file_id=20125 ___ Reply to this item at: http://gna.org/patch/?4522 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21698] Wrong client settings file used with development versions
URL: http://gna.org/bugs/?21698 Summary: Wrong client settings file used with development versions Project: Freeciv Submitted by: cazfi Submitted on: Thu 20 Feb 2014 06:11:24 AM EET Category: client Severity: 3 - Normal Priority: 9 - Immediate Status: Ready For Test Assigned to: cazfi Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0, 2.6.0 ___ Details: patch #4512 changes to checking macro values was all wrong (checking if macros are defined at all when they are always defined and should be checking the value instead) I will commit attached fix immediately on the basis that current version risks overwriting people's stable version settings files with development cruft. ___ File Attachments: --- Date: Thu 20 Feb 2014 06:11:24 AM EET Name: PreprocessorSyntax.patch Size: 580B By: cazfi http://gna.org/bugs/download.php?file_id=20126 ___ Reply to this item at: http://gna.org/bugs/?21698 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21698] Wrong client settings file used with development versions
Update of bug #21698 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21698 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21532] Windows installation tries to run modpack installer by wrong name
Follow-up Comment #2, bug #21532 (project freeciv): - Correct start menu links to programs (file #20127) ___ Additional Item Attachment: File name: FcmpCmd-2.patchSize:4 KB ___ Reply to this item at: http://gna.org/bugs/?21532 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
