[Freeciv-Dev] [bug #18170] auth md5 sum broken on big-endian machines (e.g., sparc64)
Follow-up Comment #10, bug #18170 (project freeciv): On a sparc64: 2: AI*5 has been added as Easy level AI-controlled player. 9743a66f914cc249efca164485a19c5c 2278ce9519b2223ecb2e2a2237e6d006 2: Now accepting new client connections. The bool swap part is awfully ugly. ___ Reply to this item at: http://gna.org/bugs/?18170 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18468] 2.3.0 does not compile on OpenBSD 4.9
URL: http://gna.org/bugs/?18468 Summary: 2.3.0 does not compile on OpenBSD 4.9 Project: Freeciv Submitted by: akfaew Submitted on: Mon Aug 8 15:31:41 2011 Category: general Severity: 4 - Important Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.3.0 Discussion Lock: Any Operating System: *BSD Planned Release: ___ Details: configured with: ./autogen.sh --disable-nls --disable-client --enable-debug=yes built with: gmake gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../utility -I./aicore -I/usr/local/include -DLOCALEDIR=\/usr/local/share/locale\ -DBINDIR=\/usr/local/bin\ -DDEFAULT_DATA_PATH=\.:data:~/.freeciv/2.3:/usr/local/share/freeciv\ -DDEFAULT_SAVES_PATH=\\ -DDEFAULT_SCENARIO_PATH=\.:data/scenario:~/.freeciv/2.3/scenarios:~/.freeciv/scenarios:/usr/local/share/freeciv/scenario\ -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -Werror -g -O2 -MT dataio.lo -MD -MP -MF .deps/dataio.Tpo -c dataio.c -o dataio.o cc1: warnings being treated as errors In file included from dataio.c:33: /usr//include/arpa/inet.h:74: warning: 'struct in_addr' declared inside parameter list /usr//include/arpa/inet.h:74: warning: its scope is only this definition or declaration, which is probably not what you want /usr//include/arpa/inet.h:75: warning: 'struct in_addr' declared inside parameter list gmake[4]: *** [dataio.lo] Error 1 gmake[4]: Leaving directory `/home/longturn/src/freeciv-2.3.0/common' gmake[3]: *** [all-recursive] Error 1 gmake[3]: Leaving directory `/home/longturn/src/freeciv-2.3.0/common' gmake[2]: *** [all] Error 2 rm packets_generate gmake[2]: Leaving directory `/home/longturn/src/freeciv-2.3.0/common' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/home/longturn/src/freeciv-2.3.0' gmake: *** [all] Error 2 Fix attached. Supposing you commit the fix, how do I switch to the updated source tree? ___ File Attachments: --- Date: Mon Aug 8 15:31:41 2011 Name: freeciv-2.3.0-openbsd-gmake Size: 380B By: akfaew http://gna.org/bugs/download.php?file_id=13777 ___ Reply to this item at: http://gna.org/bugs/?18468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18468] 2.3.0 does not compile on OpenBSD 4.9
Follow-up Comment #1, bug #18468 (project freeciv): Another error, this one I don't know how to fix. Might be related to the fact I run on sparc64: cc1: warnings being treated as errors ldebug.c: In function 'luaG_errormsg': ldebug.c:620: warning: cast increases required alignment of target type gmake[4]: *** [ldebug.o] Error 1 gmake[4]: Leaving directory `/home/longturn/src/freeciv-2.3.0/dependencies/lua-5.1/src' gmake[3]: *** [all-recursive] Error 1 gmake[3]: Leaving directory `/home/longturn/src/freeciv-2.3.0/dependencies/lua-5.1' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory `/home/longturn/src/freeciv-2.3.0/dependencies' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/home/longturn/src/freeciv-2.3.0' gmake: *** [all] Error 2 ___ Reply to this item at: http://gna.org/bugs/?18468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1975] Home caught units
Follow-up Comment #2, patch #1975 (project freeciv): Modified according to comment (file #10389) ___ Additional Item Attachment: File name: homecaughtunits.diff Size:3 KB ___ Reply to this item at: http://gna.org/patch/?1975 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16738] City map view
URL: http://gna.org/bugs/?16738 Summary: City map view Project: Freeciv Submitted by: akfaew Submitted on: Tuesday 09/21/2010 at 10:13 Category: client-gtk-2.0 Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: *BSD Planned Release: ___ Details: The city map view is kind of strange. NetBSD 5.0.2, gtk2+-2.18.9 ___ File Attachments: --- Date: Tuesday 09/21/2010 at 10:13 Name: 2010-09-21-120425_1024x768_scrot.png Size: 232kB By: akfaew http://gna.org/bugs/download.php?file_id=10399 ___ Reply to this item at: http://gna.org/bugs/?16738 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16739] More info about the number of cities
URL: http://gna.org/bugs/?16739 Summary: More info about the number of cities Project: Freeciv Submitted by: akfaew Submitted on: Tuesday 09/21/2010 at 10:18 Category: client-gtk-2.0 Severity: 1 - Wish Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: I find the information about the number of cities quite important. When i build a nation i check how many cities i have in the happiness tab of a city. Then i check the documentation to see how many cities before i get another unhappy citizen under the government i'm on. After that i check how many settlers i have. Then i order the production of an adequate amount of additional settlers. Can this information be more accessible? Like, number of cities: %d, number of settlers: %d, you can build this amount of cities before another unhappy citizen: %d. ___ Reply to this item at: http://gna.org/bugs/?16739 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1967] Longer T0 turn
Additional Item Attachment, patch #1967 (project freeciv): File name: first_timeout.diff Size:2 KB ___ Reply to this item at: http://gna.org/patch/?1967 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1967] Longer T0 turn
Follow-up Comment #2, patch #1967 (project freeciv): i've modified it as suggested ___ Reply to this item at: http://gna.org/patch/?1967 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1965] Verbose levelup
Follow-up Comment #2, patch #1965 (project freeciv): removed GET_UNIT_VETERAN_NAME() since it's not used anywhere else. (file #10685) ___ Additional Item Attachment: File name: verbose_levelup.diff Size:0 KB ___ Reply to this item at: http://gna.org/patch/?1965 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1967] Longer T0 turn
Follow-up Comment #6, patch #1967 (project freeciv): Applied more of pepetos suggestions (file #10698) ___ Additional Item Attachment: File name: first_timeout.diff Size:2 KB ___ Reply to this item at: http://gna.org/patch/?1967 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2262] Increase GAME_MAX_CITYMINDIST
URL: http://gna.org/patch/?2262 Summary: Increase GAME_MAX_CITYMINDIST Project: Freeciv Submitted by: akfaew Submitted on: Tue 21 Dec 2010 08:09:43 PM GMT Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: City radius can now be 4 in any direction. The old GAME_MAX_CITYMINDIST (5) is not sufficient, change it to 9 (8 squares between cities). ___ File Attachments: --- Date: Tue 21 Dec 2010 08:09:43 PM GMT Name: game.h.game_max_citymindist.patch Size: 462B By: akfaew http://gna.org/patch/download.php?file_id=11641 ___ Reply to this item at: http://gna.org/patch/?2262 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17372] assertion failed with scenario maps in trunk
URL: http://gna.org/bugs/?17372 Summary: assertion failed with scenario maps in trunk Project: Freeciv Submitted by: akfaew Submitted on: Wed 22 Dec 2010 06:41:36 AM GMT Category: None Severity: 4 - Important Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: I tried to play a scenario map. After pressing start the server did something for a couple of seconds and crashed: in dbv_isset() [bitvector.c::120]: assertion 'pdbv-vec != (void *)0' failed. ___ Reply to this item at: http://gna.org/bugs/?17372 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17373] Assertion failed during single player game in trunk
URL: http://gna.org/bugs/?17373 Summary: Assertion failed during single player game in trunk Project: Freeciv Submitted by: akfaew Submitted on: Wed 22 Dec 2010 07:32:21 AM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: *BSD Planned Release: ___ Details: I have no idea what type of additional info to provide. This warning is in the gtk2 client. 1: in get_internal_string_length() [fciconv.c::377]: assertion '0xFEFF != text2[0] 0xFFFE!= text2[0]' failed. ___ Reply to this item at: http://gna.org/bugs/?17373 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17373] Assertion failed during single player game in trunk
Follow-up Comment #2, bug #17373 (project freeciv): Latest version, from 30 minutes before my first post. I was doing nothing, just started the game. Got lots of these errors actually. This is just a warning, not a fault, no dump. I guess i can give you shell access on this computer. It's a NetBSD 5.0.2. ___ Reply to this item at: http://gna.org/bugs/?17373 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17376] Assertion failed in normal single player game
URL: http://gna.org/bugs/?17376 Summary: Assertion failed in normal single player game Project: Freeciv Submitted by: akfaew Submitted on: Wed 22 Dec 2010 02:26:10 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: [15:16:19] in auto_arrange_workers() [cityturn.c::282]: assertion '(void *)0 != ((pcenter)-owner)' failed. [15:16:19] ( 65, 51) in Ekbatana[1] [15:16:19] Please report this message at http://gna.org/projects/freeciv/ [15:16:19] in auto_arrange_workers() [cityturn.c::349]: assertion '(void *)0 != ((pcenter)-owner)' failed. [15:16:19] ( 65, 51) in Ekbatana[1] [15:16:19] Please report this message at http://gna.org/projects/freeciv/ Am i the only one getting these assertion failures? This one is also just a warning, the client didn't crash. This is an experimental game where i only have one city. The city is size 4, about to grow next turn. Again, the version is the latest trunk from around 6:00-7:00 UTC today, Revision: 18792. ___ Reply to this item at: http://gna.org/bugs/?17376 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17377] Big city radius, citizens disappear
URL: http://gna.org/bugs/?17377 Summary: Big city radius, citizens disappear Project: Freeciv Submitted by: akfaew Submitted on: Wed 22 Dec 2010 02:29:45 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: From irc from today: 08:46:58 akfaew there is some strange bug when using radius 20, sometimes citizents disappear. i have to click on the city in the city overview for them to reappear 08:58:27 akfaew i think this happens when a city grows, but not always 08:58:41 akfaew the cma gets confused by this 08:58:49 akfaew (as in: gets disabled) 09:16:37 akfaew it may be related to cannot work with fog of war. when a citizen works but then fog appears I have not verified this for sure, but i think citizens disappear (cannot assign them to a tile, they are not elvis or anything) when they work a tile, which becomes covered by fog of war. Again, Revision: 18792, system NetBSD. ___ Reply to this item at: http://gna.org/bugs/?17377 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17378] Citizens can work even if tile ocuppied by hostile explorer
URL: http://gna.org/bugs/?17378 Summary: Citizens can work even if tile ocuppied by hostile explorer Project: Freeciv Submitted by: akfaew Submitted on: Wed 22 Dec 2010 03:23:14 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: ___ File Attachments: --- Date: Wed 22 Dec 2010 03:23:14 PM GMT Name: 2010-12-22-154006_1024x768_scrot.png Size: 498kB By: akfaew http://gna.org/bugs/download.php?file_id=11646 ___ Reply to this item at: http://gna.org/bugs/?17378 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17379] City icon not refreshed after it is lost
URL: http://gna.org/bugs/?17379 Summary: City icon not refreshed after it is lost Project: Freeciv Submitted by: akfaew Submitted on: Wed 22 Dec 2010 03:23:40 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: ___ File Attachments: --- Date: Wed 22 Dec 2010 03:23:40 PM GMT Name: 2010-12-22-162132_1024x768_scrot.png Size: 465kB By: akfaew http://gna.org/bugs/download.php?file_id=11647 ___ Reply to this item at: http://gna.org/bugs/?17379 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17380] Pathfinder bug when using enemy infrastructure is disabled
URL: http://gna.org/bugs/?17380 Summary: Pathfinder bug when using enemy infrastructure is disabled Project: Freeciv Submitted by: akfaew Submitted on: Wed 22 Dec 2010 03:38:58 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: The pathfinder doesn't seem to take into account the disabled roads when calculating the time it takes to get to some enemy city. Revision: 18792 ___ Reply to this item at: http://gna.org/bugs/?17380 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17373] Assertion failed during single player game in trunk
Follow-up Comment #4, bug #17373 (project freeciv): Only english ___ Reply to this item at: http://gna.org/bugs/?17373 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17379] City icon not refreshed after it is lost
Follow-up Comment #3, bug #17379 (project freeciv): After loading a savegame everything is back to normal. Before i closed the client, and i explored land worked by the city, i could see the amount of production from the tiles, as if it were my own city. Not sure if it was my old production, or the current owners production though. Sorry i can provide so little info. ___ Reply to this item at: http://gna.org/bugs/?17379 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17379] City icon not refreshed after it is lost
Follow-up Comment #5, bug #17379 (project freeciv): No, it was not ok in the following turns. It was ok only after the client restarted. ___ Reply to this item at: http://gna.org/bugs/?17379 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17386] Certain settings not saved when creating new game
URL: http://gna.org/bugs/?17386 Summary: Certain settings not saved when creating new game Project: Freeciv Submitted by: akfaew Submitted on: Thu 23 Dec 2010 10:13:09 AM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: The client does not save certain settings when creating a new game: [11:10:34] Saved settings to file /home/dude/.freeciv-client-rc-2.4 For example: landmass, map size, generator, placement, all map temperate, poles are separate. Other options are saved: huts, map topology index. From what i see options from other tabs are saved, at least the ones i'm interested in. ___ Reply to this item at: http://gna.org/bugs/?17386 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17379] City icon not refreshed after it is lost
Follow-up Comment #6, bug #17379 (project freeciv): I can look at this city as if it was still mine, but progress on buildings is not made. (file #11660) ___ Additional Item Attachment: File name: 2010-12-23-123358_1024x768_scrot.png Size:287 KB ___ Reply to this item at: http://gna.org/bugs/?17379 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17379] City icon not refreshed after it is lost
Follow-up Comment #7, bug #17379 (project freeciv): It is displayed in the cities tab, and i can get to it by clicking next in the city dialogue. This time i lost the city to a revolt by an enemy diplomat. ___ Reply to this item at: http://gna.org/bugs/?17379 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17391] maxplayers error when loading a savegame
URL: http://gna.org/bugs/?17391 Summary: maxplayers error when loading a savegame Project: Freeciv Submitted by: akfaew Submitted on: Fri 24 Dec 2010 01:57:51 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: I played with 4 AI enemies. I believe (not 100% sure if this was this game) that one of the AI was split due to his capital being conquered. After i loaded the game the next day i got: [14:55:15] Error restoring 'maxplayers': Number of players (5) is higher than requested value (4). Keeping old value. Now there are again 4 AI enemies. ___ Reply to this item at: http://gna.org/bugs/?17391 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17392] City size x, citizen count y for abc
URL: http://gna.org/bugs/?17392 Summary: City size x, citizen count y for abc Project: Freeciv Submitted by: akfaew Submitted on: Fri 24 Dec 2010 02:04:41 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Getting these types of messages when playing with cheating AI on a 20 radius ruleset setting: [15:02:43] City size 4, citizen count 6 for Cincinnati ___ Reply to this item at: http://gna.org/bugs/?17392 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17392] City size x, citizen count y for abc
Follow-up Comment #1, bug #17392 (project freeciv): Forgot to add, the cities belong to the cheating AI, not a human. ___ Reply to this item at: http://gna.org/bugs/?17392 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17415] assertion failed in auto_arrange_workers
URL: http://gna.org/bugs/?17415 Summary: assertion failed in auto_arrange_workers Project: Freeciv Submitted by: akfaew Submitted on: Thu 30 Dec 2010 01:18:57 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: [14:15:51] in auto_arrange_workers() [cityturn.c::282]: assertion '(void *)0 != ((pcenter)-owner)' failed. [14:15:51] ( 62,5) in Yagul[1] [14:15:51] Please report this message at http://gna.org/projects/freeciv/ [14:15:51] in auto_arrange_workers() [cityturn.c::349]: assertion '(void *)0 != ((pcenter)-owner)' failed. [14:15:51] ( 62,5) in Yagul[1] [14:15:51] Please report this message at http://gna.org/projects/freeciv/ Attack Yagul with the two phalanx and destroy it, save included ___ File Attachments: --- Date: Thu 30 Dec 2010 01:18:57 PM GMT Name: civgame-T0025-Y-2750-auto.sav.bz2 Size: 29kB By: akfaew http://gna.org/bugs/download.php?file_id=11680 ___ Reply to this item at: http://gna.org/bugs/?17415 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17415] assertion failed in auto_arrange_workers
Follow-up Comment #2, bug #17415 (project freeciv): Try with this data/default/game.ruleset (file #11681) ___ Additional Item Attachment: File name: game.ruleset Size:6 KB ___ Reply to this item at: http://gna.org/bugs/?17415 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17415] assertion failed in auto_arrange_workers
Follow-up Comment #3, bug #17415 (project freeciv): Also i run with: FREECIV_PATH set to ~/freeciv/data/ Version is trunk. ___ Reply to this item at: http://gna.org/bugs/?17415 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17391] maxplayers error when loading a savegame
Follow-up Comment #2, bug #17391 (project freeciv): My vote is for #2. When I play with AI, I only care about how many of them there are initially - to set the enemy vs me proportions. I don't care how many different enemies there are, just how big a force the enemy has. #1 could be chosen only if the CPU was a consideration, right? ___ Reply to this item at: http://gna.org/bugs/?17391 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17415] assertion failed in auto_arrange_workers
Follow-up Comment #7, bug #17415 (project freeciv): Perhaps if you play a couple more turns you will see bug #17392 as well. ___ Reply to this item at: http://gna.org/bugs/?17415 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17415] assertion failed in auto_arrange_workers
Follow-up Comment #8, bug #17415 (project freeciv): Tested, no more error. ___ Reply to this item at: http://gna.org/bugs/?17415 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17423] Server option - reveal map
URL: http://gna.org/bugs/?17423 Summary: Server option - reveal map Project: Freeciv Submitted by: akfaew Submitted on: Tue 04 Jan 2011 06:45:29 PM GMT Category: None Severity: 1 - Wish Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: It's foolish to play with a unexplored map in a multiplayer scenario game, since everybody has the map anyway. Could someone please implement a setting to start a game with the map revealed? ___ Reply to this item at: http://gna.org/bugs/?17423 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17489] Display the bribe/revolt cost of own units/cities.
URL: http://gna.org/bugs/?17489 Summary: Display the bribe/revolt cost of own units/cities. Project: Freeciv Submitted by: akfaew Submitted on: Fri 14 Jan 2011 05:31:46 PM GMT Category: client Severity: 1 - Wish Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: The bribe/revolt cost calculation subroutines should be moved to common/, and printed in the middle-mouse-button menu, when clicked on own units. Own units cost can be calculated precisely, and provides important strategic information. I've made such a patch for the client but it's incredibly ugly (copy-paste) and find it very useful. ___ Reply to this item at: http://gna.org/bugs/?17489 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2354] Print pretty team names
URL: http://gna.org/patch/?2354 Summary: Print pretty team names Project: Freeciv Submitted by: akfaew Submitted on: Sat 15 Jan 2011 04:56:38 PM GMT Category: client Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: A pretty team name function has been implemented, see https://gna.org/patch/?1972 . It should be substituted where appropriate in the code. But I have no idea what to do about the translation part. These should be fixed as well i guess: [17:53:pts/8][dude@hopek:~/freeciv:15] def 'team %s' team %s found in ./server/stdinhand.c: 2247: _(No such team %s. Please give a 2260: cmd_reply(CMD_TEAM, caller, C_OK, _(Player %s set to team %s.), team %s found in ./common/team.c: 430: return fc_snprintf(buf, buf_len, _(team %s), name); 470: log_debug(Adding player %d/%s to team %s., player_number(pplayer), 495: log_debug(Removing player %d/%s from team %s (%d), ___ File Attachments: --- Date: Sat 15 Jan 2011 04:56:38 PM GMT Name: pretty.cli.diff Size: 780B By: akfaew http://gna.org/patch/download.php?file_id=11902 ___ Reply to this item at: http://gna.org/patch/?2354 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2354] Print pretty team names
Follow-up Comment #2, patch #2354 (project freeciv): I attached a patch. Also see https://gna.org/patch/?1972 . Basically, if a team does not have an explicit name, print team 1 instead of team Team 1. ___ Reply to this item at: http://gna.org/patch/?2354 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [bug #17489] Display the bribe/revolt cost of own units/cities.
On Mon, Jan 17, 2011 at 09:46:12PM +0100, Matthias Pfafferodt wrote: Follow-up Comment #2, bug #17489 (project freeciv): updated patch: * add one extra line for the bribe cost Why not add this to client/text.c:popup_info_text()? -- Michal akfaew Mazurek http://akfaew.jasminek.net ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17649] Change behaviour of unavailable options' key shortcuts in the context menu
URL: http://gna.org/bugs/?17649 Summary: Change behaviour of unavailable options' key shortcuts in the context menu Project: Freeciv Submitted by: akfaew Submitted on: Fri 04 Feb 2011 08:07:32 PM GMT Category: client Severity: 1 - Wish Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: When I relocate an army I quickly run thru some units in the city dialogue by clicking on them and pressing 'h' to homecity. If a unit is already homecitied in this particular city the keypress does nothing, I have to click somewhere else to make it disappear, and cannot just click on the next unit, because the context menu covers it. This is really annoying and time wasting. If the context menu disappeared after pressing a key for an inactive option, would that be acceptable behavior? I would really like it this way, thou I see the reasons of why not to change it. ___ Reply to this item at: http://gna.org/bugs/?17649 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17782] Cannot build trunk on OpenBSD 4.8/sparc64
URL: http://gna.org/bugs/?17782 Summary: Cannot build trunk on OpenBSD 4.8/sparc64 Project: Freeciv Submitted by: akfaew Submitted on: Tue 22 Feb 2011 04:26:35 PM GMT Category: None Severity: 4 - Important Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: *BSD Planned Release: ___ Details: [17:20:ttype][akfaew@spock:~/longturn/freeciv:8]$ ./autogen.sh + checking for autoconf = 2.58 ... found 2.65, ok. + checking for autoheader = 2.58 ... found 2.65, ok. + checking for automake = 1.6 ... found 1.9.6, ok. + checking for aclocal = 1.6 ... found 1.9.6, ok. + checking for libtoolize = 1.4.3 ... found 1.5.26, ok. + checking for xgettext = 0.10.36 ... found 0.18.1, ok. + checking for msgfmt = 0.10.36 ... found 0.18.1, ok. + running /usr/local/bin/aclocal-1.9 ... + running /usr/local/bin/autoheader-2.65 ... autoheader-2.65: error: AC_CONFIG_HEADERS not found in configure.ac /usr/local/bin/autoheader-2.65 failed [17:21:ttype][akfaew@spock:~/longturn/freeciv:9]$ uname -a OpenBSD spock.jasminek.net 4.8 GENERIC#86 sparc64 [17:21:ttype][akfaew@spock:~/longturn/freeciv:10]$ svn info |grep Revisi Revision: 19389 I can provide a shell account if any dev is interested in fixing this. ___ Reply to this item at: http://gna.org/bugs/?17782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17794] autogen failed on FreeBSD
URL: http://gna.org/bugs/?17794 Summary: autogen failed on FreeBSD Project: Freeciv Submitted by: akfaew Submitted on: Fri 25 Feb 2011 11:12:51 AM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: *BSD Planned Release: ___ Details: autogen fails on FreeBSD 8.1: ... checking for ngettext in libc... no checking for bindtextdomain in -lintl... no checking if -liconv is needed to use gettext... checking for ngettext in -lintl... no checking for ngettext in -lc... no checking for ngettext in -lintl... (cached) no configure: error: I haven't found a working ngettext function in your system. Try --disable-nls. Read ABOUT-NLS. configure failed GNU gettext is installed: pkg_info | grep gettext gettext-0.18_1 GNU gettext package It works fine with --disable-nls. I have a suggestion, the string: Now type 'make' to compile freeciv. should be replaced. On systems other than GNU 'gmake' has to be run, as the makefiles are GNUmakefiles. ___ Reply to this item at: http://gna.org/bugs/?17794 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17795] autogen --prefix=xxx fails on FreeBSD
URL: http://gna.org/bugs/?17795 Summary: autogen --prefix=xxx fails on FreeBSD Project: Freeciv Submitted by: akfaew Submitted on: Fri 25 Feb 2011 11:31:20 AM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: *BSD Planned Release: ___ Details: ./autogen.sh --disable-nls --with-client=gtk2 --prefix=/home/dude/bin ... checking for iconv... no, consider installing GNU libiconv checking for libcharset... no checking for nl_langinfo and CODESET... yes configure: error: Iconv is missing. You can get libiconv from http://gnu.org/, or try using --with-libiconv-prefix. configure failed Everything is fine if I omit the --prefix option pkg_info | grep iconv libiconv-1.13.1_1 A character set conversion library uname -a FreeBSD hopek.jasminek.net 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:55:53 UTC 2010 r...@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 Repo is latest trunk. ___ Reply to this item at: http://gna.org/bugs/?17795 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17795] autogen --prefix=xxx fails on FreeBSD
Follow-up Comment #1, bug #17795 (project freeciv): The following command worked: ./autogen.sh --disable-nls --with-client=gtk2 --prefix=/home/dude/bin --with-libiconv-prefix=/usr/local ___ Reply to this item at: http://gna.org/bugs/?17795 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17796] Libtool.m4 contents not added to aclocal.m4?
Follow-up Comment #1, bug #17796 (project freeciv):
For some reason I cannot find the original post, so I'll just post here.
Right after a svn co:
...
U freeciv
Checked out revision 19424.
[11:13:ttypd][akfaew@spock:~/longturn:34]$ cd freeciv/
[11:13:ttypd][akfaew@spock:~/longturn/freeciv:35]$ ./autogen.sh
--disable-client --enable-server --enable-auth
+ checking for autoconf = 2.58 ... found 2.65, ok.
+ checking for autoheader = 2.58 ... found 2.65, ok.
+ checking for automake = 1.7 ... found 1.9.6, ok.
+ checking for aclocal = 1.7 ... found 1.9.6, ok.
+ checking for libtoolize = 1.4.3 ... found 1.5.26, ok.
+ checking for xgettext = 0.10.36 ... found 0.18.1, ok.
+ checking for msgfmt = 0.10.36 ... found 0.18.1, ok.
+ running /usr/local/bin/aclocal-1.9 ...
+ running /usr/local/bin/autoheader-2.65 ...
+ running /usr/local/bin/autoconf-2.65 ...
configure.ac:64: error: possibly undefined macro: AM_INIT_AUTOMAKE
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure.ac:127: error: possibly undefined macro: AM_CONDITIONAL
configure.ac:135: error: possibly undefined macro: AC_MSG_ERROR
configure.ac:385: error: possibly undefined macro: AC_DISABLE_SHARED
configure.ac:386: error: possibly undefined macro: AC_PROG_LIBTOOL
configure.ac:402: error: possibly undefined macro: AM_ICONV
configure.ac:403: error: possibly undefined macro: AM_LIBCHARSET
configure.ac:404: error: possibly undefined macro: AM_LANGINFO_CODESET
configure.ac:437: error: possibly undefined macro: AM_GLIB_GNU_GETTEXT
configure.ac:553: error: possibly undefined macro: AC_C99_VARIADIC_MACROS
configure.ac:554: error: possibly undefined macro: AC_C99_VARIABLE_ARRAYS
configure.ac:555: error: possibly undefined macro: AC_C99_INITIALIZERS
configure.ac:556: error: possibly undefined macro: AC_C99_STDINT_H
configure.ac:830: error: possibly undefined macro: AC_GGZ_CHECK
configure.ac:950: error: possibly undefined macro: AC_FUNC_VSNPRINTF
/usr/local/bin/autoconf-2.65 failed
Then immediately after that:
[11:45:ttypd][akfaew@spock:~/longturn/freeciv:36]$ ./autogen.sh
--disable-client --enable-server --enable-auth
+ checking for autoconf = 2.58 ... found 2.65, ok.
+ checking for autoheader = 2.58 ... found 2.65, ok.
+ checking for automake = 1.7 ... found 1.9.6, ok.
+ checking for aclocal = 1.7 ... found 1.9.6, ok.
+ checking for libtoolize = 1.4.3 ... found 1.5.26, ok.
+ checking for xgettext = 0.10.36 ... found 0.18.1, ok.
+ checking for msgfmt = 0.10.36 ... found 0.18.1, ok.
+ running /usr/local/bin/aclocal-1.9 ...
+ running /usr/local/bin/autoheader-2.65 ...
+ running /usr/local/bin/autoconf-2.65 ...
+ running libtoolize ...
You should add the contents of `/usr/local/share/aclocal/libtool.m4' to
`aclocal.m4'.
Putting files in AC_CONFIG_AUX_DIR, `bootstrap'.
+ running /usr/local/bin/automake-1.9 ...
Use of uninitialized value $macro in string eq at /usr/local/bin/automake-1.9
line 4673, GEN0 line 1.
Use of uninitialized value $macro in exists at /usr/local/bin/automake-1.9
line 4675, GEN0 line 1.
Use of uninitialized value $macro in concatenation (.) or string at
/usr/local/bin/automake-1.9 line 4675, GEN0 line 1.
automake-1.9:
automake-1.9: ## Internal Error ##
automake-1.9:
automake-1.9: unrequested trace `'
automake-1.9: Please contact bug-autom...@gnu.org.
at /usr/local/share/automake-1.9/Automake/Channels.pm line 562
Automake::Channels::msg('automake', '', 'unrequested trace `'')
called at /usr/local/share/automake-1.9/Automake/ChannelDefs.pm line 191
Automake::ChannelDefs::prog_error('unrequested trace `'') called at
/usr/local/bin/automake-1.9 line 4675
Automake::scan_autoconf_traces('configure.ac') called at
/usr/local/bin/automake-1.9 line 4877
Automake::scan_autoconf_files() called at /usr/local/bin/automake-1.9
line 7493
/usr/local/bin/automake-1.9 failed
The second autogen fails for another reason but svn stat and svn diff show
nothing.
___
Reply to this item at:
http://gna.org/bugs/?17796
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17811] autogen warnings on Ubuntu
URL: http://gna.org/bugs/?17811 Summary: autogen warnings on Ubuntu Project: Freeciv Submitted by: akfaew Submitted on: Sun 27 Feb 2011 01:40:23 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Same warnings if autogen run without arguments. Linux odilon 2.6.35-25-generic-pae #44-Ubuntu SMP Fri Jan 21 19:01:46 UTC 2011 i686 GNU/Linux akfaew@odilon:~/freeciv$ ./autogen.sh --prefix=/usr/home/akfaew/bin + checking for autoconf = 2.58 ... found 2.67, ok. + checking for autoheader = 2.58 ... found 2.67, ok. + checking for automake = 1.7 ... found 1.11.1, ok. + checking for aclocal = 1.7 ... found 1.11.1, ok. + checking for libtoolize = 1.4.3 ... found 2.2.6b, ok. + checking for xgettext = 0.10.36 ... found 0.18.1, ok. + checking for msgfmt = 0.10.36 ... found 0.18.1, ok. + running aclocal ... configure.ac:5: warning: AC_INIT: not a literal: m4_esyscmd([./fc_version | tr -d '\n']) + running autoheader ... configure.ac:5: warning: AC_INIT: not a literal: m4_esyscmd([./fc_version | tr -d '\n']) + running autoconf ... configure.ac:5: warning: AC_INIT: not a literal: m4_esyscmd([./fc_version | tr -d '\n']) + running libtoolize ... ___ Reply to this item at: http://gna.org/bugs/?17811 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17823] ppm images
URL: http://gna.org/bugs/?17823 Summary: ppm images Project: Freeciv Submitted by: akfaew Submitted on: Wed 02 Mar 2011 04:05:01 AM GMT Category: None Severity: 1 - Wish Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: The ppm images show where a city or a unit is. Could this be changed to also show borders? Otherwise it's hard to see anything: http://longturn.org/crap/lt24.gif ___ Reply to this item at: http://gna.org/bugs/?17823 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17883] make/gmake - non linux systems
URL: http://gna.org/bugs/?17883 Summary: make/gmake - non linux systems Project: Freeciv Submitted by: akfaew Submitted on: Sat 12 Mar 2011 08:48:19 AM GMT Category: None Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Autogen prints: Now type 'make' to compile freeciv. On non-linux systems you actually have to type 'gmake', since the Makefiles are in GNU make format, not POSIX make. I propose the message be changed to: Now type 'make' (or 'gmake' on non-Linux systems) to compile freeciv. It actually does not compile with any of the BSD makes I've tried (but they all provide GNU make as a package). ___ Reply to this item at: http://gna.org/bugs/?17883 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17909] autogen warnings on FreeBSD
URL: http://gna.org/bugs/?17909 Summary: autogen warnings on FreeBSD Project: Freeciv Submitted by: akfaew Submitted on: Wed 16 Mar 2011 07:36:35 PM GMT Category: None Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: *BSD Planned Release: ___ Details: These are only warnings, the build succeeds. Logs attached. Version is trunk, Revision: 19513 ___ File Attachments: --- Date: Wed 16 Mar 2011 07:36:35 PM GMT Name: autogenlog Size: 14kB By: akfaew http://gna.org/bugs/download.php?file_id=12668 ___ Reply to this item at: http://gna.org/bugs/?17909 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18079] set timeout advances turn
URL: http://gna.org/bugs/?18079 Summary: set timeout advances turn Project: Freeciv Submitted by: akfaew Submitted on: Wed 27 Apr 2011 07:21:20 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Version is trunk After the game has started, setting /set timeout n immediately advances the turn. (n - some number) After the timeout has been set, setting it another time takes effect only after TC. ___ Reply to this item at: http://gna.org/bugs/?18079 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18081] warning: null format string
URL: http://gna.org/bugs/?18081 Summary: warning: null format string Project: Freeciv Submitted by: akfaew Submitted on: Thu 28 Apr 2011 08:43:15 AM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Compiling freeciv trunk on freebsd gives me millions of warning: null format string. That is because sometimes fc_assert is called with message == NULL, and since __attribute__ __printf__ does printf-like checks it complains. log.h: 111 void fc_assert_fail(const char *file, const char *function, int line, 112 const char *assertion, const char *message, ...) 113 fc__attribute((__format__ (__printf__, 5, 6))); ___ Reply to this item at: http://gna.org/bugs/?18081 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18082] Odd auth code
URL:
http://gna.org/bugs/?18082
Summary: Odd auth code
Project: Freeciv
Submitted by: akfaew
Submitted on: Thu 28 Apr 2011 01:24:16 PM GMT
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release:
___
Details:
I've noticed some strange code in trunk:
sernet.c:
619 if (srvarg.auth_enabled
620!pconn-server.is_closing
621pconn-server.status != AS_ESTABLISHED) {
622 auth_process_status(pconn);
623 }
only place where auth_process_status is called is from sernet.c
auth.c:
216 void auth_process_status(struct connection *pconn)
217 {
218 switch(pconn-server.status) {
...
255 break;
256 case AS_ESTABLISHED:
257 /* this better fail bigtime */
258 fc_assert(pconn-server.status != AS_ESTABLISHED);
259 break;
260 }
261 }
I might be tired, but I read this as:
if pconn-server.status != AS_ESTABLISHED run auth_process_status(pconn), and
inside that if pconn-server.status == AS_ESTABLISHED then fail if
pconn-server.status == AS_ESTABLISHED, which is rather confusing.
I'm not sure whether I am supposed to report this, but something does not
seem right to me.
___
Reply to this item at:
http://gna.org/bugs/?18082
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18086] comparison is always false due to limited range of data type
URL:
http://gna.org/bugs/?18086
Summary: comparison is always false due to limited range of
data type
Project: Freeciv
Submitted by: akfaew
Submitted on: Sat 30 Apr 2011 08:30:27 AM GMT
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release:
___
Details:
typedef.*citizens found in ../common/fc_types.h:
107: typedef unsigned char citizens;
cityturn.c:696: warning: comparison is always false due to limited range of
data type
cityturn.c:699: warning: comparison is always false due to limited range of
data type
cityturn.c:829: warning: comparison is always true due to limited range of
data type
cityturn.c:829: warning: comparison is always true due to limited range of
data type
Indeed:
692 void city_repair_size(struct city *pcity, citizens change)
693 {
694 if (change 0) {
695 pcity-specialists[DEFAULT_SPECIALIST] += change;
696 } else if (change 0) {
___
Reply to this item at:
http://gna.org/bugs/?18086
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18081] warning: null format string
Follow-up Comment #2, bug #18081 (project freeciv): How many such calls? Hundereds. Maybe the __printf__ assertion can be moved to a lower level and the fc_assert defines should include a test: fmt == NULL ? : fmt or something instead. ___ Reply to this item at: http://gna.org/bugs/?18081 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18086] comparison is always false due to limited range of data type
Follow-up Comment #2, bug #18086 (project freeciv): Standard compile with --disable-nls. I don't use debug since warnings are treated as errors and I get hundereds of warnings from those NULLS in printfs. [12:11:pts/10][dude@hopek:~:74] gcc --version gcc (GCC) 4.2.1 20070719 [FreeBSD] Copyright (C) 2007 Free Software Foundation, Inc. [12:11:pts/10][dude@hopek:~:75] uname -a FreeBSD hopek.jasminek.net 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:55:53 UTC 2010 r...@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 ___ Reply to this item at: http://gna.org/bugs/?18086 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18081] warning: null format string
Follow-up Comment #3, bug #18081 (project freeciv):
This is just terrible, if I change NULL to I get:
warning: zero-length printf format string
I propose, in fc_assert_fail and similar change
if (NULL != message) {
into
if (NOMSG != message) {
where NOMSG is some define, like (void*)0x1.
After that all calls with NULL will be change to NOMSG or EMPTYSTR or
whatever.
___
Reply to this item at:
http://gna.org/bugs/?18081
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18081] warning: null format string
Follow-up Comment #4, bug #18081 (project freeciv): Check out attached patch (file #12929) ___ Additional Item Attachment: File name: noprintfassertfail.diffSize:1 KB ___ Reply to this item at: http://gna.org/bugs/?18081 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18086] comparison is always false due to limited range of data type
Follow-up Comment #5, bug #18086 (project freeciv):
Also here:
vision_site_size_set found in ./common/vision.c:
134: void vision_site_size_set(struct vision_site *psite, citizens size)
135: {
136: fc_assert_ret(psite != NULL);
137: fc_assert_ret(size = MAX_CITY_SIZE);
138:
139: psite-size = size;
140: }
___
Reply to this item at:
http://gna.org/bugs/?18086
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18081] warning: null format string
Follow-up Comment #5, bug #18081 (project freeciv): Missed one call (file #12930) ___ Additional Item Attachment: File name: sanitycheck.c Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?18081 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles
Follow-up Comment #1, bug #18087 (project freeciv): Oh there is so much stack abuse in freeciv. Is it OK if I post patch to each file as a separate diff and message? (file #12933) ___ Additional Item Attachment: File name: startpos.c.diffSize:0 KB ___ Reply to this item at: http://gna.org/bugs/?18087 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles
Follow-up Comment #2, bug #18087 (project freeciv): The problem with my previous patch is that it will take up that space forever, which is also wrong. I think this needs to be done with malloc and free. I won't continue with this today and will wait for some feedback. Disregard startpos.c.diff please. [MAP_INDEX_SIZE] found in ./server/score.c: 162: bv_player claims[MAP_INDEX_SIZE]; [MAP_INDEX_SIZE] found in ./server/savegame2.c: 2763: int known[lines][MAP_INDEX_SIZE], j, p, l; 2815: int known[lines][MAP_INDEX_SIZE], j, l, p; [MAP_INDEX_SIZE] found in ./server/savegame.c: 1296: int known[MAP_INDEX_SIZE]; 1536: int known[MAP_INDEX_SIZE]; [MAP_INDEX_SIZE] found in ./server/generator/startpos.c: 206: int tile_value_aux[MAP_INDEX_SIZE]; 207: int tile_value[MAP_INDEX_SIZE]; [MAP_INDEX_SIZE] found in ./server/generator/utilities.c: 193: int alt_int_map[MAP_INDEX_SIZE]; [MAP_INDEX_SIZE] found in ./server/advisors/autosettlers.c: 622: struct settlermap state[MAP_INDEX_SIZE]; [MAP_INDEX_SIZE] found in ./common/map.c: 1081: int count = 0, positions[MAP_INDEX_SIZE]; ___ Reply to this item at: http://gna.org/bugs/?18087 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles
Follow-up Comment #3, bug #18087 (project freeciv): The attached patch manages to get me thru the segfaults. (It's a cat of small diffs, gna only allows max 4 uploads) Now there are problems with assertions: 1: in dbv_init() [bitvector.c::57]: assertion 'bits 0 bits 512 * 1024' failed. 1: Please report this message at http://gna.org/projects/freeciv/ /* Maximal size of a dynamic bitvector; for the map known bitvector it must be larger than the biggest possible map size (approx. MAP_MAX_SIZE * 1000) Use a large value to be on the save side (512kbits = 64kb). */ #define MAX_DBV_LENGTH 512 * 1024 So why isn't it defined to be MAP_MAX_SIZE * 1000? And is this define really necessary? These are the only occurrences: ./utility/bitvector.c:#define MAX_DBV_LENGTH 512 * 1024 ./utility/bitvector.c: than 0 and lower than the maximal size given by MAX_DBV_LENGTH. The ./utility/bitvector.c: fc_assert_ret(bits 0 bits MAX_DBV_LENGTH); ./utility/bitvector.c: fc_assert_ret(bits 0 bits MAX_DBV_LENGTH); I bumped it (and fixed a potential bug): -#define MAX_DBV_LENGTH 512 * 1024 +#define MAX_DBV_LENGTH (2048 * 1024) I call this win, because now my server is killed by the OS because of lack of memory :) The server allocated 400MB and client 200MB before being killed. (file #12935) ___ Additional Item Attachment: File name: diff Size:9 KB ___ Reply to this item at: http://gna.org/bugs/?18087 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18092] Fix some defines
URL: http://gna.org/bugs/?18092 Summary: Fix some defines Project: Freeciv Submitted by: akfaew Submitted on: Sat 30 Apr 2011 03:43:37 PM GMT Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: These defines have the potential for a bug or at least a misleading error message. ___ File Attachments: --- Date: Sat 30 Apr 2011 03:43:37 PM GMT Name: aiferry.c Size: 898B By: akfaew http://gna.org/bugs/download.php?file_id=12936 --- Date: Sat 30 Apr 2011 03:43:37 PM GMT Name: bitvector.c Size: 641B By: akfaew http://gna.org/bugs/download.php?file_id=12937 --- Date: Sat 30 Apr 2011 03:43:37 PM GMT Name: improvement.h Size: 677B By: akfaew http://gna.org/bugs/download.php?file_id=12938 --- Date: Sat 30 Apr 2011 03:43:37 PM GMT Name: stdinhand.c Size: 686B By: akfaew http://gna.org/bugs/download.php?file_id=12939 ___ Reply to this item at: http://gna.org/bugs/?18092 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles
Follow-up Comment #6, bug #18087 (project freeciv): +#define MAP_MAX_SIZE 4048 Why such a strange number? Shouldn't this be 4096? +#define MAX_DBV_LENGTH (4 * 1024 * 1024) Perhaps 4096 * 1000? ___ Reply to this item at: http://gna.org/bugs/?18087 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18111] Replace some unsafe strcpy/strcat with fc_strlcpy/fc_strlcat
URL: http://gna.org/bugs/?18111 Summary: Replace some unsafe strcpy/strcat with fc_strlcpy/fc_strlcat Project: Freeciv Submitted by: akfaew Submitted on: Sun 08 May 2011 11:07:29 AM GMT Category: None Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: I've replaced some unsafe functions. There still remain some uses of those functions in other parts of the source tree. ___ File Attachments: --- Date: Sun 08 May 2011 11:07:29 AM GMT Name: strcpy.diff Size: 22kB By: akfaew http://gna.org/bugs/download.php?file_id=12977 ___ Reply to this item at: http://gna.org/bugs/?18111 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2660] Add gamename setting
URL: http://gna.org/patch/?2660 Summary: Add gamename setting Project: Freeciv Submitted by: akfaew Submitted on: Tue 10 May 2011 08:59:08 PM GMT Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: The primary motivation for this setting is my IRC server, but if somebody runs multiple servers in one screen or tmux session a gamename prefix in all log messages might be nice. ___ File Attachments: --- Date: Tue 10 May 2011 08:59:08 PM GMT Name: gamename Size: 6kB By: akfaew http://gna.org/patch/download.php?file_id=12986 ___ Reply to this item at: http://gna.org/patch/?2660 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2661] IRC server for Freeciv (ingame chat transport)
URL: http://gna.org/patch/?2661 Summary: IRC server for Freeciv (ingame chat transport) Project: Freeciv Submitted by: akfaew Submitted on: Tue 10 May 2011 09:13:15 PM GMT Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: In Longturn, on more than one occasion somebody posted team plans to the public chat by mistake. Also quite often people post private messages to team chat. This is where the IRC server comes in. Also it makes communication easier, you do not have to be logged into the game to chat. Other than that various wrappers for instant messaging can be written. Basically the Freeciv server starts an IRC server with various channels: #all - chat, #team - team chat, #msg - the messages window, #cmd - stdout of the server and of course /query to other players. This code is not finished, especially the auth part. To run it put irc.c and irc.h to server/ and define WITH_IRC in fc_config.h. Let me know if you guys think this is worth adding to Freeciv. If not I'll just develop a patch for Longturn for my own purposes. ___ File Attachments: --- Date: Tue 10 May 2011 09:13:15 PM GMT Name: irc Size: 17kB By: akfaew http://gna.org/patch/download.php?file_id=12987 --- Date: Tue 10 May 2011 09:13:15 PM GMT Name: irc.c Size: 32kB By: akfaew http://gna.org/patch/download.php?file_id=12988 --- Date: Tue 10 May 2011 09:13:15 PM GMT Name: irc.h Size: 2kB By: akfaew http://gna.org/patch/download.php?file_id=12989 ___ Reply to this item at: http://gna.org/patch/?2661 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18170] md5 sum broken in trunk on sparc64
URL: http://gna.org/bugs/?18170 Summary: md5 sum broken in trunk on sparc64 Project: Freeciv Submitted by: akfaew Submitted on: Sun 29 May 2011 11:31:09 AM GMT Category: None Severity: 4 - Important Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: 1205 char checksum[DIGEST_HEX_BYTES + 1]; ... 1210 create_md5sum(dupa, 4, checksum); 1211 fprintf(stderr, %s\n, checksum); produces: 2278ce9519b2223ecb2e2a2237e6d006 [12:48:ttypf][akfaew@spock:~/longturn/freeciv:4]$ echo -n dupa | md5 9743a66f914cc249efca164485a19c5c ___ Reply to this item at: http://gna.org/bugs/?18170 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
