[Freeciv-Dev] [patch #6329] pf_normal_map_iterate() optimization

2016-02-09 Thread pepeto 
Follow-up Comment #2, patch #6329 (project freeciv):

This is due to patch #5201. Using right values for AI calculations is slow...
I never could find a better solution for reversed (a real one). If someone
does, I would be interested to know how it works!


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22960] Lots of runtime floating point warnings about CONN_PING_INFO

2015-12-14 Thread pepeto 
Follow-up Comment #13, bug #22960 (project freeciv):

I don't think it's a good idea to allow a limit of the approximation. Of
course, it doesn't make problem for the ping info that is just displayed to
the client. But considering more critical values that the client should
exactly knows, the error message will just disappear, but bugs would be still
present.

For stable 2.5 branch, the fix looks acceptable however.

___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24037] Client crash when attaching to another player

2015-11-06 Thread pepeto 
URL:
  <http://gna.org/bugs/?24037>

 Summary: Client crash when attaching to another player
 Project: Freeciv
Submitted by: pepeto
Submitted on: ven. 06 nov. 2015 20:29:34 CET
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1+
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Typing "/observe ", then "\observe", my client crashes with the
following backtrace:

Program received signal SIGSEGV, Segmentation fault.
0x762a49cc in g_type_check_is_value_type ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
(gdb) bt full
#0  0x762a49cc in g_type_check_is_value_type ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#1  0x762a7131 in g_value_type_compatible ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#2  0x76286b38 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#3  0x76d0c6c7 in gtk_list_store_set_valist_internal (
list_store=list_store@entry=0x1136c30, iter=iter@entry=0x7fffd960, 
emit_signal=emit_signal@entry=0x7fffd848, 
maybe_need_sort=maybe_need_sort@entry=0x7fffd84c, 
var_args=var_args@entry=0x7fffd878)
at /build/gtk+2.0-3ongxb/gtk+2.0-2.24.23/gtk/gtkliststore.c:802
_val = 0x7fffd7a0
_flags = 0
_collect_format = 
_cvalues = {{v_int = 11437536, v_long = 11437536, v_int64 = 11437536,

v_double = 5,6508936106725076e-317, v_pointer = 0xae85e0}, {
v_int = 0, v_long = 0, v_int64 = 0, v_double = 0, 
v_pointer = 0x0}, {v_int = 0, v_long = 0, v_int64 = 0, 
v_double = 0, v_pointer = 0x0}, {v_int = 0, v_long = 0, 
v_int64 = 0, v_double = 0, v_pointer = 0x0}, {v_int = 0, 
v_long = 0, v_int64 = 0, v_double = 0, v_pointer = 0x0}, {
v_int = 0, v_long = 0, v_int64 = 0, v_double = 0, 
v_pointer = 0x0}, {v_int = 0, v_long = 0, v_int64 = 0, 
v_double = 0, v_pointer = 0x0}, {v_int = 0, v_long = 0, 
v_int64 = 0, v_double = 0, v_pointer = 0x0}}
_vtab = 
_n_values = 
_value = 0x7fffd7a0
_value_type = 12332592
_vtable = 
value = {g_type = 12332592, data = {{v_int = 0, v_uint = 0, 
  v_long = 0, v_ulong = 0, v_int64 = 0, v_uint64 = 0, v_float = 0,

  v_double = 0, v_pointer = 0x0}, {v_int = 0, v_uint = 0, 
  v_long = 0, v_ulong = 0, v_int64 = 0, v_uint64 = 0, v_float = 0,

  v_double = 0, v_pointer = 0x0}}}
error = 0x0
column = 
func = 
__FUNCTION__ = "gtk_list_store_set_valist_internal"
#4  0x76d0d1d0 in IA__gtk_list_store_set_valist (list_store=0x1136c30,

iter=0x7fffd960, var_args=var_args@entry=0x7fffd878)
at /build/gtk+2.0-3ongxb/gtk+2.0-2.24.23/gtk/gtkliststore.c:899
emit_signal = 0
maybe_need_sort = 1
__FUNCTION__ = "IA__gtk_list_store_set_valist"
#5  0x76d0d2b7 in IA__gtk_list_store_set (
list_store=list_store@entry=0x1136c30, iter=iter@entry=0x7fffd960)
at /build/gtk+2.0-3ongxb/gtk+2.0-2.24.23/gtk/gtkliststore.c:941
var_args = {{gp_offset = 32, fp_offset = 48, 
overflow_arg_area = 0x7fffd950, 
reg_save_area = 0x7fffd890}}
#6  0x004e69f7 in editbar_reload_tileset (eb=0x11336f0)
at editgui.c:874
special = S_IRRIGATION
iter = {stamp = 503779592, user_data = 0x17af4f0, user_data2 = 0x3, 
  user_data3 = 0x2}
store = 0x1136c30
pixbuf = 0xae85e0
tvs = 
sprite = 
#7  editgui_tileset_changed () at editgui.c:1886
No locals.
#8  0x004765ef in set_client_state (
newstate=newstate@entry=C_S_RUNNING) at client_main.c:869
oldstate = C_S_PREPARING
__FUNCTION__ = "set_client_state"
#9  0x004a1f53 in handle_start_phase (phase=0) at packhand.c:1179
__FUNCTION__ = "handle_start_phase"
#10 0x004a96ff in client_handle_packet (
type=type@entry=PACKET_START_PHASE, packet=)
at packhand_gen.c:252
No locals.
#11 0x0047500f in client_packet_input (packet=, 
type=126) at client_main.c:698
__FUNCTION__ = "client_packet_input"
#12 0x0047b8ec in input_from_server (fd=)
at clinet.c:422
packet = 0x2ea9260
type = PACKET_START_PHASE
nb = 
__FUNCTION__ = "input_from_server"
#13 0x0044c37

[Freeciv-Dev] [bug #24037] Client crash when attaching to another player

2015-11-06 Thread pepeto 
Follow-up Comment #2, bug #24037 (project freeciv):

Yes, it solved the problem. Thank you.

___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23700] Private messages addressed to username disappear in cache

2015-07-31 Thread pepeto 
Follow-up Comment #3, bug #23700 (project freeciv):

In my opinion, private messages cannot be saved in cache. There is no warranty
about a connection with same user name comes from the same user.


___

Reply to this item at:

  http://gna.org/bugs/?23700

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23580] Ping info network error

2015-06-14 Thread pepeto 
Follow-up Comment #1, bug #23580 (project freeciv):

This looks like similar to bug #22960.


___

Reply to this item at:

  http://gna.org/bugs/?23580

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6108] Assert that a connection from the all_connections list aren't NULL.

2015-06-14 Thread pepeto 
Follow-up Comment #1, patch #6108 (project freeciv):

Shouldn't fc_assert_ret_msg() used there?

___

Reply to this item at:

  http://gna.org/patch/?6108

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23324] Server option 'first_timeout' is broken

2015-05-11 Thread pepeto 
Update of bug #23324 (project freeciv):

 Assigned to:  pepeto = None   


___

Reply to this item at:

  http://gna.org/bugs/?23324

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23324] Server option 'first_timeout' is broken

2015-04-24 Thread pepeto 
Follow-up Comment #2, bug #23324 (project freeciv):

Actually, there are two problems. One problem is the one reported here, the
server doesn't handle first_timeout every where. The other problem is that the
client ignores first_timeout and display the normal timeout at turn T0, even
if first_timeout is set.


___

Reply to this item at:

  http://gna.org/bugs/?23324

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23444] Client doesn't show some cargo units of Carriers

2015-04-19 Thread pepeto 
Follow-up Comment #10, bug #23444 (project freeciv):

I suppose that the comment in client/packhand.c should be modified in S2_6 and
TRUNK too.

___

Reply to this item at:

  http://gna.org/bugs/?23444

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23444] Carriers

2015-04-17 Thread pepeto 
Follow-up Comment #7, bug #23444 (project freeciv):

 package_unit(punit, ...) should be package_unit(ptrans, ...)

Indeed.

 Probably this check should just be removed (and the
 client_has_player() one too?) Not tested this.

I think this check is correct for the S2_5 branch because the transport are
supposed to be known by the client before their cargo (it is linked with
former recursive unit info sending).

But, the behaviour is quite different in S2_6 branch and TRUNK (see patch
#5382 which removed notably these tests).

 (The comment about send_unit_info_to_onlookers() is now wrong.)

Indeed.


___

Reply to this item at:

  http://gna.org/bugs/?23444

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23478] radomly changing tech goals without cause

2015-04-14 Thread pepeto 
Follow-up Comment #1, bug #23478 (project freeciv):

Could you provide a savegame of the buggy game?


___

Reply to this item at:

  http://gna.org/bugs/?23478

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23324] Server option 'first_timeout' is broken

2015-03-09 Thread pepeto 
Update of bug #23324 (project freeciv):

Category:None = general
  Status:None = In Progress
 Assigned to:None = pepeto 
 Planned Release: = 2.4.5, 2.5.1, 2.6.0,
3.0.0


___

Reply to this item at:

  http://gna.org/bugs/?23324

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22863] Pillaged buoys still visible on fogged tiles

2015-03-04 Thread pepeto 
Update of bug #22863 (project freeciv):

  Status: In Progress = Ready For Test 
 Open/Closed:Open = Closed 

___

Follow-up Comment #8:

@Andreas: Please, if you re-open a bug item, add at least a comment. As far I
understand, you pointed out that the fix for this bug was causing bug #23286.
Then, the new bug will be handled there...


___

Reply to this item at:

  http://gna.org/bugs/?22863

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23286] Temporary terrain change during turn change

2015-03-04 Thread pepeto 
Follow-up Comment #7, bug #23286 (project freeciv):

Tested without and with the patch. It successfully fixed the bug.

___

Reply to this item at:

  http://gna.org/bugs/?23286

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23231] advance_by_number(A_FUTURE) returning NULL

2015-02-11 Thread pepeto 
Follow-up Comment #10, bug #23231 (project freeciv):

I think this patch is not correct for S2_6 and trunk. It would return a
pointer to incorrect memory.


___

Reply to this item at:

  http://gna.org/bugs/?23231

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info

2015-02-04 Thread pepeto 
Update of bug #23154 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23154

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info

2015-02-02 Thread pepeto 
Update of bug #23154 (project freeciv):

  Status:None = Confirmed  
 Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 = 2.4.5 


___

Follow-up Comment #8:

Reproduced but only in S2_4 branches. The error occurs when the Legion takes
over Shreshthapura, which is becoming outside of player vision.


___

Reply to this item at:

  http://gna.org/bugs/?23154

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info

2015-02-02 Thread pepeto 
Follow-up Comment #9, bug #23154 (project freeciv):

The circumstances looks like similar bug #20705.

___

Reply to this item at:

  http://gna.org/bugs/?23154

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info

2015-02-02 Thread pepeto 
Update of bug #23154 (project freeciv):

  Status:   Confirmed = Ready For Test 
 Assigned to:None = pepeto 

___

Follow-up Comment #10:

Backported patch for bug #20705 attached.


(file #23697)
___

Additional Item Attachment:

File name: S2_4_transfer_city_reveal_hide_units.patch Size:4 KB


___

Reply to this item at:

  http://gna.org/bugs/?23154

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23220] Crash on exit with research dialog open and future techs researched.

2015-01-29 Thread pepeto 
Update of bug #23220 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23220

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23222] Future Tech. %d not localized with format

2015-01-29 Thread pepeto 
Update of bug #23222 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23222

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23221] Future tech rule and translated names are messed up

2015-01-29 Thread pepeto 
Update of bug #23221 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23221

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22692] Show patrol return path

2015-01-28 Thread pepeto 
Update of bug #22692 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22692

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23222] Future Tech. %d not localized with format

2015-01-28 Thread pepeto 
Update of bug #23222 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = pepeto 
Operating System:None = Any

___

Follow-up Comment #1:

Fix attached, to apply over bug #23221 one.


(file #23661)
___

Additional Item Attachment:

File name: trunk_S2_6_research_future_name_translation.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?23222

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5681] Client goto turn number art

2015-01-28 Thread pepeto 
Follow-up Comment #1, patch #5681 (project freeciv):

About missing sprites:
There is a missing sprite for way points named path.waypoint.

After that, goto sprites are displayed in 3 modes. For each mode, it is
possible to define a specific global sprite or/and a set of sprites for each
turn number (allowing to change font shape, color etc.).
* the unit will stop at this tile at the end of a turn (global sprite is named
path.step and other sprites named path.step_0, path.step_1 [...],
path.step_00, path.step_10 etc.);
* the unit will stop at this tile at the end of the path, with no remaining
moves (global sprite is named path.exhausted_mp and other sprites named
path.exhausted_mp_0, path.exhausted_mp_1 [...], path.exhausted_mp_00,
path.exhausted_mp_10 etc.);
* the unit won't stop at this tile (global sprite is named path.normal and
other sprites named path.turns_0, path.turns_1 [...], path.turns_00,
path.turns_10 etc.).


___

Reply to this item at:

  http://gna.org/patch/?5681

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5233] Client goto turn number

2015-01-28 Thread pepeto 
Update of patch #5233 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5233

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23221] Future tech rule and translated names are messed up

2015-01-28 Thread pepeto 
Update of bug #23221 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = pepeto 

___

Follow-up Comment #3:

Fix ready, using strvec instead of custom string_vector. Note it will also
fix bug #23220.


(file #23658, file #23659, file #23660)
___

Additional Item Attachment:

File name: trunk_S2_6_research_future_name.patch Size:5 KB
File name: S2_5_tech_future_name.patchSize:5 KB
File name: S2_4_tech_future_name.patchSize:5 KB


___

Reply to this item at:

  http://gna.org/bugs/?23221

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23220] Crash on exit with research dialog open and future techs researched.

2015-01-28 Thread pepeto 
Follow-up Comment #3, bug #23220 (project freeciv):

Patch for bug #23221 would also fix this issue.


___

Reply to this item at:

  http://gna.org/bugs/?23220

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23220] Crash on exit with research dialog open and future techs researched.

2015-01-27 Thread pepeto 
Update of bug #23220 (project freeciv):

Category:  client = general
  Status:None = Ready For Test 
Operating System:None = Any
 Planned Release: = 2.4.5, 2.5.0, 2.6.0,
3.0.0

___

Follow-up Comment #1:

It affects server too. A '*' was missing in bug #23173. It was not very
intuitive...


(file #23652)
___

Additional Item Attachment:

File name: researches_free_fix.patch  Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?23220

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23221] Future tech rule and translated names are messed up

2015-01-27 Thread pepeto 
URL:
  http://gna.org/bugs/?23221

 Summary: Future tech rule and translated names are messed up
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 27 janv. 2015 21:45:29 CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0

___

Details:

They are put inside the same string vector.




___

Reply to this item at:

  http://gna.org/bugs/?23221

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23220] Crash on exit with research dialog open and future techs researched.

2015-01-27 Thread pepeto 
Follow-up Comment #2, bug #23220 (project freeciv):

Maybe a better approach would be to use a strvec?


___

Reply to this item at:

  http://gna.org/bugs/?23220

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23222] Future Tech. %d not localized with format

2015-01-27 Thread pepeto 
URL:
  http://gna.org/bugs/?23222

 Summary: Future Tech. %d not localized with format
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 27 janv. 2015 21:50:53 CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:

I think it should instead of putting a number behind Future Tech
translation. I probably did a mistake when migrating the function from
tech.c to research.c because S2_4 and S2_5 are not affected.





___

Reply to this item at:

  http://gna.org/bugs/?23222

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23221] Future tech rule and translated names are messed up

2015-01-27 Thread pepeto 
Follow-up Comment #2, bug #23221 (project freeciv):

 Future techs having rule name... does that mean that we
 actually support requirements like { Tech, Future Tech 34,
 Player } ?

No, there is no way to find a particular future tech by name. Rule names here
are only used for logging messages.


___

Reply to this item at:

  http://gna.org/bugs/?23221

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20758] Buoys getting vision twice

2015-01-26 Thread pepeto 
Update of bug #20758 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20758

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22863] Pillaged buoys still visible on fogged tiles

2015-01-26 Thread pepeto 
Update of bug #22863 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22863

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5233] Client goto turn number

2015-01-26 Thread pepeto 
Follow-up Comment #14, patch #5233 (project freeciv):

Version 5 attached: reworked tileset sprite handling. The tileset author can
choose to make sprites for every state and turn number (e.g. for having
different font, shape or color), or to define a global sprite for every state
(or both).


(file #23629)
___

Additional Item Attachment:

File name: client_goto_turn_number5.patch Size:19 KB


___

Reply to this item at:

  http://gna.org/patch/?5233

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5681] Client goto turn number art

2015-01-26 Thread pepeto 
Update of patch #5681 (project freeciv):

  Depends on: = patch #5233


___

Reply to this item at:

  http://gna.org/patch/?5681

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20758] Buoys getting vision twice

2015-01-24 Thread pepeto 
Update of bug #20758 (project freeciv):

  Status: In Progress = Ready For Test 
Operating System:None = Any
 Planned Release:   2.6.0 = 2.6.0, 3.0.0   

___

Follow-up Comment #5:

I have found the cause of the bug. It is clearly not the same as originally
reported (probably invalid, see comment #1). It was due to a typo in patch
#3873. Fix attached.


(file #23599)
___

Additional Item Attachment:

File name: create_base_old_claim.patchSize:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?20758

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22863] Pillaged buoys still visible on fogged tiles

2015-01-24 Thread pepeto 
Update of bug #22863 (project freeciv):

  Status: In Progress = Ready For Test 
Operating System:None = Any
 Planned Release: = 2.6.0, 3.0.0   

___

Follow-up Comment #1:

Fix attached for TRUNK and S2_6. It looks very more complicate to implement
this for S2_4 and S2_5, so probably it could be considered as a new feature in
2.6.0.


(file #23602)
___

Additional Item Attachment:

File name: trunk_S2_6_destroy_extra_pillage.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?22863

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22863] Pillaged buoys still visible on fogged tiles

2015-01-24 Thread pepeto 
Update of bug #22863 (project freeciv):

 Planned Release:2.6.0, 3.0.0 = 2.4.5, 2.5.0, 2.6.0,
3.0.0

___

Follow-up Comment #3:

Fixes for all branches attached: make a decomposed update_tile_knowledge()
inside destroy_[extra|base]().

Note that it also fixes another bug in TRUNK and S2_6 when removing a base
with both _border_sq_ and _vision_sq_ effects (the vision wasn't removed).

 As you added tile_remove_extra() call to earlier phase, I
 assume you meant to remove it from the latter phase, but you
 remove only the empty line before it.
Actually, the accident was to remove the empty line (copied from S2_4 and
S2_5). I had kept tile_remove_extra() at the last to avoid multiple else
cases. But it doesn't longer apply.


___

Reply to this item at:

  http://gna.org/bugs/?22863

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5233] Client goto turn number

2015-01-24 Thread pepeto 
Update of patch #5233 (project freeciv):

  Status: In Progress = Ready For Test 
 Planned Release:   3.0.0 = 2.6.0, 3.0.0   

___

Follow-up Comment #13:

This one should do all what we want to show. Of course, sprites for waypoints,
turn step and exhausted move points are still missing.


(file #23605)
___

Additional Item Attachment:

File name: client_goto_turn_number4.patch Size:15 KB


___

Reply to this item at:

  http://gna.org/patch/?5233

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22692] Show patrol return path

2015-01-24 Thread pepeto 
Update of bug #22692 (project freeciv):

  Status: In Progress = Ready For Test 
 Planned Release:   3.0.0 = 2.6.0, 3.0.0   

___

Follow-up Comment #3:

Updated version including changes in the unit info label.


(file #23606)
___

Additional Item Attachment:

File name: client_patrol_show_return_path3.patch Size:19 KB


___

Reply to this item at:

  http://gna.org/bugs/?22692

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22863] Pillaged buoys still visible on fogged tiles

2015-01-24 Thread pepeto 
Additional Item Attachment, bug #22863 (project freeciv):

File name: trunk_S2_6_destroy_extra_notify.patch Size:2 KB
File name: S2_5_S2_4_destroy_base_notify.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?22863

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5233] Client goto turn number

2015-01-21 Thread pepeto 
Follow-up Comment #12, patch #5233 (project freeciv):

You might notice I have no more time free to coding Freeciv nowadays. I have
kept 4 tickets that I have started to work on. However, you may steal them.


___

Reply to this item at:

  http://gna.org/patch/?5233

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18658] Help: mbook's small wonders are treated as buildings

2015-01-13 Thread pepeto 
Update of bug #18658 (project freeciv):

 Assigned to:  pepeto = None   


___

Reply to this item at:

  http://gna.org/bugs/?18658

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18592] 1: Got a packet of type * from a dead player. (RC2 client, S2_3 server)

2015-01-13 Thread pepeto 
Update of bug #18592 (project freeciv):

 Assigned to:  pepeto = None   


___

Reply to this item at:

  http://gna.org/bugs/?18592

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3922] The Adaptisland generator

2015-01-13 Thread pepeto 
Update of patch #3922 (project freeciv):

 Assigned to:  pepeto = None   


___

Reply to this item at:

  http://gna.org/patch/?3922

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5695] Add missing semicolons at the end of fc_assert_XXX() calls

2015-01-13 Thread pepeto 
Update of patch #5695 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5695

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5700] Remove a couple of functionality made inside fc_assert_XXX() calls

2015-01-13 Thread pepeto 
Update of patch #5700 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5700

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5697] Force the usage of semicolon after fc_assert_XXX() calls

2015-01-13 Thread pepeto 
Update of patch #5697 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5697

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23175] Explorer seeing far terrain

2015-01-12 Thread pepeto 
Follow-up Comment #4, bug #23175 (project freeciv):

 Is taht near the wrapping point of the map?

Yes it is. Extra seen tiles are (83,26) and (0,23), topology is WARPX|ISO.


___

Reply to this item at:

  http://gna.org/bugs/?23175

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23030] Ghost nuclear unit left in enemy city after explosion

2015-01-12 Thread pepeto 
Update of bug #23030 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23030

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23167] Fix typo in vision_site_update_from_city() assertions

2015-01-12 Thread pepeto 
Update of bug #23167 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23167

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23177] segfault - stacktrace attached

2015-01-12 Thread pepeto 
Follow-up Comment #1, bug #23177 (project freeciv):

Thank you for reporting. Do you have any information about what was happening
just before the client crashed? Or maybe a savegame this would be
reproducible?


___

Reply to this item at:

  http://gna.org/bugs/?23177

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23058] Can't use Area Selection mode when national borders are disabled

2015-01-12 Thread pepeto 
Update of bug #23058 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23058

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23175] Explorer seeing far terrain

2015-01-11 Thread pepeto 
Follow-up Comment #2, bug #23175 (project freeciv):

I don't know what is the ruleset used for freeciv-web. But it is strange to
see so few tiles after the passage of the explorer.

 I suspect that this is a bug in the Freeciv server, though.

I have never observed such things and I don't see what could be the cause of
this in recent changes in trunk.


___

Reply to this item at:

  http://gna.org/bugs/?23175

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5696] Disable all fc_assert_XXX() effects when NDEBUG is defined

2015-01-10 Thread pepeto 
URL:
  http://gna.org/patch/?5696

 Summary: Disable all fc_assert_XXX() effects when NDEBUG is
defined
 Project: Freeciv
Submitted by: pepeto
Submitted on: sam. 10 janv. 2015 13:27:10 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:





___

File Attachments:


---
Date: sam. 10 janv. 2015 13:27:10 CET  Name:
disable_fc_assert_XXX_with_NDEBUG.patch  Size: 2 ko   By: pepeto

http://gna.org/patch/download.php?file_id=23458

___

Reply to this item at:

  http://gna.org/patch/?5696

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5695] Add missing semicolons at the end of fc_assert_XXX() calls

2015-01-10 Thread pepeto 
URL:
  http://gna.org/patch/?5695

 Summary: Add missing semicolons at the end of fc_assert_XXX()
calls
 Project: Freeciv
Submitted by: pepeto
Submitted on: sam. 10 janv. 2015 13:23:51 CET
Category: general
Priority: 3 - Low
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:





___

File Attachments:


---
Date: sam. 10 janv. 2015 13:23:51 CET  Name: fc_assert_usage_cleanup.patch 
Size: 3 ko   By: pepeto

http://gna.org/patch/download.php?file_id=23457

___

Reply to this item at:

  http://gna.org/patch/?5695

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info

2015-01-10 Thread pepeto 
Follow-up Comment #5, bug #23154 (project freeciv):

Could you send us the savegame from -13 turns?


___

Reply to this item at:

  http://gna.org/bugs/?23154

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5700] Remove a couple of functionality made inside fc_assert_XXX() calls

2015-01-10 Thread pepeto 
URL:
  http://gna.org/patch/?5700

 Summary: Remove a couple of functionality made inside
fc_assert_XXX() calls
 Project: Freeciv
Submitted by: pepeto
Submitted on: sam. 10 janv. 2015 15:15:45 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0,3.0.0

___

Details:





___

File Attachments:


---
Date: sam. 10 janv. 2015 15:15:45 CET  Name:
remove_functionality_from_fc_assert_calls.patch  Size: 3 ko   By: pepeto

http://gna.org/patch/download.php?file_id=23469

___

Reply to this item at:

  http://gna.org/patch/?5700

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23058] Can't use Area Selection mode when national borders are disabled

2015-01-10 Thread pepeto 
Update of bug #23058 (project freeciv):

Category:  client-gtk-2.0 = client 
  Status:   Confirmed = Ready For Test 
 Assigned to:None = pepeto 
Operating System:   Microsoft Windows = Any
 Planned Release: = 2.4.5,2.5.0,2.6.0,3.0.0

___

Follow-up Comment #2:

All clients in all branches affected. It is due to a mistake done at revision
13948 http://svn.gna.org/viewcvs/freeciv?view=revisionrevision=13948
(PR#39862) using tile_owner() instead of city_owner(). Fix attached.


(file #23465, file #23466)
___

Additional Item Attachment:

File name: trunk_S2_6_tiles_hilited_cities_without_borders.patch Size:0 KB
File name: S2_5_S2_4_tiles_hilited_cities_without_borders.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?23058

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23167] Fix typo in vision_site_update_from_city() assertions

2015-01-10 Thread pepeto 
URL:
  http://gna.org/bugs/?23167

 Summary: Fix typo in vision_site_update_from_city()
assertions
 Project: Freeciv
Submitted by: pepeto
Submitted on: sam. 10 janv. 2015 14:27:34 CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Release: S2_4-trunk
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.5,2.5.0,2.6.0,3.0.0

___

Details:

The assertions makes assignment instead of comparison. Fix attached.




___

File Attachments:


---
Date: sam. 10 janv. 2015 14:27:34 CET  Name:
vision_site_update_from_city_fix_assertions.patch  Size: 547 o   By: pepeto

http://gna.org/bugs/download.php?file_id=23468

___

Reply to this item at:

  http://gna.org/bugs/?23167

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23030] Ghost nuclear unit left in enemy city after explosion

2015-01-10 Thread pepeto 
Follow-up Comment #5, bug #23030 (project freeciv):

Second version of the fix attached.

It includes changes made in the first version: Remember what unit have been
made visible and hidden when moving. At the end of the move handling, simply
hide units which are no more visible. It should be robust against specific
rules like nuke detonation inside cities, paradrop on unseen tiles, or any
running script.

Additionally to the first version, it now determines the visibility of each
moves after all units have been moved and the vision sight of moving units has
been enhanced (from source and destination locations). I couldn't reproduce
any case the former implementation would be buggy, but it seems safer to fix
this part too.


(file #23455, file #23456)
___

Additional Item Attachment:

File name: trunk_S2_6_unit_move2.patchSize:18 KB
File name: S2_5_unit_move2.patch  Size:18 KB


___

Reply to this item at:

  http://gna.org/bugs/?23030

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5696] Disable all fc_assert_XXX() effects when NDEBUG is defined

2015-01-10 Thread pepeto 
Update of patch #5696 (project freeciv):

  Status:  Ready For Test = None   
 Assigned to:  pepeto = None   

___

Follow-up Comment #2:

 First one needs to fix all the places where for example
 fc_assert_ret[_val]() is used as the only means of error
 handling

I am unsure about it. Failed assertions are not supposed to occur. Usual
failed assertions are about inconsistent state of game rule. Removing the
assertions in shouldn't not crash Freeciv processes.

Moreover, setting target for 2.6.0 and 3.0.0 give us time to enforce parts
which would need more work.

 or other necessary functionality has been put inside
 fc_assert_xxx()

I have raised bug #23167 and patch #5700 in order to fix that part.


___

Reply to this item at:

  http://gna.org/patch/?5696

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5697] Force the usage of semicolon after fc_assert_XXX() calls

2015-01-10 Thread pepeto 
URL:
  http://gna.org/patch/?5697

 Summary: Force the usage of semicolon after fc_assert_XXX()
calls
 Project: Freeciv
Submitted by: pepeto
Submitted on: sam. 10 janv. 2015 13:28:08 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:





___

File Attachments:


---
Date: sam. 10 janv. 2015 13:28:08 CET  Name: force_usage_of_semi_colon.patch 
Size: 1 ko   By: pepeto

http://gna.org/patch/download.php?file_id=23460

___

Reply to this item at:

  http://gna.org/patch/?5697

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info

2015-01-07 Thread pepeto 
Follow-up Comment #2, bug #23154 (project freeciv):

 This is the same message bug #22600 (although that bug was only
 observed / fixed on 2.5 and up).

In comment 17 http://gna.org/bugs/?22600#comment17, I have said the bug was
not present in S2_4. However, I was talking about the first part of the bug
fix. Maybe the second part also implies S2_4.


___

Reply to this item at:

  http://gna.org/bugs/?23154

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5233] Client goto turn number

2015-01-06 Thread pepeto 
Update of patch #5233 (project freeciv):

 Planned Release:   2.6.0 = 3.0.0  


___

Reply to this item at:

  http://gna.org/patch/?5233

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22692] Show patrol return path

2015-01-06 Thread pepeto 
Update of bug #22692 (project freeciv):

 Planned Release:   2.6.0 = 3.0.0  


___

Reply to this item at:

  http://gna.org/bugs/?22692

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav

2015-01-06 Thread pepeto 
Update of bug #23093 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23093

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23030] Ghost nuclear unit left in enemy city after explosion

2015-01-06 Thread pepeto 
Update of bug #23030 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #4:

First version of the fix ready for testing...


(file #23420, file #23421)
___

Additional Item Attachment:

File name: trunk_S2_6_unit_move.patch Size:18 KB
File name: S2_5_unit_move.patch   Size:17 KB


___

Reply to this item at:

  http://gna.org/bugs/?23030

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23030] Ghost nuclear unit left in enemy city after explosion

2015-01-05 Thread pepeto 
Update of bug #23030 (project freeciv):

Category:None = general
Severity:  3 - Normal = 5 - Blocker
  Status:None = In Progress
 Assigned to:None = pepeto 
 Planned Release:   2.5.0 = 2.5.0, 2.6.0, 3.0.0

___

Follow-up Comment #3:

It is a regression since 2.4 version. So it should be fixed before the release
candidate of 2.5.0.

___

Reply to this item at:

  http://gna.org/bugs/?23030

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav

2015-01-04 Thread pepeto 
Update of bug #23093 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #13:

The original posted patch for S2_4 should stabilize this branch.

___

Reply to this item at:

  http://gna.org/bugs/?23093

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav

2014-12-28 Thread pepeto 
Follow-up Comment #8, bug #23093 (project freeciv):

I have made the version of the patch only for trunk currently. I won't be able
to backport it to older branches (but the bug may be present there too).


___

Reply to this item at:

  http://gna.org/bugs/?23093

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav

2014-12-26 Thread pepeto 
Follow-up Comment #5, bug #23093 (project freeciv):

startpos_hash_replace() is called into a startpos_hash_iterate loop. But
startpos_hash_replace() is actually genhash_replace() and it calls
genhash_maybe_expand() which can cause the hash table to be resized (but the
iterator keeps invalid data).

So, instead of using startpos_hash_replace() to update the counter, I have
made the hash table using integer pointers as data (instead of plain
integers).


___

Reply to this item at:

  http://gna.org/bugs/?23093

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav

2014-12-26 Thread pepeto 
Follow-up Comment #6, bug #23093 (project freeciv):

Attached another approch: resize the genhash only when the entry number will
be changed. It may replace previous one, but both can be applied too.


(file #23302)
___

Additional Item Attachment:

File name: trunk_genhash_resize.patch Size:3 KB


___

Reply to this item at:

  http://gna.org/bugs/?23093

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav

2014-12-22 Thread pepeto 
Update of bug #23093 (project freeciv):

Category: freeciv-web = general
  Status:None = Ready For Test 
 Planned Release: = 2.4.5, 2.5.0, 2.6.0

___

Follow-up Comment #3:

This patch should solve the issue. Unfortunately, I won't be back to commit
for a while. Anyone can take care of this item.


(file #23261, file #23262, file #23263)
___

Additional Item Attachment:

File name: trunk_generate_players.patch   Size:3 KB
File name: S2_5_generate_players.patchSize:3 KB
File name: S2_4_generate_players.patchSize:3 KB


___

Reply to this item at:

  http://gna.org/bugs/?23093

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5565] Replace packet variant process by function pointers

2014-12-17 Thread pepeto 
Update of patch #5565 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5565

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5566] Remove get_packet_from_connection_helper() and receive_packet_XXX() functions

2014-12-17 Thread pepeto 
Update of patch #5566 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5566

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5568] Remove usage of switch statement in packet_has_game_info_flag()

2014-12-17 Thread pepeto 
Update of patch #5568 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5568

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5567] Remove switch statement in packet_name()

2014-12-17 Thread pepeto 
Update of patch #5567 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5567

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav

2014-12-17 Thread pepeto 
Follow-up Comment #1, bug #23093 (project freeciv):

I suspect startpos_hash_replace() to be used in a startpos_hash_iterate loop.


___

Reply to this item at:

  http://gna.org/bugs/?23093

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23030] Ghost nuclear unit left in enemy city after explosion

2014-12-16 Thread pepeto 
Follow-up Comment #2, bug #23030 (project freeciv):

I have found similar problem (reversed) for paratrooper jump seen by shared
vision.


___

Reply to this item at:

  http://gna.org/bugs/?23030

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5565] Replace packet variant process by function pointers

2014-12-15 Thread pepeto 
URL:
  http://gna.org/patch/?5565

 Summary: Replace packet variant process by function pointers
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 15 déc. 2014 16:03:52 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

This patch removes the usage of switch statements to access to
send_packet_XXX_100() and receive_packet_XXX_100() functions. Instead, it use
array of function pointers to access to the functions directly. A hash table
based on network capabilities is used to limit the number of initializations
of the function arrays.

Also, make different how cs/sc restrictions are handled.




___

File Attachments:


---
Date: lun. 15 déc. 2014 16:03:52 CET  Name: packet_variants.patch  Size: 22
ko   By: pepeto

http://gna.org/patch/download.php?file_id=23201

___

Reply to this item at:

  http://gna.org/patch/?5565

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5566] Remove get_packet_from_connection_helper() and receive_packet_XXX() functions

2014-12-15 Thread pepeto 
URL:
  http://gna.org/patch/?5566

 Summary: Remove get_packet_from_connection_helper() and
receive_packet_XXX() functions
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 15 déc. 2014 16:08:54 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

After applying patch #5565, it becomes easy to remove the huge switch
statement represented by get_packet_from_connection_helper().

In addition, fix potential usage of out of bounds memory when packet
statistics are enabled.




___

File Attachments:


---
Date: lun. 15 déc. 2014 16:08:54 CET  Name: get_packet_from_connection.patch 
Size: 5 ko   By: pepeto

http://gna.org/patch/download.php?file_id=23202

___

Reply to this item at:

  http://gna.org/patch/?5566

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5567] Remove switch statement in packet_name()

2014-12-15 Thread pepeto 
URL:
  http://gna.org/patch/?5567

 Summary: Remove switch statement in packet_name()
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 15 déc. 2014 16:10:01 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Replace it by an array of strings.




___

File Attachments:


---
Date: lun. 15 déc. 2014 16:10:01 CET  Name: packet_name.patch  Size: 1 ko  
By: pepeto

http://gna.org/patch/download.php?file_id=23203

___

Reply to this item at:

  http://gna.org/patch/?5567

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5568] Remove usage of switch statement in packet_has_game_info_flag()

2014-12-15 Thread pepeto 
URL:
  http://gna.org/patch/?5568

 Summary: Remove usage of switch statement in
packet_has_game_info_flag()
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 15 déc. 2014 16:11:48 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Replace it by an array of booleans.




___

File Attachments:


---
Date: lun. 15 déc. 2014 16:11:48 CET  Name: packet_has_game_info_flag.patch 
Size: 1 ko   By: pepeto

http://gna.org/patch/download.php?file_id=23204

___

Reply to this item at:

  http://gna.org/patch/?5568

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5566] Remove get_packet_from_connection_helper() and receive_packet_XXX() functions

2014-12-15 Thread pepeto 
Update of patch #5566 (project freeciv):

  Depends on: = patch #5565


___

Reply to this item at:

  http://gna.org/patch/?5566

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

2014-12-15 Thread pepeto 
Update of patch #4949 (project freeciv):

  Depends on: = patch #5565


___

Reply to this item at:

  http://gna.org/patch/?4949

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

2014-12-15 Thread pepeto 
Update of patch #4949 (project freeciv):

  Depends on: = patch #5567


___

Reply to this item at:

  http://gna.org/patch/?4949

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

2014-12-15 Thread pepeto 
Update of patch #4949 (project freeciv):

  Depends on: = patch #5568


___

Reply to this item at:

  http://gna.org/patch/?4949

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

2014-12-15 Thread pepeto 
Update of patch #4949 (project freeciv):

  Depends on: = patch #5566


___

Reply to this item at:

  http://gna.org/patch/?4949

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23062] Qt client doesn't ask for confirmation on exit

2014-12-13 Thread pepeto 
Update of bug #23062 (project freeciv):

 Assigned to:None = mir3x  


___

Reply to this item at:

  http://gna.org/bugs/?23062

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5546] Qt client: Add special unit page to manual

2014-12-13 Thread pepeto 
Update of patch #5546 (project freeciv):

 Assigned to:None = mir3x  


___

Reply to this item at:

  http://gna.org/patch/?5546

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23058] Can't use Area Selection mode when national borders are disabled

2014-12-13 Thread pepeto 
Update of bug #23058 (project freeciv):

  Status:None = Confirmed  


___

Reply to this item at:

  http://gna.org/bugs/?23058

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5472] Shared vision and embassy sanity check for team mates

2014-12-13 Thread pepeto 
Update of patch #5472 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5472

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14473] End of turn is totally messy

2014-12-02 Thread pepeto 
Update of bug #14473 (project freeciv):

  Depends on: = bugs #23012


___

Reply to this item at:

  http://gna.org/bugs/?14473

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23012] future target purged on same turn as requirement get

2014-12-02 Thread pepeto 
Follow-up Comment #6, bug #23012 (project freeciv):

 The flip side in changing the order would be that anything
 built this turn would not contribute to the production (Library
 increasing science, Marketplace gold, Factory production,
 Military units helping martial law or (in case of field units)
 causing unhappiness, or having maintenance of any kind)
But the current behaviour is already buggy. Taking for example a city building
a settler, it gets the production as expected, but when the settler is build,
the city workers are re-arranged, and the food and trade production you get
from it depends on the new used tiles.

I have described quite similar bugs some years ago (see bug #14473).


___

Reply to this item at:

  http://gna.org/bugs/?23012

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22850] Pillaging buoys doesn't remove vision

2014-11-28 Thread pepeto 
Update of bug #22850 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22850

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22992] Team mates can withdraw vision

2014-11-28 Thread pepeto 
Update of bug #22992 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22992

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

  1   2   3   4   5   6   7   8   9   10   >