[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta
Update of patch #3698 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3698 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta
Update of patch #3698 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.5.0 ___ Follow-up Comment #7: New version0: do not refer to the real number of bytes of the packet-header, just link to HACKING... (file #17312) ___ Additional Item Attachment: File name: README.delta.diff Size:1 KB ___ Reply to this item at: http://gna.org/patch/?3698 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta
Update of patch #3698 (project freeciv): Status:None = In Progress Assigned to:None = pepeto ___ Reply to this item at: http://gna.org/patch/?3698 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta
Follow-up Comment #6, patch #3698 (project freeciv): Thank you for your help, Per. I have attached a new version adding the following explanation: The old version filled in from is the previous packet of the same kind that has the same value in each key field. (If the packet's kind don't have any key fields the previous packet of the same kind is used) If no old version exists the unchanged fields will be assumed to be zero. To prevent misunderstandings (If the packet's kind don't have any key fields the previous packet of the same kind is used) was added. No. It takes in account both keys. Sorry to waste your time. I forgot to remove that after I looked closer at genhash. (At least I remembered to remove num_buckets) (file #17201) ___ Additional Item Attachment: File name: README.delta.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?3698 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta
Follow-up Comment #3, patch #3698 (project freeciv): Maybe further clarifications would be welcome to determine how those bytes are used. Good idea. I added (See HACKING to learn how to understand the packet header) (avoids duplication) to the attached update. Also, I proposed a change in the initial network protocol (in bug #19943) that could make this path out of date. I'll keep an eye on it. Keys are taken in account in this case (that's why they are keys). Thank you. My ability to properly understand C after a quick look is rather limited. I would still like details about how the old version is selected to be added. It don't have to be in this patch. I don't have to be the one to write it. I'll make a new try after switching my brain to C-mode and carefully reading the generated code. Letting experimental results alter my working hypothesis from the one extreme (All delta packets have keys to look up fields) to the other (Ignore keys, packets of a related kind and everything else! Just use the previous packet or 'zero' if no previous packet exist) clearly isn't working. (file #17198) ___ Additional Item Attachment: File name: README.delta_corrections.patch Size:0 KB ___ Reply to this item at: http://gna.org/patch/?3698 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta
Follow-up Comment #4, patch #3698 (project freeciv): My new understanding: Packets without a key will use the previous packet of the same kind. Packets with one key will use the previous packet of the same kind that had the same key. Packets with two keys will use the previous packet of the same kind that has the same value when the keys are combined taking the first byte of key1 followed by the rest of key1 xor'ed with key2. If no previous packet following those conditions exist it will use zero. Is this correct? ___ Reply to this item at: http://gna.org/patch/?3698 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta
URL: http://gna.org/patch/?3698 Summary: Corrections to docs/README.delta Project: Freeciv Submitted by: sveinung Submitted on: Wed 13 Feb 2013 12:24:59 PM GMT Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Freeciv's packet header size is 4 bytes now. Remove a the the at the same time. ___ File Attachments: --- Date: Wed 13 Feb 2013 12:24:59 PM GMT Name: README.delta_corrections.patch Size: 795B By: sveinung http://gna.org/patch/download.php?file_id=17192 ___ Reply to this item at: http://gna.org/patch/?3698 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta
Follow-up Comment #1, patch #3698 (project freeciv): The values of the unchanged fields will be filled in from an old version at the receiving side. could use a clarification. I had a look at the generated code when delta is enabled. If it is as simple as it appears, and keys etc aren't taken into account when selecting the old packet, I suggest changing it to: The values of the unchanged fields will be filled in from the previous packet of the same kind received at the receiving side. ___ Reply to this item at: http://gna.org/patch/?3698 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta
Follow-up Comment #2, patch #3698 (project freeciv): Freeciv's packet header size is 4 bytes now. Maybe further clarifications would be welcome to determine how those bytes are used. Also, I proposed a change in the initial network protocol (in bug #19943) that could make this path out of date. and keys etc aren't taken into account when selecting the old packet Keys *are* taken in account in this case (that's why they are keys). ___ Reply to this item at: http://gna.org/patch/?3698 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
