[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation

[Marko Lindqvist]

Update of bug #13465 (project freeciv):

  Status:   Confirmed => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation

[Marko Lindqvist]

Follow-up Comment #5, bug #13465 (project freeciv):

Fix

(file #7081, file #7082)
___

Additional Item Attachment:

File name: KeepSavedSettings_13465.diff   Size:2 KB
File name: KeepSavedSettings_13465-S2_1.diff Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation

[Marko Lindqvist]

Update of bug #13465 (project freeciv):

  Status:None => Confirmed  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation

[Marko Lindqvist]

Follow-up Comment #4, bug #13465 (project freeciv):

I think whole new command for fixing this rather small detail is overkill,
and additional command in server help makes learning curve only steeper.
Logic to decide when to send settings should be in the client side. This
should not be limited to "savename" but all settings loaded from savegame
should be preferred over client defaults.

I looked this (client sources) and bug is not as obvious as previously
thought. Client should send settings only to forked servers (so server has
definitely loaded savegame before client requests it) and before savegame is
loaded. Thus values loaded from savegame should override ones sent by
client.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation

[Matthias Pfafferodt]

Follow-up Comment #3, bug #13465 (project freeciv):

add updated version of the patch which uses game.info.is_new_game; also
include a version for S2_1

(file #6675, file #6676)
___

Additional Item Attachment:

File name: 0001-add-clientset-command-for-settings-from-the-civclie.diff
Size:8 KB
File name: 0001--S2_1-add-clientset-command-for-settings-from-the.diff Size:8
KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation

[Matthias Pfafferodt]

Follow-up Comment #2, bug #13465 (project freeciv):

the updated version of the patch uses S_S_SAVEGAME as defined in   bug #14230

(file #6599)
___

Additional Item Attachment:

File name: 0001-add-clientset-command-for-settings-from-the-civclie.diff
Size:8 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation

[Matthias Pfafferodt]

Follow-up Comment #1, bug #13465 (project freeciv):

this patch adds a new command 'clientset' which is identical to 'set' but
considers the special case of 'savename' (others are possible)

missing is a check if a savegame is loaded; if the patch in bug #14230 is
applied a corresponding check can be added

(file #6582)
___

Additional Item Attachment:

File name: 0001-add-clientset-command-for-settings-from-the-civcli.patch.diff
Size:8 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation

[Marko Lindqvist]

Update of bug #13465 (project freeciv):

Severity:  3 - Normal => 5 - Blocker
 Planned Release:None => 2.1.10 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation

[Christian Knoke]

URL:
  

 Summary: wrong savename used for savefile name generation
 Project: Freeciv
Submitted by: chrisk
Submitted on: Freitag 01.05.2009 um 12:25
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

SVN 2.1.9+ Rev. 15634

When a savename is saved in the civclientrc file, civclient uses this and
sends it to the local civserver fpr creating save names from the running
game, *even* *if* a save game with another savename stored in it is loaded
and subsequentially saved.

This behaviour is new. Civclient should use the savename stored in the loaded
save game instead, or a savename that is set from the client *after* the save
game is loaded. The current behaviour leads to confusion about save games, if
2 or more games are played in parallel.

Christian




___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev