[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Update of bug #13891 (project freeciv): Status:None => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #17, bug #13891 (project freeciv): Done. (file #6543) ___ Additional Item Attachment: File name: client_implementation4.diffSize:13 KB ___ Reply to this item

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Update of bug #13891 (project freeciv): Planned Release:None => 2.2.0 ___ Follow-up Comment #16: featured_text5.diff has been committed. Remaining minor nitpick about client-implementation3.

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #14, bug #13891 (project freeciv): > For translating unit name in server side, shouldn't it put > translated name in unit_link() and text_tag_replace_text() to > always use that name? Like you answered in the previous message, it depends of the local of the emitter. If the emi

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #13, bug #13891 (project freeciv): Actually this translation thing depends where message originates from. I plan to commit this patch as it is and to leave imrpovements to future tickets. ___ Reply to this item at:

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #12, bug #13891 (project freeciv): For translating unit name in server side, shouldn't it put translated name in unit_link() and text_tag_replace_text() to always use that name? ___ Reply to this item at:

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #11, bug #13891 (project freeciv): > Just realized that rest of the message is translated at the > server side. Link name also should be translated server side > to make translation at least consistent, if not one translated > for client's local language. This is how things curr

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #10, bug #13891 (project freeciv): >> maybe it would try to translate the link name to the local >> language in text_tag_replace_text() > Yes, that sounds like right thing to do. Just realized that rest of the message is translated at the server side. Link name also should be

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #9, bug #13891 (project freeciv): > Patches in this ticket can go in first. Sending plain text to > clients without featured text capabilities should be next step > (or at least before server sends any featured text) My patch for this is nearly ready, but I have some problems t

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #8, bug #13891 (project freeciv): > (I'm not sure about the usage client_info packet instead of > server_join_req). server_join_req itself contains capability information. Capabilities cannot be checked before it is sent. I rather avoid making incompatible versions of server_jo

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #7, bug #13891 (project freeciv): featured_text4.diff: * Fixed link id initialization. client_implementation3.diff: * Parse colors only once. * Links are clickable. The colors used are the traditionnal warclient ones. The graphical implementation is not done yet

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #6, bug #13891 (project freeciv): >> maybe it would try to translate the link name to the local >> language in text_tag_replace_text() > > Yes, that sounds like right thing to do. New patch attached. > Will it be possible, and feasible, in future ticket, to make > server send

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #5, bug #13891 (project freeciv): > maybe it would try to translate the link name to the local > language in text_tag_replace_text() Yes, that sounds like right thing to do. Will it be possible, and feasible, in future ticket, to make server send plain text only to those clien

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #4, bug #13891 (project freeciv): text_tag_replace_text() actually looks for unit or city id and then determines city/unit name based on that like you said. But in the case the unit/city is not known by a client, it's replaced by the name granted with the link (ptag->link.name)

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #3, bug #13891 (project freeciv): text_tag_replace_text() looks for unit or city id and then determines city/unit name based on that. This means no name is shown when city/unit is not known by client. This is a problem. Server should be allowed to send messages about any city/un

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #2, bug #13891 (project freeciv): Some fixes... featured_text2.diff: * When there are two escape sequences for foreground color without a end sequence, really change the foreground color. client_implementation2.diff: * Do not get gtk warnings when a color name is not valid. *

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Update of bug #13891 (project freeciv): Assigned to:None => cazfi ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

Follow-up Comment #1, bug #13891 (project freeciv): Patch for the client implementation. This doesn't include yet the link stuff which require more changes. (file #6158) ___ Additional Item Attachment: File name: client_implementation.d

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

URL: Summary: [Patch] Chat colors and other improvements Project: Freeciv Submitted by: pepeto Submitted on: Tuesday 07/07/2009 at 06:40 Category: general Severity: 1 - Wish