[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Update of bug #15400 (project freeciv):

  Status: In Progress => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Follow-up Comment #22, bug #15400 (project freeciv):

Everything important to this bug is committed to S2_2; it's good for release.
It remains open only for file #9188, which I'll probably commit to trunk
(only) later today.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Matthias Pfafferodt]

Follow-up Comment #21, bug #15400 (project freeciv):

> Is this a showstopper for 2.2.1 release?

No; the error this bug is about is hard to reproduce (only with debian
binutils-gold; I can't) and a patch exists and is applied. My comment about
the configure warning changes only the output as I did not have the error in
the beginning. Only if someone with debian binutils-gold comments we would
know for sure.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Daniel Markstedt]

Follow-up Comment #20, bug #15400 (project freeciv):

Is this a showstopper for 2.2.1 release?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Matthias Pfafferodt]

Follow-up Comment #19, bug #15400 (project freeciv):

sorry for the late answer; here are additional comments

* I can't reproduce the error using an unpatched version (prior svn17430) and
'-Wl,--no-add-needed'; perhaps this needs a system which was build with this
options, i.e. debian with binutils-gold?

* it was not a configuration failure but an error message printed by the
configure script. As a result the -lm option was not set for SERVER_LIBS and
CLIENT_LIBS; nevertheless the compilation finished (on _my_ system) without
any problems


checking SDL_mixer.h usability... yes
checking SDL_mixer.h presence... yes
checking for SDL_mixer.h... yes
checking for Mix_OpenAudio in -lSDL_mixer... yes
checking building SDL_mixer support... yes
checking for GGZ library: libggz... no
checking for GGZ library: libggz... (cached) no
./configure: line 35474: -lm: command not found
./configure: line 35479: -lm: command not found
checking for gethostbyaddr in -lbind... no
checking readline/readline.h usability... yes
checking readline/readline.h presence... yes
checking for readline/readline.h... yes
checking for completion_matches in -lreadline... yes


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Follow-up Comment #16, bug #15400 (project freeciv):

I don't know why this didn't generate an error on my system, but upon looking
at the generated Makefiles, the patch wasn't giving the intended result (-lm
in CLIENT_LIBS, etc).

Since this will prevent compilation, I'm treating it as a critical patch and
checking it in immediately.

Rather than quoting, I think it'd be sufficient just to remove the space --
both cause -lm to appear in the Makefile for me -- but since I can't
reproduce the problem I will commit syntron's fix verbatim, in case there's
another subtlety that I've missed.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Update of bug #15400 (project freeciv):

 Open/Closed:  Closed => Open   

___

Follow-up Comment #15:

Rats.

> The second (or first) patch includes '-Wl,--no-add-needed' to the debug
options if --enable-debug=checks is used.

Did you manage to reproduce the original problem with this?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Matthias Pfafferodt]

Follow-up Comment #14, bug #15400 (project freeciv):

Additional Informations:


#> gcc -v
Using built-in specs.
Target: x86_64-suse-linux
Configured with: ../configure --prefix=/usr --infodir=/usr/share/info
--mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64
--enable-languages=c,c++,objc,fortran,obj-c++,java,ada
--enable-checking=release --with-gxx-include-dir=/usr/include/c++/4.3
--enable-ssp --disable-libssp --with-bugurl=http://bugs.opensuse.org/
--with-pkgversion='SUSE Linux' --disable-libgcj --disable-libmudflap
--with-slibdir=/lib64 --with-system-zlib --enable-__cxa_atexit
--enable-libstdcxx-allocator=new --disable-libstdcxx-pch
--enable-version-specific-runtime-libs --program-suffix=-4.3
--enable-linux-futex --without-system-libunwind --with-cpu=generic
--build=x86_64-suse-linux
Thread model: posix
gcc version 4.3.2 [gcc-4_3-branch revision 141291] (SUSE Linux)
#> cat /etc/SuSE-release
openSUSE 11.1 (x86_64)
VERSION = 11.1


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Matthias Pfafferodt]

Update of bug #15400 (project freeciv):

  Status:   Fixed => In Progress

___

Follow-up Comment #13:

I get the following error messages:


./configure: line 35474: -lm: command not found
./configure: line 35479: -lm: command not found


If I include quotes for CLIENT_LIBS and SERVER_LIBS it is working as expected
(20100521-02-trunk-add-quotes-to-CLIENT_LIBS-and-SERVER_LIBS.patch).

The second (or first) patch includes '-Wl,--no-add-needed' to the debug
options if --enable-debug=checks is used.

(file #9188, file #9189)
___

Additional Item Attachment:

File name:
20100521-01-trunk-additional-compiler-option-for-debug-checks.patch Size:1 KB
File name: 20100521-02-trunk-add-quotes-to-CLIENT_LIBS-and-SERVER_LIBS.patch
Size:0 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Update of bug #15400 (project freeciv):

  Status: In Progress => Fixed  
 Open/Closed:Open => Closed 
 Planned Release: => 2.2.1  

___

Follow-up Comment #12:

I tried reproducing the original error (prior to this fix by adding
"-Wl,--no-add-needed" to the linker command line as suggested here

-- "LDFLAGS=-Wl,--no-add-needed ./configure [rest-of-args]" seemed to cause it
to appear in appropriate places in make output -- but was unsuccessful in
reproducing it. I haven't tried actually using binutils-gold.

Declaring this fixed anyway.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Update of bug #15400 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #9:

> I'm not quite sure why I didn't get a compile-time error or warning when I
removed math.h from map.h.

Looks like it was compensated for by adding #include  to
server/maphand.c, server/unittools.c, ai/aiexplorer.c, all of which only use
sqrt() indirectly via map.h.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jonathan Landis]

Follow-up Comment #8, bug #15400 (project freeciv):

Nice catch.  I'm not quite sure why I didn't get a compile-time error or
warning when I removed math.h from map.h.  Maybe I did, and I missed it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Follow-up Comment #7, bug #15400 (project freeciv):

In more-math-lib-fixups.patch, I disagree with the removal of #include
"math.h" from common/map.h; the macro circle_dxyr_iterate() uses sqrt() (in
both trunk and S2_2), and the header should be self-contained.

Patches otherwise look good to me.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Update of bug #15400 (project freeciv):

  Depends on: => bugs #15973


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Update of bug #15400 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:   cazfi => jtn


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jonathan Landis]

Follow-up Comment #6, bug #15400 (project freeciv):

Here is an additional patch which fixes more problems related to math.h and
libm.  It should be applied in addition to the other patch I submitted here,
as well as the patch over on 15973 which sets up COMMON_LIBS and
UTILITY_LIBS.

Again, the theme is that each executable, library, or convenience library
which uses the math library should link to it, and each file which uses
math.h functions should directly include math.h.


(file #9119)
___

Additional Item Attachment:

File name: more-math-lib-fixups.patch Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[anonymous]

Follow-up Comment #5, bug #15400 (project freeciv):

This bug is related to 15973 , which
handles the particular case of libfreeciv.  This patch handles the other
cases, which are the common client code and the convenience library
libgui-xaw.

What this patch does is described below, together with arguments as to why
each thing is the right thing to do.  I checked to make sure all the errors
in the report are addressed, but I have not actually tested a build using
gold.

1.  Unconditonally add -lm to the autoconf variable CLIENT_LIBS

The way the build system is currently structured, the CLIENT_LIBS variable
appears to be the right place to put library requirements of the common
client code.  In particular, client_main.c uses the math library, so each
client must be linked against it.

2.  Remove the 'pow' function checks and unconditionally add -lm to SERVER
LIBS

It seems like an entirely speculative benefit to check for libm.  If someone
has an example of a real system with a functioning build kit and no libm, we
can revisit this.  But for now, to keep things simple and consistent, -lm is
unconditionally added to both CLIENT_LIBS and SERVER_LIBS.

3.  Add -lm to the LIBADD for the libgui-xaw convenience library

We must be sure to link each library to its dependencies, even if we think
the final executable will be linked with those dependencies anyway.

4.  Add an explicit include of math.h in one of the xaw implementation files

It's not a good idea to rely on a chain of header inclusions.  Each file that
uses the math library should include math.h directly.

JKL

(file #9096)
___

Additional Item Attachment:

File name: client-and-xaw-client-need-libm.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Marko Lindqvist]

Update of bug #15400 (project freeciv):

Category:None => bootstrap  
 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Marko Lindqvist]

Follow-up Comment #4, bug #15400 (project freeciv):

Please forward any bugs that are not specific to Debian. I have occasionally
checked Debian bug reports but unless it's obviously our (upstream) bug, I
have just waited Debian folks to check it first, and to forward if
applicable.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Follow-up Comment #3, bug #15400 (project freeciv):

Please continue to forward them IMO, it was just probably just coincidence I
was being nosey in Debian at the same time you were apparently having a
clearout, and anyway others on the project may not watch Debian.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Karl Goetz]

Follow-up Comment #2, bug #15400 (project freeciv):

Would you like me to forward bugs in future, or will you watch them via
debian's bts? I was thinking of sending on a few of our others incase they
were new, but i'll save everyones time if you watch both systems anyway :)
kk

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[Jacob Nevins]

Follow-up Comment #1, bug #15400 (project freeciv):

Yeah, I saw this in the Debian BTS. Looks like we're missing a "-lm"
somewhere. Haven't tried wrangling the build system to find where it should
go though.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold

[anonymous]

URL:
  

 Summary: FTBFS with binutils-gold
 Project: Freeciv
Submitted by: None
Submitted on: Wednesday 02/17/2010 at 03:06 CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.1.9
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Hi,
Reported to the Debian BTS[1]:

Tried to build your package and it fails to build with GNU binutils-gold.
The
important difference is that --no-add-needed is the default behavior of of
GNU
binutils-gold. Please provide all needed libraries to the linker when
building
your executables.

[...]

x86_64-linux-gnu-gcc  -Wall -g -O2-o civclient   audio_sdl.o attribute.o
citydlg_common.o cityrepdata.o civclient.o chatline_common.o
connectdlg_common.o climisc.o climap.o clinet.o colors_common.o control.o
ggzclient.o goto.o helpdata.o mapctrl_common.o mapview_common.o
messagewin_common.o overview_common.o packhand.o packhand_gen.o
plrdlg_common.o options.o repodlgs_common.o reqtree.o servers.o text.o
themes_common.o tilespec.o audio.o audio_none.o ../utility/libcivutility.a 
../common/libcivcommon.a ../common/aicore/libaicore.a agents/libagents.a
gui-xaw/libguiclient.a ../utility/libcivutility.a  ../common/libcivcommon.a
../common/aicore/libaicore.a agents/libagents.a gui-xaw/libguiclient.a 
-lpng12   -lXaw3d -lXpm -lXmu -lXt  -lSM -lICE -lXext -lX11  -L/usr/lib -lSDL
-lSDL_mixer   -lz  
/usr/bin/ld: civclient.o: in function
real_timer_callback:../../client/civclient.c:737: error: undefined reference
to 'ceil'
/usr/bin/ld: civclient.o: in function
real_timer_callback:../../client/civclient.c:744: error: undefined reference
to 'floor'
/usr/bin/ld: civclient.o: in function
set_seconds_to_turndone:../../client/civclient.c:685: error: undefined
reference to 'ceil'
/usr/bin/ld: overview_common.o: in function
gui_to_overview_pos:../../client/overview_common.c:85: error: undefined
reference to 'floor'
/usr/bin/ld: overview_common.o: in function
gui_to_overview_pos:../../client/overview_common.c:86: error: undefined
reference to 'floor'
/usr/bin/ld: ../common/libcivcommon.a(city.o): in function
get_caravan_enter_city_trade_bonus:../../common/city.c:936: error: undefined
reference to 'pow'
/usr/bin/ld: ../common/libcivcommon.a(combat.o): in function
win_chance:../../common/combat.c:225: error: undefined reference to 'pow'
/usr/bin/ld: ../common/libcivcommon.a(tech.o): in function
precalc_tech_data:../../common/tech.c:628: error: undefined reference to
'sqrt'
/usr/bin/ld: gui-xaw/libguiclient.a(helpdlg.o): in function
help_update_unit_type:../../../client/gui-xaw/helpdlg.c:848: error: undefined
reference to 'sqrt'
collect2: ld returned 1 exit status
make[4]: *** [civclient] Error 1

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=554411





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev