[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
Update of bug #15721 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
Update of bug #15721 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.1.12 ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
Follow-up Comment #5, bug #15721 (project freeciv): I haven't got round to looking into this in any detail, but... it seems rather a shame for pf_map_new() to silently ignore some of the parameters requested; the error message helped the diagnosis of this error. Is there any pressing need to apply a fix to S2_2 or trunk, where there's no failure caused by this fault at the moment (that I know of)? Ok, there isn't a real need to commit in S2_2 and trunk. Actually, I was wondering about it. If this is a situation that only occurs on S2_1 and this combination of path-finding requirements is not likely to be needed on S2_2/trunk in the foreseeable future, then a quick fix for S2_1 to revert to previous behaviour seems the most appropriate (even if the resulting path-finding is not ptimal). This is exactly what does the patch for S2_1. But I admit I don't fully understand the different flavours of pathfinding (normal/danger/fuel) yet, nor exactly what danger the danger_map is looking for. The pf_danger_map looks for dangerous tiles (tiles the unit cannot end the turn end). The pf_fuel_map prevents to go to a destination the unit wouldn't have fuel reaching it. pf_normal_map is the normal path-finding code. ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
Follow-up Comment #4, bug #15721 (project freeciv): I haven't got round to looking into this in any detail, but... it seems rather a shame for pf_map_new() to silently ignore some of the parameters requested; the error message helped the diagnosis of this error. Is there any pressing need to apply a fix to S2_2 or trunk, where there's no failure caused by this fault at the moment (that I know of)? If this is a situation that only occurs on S2_1 and this combination of path-finding requirements is not likely to be needed on S2_2/trunk in the foreseeable future, then a quick fix for S2_1 to revert to previous behaviour seems the most appropriate (even if the resulting path-finding is not optimal). But I admit I don't fully understand the different flavours of pathfinding (normal/danger/fuel) yet, nor exactly what danger the danger_map is looking for. ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
Follow-up Comment #2, bug #15721 (project freeciv): I checked the old behaviour: it was ignoring dangers. Is it better? Else, I could implement the missing functions, but it will take time. ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
Follow-up Comment #3, bug #15721 (project freeciv): Attached a fix to get the old behaviour. But keeping ignoring the dangerous position. Note also it prefers pf_fuel_map to pf_danger_map. (file #8707, file #8708, file #8709) ___ Additional Item Attachment: File name: trunk_pf_map_new.diff Size:1 KB File name: S2_2_pf_map_new.diff Size:1 KB File name: S2_1_pf_map_new.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
URL: http://gna.org/bugs/?15721 Summary: S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented. Project: Freeciv Submitted by: jtn Submitted on: Sunday 03/28/10 at 02:42 Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.1.11 Discussion Lock: Any Operating System: None Planned Release: ___ Details: Just tried using Engineers to connect two locations with road, rail, and irrigation on the head of S2_1 (r17172) and got the message: 1: jumbo callbacks for danger maps are not yet implemented. The resulting goto paths looked wrong (diagonal moves for irrigation) and the turns-to-completion too short (which is what I'd expect from that message -- in this case it'll completely ignore the special get_connect_road()/irrig() path-finding routines). Same issue applies to 2.1.11 (haven't checked earlier versions). Doesn't happen with S2_2. ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
Follow-up Comment #1, bug #15721 (project freeciv): I wonder if it's trying to use a danger map because of base_unsafe_terrain_loss_pct() (in pft_fill_unit_parameter()). That would explain why it doesn't apply to S2_2. Not proven though. ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
