[Freeciv-Dev] [bug #19784] flag_alt vs. load_sprite()
Follow-up Comment #6, bug #19784 (project freeciv): (To be clear, in this bug I speak about nation flags only.) Was the problem here that .spec file (=tag) existed, but actual gfx did not. I think error is correct behavior in such a case where tileset is clearly broken, and not just meant to fallback to alt gfx. Let's see. load_sprite() returns NULL if sprite isn't within image (without forced exit.) But isn't tileset clearly broken in this case too? Also, shouldn't allow_fail to be bool? Sure. === Two independent loops could give us different flags for cities and units right now, couldn't them? ___ Reply to this item at: http://gna.org/bugs/?19784 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19784] flag_alt vs. load_sprite()
Follow-up Comment #4, bug #19784 (project freeciv): Dirty [but working] concept is attached. Only tileset_setup_nation_flag() behavior's changed. (Successfully) tested against r21342. Test was with removed belgic_large.png and showed another problem - with this patch applied units and cities could have different flags (because tags used for flag and shield are independent.) (file #15856) ___ Additional Item Attachment: File name: load_sprite.diff Size:12 KB ___ Reply to this item at: http://gna.org/bugs/?19784 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19784] flag_alt vs. load_sprite()
Follow-up Comment #5, bug #19784 (project freeciv): It's not long since I last tested _alt sprites intentionally, and I think that they are actually used on purpose on some ruleset/tileset combos I use. Was the problem here that .spec file (=tag) existed, but actual gfx did not. I think error is correct behavior in such a case where tileset is clearly broken, and not just meant to fallback to alt gfx. Also, shouldn't allow_fail to be bool? ___ Reply to this item at: http://gna.org/bugs/?19784 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19784] flag_alt vs. load_sprite()
Follow-up Comment #3, bug #19784 (project freeciv): Belgic flags fixed under the auspices of patch #2507. This ticket can remain for code fix. ___ Reply to this item at: http://gna.org/bugs/?19784 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19784] flag_alt vs. load_sprite()
URL: http://gna.org/bugs/?19784 Summary: flag_alt vs. load_sprite() Project: Freeciv Submitted by: evyscr Submitted on: Tue 05 Jun 2012 12:50:01 PM MSK Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: ___ Details: Looks like flag_alt in nation ruleset is useless for client, since client/tilespec.c:load_sprite() always force you to exit if [first] sprite couldn't be loaded. Therefore there will be no call with next tag from tileset_setup_nation_flag. Right now you can see this on trunk: belgic.ruleset with belgic*.png not added to Makefile.am, and flag_alt=belgium. ___ Reply to this item at: http://gna.org/bugs/?19784 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19784] flag_alt vs. load_sprite()
Follow-up Comment #1, bug #19784 (project freeciv): So there are there two issues here or just one (that patch #2507 failed to add the new flags to trunk/data/flags/Makefile.am) ? ___ Reply to this item at: http://gna.org/bugs/?19784 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19784] flag_alt vs. load_sprite()
Follow-up Comment #2, bug #19784 (project freeciv): Well, I thought there was one issue, but about code rather than absent belgic flags. The question is: does client really _always_ need to exit if it couldn't load gfx file? ___ Reply to this item at: http://gna.org/bugs/?19784 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
