[Freeciv-Dev] [bug #19932] Attempting to set a goto path with the end tile also being a waypoint does nothing

[pepeto]

Update of bug #19932 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19932

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19932] Attempting to set a goto path with the end tile also being a waypoint does nothing

[pepeto]

Update of bug #19932 (project freeciv):

  Status:   Confirmed = Ready For Test 
 Planned Release: = 2.3.5,2.4.2,2.5.0,2.6.0

___

Follow-up Comment #4:

 end==start looks like it might be a special internal signal
 from pathfinding. If so, we should presumably filter out real
 end==start segments before they get this far.

Actually, this signal is not pathfinding related, but a logic only used in
client/goto.c. The pathfinding signal is that the returned path are NULL.
The patch I am attaching use this logic.


(file #19709)
___

Additional Item Attachment:

File name: 0001-Fix-for-bug-19932.patch   Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?19932

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19932] Attempting to set a goto path with the end tile also being a waypoint does nothing

[pepeto]

Update of bug #19932 (project freeciv):

 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?19932

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19932] Attempting to set a goto path with the end tile also being a waypoint does nothing

[Jacob Nevins]

Follow-up Comment #3, bug #19932 (project freeciv):

Bit more info (incomplete analysis):
* the abort happens in send_goto_route():


if (last_part-end_tile == last_part-start_tile) {
  /* Cannot move there */
  continue;
}


* end==start looks like it might be a special internal signal from
pathfinding. If so, we should presumably filter out real end==start segments
before they get this far.

___

Reply to this item at:

  http://gna.org/bugs/?19932

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19932] Attempting to set a goto path with the end tile also being a waypoint does nothing

[Marko Lindqvist]

Follow-up Comment #2, bug #19932 (project freeciv):

Confirmed, and also tested that other zero-length parts work: you can make
initial tile waypoint first waypoint, and you can make same tile waypoint
twice, and everything works as long as last waypoint is not same tile as final
destination.

___

Reply to this item at:

  http://gna.org/bugs/?19932

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19932] Attempting to set a goto path with the end tile also being a waypoint does nothing

[Jacob Nevins]

URL:
  http://gna.org/bugs/?19932

 Summary: Attempting to set a goto path with the end tile also
being a waypoint does nothing
 Project: Freeciv
Submitted by: jtn
Submitted on: Thu Jul 12 23:42:54 2012
Category: client
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r21520
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Noticed in passing on trunk.
* Start a goto path for a unit (G).
* Move to a tile and set a waypoint (G).
* Immediately left-click on the same tile to finish the path.
Expected: unit starts goto.
Actual: nothing happens, goto path lost.

Haven't checked other branches yet.




___

Reply to this item at:

  http://gna.org/bugs/?19932

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19932] Attempting to set a goto path with the end tile also being a waypoint does nothing

[Jacob Nevins]

Update of bug #19932 (project freeciv):

  Status:None = Confirmed  

___

Follow-up Comment #1:

Confirmed on S2_4 and S2_3 too.

___

Reply to this item at:

  http://gna.org/bugs/?19932

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev