[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed
Update of bug #20542 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed
Update of bug #20542 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #5: I think that it is necessary to explicitly clear transported_by after unit_transport_unload() in player_clear() Attached patch does that. (file #17759) ___ Additional Item Attachment: File name: UntransportClient.patchSize:0 KB ___ Reply to this item at: http://gna.org/bugs/?20542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed
Update of bug #20542 (project freeciv): Planned Release: 2.4.0,2.5.0 = 2.4.0-beta2,2.5.0 ___ Reply to this item at: http://gna.org/bugs/?20542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed
Follow-up Comment #2, bug #20542 (project freeciv): Still happening with file #17386 on latest S2_4 (r22619), FWIW. ___ Reply to this item at: http://gna.org/bugs/?20542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed
Follow-up Comment #3, bug #20542 (project freeciv): ...but I don't see it in 2.4.0-beta1 (I'm guessing the fix for bug #20085 is implicated). ___ Reply to this item at: http://gna.org/bugs/?20542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed
Follow-up Comment #4, bug #20542 (project freeciv): To expand on this: I think in this case that this assertion is wrong. When exiting the game, it shouldn't check this. So, post bug #20085, we have a policy that (unit)-client.transported_by always reflects what we last saw from the server; and we already had a policy that a unit is not allowed to be being transported at the time it's destroyed. However, in this case, we're deleting units without being told to be the server. If we want to keep these policies, I think that it is necessary to explicitly clear transported_by after unit_transport_unload() in player_clear() (probably both for cargo and the current unit). Anywhere else where the client autonomously messes with this stuff? I didn't spot anything on a quick look. ___ Reply to this item at: http://gna.org/bugs/?20542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed
Update of bug #20542 (project freeciv): Category:None = client Planned Release: = 2.4.0,2.5.0 ___ Follow-up Comment #1: I'm seeing this assertion/backtrace too, on S2_4 r22473. It's a client-side assertion. Just load the attached savefile and then quit. (file #17386) ___ Additional Item Attachment: File name: americans-T0222-Y01610-manual.sav.bz2 Size:52 KB ___ Reply to this item at: http://gna.org/bugs/?20542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed
URL: http://gna.org/bugs/?20542 Summary: in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed Project: Freeciv Submitted by: pepeto Submitted on: mer. 20 févr. 2013 16:09:57 CET Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: trunk r22403 Discussion Lock: Any Operating System: None Planned Release: ___ Details: 1: in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed. 2: Backtrace: 2: 0: ./client/freeciv-gtk2() [0x8252c0d] 2: 1: ./client/freeciv-gtk2(vdo_log+0xca) [0x825727a] 2: 2: ./client/freeciv-gtk2(do_log+0x40) [0x8257300] 2: 3: ./client/freeciv-gtk2(fc_assert_fail+0x60) [0x82574e0] 2: 4: ./client/freeciv-gtk2(unit_virtual_destroy+0x1c1) [0x824ccc1] 2: 5: ./client/freeciv-gtk2(player_clear+0x110) [0x8238a10] 2: 6: ./client/freeciv-gtk2(player_destroy+0x5b) [0x8238b9b] 2: 7: ./client/freeciv-gtk2(player_slots_free+0x68) [0x8238df8] 2: 8: ./client/freeciv-gtk2(game_free+0x8) [0x816df28] 2: 9: ./client/freeciv-gtk2() [0x80b065f] 2:10: ./client/freeciv-gtk2(client_exit+0x49) [0x80b0c69] [...] The assertion looks similar to bug #20045, but it went from an other way. I think in this case that this assertion is wrong. When exiting the game, it shouldn't check this. ___ Reply to this item at: http://gna.org/bugs/?20542 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
