[Freeciv-Dev] [bug #23382] langstat.txt not removed by distclean
Update of bug #23382 (project freeciv): Priority: 5 - Normal = 7 - High ___ Follow-up Comment #5: Now distcheck is apparently complaining about the fact that 'make dist' tries to regenerate the file even when it already exist. More precisely: It tries to regenerate one to replace the one found from tarball supposedly identical to what we are creating (the machinery to check that is that we have given no write permissions to the directory we would illegally write to, so this ends up being more than just a warning) That's because it's .PHONY target. Automake is wrong here in the sense that the regenerated file would be identical to the original in the specific case that matters. Attached patch works around distcheck problems by (always) generating the file as temporary file to builddir, then comparing it to the one in srcdir, and copying it over (only) if they differ. So it won't try to attempt the copy (i.e. write) to srcdir in the case where the file is not allowed to change, or if it ever does, that indicates a real problem somewhere else. The patch also modifies stats.sh so that it does not try to create temporary file inside the src tree while working. I hope to commit this to TRUNK/S2_6 before next fullmoon run. (file #24081) ___ Additional Item Attachment: File name: LangstatBuildToSrc.patch Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?23382 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23382] langstat.txt not removed by distclean
Update of bug #23382 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23382 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23382] langstat.txt not removed by distclean
URL: http://gna.org/bugs/?23382 Summary: langstat.txt not removed by distclean Project: Freeciv Submitted by: cazfi Submitted on: Fri 13 Mar 2015 04:05:26 AM EET Category: bootstrap Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Fullmoon reported: ERROR: files left in build directory after distclean: ./bootstrap/langstat.txt ___ Reply to this item at: http://gna.org/bugs/?23382 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23382] langstat.txt not removed by distclean
Follow-up Comment #4, bug #23382 (project freeciv): Now distcheck is apparently complaining about the fact that 'make dist' tries to regenerate the file even when it already exist. I'll think that one a bit, but it might be that we can't have the automatic update/regeneration at all (which would be unfortunate, risking us distributing outdated stats if we are not very careful) ___ Reply to this item at: http://gna.org/bugs/?23382 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23382] langstat.txt not removed by distclean
Update of bug #23382 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.6.0, 3.0.0 ___ Follow-up Comment #1: Took me while to figure out what's wrong there. As the file should be part of dist (and it's listed in EXTRA_DIST for that), it should *not* be removed by distclean. I now think that the problem is that the file is created to builddir, and not to srcdir. Files part of dist are supposed to be in the srcdir (as they are when someone untars the dist). Fix attached. Will commit immediately for tomorrow's fullmoon round. (file #24067) ___ Additional Item Attachment: File name: SrcdirLangstat.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?23382 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
