Update of patch #1850 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #1850 (project freeciv):
Status: Ready For Test = In Progress
___
Follow-up Comment #12:
Updated patch against trunk. Removed change in fc_version as we don't know
the date we will
Update of patch #1850 (project freeciv):
Status: In Progress = Ready For Test
___
Follow-up Comment #13:
get_defender() was returning unreachable units, that was the cause of the
bug. New patch
Update of patch #1850 (project freeciv):
Assigned to:None = pepeto
___
Reply to this item at:
http://gna.org/patch/?1850
___
Message
Follow-up Comment #10, patch #1850 (project freeciv):
Does is_unit_reachable_by_unit() check for native base?
No, it doesn't care where units are. It just checks if unit is normally
reachable by other.
At least it's like that as currently implemented. I'll combine and rework our
patches a
Follow-up Comment #11, patch #1850 (project freeciv):
* Combined our patches
* Setting unreachableprotects is no longer SSET_VITAL, but
SSET_RARE
* Added function is_unit_reachable_at() and used it where ever
appropriate (actually everywhere where
is_unit_reachable_by_unit() was previously
Follow-up Comment #5, patch #1850 (project freeciv):
No, my patch does not change the case of city or native base. As far as I
understand, this case is handled in previous if:
if (!is_stack_vulnerable(punit-tile) || unitcount == 1)...
So this shouldn't happen (unless you have tested it and
Follow-up Comment #6, patch #1850 (project freeciv):
No, I have not had time to actually test...
I forgot that stack is not going to die in cities or in some bases, no matter
what. So there is no problem with cities (except that this is a bit fragile
way of achieving desired effects), but there
Follow-up Comment #7, patch #1850 (project freeciv):
is_stack_vulnerable() checks for base (see common/combat.c).
___
Reply to this item at:
http://gna.org/patch/?1850
___
Message sent
Follow-up Comment #8, patch #1850 (project freeciv):
is_stack_vulnerable() checks for base (see common/combat.c).
It checks if there is base with NoStackDeath flag. It does not check if
there is base native to defending unit.
This does not affect default rulesets, but possibly some custom
Follow-up Comment #9, patch #1850 (project freeciv):
Does is_unit_reachable_by_unit() check for native base?
(file #9862)
___
Additional Item Attachment:
File name: omg.sav.gz Size:268 KB
On 13 Aug, 2010, at 5:51 AM, Lavrentij P Berija wrote:
I've made quick'n'dirty patch (which seems to work though) which makes stack
death rule applied only for reachable units. Maybe it's worth raising a
thread on forum to decide if this behaviour would be appropriate for players?
It
On 15.08.2010 10:13, David Lowe wrote:
On 13 Aug, 2010, at 5:51 AM, Lavrentij P Berija wrote:
I've made quick'n'dirty patch (which seems to work though) which makes stack
death rule applied only for reachable units. Maybe it's worth raising a
thread on forum to decide if this behaviour
URL:
http://gna.org/patch/?1850
Summary: Server setting to control if unreachable unit
protects reachable ones
Project: Freeciv
Submitted by: cazfi
Submitted on: Friday 08/13/2010 at 10:52
Category: general
Follow-up Comment #1, patch #1850 (project freeciv):
Seems the patch just makes unreachable units reachable. When you kill
reachable units, unreachable are killed too. See the attached savegame: try
to kill Confederates' spy covered by AWACS (47:96) by Mongol unit or wait
till AI kills it. AWACS
Follow-up Comment #2, patch #1850 (project freeciv):
Yes, stack death rule is not touched. Change is that unreachable units are
unreachable only if alone (or with other unreachable units) on tile.
___
Reply to this item at:
Follow-up Comment #3, patch #1850 (project freeciv):
I've made quick'n'dirty patch (which seems to work though) which makes stack
death rule applied only for reachable units. Maybe it's worth raising a
thread on forum to decide if this behaviour would be appropriate for players?
(file #9809)
17 matches
Mail list logo
