[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta

2013-02-15 Thread pepeto
Update of patch #3698 (project freeciv): Category:None => docs ___ Follow-up Comment #5: > Packets without a key will use the previous packet of the same > kind. Yes. > Packets with

[Freeciv-Dev] [bug #20512] Number of barbarian units created bugs

2013-02-15 Thread Marko Lindqvist
URL: Summary: Number of barbarian units created bugs Project: Freeciv Submitted by: cazfi Submitted on: Fri 15 Feb 2013 02:22:17 PM EET Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #20493] utype_by_number() returns invalid pointer

2013-02-15 Thread pepeto
Update of bug #20493 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed Planned Release: 2.1.10, 2.2.8, 2.3.4, 2.4.0, 2.5.0 => 2.4.0, 2.5.0 __

[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta

2013-02-15 Thread Sveinung Kvilhaugsvik
Follow-up Comment #6, patch #3698 (project freeciv): Thank you for your help, Per. I have attached a new version adding the following explanation: "The old version filled in from is the previous packet of the same kind that has the same value in each key field. (If the packet's kind don't have any

[Freeciv-Dev] [bug #20492] PACKET_UNIT_INFO unused fields

2013-02-15 Thread pepeto
Update of bug #20492 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed Planned Release: 2.5 => 2.5.0 _

[Freeciv-Dev] [patch #3685] dio_get_xxx() returned value

2013-02-15 Thread pepeto
Update of patch #3685 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed Planned Release: => 2.4.0, 2.5.0

[Freeciv-Dev] [patch #3686] dio__float()

2013-02-15 Thread pepeto
Update of patch #3686 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3687] Ensure all packets fields have been correctly read

2013-02-15 Thread pepeto
Update of patch #3687 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3688] dio_put_xxx() cleanup

2013-02-15 Thread pepeto
Update of patch #3688 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread Marko Lindqvist
URL: Summary: dataio.c compiler warnings Project: Freeciv Submitted by: cazfi Submitted on: Fri 15 Feb 2013 03:59:12 PM EET Category: None Severity: 3 - Normal P

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread Marko Lindqvist
Update of bug #20513 (project freeciv): Priority: 5 - Normal => 9 - Immediate Status:None => Ready For Test ___ Follow-up Comment #1: This fixes it for m

[Freeciv-Dev] [bug #20361] Pathfinding may prefer move+attack to simply attacking adjacent target

2013-02-15 Thread pepeto
Update of bug #20361 (project freeciv): Assigned to:None => pepeto Planned Release: => 2.4.0, 2.5.0 ___ Follow-up Comment #7: Attaching simplifie

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread pepeto
Follow-up Comment #2, bug #20513 (project freeciv): It doesn't for me. I will add casts... dataio.c: In function 'dio_get_uint8': dataio.c:501:5: error: format '%ld' expects argument of type 'long int', but argument 7 has type 'unsigned int' [-Werror=format] dataio.c: In function 'dio_get_uint16'

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread pepeto
Follow-up Comment #3, bug #20513 (project freeciv): This one works for me. (file #17204) ___ Additional Item Attachment: File name: sizeof_cast.diff Size:1 KB ___ Re

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread Marko Lindqvist
Follow-up Comment #4, bug #20513 (project freeciv): Casts are no good! It just prevents the warning, but not the bug of using another size variable than what there is memory for. Proper fix will take me a couple of moments... ___ Reply to

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread Marko Lindqvist
Follow-up Comment #5, bug #20513 (project freeciv): This is proving harder than I expected - My MinGW compiler does not support "%zd" (C99 feature) - We cannot rely on inttypes.h to exist, nor has it format identifier that is guaranteed to match site_t on all platforms - Casting size_t to unsigne

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread pepeto
Follow-up Comment #6, bug #20513 (project freeciv): The cast to (unsigned long) is used a bit everywhere in the code... > We can/should move the fc_assert(sizeof(x) == 4) earlier in the > function, before one tries to read 4 bytes to sizeof(x) block. Yes. And it could also be replaced by FC_STAT

[Freeciv-Dev] [bug #20514] gui-xaw doesn't compile

2013-02-15 Thread pepeto
URL: Summary: gui-xaw doesn't compile Project: Freeciv Submitted by: pepeto Submitted on: ven. 15 févr. 2013 16:24:57 CET Category: client-xaw Severity: 3 - Normal

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread Marko Lindqvist
Follow-up Comment #7, bug #20513 (project freeciv): > The cast to (unsigned long) is used a bit everywhere in the > code.. It can hold uint32_t, but not pointer or size_t on win64. ___ Reply to this item at:

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread pepeto
Follow-up Comment #8, bug #20513 (project freeciv): > It can hold uint32_t, but not pointer or size_t on win64. I am sorry for the noise I caused... But I thought that sizeof(long) were equal to 8 bytes on 64 bits computers. ___ Reply to

[Freeciv-Dev] [bug #20516] CMA crash

2013-02-15 Thread anonymous
URL: Summary: CMA crash Project: Freeciv Submitted by: None Submitted on: Fri Feb 15 18:04:00 2013 Category: agents Severity: 3 - Normal Priority: 5 - Normal

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread pepeto
Follow-up Comment #9, bug #20513 (project freeciv): New patch attached which doesn't use the c-format (hard-coded strings). (file #17206) ___ Additional Item Attachment: File name: dio_get_uintxxx.diff Size:0 KB __

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread Marko Lindqvist
Update of bug #20513 (project freeciv): Assigned to:None => cazfi ___ Follow-up Comment #10: I made a version that moves the asserts before this, and turns them to FC_STATIC_ASSERT. I'm g

[Freeciv-Dev] [bug #20513] dataio.c compiler warnings

2013-02-15 Thread Marko Lindqvist
Update of bug #20513 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3699] Handle many ruleset errors

2013-02-15 Thread Marko Lindqvist
URL: Summary: Handle many ruleset errors Project: Freeciv Submitted by: cazfi Submitted on: Sat 16 Feb 2013 02:40:47 AM EET Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1449] [Metaticket] Don't exit the server on ruleset loading failure

2013-02-15 Thread Marko Lindqvist
Update of patch #1449 (project freeciv): Depends on: => patch #3699 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #20504] City defenders rampaging

2013-02-15 Thread Marko Lindqvist
Update of bug #20504 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #20472] [River|Road] move_mode "Relaxed" assumes river/road on adjacent tile

2013-02-15 Thread Marko Lindqvist
Update of bug #20472 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #20514] gui-xaw doesn't compile

2013-02-15 Thread Marko Lindqvist
Follow-up Comment #1, bug #20514 (project freeciv): See also bug #19975 ___ Reply to this item at: ___ Message sent via/by Gna! http://gna.org/ _

[Freeciv-Dev] [bug #19975] dialogs.c:597:7: error: array subscript is above array bounds [-Werror=array-bounds]

2013-02-15 Thread Marko Lindqvist
Update of bug #19975 (project freeciv): Status:None => Duplicate Assigned to:None => cazfi Open/Closed:Open => Closed __

[Freeciv-Dev] [bug #20514] gui-xaw doesn't compile

2013-02-15 Thread Marko Lindqvist
Update of bug #20514 (project freeciv): Severity: 3 - Normal => 5 - Blocker Planned Release: => 2.4.0 ___ Reply to this item at:

[Freeciv-Dev] [patch #3700] Natural roads

2013-02-15 Thread Marko Lindqvist
URL: Summary: Natural roads Project: Freeciv Submitted by: cazfi Submitted on: Sat 16 Feb 2013 03:56:46 AM EET Category: general Priority: 5 - Normal Status: R

[Freeciv-Dev] [patch #3524] Republic of Salé rulset

2013-02-15 Thread Daniel Markstedt
Update of patch #3524 (project freeciv): Status:None => Need Info Assigned to:None => mixcoatl ___ Follow-up Comment #1: Hi Karim. Thanks

[Freeciv-Dev] [patch #3701] Multiple road types

2013-02-15 Thread Marko Lindqvist
URL: Summary: Multiple road types Project: Freeciv Submitted by: cazfi Submitted on: Sat 16 Feb 2013 05:22:20 AM EET Category: general Priority: 5 - Normal Sta

[Freeciv-Dev] [patch #3675] Rivers as road types in rulesets

2013-02-15 Thread Marko Lindqvist
Follow-up Comment #3, patch #3675 (project freeciv): - Made rivers unpillageable - Changed river requirement types in all lists "Special" -> "Road" - Replaced "GeneratedRiver" flag with "River" to apply on top of patch #3695 (file #17213) __

[Freeciv-Dev] [patch #3702] Citylist mutex

2013-02-15 Thread Marko Lindqvist
URL: Summary: Citylist mutex Project: Freeciv Submitted by: cazfi Submitted on: Sat 16 Feb 2013 07:15:59 AM EET Category: general Priority: 5 - Normal Status:

[Freeciv-Dev] [patch #3694] RFC: Cities requesting autosettler work

2013-02-15 Thread Marko Lindqvist
Update of patch #3694 (project freeciv): Planned Release: => 2.5.0 ___ Follow-up Comment #1: Untested first patch for the series. Untested because I have not yet code that would create any

[Freeciv-Dev] [patch #3703] Ruleset sanity checks for barbarian boats

2013-02-15 Thread Marko Lindqvist
URL: Summary: Ruleset sanity checks for barbarian boats Project: Freeciv Submitted by: cazfi Submitted on: Sat 16 Feb 2013 09:50:50 AM EET Category: general Priority: 5 - Normal