[Freeciv-Dev] [patch #5624] Move the TradeRoute unit type flag to the ruleset

2014-12-31 Thread Sveinung Kvilhaugsvik
Update of patch #5624 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

2014-12-31 Thread Jacob Nevins
Follow-up Comment #3, patch #4949 (project freeciv): Sorry to jump in on this so late, after you have done work... We have a couple of switch - case constructs with a lot of cases (packet handling has a case for each packet number, ai effect evaluation for each effect type). While I haven't

[Freeciv-Dev] [patch #5629] Move the move fragment cost of trying to do an illegal action to the ruleset.

2014-12-31 Thread Sveinung Kvilhaugsvik
Update of patch #5629 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #5013] Maglev graphics for all supplied tilesets

2014-12-31 Thread Jacob Nevins
Follow-up Comment #4, patch #5013 (project freeciv): Once new files are added to amplio in version control, also .modpack file on the modpack server should be updated to install the new files. I've just done this on modpack.freeciv.org for S2_5. I don't have access to fix the trunk/2.6 on on

[Freeciv-Dev] [patch #5626] AI: Request a unit that can help wonder when considering to build a unit.

2014-12-31 Thread Sveinung Kvilhaugsvik
Update of patch #5626 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #5628] Rulesets: Remove custom UI name of unused actions.

2014-12-31 Thread Sveinung Kvilhaugsvik
Update of patch #5628 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #5630] Send the correct action to maybe_cause_incident()

2014-12-31 Thread Sveinung Kvilhaugsvik
Update of patch #5630 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #23127] Typo'd name ui_name_posion_city in ruleset definition

2014-12-31 Thread Jacob Nevins
URL: http://gna.org/bugs/?23127 Summary: Typo'd name ui_name_posion_city in ruleset definition Project: Freeciv Submitted by: jtn Submitted on: Wed 31 Dec 2014 11:58:25 UTC Category: None Severity: 3 -

[Freeciv-Dev] [patch #5632] Backport genhash optimizations to S2_5

2014-12-31 Thread Jacob Nevins
Follow-up Comment #3, patch #5632 (project freeciv): Porting this to S2_5 is fine by me. S2_5 is not yet even in release candidate stage. ___ Reply to this item at: http://gna.org/patch/?5632

[Freeciv-Dev] [patch #5637] Use NationGroup requirement for barbarian effects

2014-12-31 Thread Jacob Nevins
URL: http://gna.org/patch/?5637 Summary: Use NationGroup requirement for barbarian effects Project: Freeciv Submitted by: jtn Submitted on: Wed 31 Dec 2014 13:50:58 UTC Category: rulesets Priority: 5 -

[Freeciv-Dev] [patch #5637] Use NationGroup requirement for barbarian effects

2014-12-31 Thread Jacob Nevins
Update of patch #5637 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-barbarian-nationgroup.patch Size:17 KB

[Freeciv-Dev] [patch #5631] AI: Ask for a help wonder unit when calculating wonder city distance

2014-12-31 Thread Sveinung Kvilhaugsvik
Update of patch #5631 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #23128] Trouble in pick nation dialog after changing ruleset with hidden nation groups

2014-12-31 Thread Jacob Nevins
URL: http://gna.org/bugs/?23128 Summary: Trouble in pick nation dialog after changing ruleset with hidden nation groups Project: Freeciv Submitted by: jtn Submitted on: Wed 31 Dec 2014 14:34:03 UTC Category:

[Freeciv-Dev] [bug #23129] Pick nation notebook not suppressed if hidden nation groups exist

2014-12-31 Thread Jacob Nevins
URL: http://gna.org/bugs/?23129 Summary: Pick nation notebook not suppressed if hidden nation groups exist Project: Freeciv Submitted by: jtn Submitted on: Wed 31 Dec 2014 14:41:35 UTC Category: client-gtk-2.0

[Freeciv-Dev] [patch #5638] Building Advicor: Ask for a help wonder unit when picking wonder city.

2014-12-31 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?5638 Summary: Building Advicor: Ask for a help wonder unit when picking wonder city. Project: Freeciv Submitted by: sveinung Submitted on: Wed 31 Dec 2014 02:42:12 PM UTC Category: None

[Freeciv-Dev] [bug #23128] Trouble in pick nation dialog after changing ruleset with hidden nation groups

2014-12-31 Thread Jacob Nevins
Update of bug #23128 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-gtk-hidden-group-ruleset-change.patch Size:1 KB

[Freeciv-Dev] [bug #23129] Pick nation notebook not suppressed if hidden nation groups exist

2014-12-31 Thread Jacob Nevins
Update of bug #23129 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-gtk-hidden-group-suppress-tabs.patch Size:3 KB

[Freeciv-Dev] [bug #23127] Typo'd name ui_name_posion_city in ruleset definition

2014-12-31 Thread Jacob Nevins
Update of bug #23127 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn ___ Reply to this item at:

[Freeciv-Dev] [patch #5629] Move the move fragment cost of trying to do an illegal action to the ruleset.

2014-12-31 Thread Marko Lindqvist
Follow-up Comment #2, patch #5629 (project freeciv): Sorry to comment only after this has been committed, but somehow I missed that it's an effect earlier. Do you have a specific reason you've made it an effect instead of single value like similar igter_cost in terrain.ruleset? I don't see you

[Freeciv-Dev] [patch #5639] Move the HelpWonder unit type flag to the ruleset.

2014-12-31 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?5639 Summary: Move the HelpWonder unit type flag to the ruleset. Project: Freeciv Submitted by: sveinung Submitted on: Wed 31 Dec 2014 03:25:20 PM UTC Category: None Priority: 5

[Freeciv-Dev] [patch #5639] Move the HelpWonder unit type flag to the ruleset.

2014-12-31 Thread Sveinung Kvilhaugsvik
Update of patch #5639 (project freeciv): Depends on: = patch #5625 ___ Reply to this item at: http://gna.org/patch/?5639 ___ Message sent

[Freeciv-Dev] [patch #4783] [Metaticket] Savegame compatibility in 3.0

2014-12-31 Thread Jacob Nevins
Update of patch #4783 (project freeciv): Depends on: = patch #5591 ___ Reply to this item at: http://gna.org/patch/?4783 ___ Message sent

[Freeciv-Dev] [patch #4783] [Metaticket] Savegame compatibility in 3.0

2014-12-31 Thread Jacob Nevins
Follow-up Comment #1, patch #4783 (project freeciv): - savegame.c will be removed, dropping support for loading savegames older than those from freeciv-2.3 What's the motivation behind this? Just to reduce our maintenance burden? Personally I haven't found maintaining savegame.c, nor fixing

[Freeciv-Dev] [patch #5011] civ2civ3: default to team_pooled_research=FALSE

2014-12-31 Thread Jacob Nevins
Update of patch #5011 (project freeciv): Status:None = Wont Do Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4783] [Metaticket] Savegame compatibility in 3.0

2014-12-31 Thread Marko Lindqvist
Follow-up Comment #2, patch #4783 (project freeciv): What's the motivation behind this? Just to reduce our maintenance burden? Yes. Good point about the 2.3 release date. I had been thinking 2.2 (latest version of dropped support) date but of course that was all people had all the way until

[Freeciv-Dev] [patch #5591] Drop savegame.[ch]

2014-12-31 Thread Marko Lindqvist
Update of patch #5591 (project freeciv): Status: Ready For Test = Postponed ___ Follow-up Comment #1: Postponed based on discussion in patch #4783

[Freeciv-Dev] [patch #5639] Move the HelpWonder unit type flag to the ruleset.

2014-12-31 Thread Sveinung Kvilhaugsvik
Update of patch #5639 (project freeciv): Status: Ready For Test = In Progress ___ Follow-up Comment #1: Causes assertion failures ___ Reply

[Freeciv-Dev] [patch #5634] Put the rule that empty cities cost half as much in the ruleset.

2014-12-31 Thread Marko Lindqvist
Follow-up Comment #1, patch #5634 (project freeciv): Your modifications do not work correctly with Courthouse. It used to be (100 + 300)% * 0.5 = 200% with the patch: (100 + 300 - 50)% = 350% ___ Reply to this item at: