[Freeciv-Dev] (PR#39901) Patch: Fix permission on open() call

2007-11-25 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39901 > Please use the email interface, your comments were not sent to the list. > Not really, it's more of a security thing. > > Quote from one of our kernel guys: "The problem is that without a mode > being passed, the kernel uses whatever the st

Re: [Freeciv-Dev] (PR#39901) Patch: Fix permission on open() call

2007-11-25 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39901 > William Allen Simpson wrote: > Is this a Fedora only kind of thing? > So, I did a bit of Googling, and there are a number of other reports about Fedora and this new requirement As a long-time BSD contributor, one of the things that anno

Re: [Freeciv-Dev] (PR#39901) Patch: Fix permission on open() call

2007-11-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39901 > > open() with O_CREAT in its second argument needs to have a third argument > That's not accurate. Only when you wish to restrict the file mode mask. Without looking hard at this code, I don't see any reason we'd want to restrict the mask.

[Freeciv-Dev] (PR#39901) Patch: Fix permission on open() call

2007-11-24 Thread
http://bugs.freeciv.org/Ticket/Display.html?id=39901 > open() with O_CREAT in its second argument needs to have a third argument Thanks, Brian Pepple Index: client/connectdlg_common.c === --- client/connectdlg_common.c (revision 14