Re: [Freeciv-Dev] (PR#40016) 2.1.2 assert - message pane after turn done

2008-01-15 Thread Jason Dorje Short

http://bugs.freeciv.org/Ticket/Display.html?id=40016 >

On Jan 15, 2008 12:30 PM, William Allen Simpson
<[EMAIL PROTECTED]> wrote:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=40016 >
>
> Jason Short wrote:
> > This is the same as 39991 which explains the cause.
>
> And had you actually read the ticket, you'd have seen the link.  It's not
> exactly the same, but they are related.

Seriously man, I am getting incredibly frustrated at your snide
remarks "go read the ticket" for every reply to a bug report.  Yes,
this bug is *exactly* the same as the first one reported in 39991.
How else would I have known that except by reading the tickets?

On a more constructive note, this can probably be solved by processing
the GUI event queue right before clearing the messages list.

-jason



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#40016) 2.1.2 assert - message pane after turn done

2008-01-15 Thread William Allen Simpson

http://bugs.freeciv.org/Ticket/Display.html?id=40016 >

Jason Short wrote:
> This is the same as 39991 which explains the cause.

And had you actually read the ticket, you'd have seen the link.  It's not
exactly the same, but they are related.



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40016) 2.1.2 assert - message pane after turn done

2008-01-15 Thread Jason Short

http://bugs.freeciv.org/Ticket/Display.html?id=40016 >

This is the same as 39991 which explains the cause.  The message click
is being dequeued after the next turn has started, meaning the message
list was already reset.  So it tries to activate message 5 (say) but the
message list is of length 0.

There needs to either be a check for this case (including the turn # in
the queued event, assuming the turn is incremented at the same time the
message queue is cleared, and assuming that's even possible which in the
GTK case it may not be), or we could allow it by tracking old messages
(keeping a message queue for each turn, say, which could then be flipped
through...and on the same note the message queue should be saved and
stored at the server end then so it will come back after a game is
reloaded).

Although 3991 says this is a problem under GTK and SDL on further
thought I'm dubious it could happen in the GTK event system.

-jason


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40016) 2.1.2 assert - message pane after turn done

2008-01-14 Thread William Allen Simpson

http://bugs.freeciv.org/Ticket/Display.html?id=40016 >

Thank you, that helps narrow down a previously reported problem.

However, I'm not personally able to reproduce.  I'll try staring at the 
code to see whether anything leaps to mind


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev