[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[pepeto]

Update of bug #13873 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[pepeto]

Update of bug #13873 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Matthias Pfafferodt]

Follow-up Comment #12, bug #13873 (project freeciv):

updated version; changes:

* loop over all entries in the [settings] section in the ruleset file
* for each entry check if it is a valid setting


(file #7854)
___

Additional Item Attachment:

File name: 0002-save-game-settings-in-game.ruleset.patch Size:15 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[pepeto]

Update of bug #13873 (project freeciv):

  Status:None => In Progress

___

Follow-up Comment #11:

I don't like how setting_ruleset() works.  Maybe you could convince me the
way you choose.  For the moment, this is my argumentation.

You iterate all settings, and attempt to take their value in the file.  In a
such implementation, I think the best would be to use secfile_lookup_str(),
secfile_lookup_int() and secfile_lookup_bool() instead of a their _default
variant.

Another approach would be to iterate all the entries of the ruleset file and
try to match the settings.  I guess this could be the best solution because
usually, there are not a lot of settings defined in the ruleset.  Also, this
would allow to warn the user if he misspelled one setting (no match).


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Matthias Pfafferodt]

Follow-up Comment #10, bug #13873 (project freeciv):

I created an rebased version and the patch now uses the new ruleset functions
- but it are only a few calls to them.

(file #7790)
___

Additional Item Attachment:

File name: 0002-save-game-settings-in-game.ruleset.patch Size:15 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[pepeto]

Update of bug #13873 (project freeciv):

 Assigned to:   cazfi => pepeto 

___

Follow-up Comment #9:

This patch could be improved a lot with the new registry interface.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Daniel Markstedt]

Update of bug #13873 (project freeciv):

 Planned Release: => 2.3.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Matthias Pfafferodt]

Follow-up Comment #8, bug #13873 (project freeciv):

updated patch; changes:

* restore all game settings, if the game is stopped by /end

(file #6969)
___

Additional Item Attachment:

File name: update20091011-0001-save-game-settings-in-game.ruleset.diff
Size:15 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Matthias Pfafferodt]

Follow-up Comment #7, bug #13873 (project freeciv):

updated version; changes:

* loading a savegame will first restore the ruleset (with possible changes to
the settings) and after that restore the savegame and the setting values saved
within the savegame


(file #6957)
___

Additional Item Attachment:

File name: settings20091010-0005-save-game-settings-in-game.ruleset.diff
Size:15 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Matthias Pfafferodt]

Follow-up Comment #6, bug #13873 (project freeciv):

rebased version of the patch:

save game settings in game.ruleset

* rulesetdir will first do a reset and
  after that load the new ruleset

* reset will restore settings from the
  ruleset

(file #6687)
___

Additional Item Attachment:

File name: 0007-save-game-settings-in-game.ruleset.diff Size:10 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Matthias Pfafferodt]

Follow-up Comment #5, bug #13873 (project freeciv):

updated patch for reset command

the points mentioned in the last comments
will be implemented in patch 8-11 (they
can be found in the tracker patches)

(file #6256)
___

Additional Item Attachment:

File name: 0007-implement-reset-command-with-settings.patch Size:7 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Matthias Pfafferodt]

Follow-up Comment #4, bug #13873 (project freeciv):

this could be done with an extra line in the
game.ruleset file

[game]
; define the game setting
borders = 2
; lock it (first player is _not_ allowed to change it)
borders.lock = 1

The .lock defaults to FALSE. If it is
true, the setting can't be changed. This requires
that the 'rulesetdir' command can't be executed by
the first player.

Does warclient/warserver has such an option?


First I have to solve the main problem. My ideas are:

* 'rulesetdir' command loads the ruleset + settings
  from the game.ruleset file

* The reset command has to restore all settings to the
  default values and load the settings from the
  game.ruleset file. An additional hint to changed
  settings could be added.

* executing 'rulesetdir' again does check if another
  ruleset is requested. If it is not the case, the
  current code will do nothing. This must be
  changed to a reset (= default settings + changes
  from the game.ruleset file). This way one will have
  a well defined state after executing the rulesetdir
  command.


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Marko Lindqvist]

Follow-up Comment #3, bug #13873 (project freeciv):

I just thought of feature which could be built on top of these patches, I
assume.

I run public servers with custom rulesets (in addition to default ruleset
ones). With these servers I'd sometimes like to further limit what settings
changes first player is able to do. Ruleset may have its own special flavor
coming from certain settings. It's a waste of these custom ruleset server
instances if first player turns them in to more generic Freeciv games (for
which there already is plenty of servers).
So ruleset could mark some settings locked, so that they cannot be changed.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Marko Lindqvist]

Follow-up Comment #2, bug #13873 (project freeciv):

> contra
> - two ways to set the values; confusion?

I'm not so sure it would cause much confusion as one way is used primarily by
players and the other by modpack authors. Of course you have to be careful in
implementing it so that player settings have higher priority than ones from
ruleset.

I'm a bit undecided if I like this feature or not. In any case, reset command
has higher priority.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Matthias Pfafferodt]

Follow-up Comment #1, bug #13873 (project freeciv):

loading game settings from the ruleset and the reset
command are exclusive at the moment. For both to work,
an additional variable ([b|i|s]val_ruleset) would be
needed for each setting to restore the corresponding
value.

So I would like a discussion about the pro and cons
of loading game settings from the ruleset file.

pro
- all settings in one file (scenarios!)

contra
- two ways to set the values; confusion?

more arguments?

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file

[Matthias Pfafferodt]

URL:
  

 Summary: [patch 07/07] load game settings from ruleset file
 Project: Freeciv
Submitted by: syntron
Submitted on: Sonntag 05.07.2009 um 22:21
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

load game settings from ruleset file

* small correction for setting_check()

* further simplification possible?



___

File Attachments:


---
Date: Sonntag 05.07.2009 um 22:21  Name:
07-load-game-settings-from-ruleset-file.patch  Size: 7kB   By: syntron



___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev