[Freeciv-Dev] [bug #14584] Bribing city and CMA

[pepeto]

Update of bug #14584 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14584] Bribing city and CMA

[pepeto]

Follow-up Comment #5, bug #14584 (project freeciv):

Same as bug #13607.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14584] Bribing city and CMA

[pepeto]

Update of bug #14584 (project freeciv):

  Status:   Confirmed => Ready For Test 
 Assigned to:None => pepeto 

___

Follow-up Comment #4:

Fix attached.


(file #7100)
___

Additional Item Attachment:

File name: trunk_S2_2_client_transfer_city.diff Size:4 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14584] Bribing city and CMA

[pepeto]

Follow-up Comment #3, bug #14584 (project freeciv):

> The problem is that transfering a city sends a
> packet_city_remove and packet_city_info to create a new city.

Ok, I was wrong it doesn't anymore.

> Maybe the client should able to handle the city owner change
> from the packet_city_info?

It already does that.  So I will find an easy way to fix the bug.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14584] Bribing city and CMA

[pepeto]

Follow-up Comment #2, bug #14584 (project freeciv):

I found what was wrong.  But I am not sure I will be able to fix that
easily.

The problem is that transfering a city sends a packet_city_remove and
packet_city_info to create a new city.  The client removes the city first,
and call game_remove_city() which set to NULL all worked tiles.  But the
delta stuff assumes the client didn't change illegally any worked info, so
don't send the new information.

I am unsure about how to resolve this.  It's a very big bug in S2_2.  Maybe
the client should able to handle the city owner change from the
packet_city_info?


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14584] Bribing city and CMA

[pepeto]

Update of bug #14584 (project freeciv):

  Status:None => Confirmed  
 Planned Release:None => 2.2.0  

___

Follow-up Comment #1:

It also occurs when conquering a city.  Take Bochum in the attached savegame
to reproduce.


(file #7088)
___

Additional Item Attachment:

File name: test.sav.gzSize:78 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14584] Bribing city and CMA

[pepeto]

URL:
  

 Summary: Bribing city and CMA
 Project: Freeciv
Submitted by: pepeto
Submitted on: jeudi 22.10.2009 à 21:39
Category: client
Severity: 2 - Minor
Priority: 3 - Low
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: None

___

Details:

From mrvn from IRC:
> And the other one is that in a freshly bribed city when you turn
> on the governer it can happen that it gets confused and the city
> only shows the city tile used but the stats show 2 tiles being
> worked on. The cities poeple also show as being farmers.
>
> Not sure how to reliably reproduce the second.
>
> Only restarting the client solves the second problem.

This also could have caused bug #13607.





___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev