[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Update of bug #19296 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Follow-up Comment #13, bug #19296 (project freeciv): btw. I just got cross-compilation on one machine to work by applying this patch. There was Magickwand-config for host system but not for target system. It found one for host system and tried to build with CFLAGS and LIBS it provided. ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Follow-up Comment #12, bug #19296 (project freeciv): We want to know if we can link programs together, not if we can run them on build machine. Testing the latter breaks cross-compilation. Attached version of the patch uses AC_LINK_IFELSE() instead of AC_RUN_IFELSE() (file #16039) ___ Additional Item Attachment: File name: MwAcLink.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Follow-up Comment #10, bug #19296 (project freeciv): Almost six months since the previous discussion. There were different opinions earlier, but since this long has passed without anybody replying to my last argument Still, better to find out it, with better error diagnostics, configure time than to have unexplained compile or link time error I assume we found agreement. ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Follow-up Comment #11, bug #19296 (project freeciv): ...more like I agreed that it's your choice. Some projects like adding AC_CHECK_LIB checks even for packages having upstream pkg-config files, others tend to rely just on pkg-config in such cases and not fix broken distros. A matter of taste, really. ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Follow-up Comment #8, bug #19296 (project freeciv): This is currently targeted at 2.3.2, but I wouldn't expect S2_3 to depend on MagickWand (since mapimg is new in 2.4)? ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Follow-up Comment #9, bug #19296 (project freeciv): Related to bug #18539? ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Follow-up Comment #5, bug #19296 (project freeciv): pkg-config --libs MagickWand -lMagickWand -lMagickCore and at least as of ImageMagick 6.7.4.0 MagickWand-config --libs MagickWand-config --libs the output is the same. Correct - but it wasn't on opensuse. If you got to the bug I opened you will find that it will be fixed in the next version. I think, doing the compiling check is a save way to go. On the other hand, it might just be another (odd) freciv policy - you still use the whole AM_PATH_GTK_2_0 macro; most packages simply rely on pkg-config here, instead of that compile check. No, I do not think is is a policy to use use old macros. But often the old ones are not changed till they do not work anymore. In the case you mentioned, the information of the macro is also available via a pkg-config call? Do you know other things which should be checked? ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Update of bug #19296 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #3: Test linkage for whole WAND_LIBS would be cleaner and would also catch other problematic libraries, not just libbz2. Done by the patch; Thanks for the hint - more learned about the internals of the tools I use ;-) why isn't freeciv simply using pkg-config for this and serveral other checks ? If that's broken, most of your build system like is. MagickWand has its own tools (MagickWand-config) which are used. They report -lbz2 as a dependency but the corresponding development packages are not automatically installed. I have reported it at the opensuse bug tracker at https://bugzilla.novell.com/show_bug.cgi?id=741947 (file #14811) ___ Additional Item Attachment: File name: 0016-fix-check-for-MagickWand-libbzip2.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Follow-up Comment #4, bug #19296 (project freeciv): Hmmm... 2008-02-03 6.3.8-5 Cristy quetzlzacatenango@image... ... Add Magick++-config, MagickCore.pc, MagickWand.pc, Magick++.pc Is this old enough ? pkg-config --libs MagickWand -lMagickWand -lMagickCore and at least as of ImageMagick 6.7.4.0 MagickWand-config --libs the output is the same. Again, this may simply be a freeciv policy, but adding workarounds for *distro* packaging errors seems an odd solution. If a distro builds freeciv, they'll add the dep, once it fails to run, if a user has the problem, they should bug their distro. On the other hand, it might just be another (odd) freciv policy - you still use the whole AM_PATH_GTK_2_0 macro; most packages simply rely on pkg-config here, instead of that compile check. ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
URL: http://gna.org/bugs/?19296 Summary: fix check for MagickWand (libbzip2) Project: Freeciv Submitted by: syntron Submitted on: Mon 16 Jan 2012 08:07:53 PM CET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.2, 2.4.0, 2.5.0 ___ Details: ___ File Attachments: --- Date: Mon 16 Jan 2012 08:07:53 PM CET Name: 0017-fix-check-for-MagickWand-libbzip2.patch Size: 1kB By: syntron http://gna.org/bugs/download.php?file_id=14806 ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Update of bug #19296 (project freeciv): Status: Ready For Test = In Progress Assigned to:None = cazfi ___ Follow-up Comment #1: Quite a kludge, with dependencies to things like wc. Test linkage for whole WAND_LIBS would be cleaner and would also catch other problematic libraries, not just libbz2. IIRC there already was ticket for this... ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)
Follow-up Comment #2, bug #19296 (project freeciv): Is there a point of adding workarounds in freeciv for distro packaging errors ? Cause that's what this patch seems to be. If libMagickWand is built with bzip2 support and distro management system doesn't pull it in, it's the distro problem. libMagickWand can depend on up to about two dozen various libs. On more generic note: why isn't freeciv simply using pkg-config for this and serveral other checks ? If that's broken, most of your build system like is. ___ Reply to this item at: http://gna.org/bugs/?19296 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
