[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
Update of bug #19921 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
Update of bug #19921 (project freeciv): Status:None = Ready For Test Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
Follow-up Comment #5, bug #19921 (project freeciv): Raised longstanding déjà vu effect separately as bug #19946. ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
Follow-up Comment #6, bug #19921 (project freeciv): BTW, why does it seem that on an isohex map when moving in cardinal directions (N/S/E/W), N/S moves seem far slower than E/W ? Not sure what you mean here? -- on an iso|hex topology, you can only move N/S, you can't move directly E/W. I can't reproduce any variation in movement times in either the Gtk2 or Gtk3 clients. ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
Follow-up Comment #7, bug #19921 (project freeciv): However, I can confirm that the attached patch solves my problem. ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
Follow-up Comment #8, bug #19921 (project freeciv): My mistake - that was simply iso, not isohex (Amplio2, if it matters). Not that I looked closer at the code, but I suspect it's the method of measuring the distance that plays a role here - I was testing by setting very high Unit Movement Animation Time and N/S delays differed from S/W ones significantly. ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
Follow-up Comment #1, bug #19921 (project freeciv): So,... Adding 'gdk_window_process_updates(gtk_widget_get_window(map_canvas), FALSE);' in void flush_dirty(void) seems to get the desired effect (that is IIUC what the desired effect is), but there's a tiny catch. In my save I've got a combined airbase/fortress with one guerrilla unit and a few engineers. If I select the guerrilla and move it a bit around the base (lots of railroads around), I'm getting a sort of reverse deja vu as I move the unit back to the base. That is the unit gets drawn in the base while it's still moving there. It would seem that this is not the problem in this particular client, but in common client code. BTW, why does it seem that on an isohex map when moving in cardinal directions (N/S/E/W), N/S moves seem far slower than E/W ? ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
Follow-up Comment #2, bug #19921 (project freeciv): That is the unit gets drawn in the base while it's still moving there. Yeah, I see that sort of thing a lot in the Gtk2 client. Also with transports containing lots of units, I think. Never got round to investigating it. --jtn ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
Follow-up Comment #3, bug #19921 (project freeciv): I noticed comment in move_unit_map_canvas() about setting up target tile first, and wondered wouldn't it cause such problems of unit being drawn there before move animation. Maybe it was considered something that nobody's brain would register in the fractions of the second unit moves. ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
Follow-up Comment #4, bug #19921 (project freeciv): In such case, lets add that call to try to solve the initial problem. Still, that speed difference is odd. (file #16063) ___ Additional Item Attachment: File name: update-map-anim.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible
URL: http://gna.org/bugs/?19921 Summary: Intermediate animation steps in map update not visible Project: Freeciv Submitted by: jtn Submitted on: Wed Jul 11 01:07:04 2012 Category: client-gtk-3.0 Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: GNU/Linux Planned Release: 2.4.0,2.5.0 ___ Details: As posted to freeciv-dev http://mail.gna.org/public/freeciv-dev/2012-07/msg00147.html: Not sure if this is a bug or expected behaviour. With the Gtk3 client, I've noticed that intermediate updates to the map don't seem to be drawn. For instance if I start a game and then hit X on my Explorer, he instantly appears three tiles away, whereas with the Gtk2 client, I see all the intermediate steps. (My Gtk3 machine is a slowish netbook, in case it makes a difference.) cazfi responded: Even if it's expected result of the way buffering (or something) has been made, this has to be fixed somehow. I confirmed this by setting very high Unit Movement Animation Time. When I then moved a unit, nothing happened for a while (time I set) and then unit appeared in its target tile. I also added logging to move_unit_map_canvas() to show coordinates it tries to draw unit to, and that number changed pixel by pixel from old tile to new one. ___ Reply to this item at: http://gna.org/bugs/?19921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
