Update of bug #20095 (project freeciv):
Status: Ready For Test = Fixed
Assigned to:None = cazfi
Open/Closed:Open = Closed
Update of bug #20095 (project freeciv):
Status: In Progress = Ready For Test
___
Follow-up Comment #21:
- As LUA_AS_DEPENDENCY gets obsolete, remove it completely.
Even if TOLUA_AS_DEPENDENCY is not
Follow-up Comment #20, bug #20095 (project freeciv):
New bug raised as bug #20109
___
Reply to this item at:
http://gna.org/bugs/?20095
___
Message sent via/by Gna!
http://gna.org/
Follow-up Comment #13, bug #20095 (project freeciv):
Both Marko's and Rafał's patches avoid the error (trunk).
Only Marko's patch apply cleanly to S2_4, and I confirmed that it avoids the
error, and that it is possible to launch the server/client and play a turn.
On trunk, however, compilation
Follow-up Comment #14, bug #20095 (project freeciv):
Well, on S2_4 the patch looks differently, mainly due to tree moves and
freciv-web.
This one is same revision, for S2_4.
Your new error regards readline.
(file #16448)
___
Additional
Follow-up Comment #15, bug #20095 (project freeciv):
The last part of my last comment was a bit silly.
I should have said the new problem is due to the change from patch #3436 and
regards readline.
___
Reply to this item at:
Follow-up Comment #16, bug #20095 (project freeciv):
stdinhand.c:6877: error: ‘rl_completion_suppress_append’ undeclared
(first use in this function)
Huh. Can you raise a new ticket for this?
(In it, can you say what version of readline you have? Although I can't
imagine too-old-readline is the
Follow-up Comment #17, bug #20095 (project freeciv):
Although I can't imagine too-old-readline is the issue
Without checking the code, is it properly inside #ifdef HAVE_READLINE (or
similar)? While too old readline doesn't sound realistic reason, compiling
without readline support could be.
Follow-up Comment #18, bug #20095 (project freeciv):
On an interesting note, each of these patches seems to make those three lua
*_AS_DEPENDENCY vars redundant for their respective trees.
I wonder though: is there any reason (other than not compiling the file twice)
for not simply listing
Follow-up Comment #3, bug #20095 (project freeciv):
How about also moving them to _LDADD from _LDFLAGS?
(file #16436, file #16437)
___
Additional Item Attachment:
File name: ToluaLDADD.patch Size:0 KB
File name:
Follow-up Comment #4, bug #20095 (project freeciv):
Strangely enough, still bailing out with the same message. (And yes, I ran
make clean and autogen.sh inbetween...)
Here are a couple of massive logs, if this helps you at all.
(file #16439)
Follow-up Comment #5, bug #20095 (project freeciv):
Too massive for Gna, so now here cropped in half.
(file #16440)
___
Additional Item Attachment:
File name: daniel-make.txtSize:455 KB
Follow-up Comment #6, bug #20095 (project freeciv):
Perhaps a silly question, but does OS X have a *separate* libm ?
(IIRC, that's a valid question for i.e. OpenBSD (or was that just about were
*some* of math functions are ?))
Also, both LUA_AS_DEPENDENCY and LUA_LIBS carry '-lm'.
As for the
Follow-up Comment #7, bug #20095 (project freeciv):
Looking at tolua-5.1/src/bin/Makefile.am again, *unless* I'm missing
something, after changing _LDFLAGS to _LDADD it would seem tolua_DEPENDENCIES
are redundant - see if removing it helps.
Update of bug #20095 (project freeciv):
Status: Ready For Test = In Progress
___
Follow-up Comment #8:
Also, both LUA_AS_DEPENDENCY and LUA_LIBS carry '-lm'.
Oh, that explains it. LUA_AS_DEPENDENCY
Follow-up Comment #9, bug #20095 (project freeciv):
Fix to not to pollute LUA_AS_DEPENDENCY with -lm. Note that all places that
link against liblua are affected - tolua just happens to be first one.
_LDFLAGS - _LDADD change was just a test, and I don't think it's even right
thing to do (we are
Follow-up Comment #10, bug #20095 (project freeciv):
What about what I've wrote in comment #7 ?
After all, the reason dependencies were not computed correctly before was
exactly that those libs were passed via _LDFLAGS instead of _LDADD.
Follow-up Comment #11, bug #20095 (project freeciv):
...also passing '-lm' to libtolua_la_LIBADD (if it's actually needed there and
not for liblua itself) should make it easier to propagate it down the tree.
___
Reply to this item at:
Follow-up Comment #12, bug #20095 (project freeciv):
OK, it's better to write the patch on your own.
This is against trunk r21843.
freeciv-server, freeciv-manual, freeciv-modpack and gtk2/gtk3 clients seems to
build correctly with it.
Please test.
(file #16445)
Update of bug #20095 (project freeciv):
Status:None = Ready For Test
Planned Release: = 2.4.0, 2.5.0
___
Follow-up Comment #1:
Does dropping of
Follow-up Comment #2, bug #20095 (project freeciv):
I'm having the same problem as David, OS X 10.6.
The patch didn't help in my case, S2_4 and trunk.
___
Reply to this item at:
http://gna.org/bugs/?20095
21 matches
Mail list logo
