[Freeciv-Dev] [bug #20690] maxplayers setting does not prevent midgame player /create

[Marko Lindqvist]

Update of bug #20690 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20690] maxplayers setting does not prevent midgame player /create

[Marko Lindqvist]

Follow-up Comment #3, bug #20690 (project freeciv):

- Removed accidental change to player.h

(file #17753)
___

Additional Item Attachment:

File name: MaxplayersNewcomer-2.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20690] maxplayers setting does not prevent midgame player /create

[Marko Lindqvist]

Update of bug #20690 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

I think we must postpone restricting newcomer creation, and civil war player
creation, by maxplayers setting. Newcomer creation part is anyway unimportant
in that player requests it explicitly, and thus current behavior can be
considered just user-friendlier way to do two player actions "increase
maxplayers" + "create player". Civil war I consider a bit more a problem, as
that can increase number of players over maxplayers even when that's not
desired (most important use-case for me would be, as a public server operator,
to limit number of players with ruleset-locked maxplayer setting)

Anyway, attached patch fixes the newcomer creation to work in respect to
maxplayers similar to civil war - increase maxplayers if it's reached, so that
player count does not end up bigger than maxplayers limit.

(file #17712)
___

Additional Item Attachment:

File name: MaxplayersNewcomer.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20690] maxplayers setting does not prevent midgame player /create

[Marko Lindqvist]

Update of bug #20690 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #1:

Given that "maxplayers" value cannot be currently changed in running game, and
that bug #20689 has caused it to be set to number of players in game start (=
if nobody has died it's equal to current players) in old savegames already
gone over one save/load cycle before, using the setting against midgame player
creation would block cases where it should be allowed.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20690] maxplayers setting does not prevent midgame player /create

[Marko Lindqvist]

URL:
  

 Summary: maxplayers setting does not prevent midgame player
/create
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 31 Mar 2013 02:39:37 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0, 2.5.0

___

Details:

One can /create players to running game without maxplayers setting any way
restricting it. Fix attached.



___

File Attachments:


---
Date: Sun 31 Mar 2013 02:39:37 AM EET  Name: MidgameMaxplayers.patch  Size:
670B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev