[Freeciv-Dev] [bug #20844] Effects.ruleset [effect_maint_player] has unknown req: Building" "Service Shop"

2013-05-29 Thread anonymous
Follow-up Comment #3, bug #20844 (project freeciv):

when i shifted from[building_work_bay]
name= _("Service Bay")
genus   = "Improvement"
reqs=
{ "type", "name", "range"
  "Tech", "Invention", "Player"
  "MinSize", "10", "City"
}
To

[building_work_bay]
name= _("Service Bay")
genus   = "SmallWonder"
reqs=
{ "type", "name", "range"
  "Tech", "Invention", "Player"
  "MinSize", "10", "City"
}

And removed the extra service bays Fixed the Problem now get the upgraded
units. thanks for the help.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20844] Effects.ruleset [effect_maint_player] has unknown req: Building" "Service Shop"

2013-05-29 Thread anonymous
Follow-up Comment #2, bug #20844 (project freeciv):

i have noticed on several of my ruleset tweks this type of error. part of why
i used improvement is that in ver 2.? i was able to get a similer building to
work on player. i was trying to get the service shop made that required me to
get the units to where the city was woking tiles to have a unit upgraded. 
i would be nice if someone would document more on the effects for valid
ranges, and aplied to 

ie 
upgrade_unit valid for wonders and small wanders only valid range of player or
world.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20844] Effects.ruleset [effect_maint_player] has unknown req: Building" "Service Shop"

2013-05-28 Thread Emmet Hikory
Follow-up Comment #1, bug #20844 (project freeciv):

This would require changes to unittools.c:do_upgrade_effects(), as the current
logic only checks for upgrade counts on a per-player basis, meaning that only
World and Player ranges can be used to control the Upgrade_Unit effect (as
there is no available information regarding the continent, city, tile, etc.).

That aside, I'm not sure why the Building is an unknown requirement: looks
like it might be a missing comma from the error message, but that's a wild
guess (as I don't see the corresponding missing comma in the presented ruleset
code).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [bug #20844] Effects.ruleset [effect_maint_player] has unknown req: Building" "Service Shop"

2013-05-28 Thread Vasco Alexandre da Silva Costa
"Player" range is used for small wonders. If the building is not a small
wonder it won't work.
"City" is the range used for checking if a particular city has that
improvement.


On Sat, May 25, 2013 at 4:59 PM, anonymous  wrote:

> URL:
>   
>
>  Summary: Effects.ruleset [effect_maint_player] has unknown
> req: Building" "Service Shop"
>  Project: Freeciv
> Submitted by: None
> Submitted on: Sat 25 May 2013 03:59:18 PM UTC
> Category: rulesets
> Severity: 3 - Normal
> Priority: 5 - Normal
>   Status: None
>  Assigned to: None
> Originator Email: nighto...@cox.net
>  Open/Closed: Open
>  Release: FreeCiv 2.4.0 Beta 2 gui-gtk 2.0 client
>  Discussion Lock: Any
> Operating System: Microsoft Windows
>  Planned Release:
>
> ___
>
> Details:
>
> Upgrade_Unit only works for Leonardo's Workshop
>
> Tried Several Variations
>
> [effect_maint_player]
> name = "Upgrade_Unit"
> value   = 1
> reqs=
> { "type", "name", "range"
>   "Building", "Service Shop", "RANGE"
> }
> Player and Continent Got same error
>
> Local and City Load and run but do not upgrade units
>
> more info and effects.ruleset add and building ruleset add in attached
> files i
> did have this working in freeciv 2.2.? i thing can't access  due to drive
> crash
>
>
>
> ___
>
> File Attachments:
>
>
> ---
> Date: Sat 25 May 2013 03:59:18 PM UTC  Name: Upgrade_Unit Problems.txt
>  Size:
> 3kB   By: None
>
> 
>
> ___
>
> Reply to this item at:
>
>   
>
> ___
>   Message sent via/by Gna!
>   http://gna.org/
>
>
> ___
> Freeciv-dev mailing list
> Freeciv-dev@gna.org
> https://mail.gna.org/listinfo/freeciv-dev
>



-- 
Vasco Alexandre da Silva Costa
PhD Student at Department of Information Systems and Computer Science
IST/Technical University of Lisbon
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20844] Effects.ruleset [effect_maint_player] has unknown req: Building" "Service Shop"

2013-05-25 Thread anonymous
URL:
  

 Summary: Effects.ruleset [effect_maint_player] has unknown
req: Building" "Service Shop"
 Project: Freeciv
Submitted by: None
Submitted on: Sat 25 May 2013 03:59:18 PM UTC
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: nighto...@cox.net
 Open/Closed: Open
 Release: FreeCiv 2.4.0 Beta 2 gui-gtk 2.0 client
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

Upgrade_Unit only works for Leonardo's Workshop

Tried Several Variations 

[effect_maint_player]
name = "Upgrade_Unit"
value   = 1
reqs=
{ "type", "name", "range"
  "Building", "Service Shop", "RANGE"
}
Player and Continent Got same error

Local and City Load and run but do not upgrade units

more info and effects.ruleset add and building ruleset add in attached files i
did have this working in freeciv 2.2.? i thing can't access  due to drive
crash



___

File Attachments:


---
Date: Sat 25 May 2013 03:59:18 PM UTC  Name: Upgrade_Unit Problems.txt  Size:
3kB   By: None



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev