[Freeciv-Dev] [bug #21159] 'mapimg colortest' causes assertion failures and server disconnection

[Marko Lindqvist]

Update of bug #21159 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21159] 'mapimg colortest' causes assertion failures and server disconnection

[Marko Lindqvist]

Update of bug #21159 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #7:

Patches

(file #19254, file #19255)
___

Additional Item Attachment:

File name: ColortestCrash.patch.bz2   Size:5 KB
File name: ColortestCrash-S2_5.patch.bz2  Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21159] 'mapimg colortest' causes assertion failures and server disconnection

[Marko Lindqvist]

Update of bug #21159 (project freeciv):

Category:None => general
  Status:   Confirmed => In Progress
 Assigned to:None => cazfi  

___

Follow-up Comment #6:

I'm working on a fix that has essentially two parts:

- img_new() gets topology as parameter. topo_has_flag() takes topology
argument too - new current_topo_has_flag() takes not (behaves like old
topo_has_flag() )
- img_plot() takes coordinates instead of tile index (to fix mess in
conversions between 3 different coordinate systems). colortest does not need
dummy tile any more. New wrapper img_plot_tile() takes tile and converts to
coordinates.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21159] 'mapimg colortest' causes assertion failures and server disconnection

[Marko Lindqvist]

Follow-up Comment #5, bug #21159 (project freeciv):

> Fix as simple as adding a topology argument to img_new() rather
> than it using the global map.topology_id? (Haven't tried it.)

Global topology is accessed directly deeper in the helper functions, so I
guess (I could be wrong: maybe the topology doesn't matter in those cases)
it's not simply matter of img_new() knowing correct topology.

If there's no proper fix when 2.4.1 release date draws near, I would try ugly
hack (tm) of "saved_topology = map.topology_id; map.topology_id = NONISO; ...
map.topology_id = saved_topology;" as temporary solution.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21159] 'mapimg colortest' causes assertion failures and server disconnection

[Jacob Nevins]

Follow-up Comment #4, bug #21159 (project freeciv):

Fix as simple as adding a topology argument to img_new() rather than it using
the global map.topology_id? (Haven't tried it.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21159] 'mapimg colortest' causes assertion failures and server disconnection

[Jacob Nevins]

Follow-up Comment #3, bug #21159 (project freeciv):

Aha, that would neatly explain why I didn't spot it when polishing
mapimg/playercolor -- the default was changed to iso quite late on.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21159] 'mapimg colortest' causes assertion failures and server disconnection

[Marko Lindqvist]

Follow-up Comment #2, bug #21159 (project freeciv):

It suspiciously uses common tile coordinate / index conversion functions etc
while not targeting to the same shape and dimensions as current map has - and
indeed, by setting map topology to non-iso before running 'mapimg colortest',
it success without assertions.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21159] 'mapimg colortest' causes assertion failures and server disconnection

[Jacob Nevins]

Follow-up Comment #1, bug #21159 (project freeciv):

(I have MagickWand compiled in, no idea about the original reporter.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21159] 'mapimg colortest' causes assertion failures and server disconnection

[Jacob Nevins]

URL:
  

 Summary: 'mapimg colortest' causes assertion failures and
server disconnection
 Project: Freeciv
Submitted by: jtn
Submitted on: Mon Sep 23 10:41:02 2013
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Confirmed
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.4.0
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.4.1,2.5.0,2.6.0

___

Details:

Reported by Dox4242 on the forum
, reproduced by me:

In a client-spawned server, '/mapimg colortest' in a running game leads to the
client/server connection being broken with the client saving 'Lost connection
to server (decoding error)!'

In a standalone server, doing '/mapimg colortest' pregame, there are loads of
assertion failures including repeats of the following, but the server stays
alive:


1: invalid index: 0 <= -1 < 20736
1: in img_index() [mapimg.c::1980]: assertion 'y >= 0 && y < pimg->imgsize.y'
failed.
1: Please report this message at http://gna.org/projects/freeciv/





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev